[GitHub] [incubator-echarts] pissang commented on pull request #13315: german translation added

2020-09-21 Thread GitBox


pissang commented on pull request #13315:
URL: 
https://github.com/apache/incubator-echarts/pull/13315#issuecomment-695933159







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] pissang commented on pull request #13315: german translation added

2020-09-21 Thread GitBox


pissang commented on pull request #13315:
URL: 
https://github.com/apache/incubator-echarts/pull/13315#issuecomment-695937119


   Looks good, thanks!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] pissang commented on pull request #13315: german translation added

2020-09-21 Thread GitBox


pissang commented on pull request #13315:
URL: 
https://github.com/apache/incubator-echarts/pull/13315#issuecomment-695933159


   Hi, @YvesR Thanks for the contribution. The language source file is in the 
https://github.com/apache/incubator-echarts/tree/next/src/i18n
   
   https://github.com/apache/incubator-echarts/blob/next/src/i18n/langEN.ts is 
an example template.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org