Re: [PR] fix(pie): fix `endAngle` is not applied on the empty circle [echarts]
echarts-bot[bot] commented on PR #19642: URL: https://github.com/apache/echarts/pull/19642#issuecomment-1963512333 Congratulations! Your PR has been merged. Thanks for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
Re: [PR] fix(pie): fix `endAngle` is not applied on the empty circle [echarts]
Ovilia merged PR #19642: URL: https://github.com/apache/echarts/pull/19642 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
Re: [PR] fix(pie): fix `endAngle` is not applied on the empty circle [echarts]
github-actions[bot] commented on PR #19642: URL: https://github.com/apache/echarts/pull/19642#issuecomment-1962325566 The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-19642@c539b1f -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
Re: [PR] fix(pie): fix `endAngle` is not applied on the empty circle [echarts]
echarts-bot[bot] commented on PR #19642: URL: https://github.com/apache/echarts/pull/19642#issuecomment-1962324305 Thanks for your contribution! The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request). The pull request is marked to be `PR: author is committer` because you are a committer of this project. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[PR] fix(pie): fix `endAngle` is not applied on the empty circle [echarts]
plainheart opened a new pull request, #19642: URL: https://github.com/apache/echarts/pull/19642 ## Brief Information This pull request is in the type of: - [x] bug fixing - [ ] new feature - [ ] others ### What does this PR do? Fix a bug brought by the `endAngle` feature - The empty circle should take the configured `endAngle` into account. ### Fixed issues - #18820 ## Comparison | Before | After | | :: | :: | |  | | | [Preview](https://echarts.apache.org/examples/editor.html?c=pie-half-donut=5.5.0=PYBwLglsB2AEC8sDeAoWszGAG0iAXMmuhgE4QDmFApqYQOQRjUC29xAvgDTHbU3QAJoVQkMoBgFYApPR5i-AMzAMAxtWjNSc4ugDO1PqubCiY9PQDK1AIalVAC1gBRaBQjRq9QopvYD8ub0ACIQpNTG3rC-_tSBYvTOLDYQ2FExAbok9ACq0FBwAIKCeul-meaw9ABqEILUwLDFpT7l1FkcnIEG5NR6hADaWaLm0DYs1AyFqup6erAAYqTAbPEkYACeIJNVIBBea-ikNoIQAK79sAP0ACwADLJcVQDsD_QAuoew6pq0g_SSN5PeivWSfLLoAD0kNgJwAVhcwBgHNRYHowHYkTYhLANIJYW4-BC0RjSGBCoSdgBGAAcdy-eIpFD4hAAzAA2enEwQ2DGDYnoJCwABufjO1LuNxpTzGEwY1jsjhcbg8Xlg3AFyBFYp2z1Zkhl4x2ITCETA9HVX0F2uw4sIkjphrlVSSKTSls1QtFtp2UpuTuNeQKTRKFo1lWt3rtsFZd3psFlxtq9UazTDxPeHWImY4AG4gA) | [Preview](https://echarts.apache.org/examples/editor.html?c=pie-half-donut=PR-19642=PYBwLglsB2AEC8sDeAoWszGAG0iAXMmuhgE4QDmFApqYQOQRjUC29xAvgDTHbU3QAJoVQkMoBgFYApPR5i-AMzAMAxtWjNSc4ugDO1PqubCiY9PQDK1AIalVAC1gBRaBQjRq9QopvYD8ub0ACIQpNTG3rC-_tSBYvTOLDYQ2FExAbok9ACq0FBwAIKCeul-meaw9ABqEILUwLDFpT7l1FkcnIEG5NR6hADaWaLm0DYs1AyFqup6erAAYq TAbPEkYACeIJNVIBBea-ikNoIQAK79sAP0ACwADLJcVQDsD_QAuoew6pq0g_SSN5PeivWSfLLoAD0kNgJwAVhcwBgHNRYHowHYkTYhLANIJYW4-BC0RjSGBCoSdgBGAAcdy-eIpFD4hAAzAA2enEwQ2DGDYnoJCwABufjO1LuNxpTzGEwY1jsjhcbg8Xlg3AFyBFYp2z1Zkhl4x2ITCETA9HVX0F2uw4sIkjphrlVSSKTSls1QtFtp2UpuTuNeQKTRKFo1lWt3rtsFZd3psFlxtq9UazTDxPeHWImY4AG4gA)| ## Document Info One of the following should be checked. - [x] This PR doesn't relate to document changes - [ ] The document should be updated later - [ ] The document changes have been made in apache/echarts-doc#xxx ## Misc ### ZRender Changes - [ ] This PR depends on ZRender changes (ecomfe/zrender#xxx). ### Related test cases or examples to use the new APIs Please refer to `test/pie-endAngle.html`. ## Others ### Merging options - [ ] Please squash the commits into a single one when merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
