Re: [PR] visual improvement and correction to scatter-aggregate-to-bar chart [echarts-website]
Ovilia closed pull request #13: visual improvement and correction to scatter-aggregate-to-bar chart URL: https://github.com/apache/echarts-website/pull/13 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
Re: [PR] visual improvement and correction to scatter-aggregate-to-bar chart [echarts-website]
Ovilia commented on PR #13: URL: https://github.com/apache/echarts-website/pull/13#issuecomment-1955726874 Please change the code in [echarts-examples](https://github.com/apache/echarts-examples/blob/gh-pages/public/examples/ts/scatter-aggregate-bar.ts). The file in this repo is generated from that file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
Re: [PR] visual improvement and correction to scatter-aggregate-to-bar chart [echarts-website]
Ovilia commented on code in PR #13:
URL: https://github.com/apache/echarts-website/pull/13#discussion_r1496767925
##
examples/examples/ts/scatter-aggregate-bar.ts:
##
@@ -171,11 +171,14 @@ const barOption: echarts.EChartsOption = {
data: [
{
value: calculateAverage(maleDeta, 0),
- groupId: 'male'
+ groupId: 'female',
Review Comment:
I think the `groupId` should not be changed, and you don't have to add
`itemStyle.color`. Instead, we could use `colorBy: 'data'`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
