[GitHub] fineract pull request #442: Fix for In-App Triggered Notifications

2018-02-16 Thread conradsp
Github user conradsp closed the pull request at:

https://github.com/apache/fineract/pull/442


---


[GitHub] fineract issue #442: Fix for In-App Triggered Notifications

2018-02-16 Thread conradsp
Github user conradsp commented on the issue:

https://github.com/apache/fineract/pull/442
  
Will re-submit PR with single change


---


[GitHub] fineract pull request #443: Fix for In app notification

2018-02-16 Thread conradsp
GitHub user conradsp opened a pull request:

https://github.com/apache/fineract/pull/443

Fix for In app notification

For a triggered SMS message, check if notification flag is set. If so, send 
to GCM service.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/conradsp/fineract InAppNotification

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/fineract/pull/443.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #443


commit e2ae145a11a7a5232c2750b9479e8e855fbd2202
Author: conradsp 
Date:   2018-02-16T02:55:31Z

For a triggered SMS message, check if notification flag is set. If so, send 
to GCM service.

commit f28aadf3128f00f32d640a4bc194ed6f57558975
Author: conradsp 
Date:   2018-02-16T02:56:22Z

For a triggered SMS message, check if notification flag is set. If so, send 
to GCM service.




---


[GitHub] myrle-krantz commented on issue #1: Sync with latest Mifos I/O

2018-02-16 Thread GitBox
myrle-krantz commented on issue #1: Sync with latest Mifos I/O
URL: 
https://github.com/apache/fineract-cn-portfolio/pull/1#issuecomment-366206641
 
 
   Awesome!  Thank you Mark.
   
   Before I merge that though I need you to get an iCLA on file with the ASF.  
I imagine that request feels a little silly, since all of those changes except 
the pull request itself are from me.  The reason I'm covering our bases here is 
that before I left Kuelap, I asked for permission to merge this repository 
(among others) and that permission was denied.  I want to make extra sure that 
I don't create any legal jeopardy for the ASF by accepting your pull request 
now.
   
   An iCLA is required of all committers and many contributors to Apache 
projects.  It's a fairly low-key affair.  The form is here: 
https://www.apache.org/licenses/icla.pdf  It contains complete instructions.  
Please include Fineract in the projects you wish to have notified.
   
   Best Regards,
   Myrle Krantz


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services