[GitHub] ebenezergraham commented on issue #1: Update

[GitBox]

ebenezergraham commented on issue #1: Update 
URL: 
https://github.com/apache/fineract-cn-notifications/pull/1#issuecomment-413068577
 
 
   Thanks for the feedback. I will rectify this.
   
   On Tue, 14 Aug 2018, 19:14 Awasum Yannick,  wrote:
   
   > @ebenezergraham  Add unit tests for
   > your service.
   > Also ignore these files:
   > service/build/
   > service/out/
   > service/.gradle/
   > component-test/.gradle/
   > api/out/
   > api/.gradle
   >
   > Other devs do not need to see .class files as these can be generated by
   > the IDEs on their machines.
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > 
,
   > or mute the thread
   > 

   > .
   >
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] awasum commented on issue #1: Update

[GitBox]

awasum commented on issue #1: Update 
URL: 
https://github.com/apache/fineract-cn-notifications/pull/1#issuecomment-412907661
 
 
   @ebenezergraham Add unit tests for your service.
   Also ignore these files:
service/build/
service/out/
service/.gradle/
   component-test/.gradle/
api/out/
api/.gradle
   
   Other devs do not need to see .class files as these can be generated by the 
IDEs on their machines.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] awasum commented on issue #7: Changes added to the Group Microservice [GSoC period]

[GitBox]

awasum commented on issue #7: Changes added to the Group Microservice [GSoC 
period]
URL: https://github.com/apache/fineract-cn-group/pull/7#issuecomment-412898552
 
 
   @kengneruphine Please Add unit tests for GroupDefinitions and UpdateGroups 
then I can merge this.
   Also run licenseFormat to add apache license at the top of all source files.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] awasum commented on issue #8: Compilation error

[GitBox]

awasum commented on issue #8: Compilation error
URL: 
https://github.com/apache/fineract-cn-fims-web-app/pull/8#issuecomment-412889199
 
 
   
![image](https://user-images.githubusercontent.com/15528032/44097182-1a3bfffa-9fd5-11e8-9b9a-7d9b72d58096.png)
   
   @vigyat123 There is the above error I get when I run 'npm run dev'. It seems 
merging an earlier commit from @kengneruphine has fixed some of the problems 
and this PR might no longer be necessary.
   Please pull the latest changes from develop branch and test again. Then let 
me know if we need to close this one and you send another PR.
   
   Thanks. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] awasum commented on issue #7: Consume sign-off meeting endpoint [GSoC Period]

[GitBox]

awasum commented on issue #7: Consume sign-off meeting endpoint [GSoC Period]
URL: 
https://github.com/apache/fineract-cn-fims-web-app/pull/7#issuecomment-412885295
 
 
   @kengneruphine I have merged your PR. Make sure to pull before adding any 
other code on your side.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] awasum closed pull request #7: Consume sign-off meeting endpoint [GSoC Period]

[GitBox]

awasum closed pull request #7: Consume sign-off meeting endpoint [GSoC Period]
URL: https://github.com/apache/fineract-cn-fims-web-app/pull/7
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/src/app/common/common.module.ts b/src/app/common/common.module.ts
index e5e7b4c..544ad60 100644
--- a/src/app/common/common.module.ts
+++ b/src/app/common/common.module.ts
@@ -100,6 +100,7 @@ import {DisplayFimsFinancialNumber} from 
'./number/fims-financial-number.pipe';
 AccountSelectComponent,
 LedgerSelectComponent,
 ProductSelectComponent,
+GroupSelectComponent,
 EmployeeAutoCompleteComponent,
 IdInputComponent,
 PermissionDirective,
diff --git a/src/app/groups/definition/form/edit.form.component.ts 
b/src/app/groups/definition/form/edit.form.component.ts
index fb496f0..e2aee9a 100644
--- a/src/app/groups/definition/form/edit.form.component.ts
+++ b/src/app/groups/definition/form/edit.form.component.ts
@@ -35,7 +35,7 @@ export class EditGroupDefinitionFormComponent {
 this.groupDefinition$ = 
store.select(fromGroups.getSelectedGroupDefinition);
   }
 
-  onSave(groupDefinition: GroupDefinition):void {
+  onSave(groupDefinition: GroupDefinition){
 this.store.dispatch({ type: UPDATE, payload: {
   groupDefinition,
   activatedRoute: this.route
diff --git a/src/app/groups/detail/meeting/meeting.detail.component.html 
b/src/app/groups/detail/meeting/meeting.detail.component.html
index b5aec31..6c7eddf 100644
--- a/src/app/groups/detail/meeting/meeting.detail.component.html
+++ b/src/app/groups/detail/meeting/meeting.detail.component.html
@@ -18,7 +18,14 @@
 
 
 
-
+
+
+
+Duration for the meeting
+{{meeting.duration}}
+ 
+
+
 
 Attendance Sheet
 
diff --git 
a/src/app/groups/detail/signOffMeeting/signOff-meeting.component.html 
b/src/app/groups/detail/signOffMeeting/signOff-meeting.component.html
index e88e1ff..ac72d86 100644
--- a/src/app/groups/detail/signOffMeeting/signOff-meeting.component.html
+++ b/src/app/groups/detail/signOffMeeting/signOff-meeting.component.html
@@ -15,14 +15,14 @@
   limitations under the License.
 -->
 
-
-
+
+
   
 
   
 
 
-
+
  Attendance 
 
   
@@ -37,19 +37,22 @@  Attendance 
   
 
 
-  
+  
 
- {{customer.identifier}}
+
 
 
   
-  
+   
 
   
 {{ status.label }}
   
 
   
+  
 
 
   
@@ -66,5 +69,5 @@  Attendance 
 
 
   
-
+
 
\ No newline at end of file
diff --git a/src/app/groups/detail/signOffMeeting/signOff-meeting.component.ts 
b/src/app/groups/detail/signOffMeeting/signOff-meeting.component.ts
index dc9343c..10954f4 100644
--- a/src/app/groups/detail/signOffMeeting/signOff-meeting.component.ts
+++ b/src/app/groups/detail/signOffMeeting/signOff-meeting.component.ts
@@ -21,7 +21,7 @@ import {ActivatedRoute, Router} from '@angular/router';
 import {FormComponent} from '../../../common/forms/form.component';
 import {FormBuilder, Validators,FormGroup} from '@angular/forms';
 import {FimsValidators} from '../../../common/validator/validators';
-import { Attendee,Status} from '../../../services/group/domain/attendee.model';
+import { Attendee} from '../../../services/group/domain/attendee.model';
 import {Customer} from '../../../services/customer/domain/customer.model';
 import {Observable} from 'rxjs/Observable';
 import * as fromGroups from '../../store';
@@ -32,7 +32,11 @@ import * as fromRoot from '../../../store';
 import {StatusOptionList} from './domain/status-option-list.model';
 import {FetchRequest} from 
'../../../services/domain/paging/fetch-request.model';
 import {SEARCH} from '../../../store/customer/customer.actions';
-
+import {Meeting} from '../../../services/group/domain/meeting.model'
+import {SignOffMeeting} from 
'../../../services/group/domain/signoff-meeting.model'
+import {UPDATE} from '../../store/meeting/meeting.actions';
+import {Group} from '../../../services/group/domain/group.model';
+import {GroupsStore} from '../../store/index';
 
 
 @Component({
@@ -45,6 +49,15 @@ form:FormGroup
 customers: Observable;
 customers1: Customer[];
 name:Subscription;
+groupSubscription: Subscription;
+group: Group;
+members: any[];
+
+
+attendee : Attendee[] 

[fineract-cn-fims-web-app] branch develop updated (6b10d04 -> 58d2000)

[awasum]

This is an automated email from the ASF dual-hosted git repository.

awasum pushed a change to branch develop
in repository https://gitbox.apache.org/repos/asf/fineract-cn-fims-web-app.git.


from 6b10d04  Merge pull request #5 from davidyaha/feature/fix-ts
 add 398c3dd  implement multiple selection on members during group 
creation, consume sign-off endpoint
 new 58d2000  Merge pull request #7 from kengneruphine/develop

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 src/app/common/common.module.ts|  1 +
 .../groups/definition/form/edit.form.component.ts  |  2 +-
 .../detail/meeting/meeting.detail.component.html   |  9 ++-
 .../signOffMeeting/signOff-meeting.component.html  | 17 +++--
 .../signOffMeeting/signOff-meeting.component.ts| 81 --
 .../groups/form/customers/customers.component.html |  2 +-
 src/app/groups/form/form.component.spec.ts |  2 +-
 src/app/groups/form/form.component.ts  |  3 +-
 .../store/meeting/effects/service.effects.ts   |  4 +-
 src/app/groups/store/meeting/meeting.actions.ts|  4 +-
 src/app/services/group/domain/group.model.ts   |  3 +-
 src/app/services/group/group.service.ts|  4 +-
 12 files changed, 91 insertions(+), 41 deletions(-)

[fineract-cn-fims-web-app] 01/01: Merge pull request #7 from kengneruphine/develop

[awasum]

This is an automated email from the ASF dual-hosted git repository.

awasum pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/fineract-cn-fims-web-app.git

commit 58d2000679a9b178a9905b985da3647072095c51
Merge: 6b10d04 398c3dd
Author: Awasum Yannick 
AuthorDate: Tue Aug 14 15:09:48 2018 +0100

Merge pull request #7 from kengneruphine/develop

Consume sign-off meeting endpoint [GSoC Period]

 src/app/common/common.module.ts|  1 +
 .../groups/definition/form/edit.form.component.ts  |  2 +-
 .../detail/meeting/meeting.detail.component.html   |  9 ++-
 .../signOffMeeting/signOff-meeting.component.html  | 17 +++--
 .../signOffMeeting/signOff-meeting.component.ts| 81 --
 .../groups/form/customers/customers.component.html |  2 +-
 src/app/groups/form/form.component.spec.ts |  2 +-
 src/app/groups/form/form.component.ts  |  3 +-
 .../store/meeting/effects/service.effects.ts   |  4 +-
 src/app/groups/store/meeting/meeting.actions.ts|  4 +-
 src/app/services/group/domain/group.model.ts   |  3 +-
 src/app/services/group/group.service.ts|  4 +-
 12 files changed, 91 insertions(+), 41 deletions(-)

[GitHub] fineract pull request #457: Fixing Apache POI issue - Formula Cell evaluatio...

[ShruthiRajaram]

Github user ShruthiRajaram commented on a diff in the pull request:

https://github.com/apache/fineract/pull/457#discussion_r209896737
  
--- Diff: 
fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/importhandler/ImportHandlerUtils.java
 ---
@@ -63,8 +63,13 @@ public static Long readAsLong(int colIndex, Row row) {
 FormulaEvaluator eval = 
row.getSheet().getWorkbook().getCreationHelper().createFormulaEvaluator();
 if(c.getCellType() == Cell.CELL_TYPE_FORMULA) {
 if(eval!=null) {
-CellValue val = eval.evaluate(c);
-return ((Double) val.getNumberValue()).longValue();
+CellValue val = null;
--- End diff --

Can you please let us know in which scenario a null pointer exception is 
thrown.  As there is a null check for  'c and eval', I am not able to figure 
out  the case when a null pointer exception is thrown  by the statement in try 
block . This applies for all remaining method changes.


---

[GitHub] vigyat123 opened a new pull request #8: Compilation error

[GitBox]

vigyat123 opened a new pull request #8: Compilation error
URL: https://github.com/apache/fineract-cn-fims-web-app/pull/8
 
 
   ## Description
   
   Variable not defined and a variable spelled incorrectly
   
   ### What's included?
   
   - "lastModifiedBy" spelled incorrectly in 
"src/app/services/group/domain/group.model.ts"
   - "applicationDate?: string;" added in 
"src/app/services/group/domain/group.model.ts"
    Test Steps
   
   - Pull
   - npm i
   - npm run dev
   
   # Screenshots or link to CodePen/Plunker/JSfiddle


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services