[GitHub] Izakey commented on issue #7: Document APIs for transaction types, journal entries, accounts and le…
Izakey commented on issue #7: Document APIs for transaction types, journal entries, accounts and le… URL: https://github.com/apache/fineract-cn-accounting/pull/7#issuecomment-419156444 Thanks Awasum. I've open a PR https://github.com/apache/fineract-cn-accounting/pull/8 which addresses these accounting reports. Hopefully, this works. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Izakey opened a new pull request #8: Documenting accounting reports viz trial balance, chart of accounts, …
Izakey opened a new pull request #8: Documenting accounting reports viz trial balance, chart of accounts, … URL: https://github.com/apache/fineract-cn-accounting/pull/8 Documenting accounting reports viz trial balance, chart of accounts, income statement and financial condition This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] awasum commented on issue #7: Changes added to the Group Microservice [GSoC period]
awasum commented on issue #7: Changes added to the Group Microservice [GSoC period] URL: https://github.com/apache/fineract-cn-group/pull/7#issuecomment-419143402 Thank you @kengneruphine This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[fineract-cn-group] branch develop updated (c9f6fb4 -> acdd064)
This is an automated email from the ASF dual-hosted git repository.
awasum pushed a change to branch develop
in repository https://gitbox.apache.org/repos/asf/fineract-cn-group.git.
from c9f6fb4 Merge pull request #6 from apache/revert-5-develop
add 3ce19f9 adding permittableGroupIds and modifiying the bootstrap.yml
file
add 62c4bd0 modified requestparams in GrouprestController and some
modifications in GroupDefinitionRestController
add f2297c2 Implementing PUT request on Group definition
add 57e94d3 adding UpdateGroupdefinition in Group aggregate
add 4bd0052 implemeting UpdateGroup request
add a018cdd modifying updateGroup request in the groupAggregate.java file
add a9aeb1b changing name from updateGroupDefinition to updateDefinition
add 9484cac modifying the implementation of updateGroupDefinition
add 7df8dc5 modifying the implementation of updateGroupDefinition in the
GroupAggregate.java file
add c96cd33 modified endpoint for updateGroupDefinition
add b9f1f39 running ./gradlew licenseFormat
add 4b1b30b implementing Unit test on Group and GroupDefinition
new acdd064 Merge pull request #7 from kengneruphine/develop
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.gitignore | 2 +
.../fineract/cn/group/api/v1/EventConstants.java | 2 +
...tionException.java => PermittableGroupIds.java} | 11 ++-
.../cn/group/api/v1/client/GroupManager.java | 35 +++--
.../cn/group/api/v1/domain/GroupCommand.java | 2 +-
.../org/apache/fineract/cn/group/TestGroup.java| 23 ++
.../fineract/cn/group/TestGroupDefinition.java | 31 +++-
.../listener/GroupDefinitionEventListener.java | 11 +++
...teGroupCommand.java => UpdateGroupCommand.java} | 20 ++---
...mand.java => UpdateGroupDefinitionCommand.java} | 19 ++---
.../internal/command/handler/GroupAggregate.java | 91 +-
.../repository/GroupDefinitionRepository.java | 5 +-
.../internal/service/GroupDefinitionService.java | 4 +
.../group/rest/GroupDefinitionRestController.java | 52 ++---
.../cn/group/rest/GroupRestController.java | 45 +--
service/src/main/resources/bootstrap.yml | 2 +-
16 files changed, 306 insertions(+), 49 deletions(-)
copy
api/src/main/java/org/apache/fineract/cn/group/api/v1/{client/GroupValidationException.java
=> PermittableGroupIds.java} (82%)
copy
service/src/main/java/org/apache/fineract/cn/group/internal/command/{CreateGroupCommand.java
=> UpdateGroupCommand.java} (80%)
copy
service/src/main/java/org/apache/fineract/cn/group/internal/command/{CreateGroupDefinitionCommand.java
=> UpdateGroupDefinitionCommand.java} (73%)
[fineract-cn-deposit-account-management] 01/01: Merge pull request #8 from Izakey/develop
This is an automated email from the ASF dual-hosted git repository. awasum pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/fineract-cn-deposit-account-management.git commit 72b563b8c17ee72bbb321f0a401749c5a25a7033 Merge: 36e5765 b520887 Author: Awasum Yannick AuthorDate: Thu Sep 6 11:11:19 2018 +0100 Merge pull request #8 from Izakey/develop Document Deposit API to manage various deposit accounts component-test/build.gradle| 14 +- .../cn/deposit/DepositApiDocumentation.java| 699 + .../org/apache/fineract/cn/deposit/Fixture.java| 18 +- 3 files changed, 721 insertions(+), 10 deletions(-)
[GitHub] awasum closed pull request #7: Document Identity API to manage identities, roles and permissions
awasum closed pull request #7: Document Identity API to manage identities,
roles and permissions
URL: https://github.com/apache/fineract-cn-identity/pull/7
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/component-test/build.gradle b/component-test/build.gradle
index 87a5696..6e2d080 100644
--- a/component-test/build.gradle
+++ b/component-test/build.gradle
@@ -26,6 +26,7 @@ buildscript {
dependencies {
classpath
("org.springframework.boot:spring-boot-gradle-plugin:${springBootVersion}")
+classpath("org.asciidoctor:asciidoctor-gradle-plugin:1.5.3")
}
}
@@ -35,6 +36,7 @@ plugins {
}
apply from: '../shared.gradle'
+apply plugin: 'org.asciidoctor.convert'
dependencies {
compile(
@@ -45,6 +47,16 @@ dependencies {
[group: 'org.apache.fineract.cn', name: 'api', version:
versions.frameworkapi],
[group: 'org.apache.fineract.cn', name: 'test', version:
versions.frameworktest],
[group: 'org.apache.fineract.cn.anubis', name: 'api', version:
versions.frameworkanubis],
-[group: 'org.apache.fineract.cn.anubis', name: 'test', version:
versions.frameworkanubis]
+[group: 'org.apache.fineract.cn.anubis', name: 'test', version:
versions.frameworkanubis],
+[group: 'org.springframework.restdocs', name:
'spring-restdocs-mockmvc'],
+[group: 'junit', name: 'junit', version: '4.12']
)
}
+
+asciidoctor {
+sourceDir 'build/doc/asciidoc/'
+outputDir 'build/doc/html5'
+options backend: "html", doctype: "book"
+attributes "source-highlighter": "highlightjs", \
+'snippets': file('build/doc/generated-snippets/')
+}
\ No newline at end of file
diff --git a/component-test/src/main/java/AbstractComponentTest.java
b/component-test/src/main/java/AbstractIdentityTest.java
similarity index 83%
rename from component-test/src/main/java/AbstractComponentTest.java
rename to component-test/src/main/java/AbstractIdentityTest.java
index aeb6b08..3d45af6 100644
--- a/component-test/src/main/java/AbstractComponentTest.java
+++ b/component-test/src/main/java/AbstractIdentityTest.java
@@ -16,6 +16,7 @@
* specific language governing permissions and limitations
* under the License.
*/
+
import org.apache.fineract.cn.identity.api.v1.PermittableGroupIds;
import org.apache.fineract.cn.identity.api.v1.client.IdentityManager;
import org.apache.fineract.cn.identity.api.v1.domain.Authentication;
@@ -26,8 +27,10 @@
import
org.apache.fineract.cn.identity.api.v1.events.ApplicationPermissionEvent;
import org.apache.fineract.cn.identity.api.v1.events.ApplicationSignatureEvent;
import org.apache.fineract.cn.identity.api.v1.events.EventConstants;
+
import java.util.Arrays;
import javax.annotation.PostConstruct;
+
import org.apache.commons.lang.RandomStringUtils;
import org.apache.fineract.cn.anubis.api.v1.domain.AllowedOperation;
import org.apache.fineract.cn.anubis.api.v1.domain.Signature;
@@ -61,21 +64,20 @@
@SuppressWarnings("SpringAutowiredFieldsWarningInspection")
@RunWith(SpringRunner.class)
@SpringBootTest(webEnvironment = SpringBootTest.WebEnvironment.DEFINED_PORT,
-classes = {AbstractComponentTest.TestConfiguration.class})
+classes = {AbstractIdentityTest.TestConfiguration.class})
@TestPropertySource(properties = {"cassandra.cl.read = LOCAL_QUORUM",
"cassandra.cl.write = LOCAL_QUORUM", "cassandra.cl.delete = LOCAL_QUORUM",
"identity.token.refresh.secureCookie = false", "identity.passwordExpiresInDays
= 93"})
-public class AbstractComponentTest extends SuiteTestEnvironment {
+public class AbstractIdentityTest extends SuiteTestEnvironment {
@Configuration
@EnableApiFactory
@EnableEventRecording
@Import({IdentityServiceConfig.class})
@ComponentScan("listener")
public static class TestConfiguration {
-public TestConfiguration() {
+public TestConfiguration ( ) {
super();
}
}
-
static final String ADMIN_PASSWORD = "golden_osiris";
static final String ADMIN_ROLE = "pharaoh";
static final String ADMIN_IDENTIFIER = "antony";
@@ -99,27 +101,26 @@ public TestConfiguration() {
private IdentityManager identityManager;
@PostConstruct
- public void provision() throws Exception {
-identityManager = apiFactory.create(IdentityManager.class,
testEnvironment.serverURI());
+ public void provision ( ) throws Exception {
+identityManager = apiFactory.create(IdentityManager.class,
testEnvironment.serverURI());
try (final AutoUserContext ignored
- = tenantApplicationSecurityEnvironment.createAutoSeshatContext())
{
+ =
tenantApplicationSecurityEnvironment.createAutoSeshatContext()) {
[fineract-cn-identity] 01/01: Merge pull request #7 from Izakey/develop
This is an automated email from the ASF dual-hosted git repository. awasum pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/fineract-cn-identity.git commit 7f9842b8da53d534526738879766ac88512fab5f Merge: 36c7e12 10f7b9b Author: Awasum Yannick AuthorDate: Thu Sep 6 11:02:59 2018 +0100 Merge pull request #7 from Izakey/develop Document Identity API to manage identities, roles and permissions component-test/build.gradle| 14 +- ...omponentTest.java => AbstractIdentityTest.java} | 65 +- .../src/main/java/IdentityApiDocumentation.java| 1075 component-test/src/main/java/TestApplications.java |2 +- .../src/main/java/TestAuthentication.java |2 +- component-test/src/main/java/TestKeyRotation.java |2 +- component-test/src/main/java/TestPasswords.java|2 +- .../src/main/java/TestPermittableGroups.java |2 +- component-test/src/main/java/TestProvisioning.java |2 +- component-test/src/main/java/TestRefreshToken.java |2 +- component-test/src/main/java/TestRoles.java|2 +- component-test/src/main/java/TestUsers.java|2 +- 12 files changed, 1129 insertions(+), 43 deletions(-)
[GitHub] Izakey commented on issue #7: Document APIs for transaction types, journal entries, accounts and le…
Izakey commented on issue #7: Document APIs for transaction types, journal entries, accounts and le… URL: https://github.com/apache/fineract-cn-accounting/pull/7#issuecomment-419034660 Thanks for the kind review @awasum. Let check if this is from my side and fix it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] awasum closed pull request #7: Document Teller API to manage teller operations
awasum closed pull request #7: Document Teller API to manage teller operations
URL: https://github.com/apache/fineract-cn-teller/pull/7
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/component-test/build.gradle b/component-test/build.gradle
index 6100a08..543c2b4 100644
--- a/component-test/build.gradle
+++ b/component-test/build.gradle
@@ -26,6 +26,7 @@ buildscript {
dependencies {
classpath
("org.springframework.boot:spring-boot-gradle-plugin:${springBootVersion}")
+classpath("org.asciidoctor:asciidoctor-gradle-plugin:1.5.3")
}
}
@@ -34,6 +35,7 @@ plugins {
id("org.nosphere.apache.rat") version "0.3.1"
}
apply from: '../shared.gradle'
+apply plugin: 'org.asciidoctor.convert'
dependencies {
compile(
@@ -43,10 +45,20 @@ dependencies {
[group: 'org.apache.fineract.cn', name: 'api', version:
versions.frameworkapi],
[group: 'org.apache.fineract.cn', name: 'test', version:
versions.frameworktest],
[group: 'org.apache.fineract.cn', name: 'lang', version:
versions.frameworklang],
-[group: 'org.springframework.boot', name:
'spring-boot-starter-test']
+[group: 'org.springframework.boot', name:
'spring-boot-starter-test'],
+[group: 'org.springframework.restdocs', name:
'spring-restdocs-mockmvc'],
+[group: 'junit', name: 'junit', version: '4.12']
)
}
+asciidoctor {
+sourceDir 'build/doc/asciidoc/'
+outputDir 'build/doc/html5'
+options backend: "html", doctype: "book"
+attributes "source-highlighter": "highlightjs", \
+ 'snippets': file('build/doc/generated-snippets/')
+}
+
publishing {
publications {
mavenJava(MavenPublication) {
diff --git
a/component-test/src/main/java/org/apache/fineract/cn/teller/TellerApiDocumentation.java
b/component-test/src/main/java/org/apache/fineract/cn/teller/TellerApiDocumentation.java
new file mode 100644
index 000..5c8ad65
--- /dev/null
+++
b/component-test/src/main/java/org/apache/fineract/cn/teller/TellerApiDocumentation.java
@@ -0,0 +1,890 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.fineract.cn.teller;
+
+import com.google.common.collect.Lists;
+import com.google.gson.Gson;
+import org.apache.commons.lang3.RandomStringUtils;
+import org.apache.fineract.cn.accounting.api.v1.domain.Account;
+import
org.apache.fineract.cn.deposit.api.v1.definition.domain.ProductDefinition;
+import org.apache.fineract.cn.deposit.api.v1.instance.domain.ProductInstance;
+import org.apache.fineract.cn.lang.DateConverter;
+import org.apache.fineract.cn.teller.api.v1.EventConstants;
+import org.apache.fineract.cn.teller.api.v1.domain.*;
+import org.apache.fineract.cn.teller.service.internal.service.helper.*;
+import org.apache.fineract.cn.teller.util.TellerGenerator;
+import org.junit.Assert;
+import org.junit.Before;
+import org.junit.Rule;
+import org.junit.Test;
+import org.mockito.Matchers;
+import org.mockito.Mockito;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.boot.test.mock.mockito.MockBean;
+import org.springframework.http.MediaType;
+import org.springframework.restdocs.JUnitRestDocumentation;
+import org.springframework.test.web.servlet.MockMvc;
+import org.springframework.test.web.servlet.setup.MockMvcBuilders;
+import org.springframework.web.context.WebApplicationContext;
+
+import java.math.BigDecimal;
+import java.time.Clock;
+import java.time.LocalDateTime;
+import java.util.Collections;
+import java.util.List;
+import java.util.Optional;
+
+import static
org.springframework.restdocs.mockmvc.MockMvcRestDocumentation.document;
+import static
org.springframework.restdocs.mockmvc.MockMvcRestDocumentation.documentationConfiguration;
+import static
org.springframework.restdocs.mockmvc.RestDocumentationRequestBuilders.post;
+import static
org.springframework.restdocs.mockmvc.RestDocumentationRequestBuilders.get;
+import
[fineract-cn-teller] branch develop updated (d9dc9b0 -> fb3a74a)
This is an automated email from the ASF dual-hosted git repository. awasum pushed a change to branch develop in repository https://gitbox.apache.org/repos/asf/fineract-cn-teller.git. from d9dc9b0 Merge pull request #6 from apache/revert-5-develop add b093025 Document Teller API to manage teller operations add 02d379f Updating license information new fb3a74a Merge pull request #7 from Izakey/develop The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: component-test/build.gradle| 14 +- .../fineract/cn/teller/TellerApiDocumentation.java | 890 + .../rest/TellerOperationRestController.java| 4 +- 3 files changed, 905 insertions(+), 3 deletions(-) create mode 100644 component-test/src/main/java/org/apache/fineract/cn/teller/TellerApiDocumentation.java
[GitHub] awasum closed pull request #7: Document APIs for transaction types, journal entries, accounts and le…
awasum closed pull request #7: Document APIs for transaction types, journal
entries, accounts and le…
URL: https://github.com/apache/fineract-cn-accounting/pull/7
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/.gitignore b/.gitignore
index 5e1104b..0cd4b09 100644
--- a/.gitignore
+++ b/.gitignore
@@ -2,6 +2,10 @@
.idea
**/build/
**/target/
+api/out/
+component-test/out/
+importer/out/
+service/out/
# Ignore Gradle GUI config
gradle-app.setting
diff --git a/component-test/build.gradle b/component-test/build.gradle
index 64d0d9b..411086c 100644
--- a/component-test/build.gradle
+++ b/component-test/build.gradle
@@ -26,6 +26,7 @@ buildscript {
dependencies {
classpath
("org.springframework.boot:spring-boot-gradle-plugin:${springBootVersion}")
+classpath("org.asciidoctor:asciidoctor-gradle-plugin:1.5.3")
}
}
@@ -35,6 +36,7 @@ plugins {
}
apply from: '../shared.gradle'
+apply plugin: 'org.asciidoctor.convert'
dependencies {
compile(
@@ -45,10 +47,20 @@ dependencies {
[group: 'org.apache.fineract.cn', name: 'api', version:
versions.frameworkapi],
[group: 'org.apache.fineract.cn', name: 'test', version:
versions.frameworktest],
[group: 'org.apache.fineract.cn', name: 'lang', version:
versions.frameworklang],
-[group: 'org.springframework.boot', name:
'spring-boot-starter-test']
+[group: 'org.springframework.boot', name:
'spring-boot-starter-test'],
+[group: 'org.springframework.restdocs', name:
'spring-restdocs-mockmvc'],
+[group: 'junit', name: 'junit', version: '4.12']
)
}
+asciidoctor {
+sourceDir 'build/doc/asciidoc/'
+outputDir 'build/doc/html5/'
+options backend: "html", doctype: "book"
+attributes "source-highlighter": "highlightjs", \
+'snippets': file('build/doc/generated-snippets/')
+}
+
publishing {
publications {
mavenJava(MavenPublication) {
diff --git
a/component-test/src/main/java/org/apache/fineract/cn/accounting/AccountApiDocumentation.java
b/component-test/src/main/java/org/apache/fineract/cn/accounting/AccountApiDocumentation.java
new file mode 100644
index 000..d461f2c
--- /dev/null
+++
b/component-test/src/main/java/org/apache/fineract/cn/accounting/AccountApiDocumentation.java
@@ -0,0 +1,1019 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.fineract.cn.accounting;
+
+import com.google.gson.Gson;
+import org.apache.fineract.cn.accounting.api.v1.EventConstants;
+import org.apache.fineract.cn.accounting.api.v1.domain.*;
+import org.apache.fineract.cn.accounting.util.AccountGenerator;
+import org.apache.fineract.cn.accounting.util.JournalEntryGenerator;
+import org.apache.fineract.cn.accounting.util.LedgerGenerator;
+import org.apache.fineract.cn.lang.DateRange;
+import org.junit.Assert;
+import org.junit.Before;
+import org.junit.Rule;
+import org.junit.Test;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.data.domain.Sort;
+import org.springframework.http.MediaType;
+import org.springframework.restdocs.JUnitRestDocumentation;
+import org.springframework.test.web.servlet.MockMvc;
+import org.springframework.test.web.servlet.setup.MockMvcBuilders;
+import org.springframework.web.context.WebApplicationContext;
+
+import java.math.BigDecimal;
+import java.time.Clock;
+import java.time.LocalDate;
+import java.util.ArrayList;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Set;
+import java.util.stream.Collectors;
+import java.util.stream.Stream;
+
+import static
org.springframework.restdocs.mockmvc.MockMvcRestDocumentation.document;
+import static
org.springframework.restdocs.mockmvc.MockMvcRestDocumentation.documentationConfiguration;
+import static
org.springframework.restdocs.mockmvc.RestDocumentationRequestBuilders.delete;
+import static
[GitHub] awasum commented on issue #7: Document APIs for transaction types, journal entries, accounts and le…
awasum commented on issue #7: Document APIs for transaction types, journal
entries, accounts and le…
URL:
https://github.com/apache/fineract-cn-accounting/pull/7#issuecomment-419020487
In LedgerAPIDoc.documentAddSubLedger():
org.springframework.web.util.NestedServletException: Request processing
failed; nested exception is
ServiceException{serviceError=ServiceError{code=404, message='Parent ledger
6200 not found.'}}
Is this normal behavior or is it just on my side?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
