subject:"\[GitHub\] \[fineract\] thesmallstar commented on a change in pull request #1290\: Added and Enforced AbbreviationAsWordInName Checkstyle \(FINERACT\-821\)"

[GitHub] [fineract] thesmallstar commented on a change in pull request #1290: Added and Enforced AbbreviationAsWordInName Checkstyle (FINERACT-821)

2020-10-11 Thread GitBox



thesmallstar commented on a change in pull request #1290:
URL: https://github.com/apache/fineract/pull/1290#discussion_r502972758



##
File path: 
fineract-provider/src/main/java/org/apache/fineract/useradministration/api/RolesApiResourceSwagger.java
##
@@ -24,7 +24,7 @@
 /**
  * Created by sanyam on 23/8/17.
  */
-@SuppressWarnings({ "MemberName" })
+@SuppressWarnings({ "MemberName", "AbbreviationAsWordInName" })

Review comment:
   Yes agreed, Updating.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [fineract] thesmallstar commented on a change in pull request #1290: Added and Enforced AbbreviationAsWordInName Checkstyle (FINERACT-821)

2020-09-21 Thread GitBox



thesmallstar commented on a change in pull request #1290:
URL: https://github.com/apache/fineract/pull/1290#discussion_r491842279



##
File path: 
fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/LoanWithWaiveInterestAndWriteOffIntegrationTest.java
##
@@ -140,7 +140,7 @@ public void checkClientLoanCreateAndDisburseFlow() {
 }
 
 @Test
-public void checkClientLoan_WRITTEN_OFF() {
+public void checkClientLoanWrittenOFF() {

Review comment:
   fixed.

##
File path: 
fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/boot/EmbeddedTomcatWithSSLConfiguration.java
##
@@ -55,7 +55,7 @@ protected Connector createSslConnector() {
 File keystore = getFile(getKeystore());
 connector.setScheme("https");
 connector.setSecure(true);
-connector.setPort(getHTTPSPort());
+connector.setPort(getHTTPSport());

Review comment:
   fixed

##
File path: 
fineract-provider/src/main/java/org/apache/fineract/portfolio/group/api/GroupsApiResource.java
##
@@ -624,11 +624,11 @@ public String retrieveGsimAccounts(@PathParam("groupId") 
final Long groupId,
 
 }
 
-final Set GSIM_ACCOUNTS_DATA_PARAMETERS = new HashSet<>(
+final Set glimAccountsDataParameters = new HashSet<>(
 Arrays.asList("gsimId", "groupId", "accountNumber", 
"childGSIMAccounts", "parentBalance", "savingsStatus"));

Review comment:
   updated, thanks for finding this. 

##
File path: 
fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/common/recurringdeposit/RecurringDepositProductHelper.java
##
@@ -244,8 +244,8 @@ public static ArrayList 
retrieveAllRecurringDepositProducts(final RequestSpecifi
 public static HashMap retrieveRecurringDepositProductById(final 
RequestSpecification requestSpec,
 final ResponseSpecification responseSpec, final String productId) {
 LOG.info(" RETRIEVING RECURRING DEPOSIT PRODUCT BY 
ID --");
-final String GET_RD_PRODUCT_BY_ID_URL = RECURRING_DEPOSIT_PRODUCT_URL 
+ "/" + productId + "?" + Utils.TENANT_IDENTIFIER;
-final HashMap response = Utils.performServerGet(requestSpec, 
responseSpec, GET_RD_PRODUCT_BY_ID_URL, "");
+final String getRDproductByIDurl = RECURRING_DEPOSIT_PRODUCT_URL + "/" 
+ productId + "?" + Utils.TENANT_IDENTIFIER;

Review comment:
   updated.

##
File path: 
fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/common/recurringdeposit/RecurringDepositAccountHelper.java
##
@@ -156,9 +156,9 @@ public static Integer 
applyRecurringDepositApplication(final String recurringDep
 
 public static HashMap getRecurringDepositAccountById(final 
RequestSpecification requestSpec, final ResponseSpecification responseSpec,
 final Integer accountID) {
-final String GET_RECURRING_DEPOSIT_BY_ID_URL = 
RECURRING_DEPOSIT_ACCOUNT_URL + "/" + accountID + "?" + Utils.TENANT_IDENTIFIER;
+final String getRecurringDepositByIDurl = 
RECURRING_DEPOSIT_ACCOUNT_URL + "/" + accountID + "?" + Utils.TENANT_IDENTIFIER;

Review comment:
   updated.

##
File path: 
fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/common/organisation/CampaignsHelper.java
##
@@ -53,50 +53,50 @@ public CampaignsHelper(final RequestSpecification 
requestSpec, final ResponseSpe
 
 public Integer createCampaign(String reportName, Integer triggerType) {
 LOG.info("-CREATING A 
CAMPAIGN-");
-final String CREATE_SMS_CAMPAIGNS_URL = SMS_CAMPAIGNS_URL + "?" + 
Utils.TENANT_IDENTIFIER;
-return Utils.performServerPost(requestSpec, responseSpec, 
CREATE_SMS_CAMPAIGNS_URL, getCreateCampaignJSON(reportName, triggerType),
+final String createSMScampaignsURL = SMS_CAMPAIGNS_URL + "?" + 
Utils.TENANT_IDENTIFIER;

Review comment:
   updated.

##
File path: 
fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/common/loans/LoanTransactionHelper.java
##
@@ -303,46 +303,46 @@ public HashMap withdrawLoanApplicationByClient(final 
String date, final Integer
 
 public Integer addChargesForLoan(final Integer loanId, final String 
request) {
 LOG.info("- ADD CHARGES FOR LOAN 
");
-final String ADD_CHARGES_URL = "/fineract-provider/api/v1/loans/" + 
loanId + "/charges?" + Utils.TENANT_IDENTIFIER;
-final HashMap response = Utils.performServerPost(requestSpec, 
responseSpec, ADD_CHARGES_URL, request, "");
+final String chargesURL = "/fineract-provider/api/v1/loans/" + loanId 
+ "/charges?" + Utils.TENANT_IDENTIFIER;

Review comment:
   updated, I dont know

[GitHub] [fineract] thesmallstar commented on a change in pull request #1290: Added and Enforced AbbreviationAsWordInName Checkstyle (FINERACT-821)

2020-09-21 Thread GitBox



thesmallstar commented on a change in pull request #1290:
URL: https://github.com/apache/fineract/pull/1290#discussion_r491848617



##
File path: 
fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/ClientLoanIntegrationTest.java
##
@@ -65,7 +65,7 @@
  * Client Loan Integration Test for checking Loan Application Repayments 
Schedule, loan charges, penalties, loan
  * repayments and verifying accounting transactions
  */
-@SuppressWarnings({ "rawtypes", "unchecked" })
+@SuppressWarnings({ "rawtypes", "unchecked", "AbbreviationAsWordInName" })
 public class ClientLoanIntegrationTest {

Review comment:
   Only this remains, I suppressed it here since there were 130-140 letter 
big function names and many of them, I thought it was really easy to read them 
in the way they are now. 
   
   Also, I found those changes unnecessary since other errors in that file were 
solved already. test functions name should not matter much?
   
   What do you think?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [fineract] thesmallstar commented on a change in pull request #1290: Added and Enforced AbbreviationAsWordInName Checkstyle (FINERACT-821)

2020-09-21 Thread GitBox



thesmallstar commented on a change in pull request #1290:
URL: https://github.com/apache/fineract/pull/1290#discussion_r491847257



##
File path: 
fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/MinimumDaysBetweenDisbursalAndFirstRepaymentTest.java
##
@@ -43,7 +43,7 @@
 /**
  * Test the creation, approval and rejection of a loan reschedule request
  **/
-@SuppressWarnings({ "rawtypes" })
+@SuppressWarnings({ "rawtypes", "AbbreviationAsWordInName" })
 public class MinimumDaysBetweenDisbursalAndFirstRepaymentTest {

Review comment:
   Agreed, Removed. 

##
File path: 
fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/GroupSavingsIntegrationTest.java
##
@@ -160,10 +160,10 @@ public void testSavingsAccount_CLOSE_APPLICATION() {
 
 DateFormat dateFormat = new SimpleDateFormat("dd  ", 
Locale.US);
 Calendar todaysDate = Calendar.getInstance();
-final String CLOSEDON_DATE = dateFormat.format(todaysDate.getTime());
+final String closedOnDateValue = 
dateFormat.format(todaysDate.getTime());
 String withdrawBalance = "false";

Review comment:
   updated.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [fineract] thesmallstar commented on a change in pull request #1290: Added and Enforced AbbreviationAsWordInName Checkstyle (FINERACT-821)

2020-09-21 Thread GitBox



thesmallstar commented on a change in pull request #1290:
URL: https://github.com/apache/fineract/pull/1290#discussion_r491847373



##
File path: 
fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/ClientLoanIntegrationTest.java
##
@@ -3117,7 +3117,7 @@ public void 
testLoanScheduleWithInterestRecalculation_WITH_REST_SAME_AS_REPAYMEN
 
 Calendar todaysDate = 
Calendar.getInstance(Utils.getTimeZoneOfTenant());
 todaysDate.add(Calendar.DAY_OF_MONTH, -14);
-final String LOAN_DISBURSEMENT_DATE = 
dateFormat.format(todaysDate.getTime());
+final String loanDisbursementDateValue = 
dateFormat.format(todaysDate.getTime());
 

Review comment:
   Updated





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [fineract] thesmallstar commented on a change in pull request #1290: Added and Enforced AbbreviationAsWordInName Checkstyle (FINERACT-821)

2020-09-21 Thread GitBox



thesmallstar commented on a change in pull request #1290:
URL: https://github.com/apache/fineract/pull/1290#discussion_r491846979



##
File path: 
fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/SchedulerJobsTestResults.java
##
@@ -537,11 +537,11 @@ public void testUpdateLoanSummaryJobOutcome() throws 
InterruptedException {
 final String currentDate = dateFormat.format(todaysDate.getTime());
 
 todaysDate.add(Calendar.MONTH, -1);
-final String LOAN_DISBURSEMENT_DATE = 
dateFormat.format(todaysDate.getTime());
+final String loanDisbursementDateValue = 
dateFormat.format(todaysDate.getTime());
 

Review comment:
   Updated, I did it since the variable  loanDisbursementDate was used in 
some files, did not let me mass replace.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [fineract] thesmallstar commented on a change in pull request #1290: Added and Enforced AbbreviationAsWordInName Checkstyle (FINERACT-821)

2020-09-21 Thread GitBox



thesmallstar commented on a change in pull request #1290:
URL: https://github.com/apache/fineract/pull/1290#discussion_r491846062



##
File path: 
fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/common/HolidayHelper.java
##
@@ -77,15 +77,15 @@ public static Integer createHolidays(final 
RequestSpecification requestSpec, fin
 
 public static Integer activateHolidays(final RequestSpecification 
requestSpec, final ResponseSpecification responseSpec,
 final String holidayID) {
-final String ACTIVATE_HOLIDAY_URL = HOLIDAYS_URL + "/" + holidayID + 
"?command=activate&" + Utils.TENANT_IDENTIFIER;
-return Utils.performServerPost(requestSpec, responseSpec, 
ACTIVATE_HOLIDAY_URL, getActivateHolidayDataAsJSON(), "resourceId");
+final String activateHolidayURL = HOLIDAYS_URL + "/" + holidayID + 
"?command=activate&" + Utils.TENANT_IDENTIFIER;
+return Utils.performServerPost(requestSpec, responseSpec, 
activateHolidayURL, getActivateHolidayDataAsJSON(), "resourceId");
 }
 
 public static HashMap getHolidayById(final RequestSpecification 
requestSpec, final ResponseSpecification responseSpec,
 final String holidayID) {
-final String GET_HOLIDAY_BY_ID_URL = HOLIDAYS_URL + "/" + holidayID + 
"?" + Utils.TENANT_IDENTIFIER;
+final String getHolidayByIDurl = HOLIDAYS_URL + "/" + holidayID + "?" 
+ Utils.TENANT_IDENTIFIER;
 LOG.info(" RETRIEVING HOLIDAY BY ID 
-");

Review comment:
   upated





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [fineract] thesmallstar commented on a change in pull request #1290: Added and Enforced AbbreviationAsWordInName Checkstyle (FINERACT-821)

2020-09-21 Thread GitBox



thesmallstar commented on a change in pull request #1290:
URL: https://github.com/apache/fineract/pull/1290#discussion_r491846195



##
File path: 
fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/common/GlobalConfigurationHelper.java
##
@@ -41,18 +41,17 @@ public GlobalConfigurationHelper(final RequestSpecification 
requestSpec, final R
 
 public static ArrayList getAllGlobalConfigurations(final 
RequestSpecification requestSpec,
 final ResponseSpecification responseSpec) {
-final String GET_ALL_GLOBAL_CONFIG_URL = 
"/fineract-provider/api/v1/configurations?" + Utils.TENANT_IDENTIFIER;
+final String getAllGlobalConfigURL = 
"/fineract-provider/api/v1/configurations?" + Utils.TENANT_IDENTIFIER;
 LOG.info(" RETRIEVING ALL GLOBAL 
CONFIGURATIONS -");
-final HashMap> response = 
Utils.performServerGet(requestSpec, responseSpec, GET_ALL_GLOBAL_CONFIG_URL,
-"");
+final HashMap> response = 
Utils.performServerGet(requestSpec, responseSpec, getAllGlobalConfigURL, "");
 return response.get("globalConfiguration");
 }
 
 public static HashMap getGlobalConfigurationById(final 
RequestSpecification requestSpec, final ResponseSpecification responseSpec,
 final String configId) {
-final String GET_GLOBAL_CONFIG_BY_ID_URL = 
"/fineract-provider/api/v1/configurations/" + configId + "?" + 
Utils.TENANT_IDENTIFIER;
+final String getGlobalConfigByIDurl = 
"/fineract-provider/api/v1/configurations/" + configId + "?" + 
Utils.TENANT_IDENTIFIER;
 LOG.info(" RETRIEVING GLOBAL CONFIGURATION BY 
ID -");

Review comment:
   updated





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [fineract] thesmallstar commented on a change in pull request #1290: Added and Enforced AbbreviationAsWordInName Checkstyle (FINERACT-821)

2020-09-21 Thread GitBox



thesmallstar commented on a change in pull request #1290:
URL: https://github.com/apache/fineract/pull/1290#discussion_r491844647



##
File path: 
fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/common/StandingInstructionsHelper.java
##
@@ -108,20 +108,20 @@ public Integer createStandingInstruction(final String 
clientId, final String fro
 public HashMap getStandingInstructionById(final String 
standingInstructionId) {
 
 LOG.info("- RETRIEVING STANDING 
INSTRUCTION BY ID---");
-final String GET_STANDING_INSTRUCTION_BY_ID_URL = 
STANDING_INSTRUCTIONS_URL + "/" + standingInstructionId + "?"
+final String getStandingInstructionsByIDurl = 
STANDING_INSTRUCTIONS_URL + "/" + standingInstructionId + "?"
 + Utils.TENANT_IDENTIFIER;

Review comment:
   updated.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [fineract] thesmallstar commented on a change in pull request #1290: Added and Enforced AbbreviationAsWordInName Checkstyle (FINERACT-821)

2020-09-21 Thread GitBox



thesmallstar commented on a change in pull request #1290:
URL: https://github.com/apache/fineract/pull/1290#discussion_r491843975



##
File path: 
fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/common/fixeddeposit/FixedDepositAccountHelper.java
##
@@ -144,9 +144,9 @@ public static Integer applyFixedDepositApplication(final 
String fixedDepositAcco
 
 public static HashMap getFixedDepositAccountById(final 
RequestSpecification requestSpec, final ResponseSpecification responseSpec,
 final Integer accountID) {
-final String GET_FIXED_DEPOSIT_BY_ID_URL = FIXED_DEPOSIT_ACCOUNT_URL + 
"/" + accountID + "?" + Utils.TENANT_IDENTIFIER;
+final String getFixedDepositByIDurl = FIXED_DEPOSIT_ACCOUNT_URL + "/" 
+ accountID + "?" + Utils.TENANT_IDENTIFIER;
 LOG.info(" RETRIEVING FIXED DEPOSIT ACCOUNT BY 
ID -");

Review comment:
   agreed, updated.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [fineract] thesmallstar commented on a change in pull request #1290: Added and Enforced AbbreviationAsWordInName Checkstyle (FINERACT-821)

2020-09-21 Thread GitBox



thesmallstar commented on a change in pull request #1290:
URL: https://github.com/apache/fineract/pull/1290#discussion_r491843455



##
File path: 
fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/common/loans/LoanTransactionHelper.java
##
@@ -303,46 +303,46 @@ public HashMap withdrawLoanApplicationByClient(final 
String date, final Integer
 
 public Integer addChargesForLoan(final Integer loanId, final String 
request) {
 LOG.info("- ADD CHARGES FOR LOAN 
");
-final String ADD_CHARGES_URL = "/fineract-provider/api/v1/loans/" + 
loanId + "/charges?" + Utils.TENANT_IDENTIFIER;
-final HashMap response = Utils.performServerPost(requestSpec, 
responseSpec, ADD_CHARGES_URL, request, "");
+final String chargesURL = "/fineract-provider/api/v1/loans/" + loanId 
+ "/charges?" + Utils.TENANT_IDENTIFIER;

Review comment:
   updated, I dont know what I was thinking at that time, probably a 
mistake.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [fineract] thesmallstar commented on a change in pull request #1290: Added and Enforced AbbreviationAsWordInName Checkstyle (FINERACT-821)

2020-09-21 Thread GitBox



thesmallstar commented on a change in pull request #1290:
URL: https://github.com/apache/fineract/pull/1290#discussion_r491843695



##
File path: 
fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/common/fixeddeposit/FixedDepositProductHelper.java
##
@@ -436,8 +436,8 @@ public static ArrayList 
retrieveAllFixedDepositProducts(final RequestSpecificati
 public static HashMap retrieveFixedDepositProductById(final 
RequestSpecification requestSpec, final ResponseSpecification responseSpec,
 final String productId) {
 LOG.info(" RETRIEVING FIXED DEPOSIT PRODUCT BY 
ID ");
-final String GET_FD_PRODUCT_BY_ID_URL = FIXED_DEPOSIT_PRODUCT_URL + 
"/" + productId + "?" + Utils.TENANT_IDENTIFIER;
-final HashMap response = Utils.performServerGet(requestSpec, 
responseSpec, GET_FD_PRODUCT_BY_ID_URL, "");
+final String getFDproductByIDurl = FIXED_DEPOSIT_PRODUCT_URL + "/" + 
productId + "?" + Utils.TENANT_IDENTIFIER;
+final HashMap response = Utils.performServerGet(requestSpec, 
responseSpec, getFDproductByIDurl, "");

Review comment:
   agreed, updated.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [fineract] thesmallstar commented on a change in pull request #1290: Added and Enforced AbbreviationAsWordInName Checkstyle (FINERACT-821)

2020-09-21 Thread GitBox



thesmallstar commented on a change in pull request #1290:
URL: https://github.com/apache/fineract/pull/1290#discussion_r491842279



##
File path: 
fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/LoanWithWaiveInterestAndWriteOffIntegrationTest.java
##
@@ -140,7 +140,7 @@ public void checkClientLoanCreateAndDisburseFlow() {
 }
 
 @Test
-public void checkClientLoan_WRITTEN_OFF() {
+public void checkClientLoanWrittenOFF() {

Review comment:
   fixed.

##
File path: 
fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/boot/EmbeddedTomcatWithSSLConfiguration.java
##
@@ -55,7 +55,7 @@ protected Connector createSslConnector() {
 File keystore = getFile(getKeystore());
 connector.setScheme("https");
 connector.setSecure(true);
-connector.setPort(getHTTPSPort());
+connector.setPort(getHTTPSport());

Review comment:
   fixed





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [fineract] thesmallstar commented on a change in pull request #1290: Added and Enforced AbbreviationAsWordInName Checkstyle (FINERACT-821)

2020-08-28 Thread GitBox



thesmallstar commented on a change in pull request #1290:
URL: https://github.com/apache/fineract/pull/1290#discussion_r478860118



##
File path: 
fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/RecurringDepositTest.java
##
@@ -2774,11 +2774,11 @@ public void 
testRecurringDepositQuarterlyCompoundingAndQuarterlyPosting_360_Days
 Assertions.assertNotNull(recurringDepositProductId);
 
 Integer recurringDepositAccountId = 
applyForRecurringDepositApplication(clientId.toString(), 
recurringDepositProductId.toString(),
-VALID_FROM, VALID_TO, SUBMITTED_ON_DATE, WHOLE_TERM, 
expectedFirstDepositOnDate);
+VALID_FROM, VALID_TO, submittedOnDate, WHOLE_TERM, 
expectedFirstDepositOnDate);
 Assertions.assertNotNull(recurringDepositAccountId);
 
 HashMap modificationsHashMap = 
this.recurringDepositAccountHelper.updateInterestCalculationConfigForRecurringDeposit(
-clientId.toString(), recurringDepositProductId.toString(), 
recurringDepositAccountId.toString(), SUBMITTED_ON_DATE,
+clientId.toString(), recurringDepositProductId.toString(), 
recurringDepositAccountId.toString(), submittedOnDate,
 VALID_FROM, VALID_TO, DAYS_360, WHOLE_TERM, 
INTEREST_CALCULATION_USING_DAILY_BALANCE, QUARTERLY, QUARTERLY,

Review comment:
   no this is how it should be, the other variables are static finals 
(constant) and hence they are named like that. 





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [fineract] thesmallstar commented on a change in pull request #1290: Added and Enforced AbbreviationAsWordInName Checkstyle (FINERACT-821)

[GitHub] [fineract] thesmallstar commented on a change in pull request #1290: Added and Enforced AbbreviationAsWordInName Checkstyle (FINERACT-821)

[GitHub] [fineract] thesmallstar commented on a change in pull request #1290: Added and Enforced AbbreviationAsWordInName Checkstyle (FINERACT-821)

[GitHub] [fineract] thesmallstar commented on a change in pull request #1290: Added and Enforced AbbreviationAsWordInName Checkstyle (FINERACT-821)

[GitHub] [fineract] thesmallstar commented on a change in pull request #1290: Added and Enforced AbbreviationAsWordInName Checkstyle (FINERACT-821)

[GitHub] [fineract] thesmallstar commented on a change in pull request #1290: Added and Enforced AbbreviationAsWordInName Checkstyle (FINERACT-821)

[GitHub] [fineract] thesmallstar commented on a change in pull request #1290: Added and Enforced AbbreviationAsWordInName Checkstyle (FINERACT-821)

[GitHub] [fineract] thesmallstar commented on a change in pull request #1290: Added and Enforced AbbreviationAsWordInName Checkstyle (FINERACT-821)

[GitHub] [fineract] thesmallstar commented on a change in pull request #1290: Added and Enforced AbbreviationAsWordInName Checkstyle (FINERACT-821)

[GitHub] [fineract] thesmallstar commented on a change in pull request #1290: Added and Enforced AbbreviationAsWordInName Checkstyle (FINERACT-821)

[GitHub] [fineract] thesmallstar commented on a change in pull request #1290: Added and Enforced AbbreviationAsWordInName Checkstyle (FINERACT-821)

[GitHub] [fineract] thesmallstar commented on a change in pull request #1290: Added and Enforced AbbreviationAsWordInName Checkstyle (FINERACT-821)

[GitHub] [fineract] thesmallstar commented on a change in pull request #1290: Added and Enforced AbbreviationAsWordInName Checkstyle (FINERACT-821)

[GitHub] [fineract] thesmallstar commented on a change in pull request #1290: Added and Enforced AbbreviationAsWordInName Checkstyle (FINERACT-821)

14 matches

Site Navigation

Mail list logo

Footer information