[GitHub] [fineract] thesmallstar commented on pull request #1251: FINERACT-1095 Added status parameter in Loans API
thesmallstar commented on pull request #1251: URL: https://github.com/apache/fineract/pull/1251#issuecomment-730561952 @ptuomola @vorburger thanks, on it :) Sorry for delaying this long, I have been juggling between college exams, assignments and health :( I will be done with my finals on 28th and have a month-long holiday, and I would have plenty of time to commit daily!! PS: I miss the summer days and lot of "productive" discussions with @vorburger @ptuomola and @xurror :D This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [fineract] thesmallstar commented on pull request #1251: FINERACT-1095 Added status parameter in Loans API
thesmallstar commented on pull request #1251: URL: https://github.com/apache/fineract/pull/1251#issuecomment-700315401 @vorburger oops, I missed to ping you after I pushed new changes. I think we can merge this now? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [fineract] thesmallstar commented on pull request #1251: FINERACT-1095 Added status parameter in Loans API
thesmallstar commented on pull request #1251: URL: https://github.com/apache/fineract/pull/1251#issuecomment-698608546 @vorburger @ptuomola @luckyman20 Thank you for waiting a long time for these here is the update: 1. As mentioned by @ptuomola for using the implementation ["a","b"] that cannot be really used here because the request type is not JSON, but we can do something similar. 2. The API now takes one string and works for both: examples: a. "active" b. "active,approved" Example URLS: https://localhost:8443/fineract-provider/api/v1/loans?status=active,approved=default=true 3. We will merge this now, I will write the Integration tests and I have also made an issue so that we don't forget to do it. https://issues.apache.org/jira/browse/FINERACT-1160 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [fineract] thesmallstar commented on pull request #1251: FINERACT-1095 Added status parameter in Loans API
thesmallstar commented on pull request #1251: URL: https://github.com/apache/fineract/pull/1251#issuecomment-698608546 @vorburger @ptuomola @luckyman20 Thank you for waiting a long time for these here is the update: 1. As mentioned by @ptuomola for using the implementation ["a","b"] that cannot be really used here because the request type is not JSON, but we can do something similar. 2. The API now takes one string and works for both: examples: a. "active" b. "active,approved" Example URLS: https://localhost:8443/fineract-provider/api/v1/loans?status=active,approved=default=true 3. We will merge this now, I will write the Integration tests and I have also made an issue so that we don't forget to do it. https://issues.apache.org/jira/browse/FINERACT-1160 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [fineract] thesmallstar commented on pull request #1251: FINERACT-1095 Added status parameter in Loans API
thesmallstar commented on pull request #1251: URL: https://github.com/apache/fineract/pull/1251#issuecomment-696933182 @vorburger yes already working on it! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [fineract] thesmallstar commented on pull request #1251: FINERACT-1095 Added status parameter in Loans API
thesmallstar commented on pull request #1251: URL: https://github.com/apache/fineract/pull/1251#issuecomment-696933182 @vorburger yes already working on it! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [fineract] thesmallstar commented on pull request #1251: FINERACT-1095 Added status parameter in Loans API
thesmallstar commented on pull request #1251: URL: https://github.com/apache/fineract/pull/1251#issuecomment-691527335 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [fineract] thesmallstar commented on pull request #1251: FINERACT-1095 Added status parameter in Loans API
thesmallstar commented on pull request #1251: URL: https://github.com/apache/fineract/pull/1251#issuecomment-691527335 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [fineract] thesmallstar commented on pull request #1251: FINERACT-1095 Added status parameter in Loans API
thesmallstar commented on pull request #1251: URL: https://github.com/apache/fineract/pull/1251#issuecomment-691527335 @vorburger sorry for the delay, I am in between of my college mid-semester exams, I will continue working as soon as I am done with it(hopefully no sooner than 19th Sept). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [fineract] thesmallstar commented on pull request #1251: FINERACT-1095 Added status parameter in Loans API
thesmallstar commented on pull request #1251: URL: https://github.com/apache/fineract/pull/1251#issuecomment-687846652 @vorburger yup I will fix this in a day or two. @ptuomola thanks for the suggestion!! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [fineract] thesmallstar commented on pull request #1251: FINERACT-1095 Added status parameter in Loans API
thesmallstar commented on pull request #1251: URL: https://github.com/apache/fineract/pull/1251#issuecomment-683417327 @ptuomola @vorburger , From my discussions with @luckyman20 we came to the conclusion that we cannot send two parameters from the community-app, do you see any other solution to solve this one? We need our API to accept a list of strings... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [fineract] thesmallstar commented on pull request #1251: FINERACT-1095 Added status parameter in Loans API
thesmallstar commented on pull request #1251: URL: https://github.com/apache/fineract/pull/1251#issuecomment-680306593 @luckyman20 and I, are still not able to figure out how to do this on the frontend, I will try to get it done tomorrow, after which we can merge this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [fineract] thesmallstar commented on pull request #1251: FINERACT-1095 Added status parameter in Loans API
thesmallstar commented on pull request #1251: URL: https://github.com/apache/fineract/pull/1251#issuecomment-680306139 @vorburger It would be nice if we could merge this rn, Since this is blocking the work for removing SQL String concatenation, I will have enough time and I am making an issue so that I don't forget the IT for this ;) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [fineract] thesmallstar commented on pull request #1251: FINERACT-1095 Added status parameter in Loans API
thesmallstar commented on pull request #1251: URL: https://github.com/apache/fineract/pull/1251#issuecomment-680266177 @vorburger @ptuomola taking exceptionally long time to write tests since it is really hard to understand how loans work :( This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [fineract] thesmallstar commented on pull request #1251: FINERACT-1095 Added status parameter in Loans API
thesmallstar commented on pull request #1251: URL: https://github.com/apache/fineract/pull/1251#issuecomment-679000910 @vorburger yes yes, I am in conversion with @luckyman20 we are trying to resolve the frontend part. We should confirm it by today, And then find the best way for this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [fineract] thesmallstar commented on pull request #1251: FINERACT-1095 Added status parameter in Loans API
thesmallstar commented on pull request #1251: URL: https://github.com/apache/fineract/pull/1251#issuecomment-675096834 @vorburger @ptuomola @luckyman20 As soon as this is merged, we can completely remove sqlsearch and the PRs #1171 and #1123 can be merged with minor changes. And we will be done with removing all SQL string concatenations from our code :D This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
