[GitHub] [fineract] vorburger commented on pull request #1251: FINERACT-1095 Added status parameter in Loans API
vorburger commented on pull request #1251: URL: https://github.com/apache/fineract/pull/1251#issuecomment-731561291 > Sorry for delaying this long, I have been juggling between college exams, assignments and health :( Don't say Sorry! You have no "obligation" to continue contributing to this project (after your GSoC) - no stress! Best wishes for health. > I will be done with my finals on 28th and have a month-long holiday, and I would have plenty of time to commit daily!! But we are of course excited to hear from you! If you can make the time, we always love to hear from you. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #1251: FINERACT-1095 Added status parameter in Loans API
vorburger commented on pull request #1251: URL: https://github.com/apache/fineract/pull/1251#issuecomment-717046148 @thesmallstar @ptuomola where were we with this one? Good to merge as-is, or updates needed? (Perhaps best to rebase it now.) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #1251: FINERACT-1095 Added status parameter in Loans API
vorburger commented on pull request #1251: URL: https://github.com/apache/fineract/pull/1251#issuecomment-698790415 @thesmallstar sounds like a plan, and PK for me to add the IT in a follow up. But the build on this is not passing, did you see? BTW watch the related discussion over on https://github.com/openMF/community-app/issues/3275. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #1251: FINERACT-1095 Added status parameter in Loans API
vorburger commented on pull request #1251: URL: https://github.com/apache/fineract/pull/1251#issuecomment-698790415 @thesmallstar sounds like a plan, and PK for me to add the IT in a follow up. But the build on this is not passing, did you see? BTW watch the related discussion over on https://github.com/openMF/community-app/issues/3275. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #1251: FINERACT-1095 Added status parameter in Loans API
vorburger commented on pull request #1251: URL: https://github.com/apache/fineract/pull/1251#issuecomment-696929477 @thesmallstar hope your exams went well! Whenever you have time to pick this up, we appreciate your contributions, very much! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #1251: FINERACT-1095 Added status parameter in Loans API
vorburger commented on pull request #1251: URL: https://github.com/apache/fineract/pull/1251#issuecomment-696929477 @thesmallstar hope your exams went well! Whenever you have time to pick this up, we appreciate your contributions, very much! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #1251: FINERACT-1095 Added status parameter in Loans API
vorburger commented on pull request #1251: URL: https://github.com/apache/fineract/pull/1251#issuecomment-691273760 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #1251: FINERACT-1095 Added status parameter in Loans API
vorburger commented on pull request #1251: URL: https://github.com/apache/fineract/pull/1251#issuecomment-691273760 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #1251: FINERACT-1095 Added status parameter in Loans API
vorburger commented on pull request #1251: URL: https://github.com/apache/fineract/pull/1251#issuecomment-691273760 @thesmallstar friendly ping, update? (as well as now have to rebase and fix merge conflict) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #1251: FINERACT-1095 Added status parameter in Loans API
vorburger commented on pull request #1251: URL: https://github.com/apache/fineract/pull/1251#issuecomment-687845780 @thesmallstar the suggestion from @ptuomola in the last comment on FINERACT-1095 to use e.g. `"loanStatus": ["all","active","overpaid"], "loanProducts": ["65","97","73","82"], "offices": ["1","10","100"]` syntax makes a lot of sense, to me.. will you do the needful here? It would be cool if we could wrap up FINERACT-1095! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #1251: FINERACT-1095 Added status parameter in Loans API
vorburger commented on pull request #1251: URL: https://github.com/apache/fineract/pull/1251#issuecomment-680293678 > @vorburger @ptuomola taking exceptionally long time to write tests since it is really hard to understand how loans work :( if you have a more specific question, then perhaps @ptuomola (likely better than me!) can answer. but if it's just writing integration tests for this that's very significant additional work, than perhaps it wouldn't be the end of the world to get this merged without additional new ITs already (but it can break existing ITs, of course), and then perhaps later add more test coverage for it, when (if) you have more time. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #1251: FINERACT-1095 Added status parameter in Loans API
vorburger commented on pull request #1251: URL: https://github.com/apache/fineract/pull/1251#issuecomment-679000204 @thesmallstar are you on this? :smiling_imp: This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
