[GitHub] [fineract] vorburger opened a new pull request #692: add GitHub Action to autoclose stale pull requests
vorburger opened a new pull request #692: add GitHub Action to autoclose stale pull requests URL: https://github.com/apache/fineract/pull/692 It will automatically add a comment after 30 days, and then another 30 days later (so after a total of 60 days of inactivity) automatically close Pull Requests. https://github.com/marketplace/actions/close-stale-issues https://github.com/actions/stale/blob/master/action.yml https://github.com/actions/stale This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [fineract] vorburger commented on issue #684: more SpotBugs related / inspired code clean up (see FINERACT-702)
vorburger commented on issue #684: more SpotBugs related / inspired code clean up (see FINERACT-702) URL: https://github.com/apache/fineract/pull/684#issuecomment-573551071 @awasum this now passed the build (because it's Monday), and is finished and ready from my side. Will you review and merge this one when you have a moment? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[fineract] annotated tag release-1.4.0 created (now 5d9773d)
This is an automated email from the ASF dual-hosted git repository. nazeer1100126 pushed a change to annotated tag release-1.4.0 in repository https://gitbox.apache.org/repos/asf/fineract.git. at 5d9773d (tag) tagging 7420545d8f9c35276954def94a58800b29bdde93 (commit) replaces 1.3.0 by Shaik Nazeer Hussain on Mon Jan 13 13:46:16 2020 +0530 - Log - Fineract 1.4.0 release --- No new revisions were added by this update.
[GitHub] [fineract] vorburger merged pull request #693: fix build.gradle for RAT to ignore .github/workflows/
vorburger merged pull request #693: fix build.gradle for RAT to ignore .github/workflows/ URL: https://github.com/apache/fineract/pull/693 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [fineract] vorburger commented on issue #692: add GitHub Action to autoclose stale pull requests
vorburger commented on issue #692: add GitHub Action to autoclose stale pull requests URL: https://github.com/apache/fineract/pull/692#issuecomment-573563316 @awasum and anyone else reading this, how about adding this? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[fineract] branch develop updated (7420545 -> 0379ba7)
This is an automated email from the ASF dual-hosted git repository. vorburger pushed a change to branch develop in repository https://gitbox.apache.org/repos/asf/fineract.git. from 7420545 Merge pull request #690 from vorburger/FINERACT-773_fix-docker-compose add 0379ba7 fix build.gradle for RAT to ignore .github/workflows/ No new revisions were added by this update. Summary of changes: fineract-provider/build.gradle | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
[fineract] branch vorburger-stale-action updated (a8c0e97 -> 286277d)
This is an automated email from the ASF dual-hosted git repository. vorburger pushed a change to branch vorburger-stale-action in repository https://gitbox.apache.org/repos/asf/fineract.git. discard a8c0e97 add GitHub Action to autoclose stale pull requests add 0379ba7 fix build.gradle for RAT to ignore .github/workflows/ add 286277d add GitHub Action to autoclose stale pull requests This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (a8c0e97) \ N -- N -- N refs/heads/vorburger-stale-action (286277d) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. No new revisions were added by this update. Summary of changes: fineract-provider/build.gradle | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
[fineract] branch vorburger-slash-rebase-pr-comment-action updated (ad56f0d -> aa310aa)
This is an automated email from the ASF dual-hosted git repository. vorburger pushed a change to branch vorburger-slash-rebase-pr-comment-action in repository https://gitbox.apache.org/repos/asf/fineract.git. discard ad56f0d add /rebase comment support for Pull Requests add aa310aa add /rebase comment support for Pull Requests This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (ad56f0d) \ N -- N -- N refs/heads/vorburger-slash-rebase-pr-comment-action (aa310aa) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. No new revisions were added by this update. Summary of changes: .github/workflows/rebase.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
[fineract] 01/01: add GitHub Action to autoclose stale pull requests
This is an automated email from the ASF dual-hosted git repository.
vorburger pushed a commit to branch vorburger-stale-action
in repository https://gitbox.apache.org/repos/asf/fineract.git
commit a8c0e97217616175a7a8f54ae598701115d99a46
Author: Michael Vorburger ⛑️
AuthorDate: Mon Jan 13 09:13:31 2020 +0100
add GitHub Action to autoclose stale pull requests
It will automatically add a comment after 30 days, and then another 30 days
later (so after a total of 60 days of inactivity) automatically close Pull
Requests.
https://github.com/marketplace/actions/close-stale-issues
https://github.com/actions/stale/blob/master/action.yml
https://github.com/actions/stale
---
.github/workflows/stale.yml | 20
1 file changed, 20 insertions(+)
diff --git a/.github/workflows/stale.yml b/.github/workflows/stale.yml
new file mode 100644
index 000..252f296
--- /dev/null
+++ b/.github/workflows/stale.yml
@@ -0,0 +1,20 @@
+# https://github.com/marketplace/actions/close-stale-issues
+# https://github.com/actions/stale/blob/master/action.yml
+# https://github.com/actions/stale
+name: Mark stale issues and pull requests
+on:
+ schedule:
+ - cron: "0 0 * * *"
+jobs:
+ stale:
+runs-on: ubuntu-latest
+steps:
+- uses: actions/stale@v1
+ with:
+repo-token: ${{ secrets.GITHUB_TOKEN }}
+# stale-issue-message: 'Stale issue message'
+# stale-issue-label: 'no-issue-activity'
+stale-pr-message: 'This pull request seems to be stale. Are you still
planning to work on it? We will automatically close it in 30 days.'
+stale-pr-label: 'stale'
+days-before-stale: 30
+days-before-close: 30
[fineract] branch vorburger-stale-action created (now a8c0e97)
This is an automated email from the ASF dual-hosted git repository. vorburger pushed a change to branch vorburger-stale-action in repository https://gitbox.apache.org/repos/asf/fineract.git. at a8c0e97 add GitHub Action to autoclose stale pull requests This branch includes the following new commits: new a8c0e97 add GitHub Action to autoclose stale pull requests The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
[fineract] branch 1.4.0 created (now 7420545)
This is an automated email from the ASF dual-hosted git repository. nazeer1100126 pushed a change to branch 1.4.0 in repository https://gitbox.apache.org/repos/asf/fineract.git. at 7420545 Merge pull request #690 from vorburger/FINERACT-773_fix-docker-compose No new revisions were added by this update.
[GitHub] [fineract] vorburger commented on issue #691: add /rebase comment support for Pull Requests
vorburger commented on issue #691: add /rebase comment support for Pull Requests URL: https://github.com/apache/fineract/pull/691#issuecomment-573554719 #693 will fix the build failure seen here This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[fineract] branch vorburger-slash-rebase-pr-comment-action updated (aa310aa -> 6c0755a)
This is an automated email from the ASF dual-hosted git repository. vorburger pushed a change to branch vorburger-slash-rebase-pr-comment-action in repository https://gitbox.apache.org/repos/asf/fineract.git. discard aa310aa add /rebase comment support for Pull Requests add 0379ba7 fix build.gradle for RAT to ignore .github/workflows/ add 6c0755a add /rebase comment support for Pull Requests This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (aa310aa) \ N -- N -- N refs/heads/vorburger-slash-rebase-pr-comment-action (6c0755a) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. No new revisions were added by this update. Summary of changes: .github/workflows/rebase.yml | 2 +- fineract-provider/build.gradle | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
[GitHub] [fineract] vorburger commented on issue #692: add GitHub Action to autoclose stale pull requests
vorburger commented on issue #692: add GitHub Action to autoclose stale pull requests URL: https://github.com/apache/fineract/pull/692#issuecomment-573791466 The test build failure seen here seems arbitrary, I've created [FINERACT-828](https://issues.apache.org/jira/browse/FINERACT-828), let's just retry. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [fineract] vorburger closed pull request #692: add GitHub Action to autoclose stale pull requests
vorburger closed pull request #692: add GitHub Action to autoclose stale pull requests URL: https://github.com/apache/fineract/pull/692 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [fineract] vorburger opened a new pull request #692: add GitHub Action to autoclose stale pull requests
vorburger opened a new pull request #692: add GitHub Action to autoclose stale pull requests URL: https://github.com/apache/fineract/pull/692 It will automatically add a comment after 30 days, and then another 30 days later (so after a total of 60 days of inactivity) automatically close Pull Requests. https://github.com/marketplace/actions/close-stale-issues https://github.com/actions/stale/blob/master/action.yml https://github.com/actions/stale This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [fineract] vorburger opened a new pull request #685: clean up GLAccountBuilder, following SpotBugs (FINERACT-702)
vorburger opened a new pull request #685: clean up GLAccountBuilder, following SpotBugs (FINERACT-702) URL: https://github.com/apache/fineract/pull/685 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [fineract] vorburger closed pull request #684: more SpotBugs related / inspired code clean up (see FINERACT-702)
vorburger closed pull request #684: more SpotBugs related / inspired code clean up (see FINERACT-702) URL: https://github.com/apache/fineract/pull/684 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [fineract] vorburger closed pull request #685: clean up GLAccountBuilder, following SpotBugs (FINERACT-702)
vorburger closed pull request #685: clean up GLAccountBuilder, following SpotBugs (FINERACT-702) URL: https://github.com/apache/fineract/pull/685 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [fineract] vorburger opened a new pull request #684: more SpotBugs related / inspired code clean up (see FINERACT-702)
vorburger opened a new pull request #684: more SpotBugs related / inspired code clean up (see FINERACT-702) URL: https://github.com/apache/fineract/pull/684 based upon code review of changes made by @awasum in previous commit: - fix clear contains() GC_UNRELATED_TYPES bug in Loan - fix clear equals() EC_UNRELATED_TYPES bug in Loan - fix more equals() & hashCode() in... * Charge * TrialBalance * LoanProductBorrowerCycleVariations * LoanProductProvisioningEntry - fix AccountingConstants to avoid using @FindBugsSuppressWarnings - fix SelfLoansDataValidator instead of @FindBugsSuppressWarnings - fix up weird static in GLAccountBuilder - minor clean up in build.gradle (spotbugs has replaced findbugs) PS: This change originally included also fixing the missing `hashCode()` and `equals()` in `ShareAccountCharge`, but that turned out to be non trivial, see [FINERACT-827](https://issues.apache.org/jira/browse/FINERACT-827), and is thus not yet fixed by this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [fineract] vorburger commented on issue #664: FINERACT-802-restrict-client-to-have-single-self-service-user
vorburger commented on issue #664: FINERACT-802-restrict-client-to-have-single-self-service-user URL: https://github.com/apache/fineract/pull/664#issuecomment-573794166 jamesidw@ yes sorry you are absolutely correct of course... ;-) aimanoj@ will you rebase and resolve conflicts for this PR? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [fineract] vorburger commented on issue #592: FINERACT-614: Rates Module
vorburger commented on issue #592: FINERACT-614: Rates Module URL: https://github.com/apache/fineract/pull/592#issuecomment-573793341 > Ok, I will rebase the branch with dev. No problem @angelboxes were you still planning to do that? Just asking. If not, would you like to close this one? Once this doesn't have merge conflicts anymore and builds, we need to find someone who can do a functional verification. Could I suggest that you ask on the public mailing list asking who can review this for you? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [fineract] jamesidw commented on issue #664: FINERACT-802-restrict-client-to-have-single-self-service-user
jamesidw commented on issue #664: FINERACT-802-restrict-client-to-have-single-self-service-user URL: https://github.com/apache/fineract/pull/664#issuecomment-573663057 @aimanoj I believe that should have been directed at you (since this PR comes from your repository) @vorburger Don't think I can This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [fineract] awasum commented on issue #692: add GitHub Action to autoclose stale pull requests
awasum commented on issue #692: add GitHub Action to autoclose stale pull requests URL: https://github.com/apache/fineract/pull/692#issuecomment-573834932 > @awasum and anyone else reading this, how about adding this? This makes sense to have a 60 day auto close rule. I have no experience with Github Actions. Merge when you feel comfortable with this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[fineract] branch Fineract-614 updated (bf0393b -> 565999a)
This is an automated email from the ASF dual-hosted git repository.
angelboxes pushed a change to branch Fineract-614
in repository https://gitbox.apache.org/repos/asf/fineract.git.
from bf0393b Fixing some code to be compatible with Spring update
add 565999a Fineract-614: Renaming SQL file for a higher version number
No new revisions were added by this update.
Summary of changes:
.../resources/sql/migrations/core_db/{V352__rates.sql => V354__rates.sql} | 0
1 file changed, 0 insertions(+), 0 deletions(-)
rename
fineract-provider/src/main/resources/sql/migrations/core_db/{V352__rates.sql =>
V354__rates.sql} (100%)
[fineract] branch Fineract-614 updated (867e7e1 -> bf0393b)
This is an automated email from the ASF dual-hosted git repository. angelboxes pushed a change to branch Fineract-614 in repository https://gitbox.apache.org/repos/asf/fineract.git. discard 867e7e1 Merge branch 'develop' into Fineract-614 discard c66c55f FINERACT-737: Updated Api Docs to include loan charges paid by FINERACT-736: Api Docs were updated to include rates documentation FINERACT-735: Integration test were created for rates creation, retrieval and update discard 68345a4 A new rates module was added to define new rates that can be used to set min and max nominal interest rate, when a new loan account is created they can be used to determine which rates may be applicable for the loan account. add cc181b5 reset/verify all default global configurations in some integration tests (PR #671 for FINERACT-722) add 0da4cdd Parallelization of Jobs: Parallelizing and paging of recalculate interest for loans (PR #524 for FINERACT-428) add 030d9c8 fix potential NPE in JobParameter.equals() (FINERACT-428) add f739f91 Merge pull request #672 from vorburger/fix-equals-NPE add 5bce242 change .travis.yml to only run docker test if integration test passed add ba6f778 Merge pull request #675 from apache/vorburger-travis add a93a6b8 Change /authentication API to pass data in request body instead of URL arguments (FINERACT-726) add ff702db FINERACT-803 fix exception handling for username duplication add 865e5a5 FINERACT-803 change the license comment type add 75f7c59 add .project and .settings/ to .gitignore add af0dd7e use SpotBugs & fix over 300 high priority rule violations (FINERACT-702) add 89b996c Revert changes made to LoanReschedulingWithinCenterTest (FINERACT-702) add 4e1d87f fix broken docker-compose set up (re. FINERACT-773) add 7420545 Merge pull request #690 from vorburger/FINERACT-773_fix-docker-compose add 0379ba7 fix build.gradle for RAT to ignore .github/workflows/ add c7a27f9 A new rates module was added to define new rates that can be used to set min and max nominal interest rate, when a new loan account is created they can be used to determine which rates may be applicable for the loan account. add 01c5231 FINERACT-737: Updated Api Docs to include loan charges paid by FINERACT-736: Api Docs were updated to include rates documentation FINERACT-735: Integration test were created for rates creation, retrieval and update add bf0393b Fixing some code to be compatible with Spring update This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (867e7e1) \ N -- N -- N refs/heads/Fineract-614 (bf0393b) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. No new revisions were added by this update. Summary of changes: .gitignore | 3 + .travis.yml| 9 +- fineract-provider/build.gradle | 17 +- fineract-provider/dependencies.gradle | 2 +- .../integrationtests/CenterIntegrationTest.java| 27 +- .../ClientLoanIntegrationTest.java | 53 ++-- .../ClientSavingsIntegrationTest.java | 64 ++--- ...ientUndoRejectAndWithdrawalIntegrationTest.java | 37 +-- .../fineract/integrationtests/CurrenciesTest.java | 15 +- ...xibleSavingsInterestPostingIntegrationTest.java | 3 +- ...restChargedFromDateSameAsDisbursalDateTest.java | 7 + .../integrationtests/GlobalConfigurationTest.java | 7 + .../LoanReschedulingWithinCenterTest.java | 9 +- .../integrationtests/SchedulerJobsTestResults.java | 53 ++-- .../SkipRepaymentOnMonthFirstTest.java | 7 + .../integrationtests/UserAdministrationTest.java | 126 + .../integrationtests/common/CenterDomain.java | 8 +- .../integrationtests/common/CurrenciesHelper.java | 6 +- .../common/GlobalConfigurationHelper.java | 280 +++- .../fineract/integrationtests/common/Utils.java| 11 +- .../integrationtests/common/WorkingDaysHelper.java | 15 +- .../common/accounting/GLAccountBuilder.java| 90 +++ .../common/savings/SavingsAccountHelper.java | 28 +- .../savings/SavingsApplicationTestBuilder.java | 6 +- .../shares/ShareAccountIntegrationTests.java | 24 +- .../shares/ShareAccountTransactionHelper.java | 7 +- .../common/shares/ShareProductHelper.java
[GitHub] [fineract] awasum commented on issue #688: clean up all whitespace issues in Java files (FINERACT-821)
awasum commented on issue #688: clean up all whitespace issues in Java files (FINERACT-821) URL: https://github.com/apache/fineract/pull/688#issuecomment-574042839 > @awasum I'll fix the Merge Conflicts on this one **AFTER** my other work in #684 and #685 has been reviewed and merged. (I expect it may be simplest & fastest to just completely "recreate" this PR, from scratch on HEAD, by running the commands shown above, instead of actually resolving conflicts individually.) Makes sense. Go for it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [fineract] vorburger commented on issue #691: add /rebase comment support for Pull Requests
vorburger commented on issue #691: add /rebase comment support for Pull Requests
URL: https://github.com/apache/fineract/pull/691#issuecomment-574045294
self merging this one based on @awasum comment in #692 ("no experience with
Github Actions. Merge when you feel comfortable with this.") - I don't expect
any other committers could have a problem with this.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] vorburger merged pull request #691: add /rebase comment support for Pull Requests
vorburger merged pull request #691: add /rebase comment support for Pull Requests URL: https://github.com/apache/fineract/pull/691 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[fineract] branch develop updated: add /rebase comment support for Pull Requests
This is an automated email from the ASF dual-hosted git repository.
vorburger pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/fineract.git
The following commit(s) were added to refs/heads/develop by this push:
new 653b0b7 add /rebase comment support for Pull Requests
653b0b7 is described below
commit 653b0b76dd19c46ea3e1a82d2efcc223fba17e0e
Author: Michael Vorburger ⛑️
AuthorDate: Mon Jan 13 08:54:53 2020 +0100
add /rebase comment support for Pull Requests
https://github.com/marketplace/actions/automatic-rebase
https://github.com/cirrus-actions/rebase
---
.github/workflows/rebase.yml | 23 +++
1 file changed, 23 insertions(+)
diff --git a/.github/workflows/rebase.yml b/.github/workflows/rebase.yml
new file mode 100644
index 000..d8df210
--- /dev/null
+++ b/.github/workflows/rebase.yml
@@ -0,0 +1,23 @@
+# https://github.com/marketplace/actions/automatic-rebase
(https://github.com/cirrus-actions/rebase)
+on:
+ issue_comment:
+types: [created]
+name: Automatic Rebase
+jobs:
+ rebase:
+name: Rebase
+if: github.event.issue.pull_request != '' &&
contains(github.event.comment.body, '/rebase')
+runs-on: ubuntu-latest
+steps:
+- uses: actions/checkout@master
+- name: Automatic Rebase
+ uses: cirrus-actions/rebase@1.2
+ env:
+GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+ #
https://github.community/t5/GitHub-Actions/Workflow-is-failing-if-no-job-can-be-ran-due-to-condition/m-p/38186#M3250
+ always_job:
+name: Aways run job
+runs-on: ubuntu-latest
+steps:
+ - name: Always run
+run: "echo \"fineract/.github/workflows/rebase.yml: This job is used
to prevent the workflow to fail when all other jobs are skipped.\""
[GitHub] [fineract] vorburger commented on a change in pull request #629: Swagger documentation gsoc2019
vorburger commented on a change in pull request #629: Swagger documentation
gsoc2019
URL: https://github.com/apache/fineract/pull/629#discussion_r366189471
##
File path:
fineract-provider/src/main/java/org/apache/fineract/portfolio/floatingrates/api/FloatingRatesApiResource.java
##
@@ -45,7 +45,11 @@
@Path("/floatingrates")
@Component
@Scope("singleton")
-@Api(value = "Floating Rates", description = "It lets you create, list,
retrieve and upload the floating rates")
+@Api(tags = {"Floating Rates"})
+@SwaggerDefinition(tags = {
+ @Tag(name = "Floating Rates", description = "It lets you
create, list, retrieve and upload the floating rates")
Review comment:
@Sanyam96 I would not worry too much about this kind of thing (whitespace
and indent), we're about to have a general solution for this, please watch
[FINERACT-821](https://issues.apache.org/jira/browse/FINERACT-821). (Help from
you on that one would be very welcome BTW!)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] awasum commented on issue #629: Swagger documentation gsoc2019
awasum commented on issue #629: Swagger documentation gsoc2019 URL: https://github.com/apache/fineract/pull/629#issuecomment-574038079 @Sanyam96 , @vorburger , Seems conflicts are now fixed by @kangbreder and Travis is passing. Merge this when yo feel comfortable... instead create more issues and enhancement tickets related to this feature on Jira for @kangbreder to pick up and fix gradually. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [fineract] vorburger merged pull request #692: add GitHub Action to autoclose stale pull requests
vorburger merged pull request #692: add GitHub Action to autoclose stale pull requests URL: https://github.com/apache/fineract/pull/692 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[fineract] branch develop updated (0379ba7 -> 54b7ddf)
This is an automated email from the ASF dual-hosted git repository. vorburger pushed a change to branch develop in repository https://gitbox.apache.org/repos/asf/fineract.git. from 0379ba7 fix build.gradle for RAT to ignore .github/workflows/ add 54b7ddf add GitHub Action to autoclose stale pull requests No new revisions were added by this update. Summary of changes: .github/workflows/stale.yml | 20 1 file changed, 20 insertions(+) create mode 100644 .github/workflows/stale.yml
[GitHub] [fineract] vorburger commented on issue #688: clean up all whitespace issues in Java files (FINERACT-821)
vorburger commented on issue #688: clean up all whitespace issues in Java files (FINERACT-821) URL: https://github.com/apache/fineract/pull/688#issuecomment-574040714 @awasum I'll fix the Merge Conflicts on this one **AFTER** my other work in #684 and #685 has been reviewed and merged. (I expect it may be simplest & fastest to just completely "recreate" this PR, from scratch on HEAD, by running the commands shown above, instead of actually resolving conflicts individually.) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [fineract] vorburger commented on issue #688: clean up all whitespace issues in Java files (FINERACT-821)
vorburger commented on issue #688: clean up all whitespace issues in Java files (FINERACT-821) URL: https://github.com/apache/fineract/pull/688#issuecomment-574043410 > Makes sense. Go for it. but I'm waiting for you to review and hopefully merge #684 and #685 ... :smiley: This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [fineract] awasum commented on issue #691: add /rebase comment support for Pull Requests
awasum commented on issue #691: add /rebase comment support for Pull Requests URL: https://github.com/apache/fineract/pull/691#issuecomment-574043551 @vorburger Do we need this documented somewhere on the readme. It can be done after this has been merged if you want. Looks like just writing /rebase in a PR comment should activate this action and rebase the PR. Is this correct? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [fineract] vorburger commented on a change in pull request #629: Swagger documentation gsoc2019
vorburger commented on a change in pull request #629: Swagger documentation gsoc2019 URL: https://github.com/apache/fineract/pull/629#discussion_r366188664 ## File path: fineract-provider/build.gradle ## @@ -59,6 +60,8 @@ apply plugin: 'eclipse' apply plugin: 'idea' apply plugin: 'com.bmuschko.tomcat' apply plugin: 'project-report' +apply plugin: 'java' Review comment: @kangbreder do you happen to remember why you had to add `apply plugin: 'java'` here? Does it work without it as well? I guess it's a bit strange to have a project use BOTH `apply plugin: 'java-library'` AND `apply plugin: 'java'` - it's either or the other. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [fineract] vorburger commented on issue #629: Swagger documentation gsoc2019
vorburger commented on issue #629: Swagger documentation gsoc2019 URL: https://github.com/apache/fineract/pull/629#issuecomment-574047849 /rebase This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [fineract] awasum commented on issue #592: FINERACT-614: Rates Module
awasum commented on issue #592: FINERACT-614: Rates Module URL: https://github.com/apache/fineract/pull/592#issuecomment-574036658 @angelboxes , we now have spotbugs enabled for Fineract. So check to make sure your changes do not fail spotbug rules. See #670 #673 Fineract has also been updated to use recent spring boot version. So a few changes might be needed here too. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[fineract] branch develop updated (54b7ddf -> efb0a55)
This is an automated email from the ASF dual-hosted git repository. vorburger pushed a change to branch develop in repository https://gitbox.apache.org/repos/asf/fineract.git. from 54b7ddf add GitHub Action to autoclose stale pull requests add efb0a55 FINERACT-824: Removed the second validation since realCause.getCause() is null if it is equal to realCause No new revisions were added by this update. Summary of changes: .../service/LoanApplicationWritePlatformServiceJpaRepositoryImpl.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
[GitHub] [fineract] vorburger merged pull request #683: FINERACT-824: NullPointerException is thrown when submitting a loan account application with an existing externalId
vorburger merged pull request #683: FINERACT-824: NullPointerException is thrown when submitting a loan account application with an existing externalId URL: https://github.com/apache/fineract/pull/683 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [fineract] awasum merged pull request #685: clean up GLAccountBuilder, following SpotBugs (FINERACT-702)
awasum merged pull request #685: clean up GLAccountBuilder, following SpotBugs (FINERACT-702) URL: https://github.com/apache/fineract/pull/685 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[fineract] branch develop updated: clean up GLAccountBuilder, following SpotBugs (FINERACT-702)
This is an automated email from the ASF dual-hosted git repository.
awasum pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/fineract.git
The following commit(s) were added to refs/heads/develop by this push:
new a5c60b0 clean up GLAccountBuilder, following SpotBugs (FINERACT-702)
new eee163a Merge pull request #685 from
vorburger/spotbugs-extra-GLAccountBuilder
a5c60b0 is described below
commit a5c60b06e59314dc701a6f62c8aa45d272eddc0f
Author: Michael Vorburger
AuthorDate: Sat Jan 11 00:02:11 2020 +0100
clean up GLAccountBuilder, following SpotBugs (FINERACT-702)
SpotBugs didn't like the original version, and the initial changes made
for SpotBugs satisfied SpotBugs, but the class was still pretty weird.
This change makes it follow the regular standard builder pattern.
---
.../common/accounting/GLAccountBuilder.java| 47 +++---
1 file changed, 24 insertions(+), 23 deletions(-)
diff --git
a/fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/common/accounting/GLAccountBuilder.java
b/fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/common/accounting/GLAccountBuilder.java
index 348c913..0e8467a 100644
---
a/fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/common/accounting/GLAccountBuilder.java
+++
b/fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/common/accounting/GLAccountBuilder.java
@@ -26,69 +26,70 @@ import java.util.HashMap;
public class GLAccountBuilder {
-public final String ASSET_ACCOUNT = "1";
-public final String LIABILITY_ACCOUNT = "2";
-public final String EQUITY_ACCOUNT = "3";
-public final String INCOME_ACCOUNT = "4";
-public final String EXPENSE_ACCOUNT = "5";
+public static final String ASSET_ACCOUNT = "1";
+public static final String LIABILITY_ACCOUNT = "2";
+public static final String EQUITY_ACCOUNT = "3";
+public static final String INCOME_ACCOUNT = "4";
+public static final String EXPENSE_ACCOUNT = "5";
-private final String ACCOUNT_USAGE_DETAIL = "1";
-private final String ACCOUNT_USAGE_HEADER = "2";
-private final String MANUAL_ENTRIES_ALLOW = "true";
-private final String MANUAL_ENTRIES_NOT_ALLOW = "false";
+private static final String ACCOUNT_USAGE_DETAIL = "1";
+private static final String ACCOUNT_USAGE_HEADER = "2";
+private static final String MANUAL_ENTRIES_ALLOW = "true";
+private static final String MANUAL_ENTRIES_NOT_ALLOW = "false";
+
+private static final String DESCRIPTION = "DEFAULT_DESCRIPTION";
private String name = Utils.randomStringGenerator("ACCOUNT_NAME_", 5);
-private String GLCode = "";
+private String glCode = "";
private String accountType = "";
private String accountUsage = ACCOUNT_USAGE_DETAIL;
private String manualEntriesAllowed = MANUAL_ENTRIES_ALLOW;
-private String description = "DEFAULT_DESCRIPTION";
public String build() {
final HashMap map = new HashMap<>();
map.put("name", name);
-map.put("glCode", GLCode);
+map.put("glCode", glCode);
map.put("manualEntriesAllowed", manualEntriesAllowed);
map.put("type", accountType);
map.put("usage", accountUsage);
-map.put("description", description);
+map.put("description", DESCRIPTION);
return new Gson().toJson(map);
}
public GLAccountBuilder withAccountTypeAsAsset() {
accountType = ASSET_ACCOUNT;
-GLCode = Utils.randomStringGenerator("ASSET_", 2);
+glCode = Utils.randomStringGenerator("ASSET_", 2);
// Add unique timestamp to avoid random collisions
-GLCode += Calendar.getInstance().getTimeInMillis() + "";
+glCode += Calendar.getInstance().getTimeInMillis() + "";
return this;
}
public GLAccountBuilder withAccountTypeAsLiability() {
accountType = LIABILITY_ACCOUNT;
-GLCode = Utils.randomStringGenerator("LIABILITY_", 2);
-GLCode += Calendar.getInstance().getTimeInMillis() + "";
+glCode = Utils.randomStringGenerator("LIABILITY_", 2);
+glCode += Calendar.getInstance().getTimeInMillis() + "";
return this;
}
public GLAccountBuilder withAccountTypeAsAsEquity() {
accountType = EQUITY_ACCOUNT;
-GLCode = Utils.randomStringGenerator("EQUITY_", 2);
-GLCode += Calendar.getInstance().getTimeInMillis() + "";
+glCode = Utils.randomStringGenerator("EQUITY_", 2);
+glCode += Calendar.getInstance().getTimeInMillis() + "";
return this;
}
public GLAccountBuilder withAccountTypeAsIncome() {
accountType = INCOME_ACCOUNT;
-GLCode = Utils.randomStringGenerator("INCOME_", 2);
-GLCode += Calendar.getInstance().getTimeInMillis() + "";
+glCode =
[GitHub] [fineract] awasum merged pull request #684: more SpotBugs related / inspired code clean up (see FINERACT-702)
awasum merged pull request #684: more SpotBugs related / inspired code clean up (see FINERACT-702) URL: https://github.com/apache/fineract/pull/684 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [fineract] awasum commented on issue #688: clean up all whitespace issues in Java files (FINERACT-821)
awasum commented on issue #688: clean up all whitespace issues in Java files (FINERACT-821) URL: https://github.com/apache/fineract/pull/688#issuecomment-574044939 > > Makes sense. Go for it. > > but I'm waiting for you to review and hopefully merge #684 and #685 ... I think you are all set. Both PRs have now been merged. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [fineract] awasum commented on issue #685: clean up GLAccountBuilder, following SpotBugs (FINERACT-702)
awasum commented on issue #685: clean up GLAccountBuilder, following SpotBugs (FINERACT-702) URL: https://github.com/apache/fineract/pull/685#issuecomment-574044586 This looks good merging now. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
