This is an automated email from the ASF dual-hosted git repository. mmartell pushed a commit to branch GEODE-9712-genericize-netcore in repository https://gitbox.apache.org/repos/asf/geode-native.git
commit a5fc92096f969326da2edb10c2d81dce615d571b Author: Mike Martell <mmart...@pivotal.io> AuthorDate: Wed Dec 8 15:14:07 2021 -0800 Modify tests for generics (wip) --- netcore/netcore-integration-test/CacheTest.cs | 2 +- .../netcore-integration-test/RegionFactoryTest.cs | 34 ++++++++++++---------- 2 files changed, 20 insertions(+), 16 deletions(-) diff --git a/netcore/netcore-integration-test/CacheTest.cs b/netcore/netcore-integration-test/CacheTest.cs index f35d181..ececc4f 100644 --- a/netcore/netcore-integration-test/CacheTest.cs +++ b/netcore/netcore-integration-test/CacheTest.cs @@ -80,7 +80,7 @@ namespace Apache.Geode.Client.IntegrationTests { cacheFactory.PdxIgnoreUnreadFields = true; using var cache = cacheFactory.CreateCache(); Assert.NotNull(cache); - using var regionFactory = cache.CreateRegionFactory( + var regionFactory = cache.CreateRegionFactory<string>( RegionShortcut.Proxy); // lgtm[cs / useless - assignment - to - local] Assert.NotNull(regionFactory); } diff --git a/netcore/netcore-integration-test/RegionFactoryTest.cs b/netcore/netcore-integration-test/RegionFactoryTest.cs index edac8ad..a995547 100644 --- a/netcore/netcore-integration-test/RegionFactoryTest.cs +++ b/netcore/netcore-integration-test/RegionFactoryTest.cs @@ -57,38 +57,41 @@ namespace Apache.Geode.Client.IntegrationTests { poolFactory.CreatePool("myPool"); // lgtm[cs / useless - assignment - to - local] } - private void doPutsAndGets(Region region) { + private void doPutsAndGets(IRegion<object, object> region) { var fullname1 = "Robert Timmons"; var fullname2 = "Sylvia Charles"; + var car = new Dictionary<int, string>() { { 1, "Ford" }, { 2, "Chevy" } }; - region.PutString(Username1, fullname1); - region.PutString(Username2, fullname2); + region.Put(Username1, fullname1); + region.Put(777, fullname2); + region.Put(888, car); - var user1 = region.GetString(Username1); - var user2 = region.GetString(Username2); + var user1 = region.Get(Username1); + var user2 = region.Get(777); + var car1 = region.Get(888); Assert.Equal(user1, fullname1); Assert.Equal(user2, fullname2); } - private void DoRemoves(Region region) { - region.Remove(Username1); - region.Remove(Username2); + private void DoRemoves(IRegion<string, string> region) { + //region.Remove(Username1); + //region.Remove(Username2); - var hasUser1 = region.ContainsValueForKey(Username1); - var hasUser2 = region.ContainsValueForKey(Username2); + //var hasUser1 = region.ContainsValueForKey(Username1); + //var hasUser2 = region.ContainsValueForKey(Username2); - Assert.False(hasUser1); - Assert.False(hasUser2); + //Assert.False(hasUser1); + //Assert.False(hasUser2); } private void CreateRegionAndDoWork(IGeodeCache cache, string regionName, RegionShortcut regionType) { - using var regionFactory = cache.CreateRegionFactory(regionType); - using var region = regionFactory.CreateRegion(regionName); + var regionFactory = cache.CreateRegionFactory<string>(regionType); + var region = regionFactory.Create<object, object>(regionName); doPutsAndGets(region); - DoRemoves(region); + //DoRemoves(region); } [Fact] @@ -102,6 +105,7 @@ namespace Apache.Geode.Client.IntegrationTests { .CreatePool("myPool"); CreateRegionAndDoWork(cache, "exampleRegion", RegionShortcut.Proxy); + } [Fact]