[4/4] guacamole-server git commit: GUACAMOLE-597: Merge add optional flags to OSC for controlling redirected terminal output.
GUACAMOLE-597: Merge add optional flags to OSC for controlling redirected terminal output. Project: http://git-wip-us.apache.org/repos/asf/guacamole-server/repo Commit: http://git-wip-us.apache.org/repos/asf/guacamole-server/commit/d8cb2218 Tree: http://git-wip-us.apache.org/repos/asf/guacamole-server/tree/d8cb2218 Diff: http://git-wip-us.apache.org/repos/asf/guacamole-server/diff/d8cb2218 Branch: refs/heads/master Commit: d8cb2218ee5b96ce23f8a1cc077988f61abbfb29 Parents: 79ce5ad e66178f Author: Nick Couchman Authored: Fri Jul 27 22:08:20 2018 -0400 Committer: Nick Couchman Committed: Fri Jul 27 22:08:20 2018 -0400 -- src/terminal/terminal.c | 12 +++--- src/terminal/terminal/terminal.h | 35 +- src/terminal/terminal_handlers.c | 41 +++ 3 files changed, 75 insertions(+), 13 deletions(-) --
[1/4] guacamole-server git commit: GUACAMOLE-597: Additionally parse integer flags which may affect pipe stream contents.
Repository: guacamole-server
Updated Branches:
refs/heads/master 79ce5ad8b -> d8cb2218e
GUACAMOLE-597: Additionally parse integer flags which may affect pipe stream
contents.
Project: http://git-wip-us.apache.org/repos/asf/guacamole-server/repo
Commit: http://git-wip-us.apache.org/repos/asf/guacamole-server/commit/e02df8d5
Tree: http://git-wip-us.apache.org/repos/asf/guacamole-server/tree/e02df8d5
Diff: http://git-wip-us.apache.org/repos/asf/guacamole-server/diff/e02df8d5
Branch: refs/heads/master
Commit: e02df8d5504214acf3b01cc55e124754ce0b4bcf
Parents: 79ce5ad
Author: Michael Jumper
Authored: Sun Jul 1 22:25:09 2018 -0700
Committer: Michael Jumper
Committed: Fri Jul 27 14:23:33 2018 -0700
--
src/terminal/terminal.c | 8 +---
src/terminal/terminal/terminal.h | 14 +-
src/terminal/terminal_handlers.c | 33 +
3 files changed, 43 insertions(+), 12 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/guacamole-server/blob/e02df8d5/src/terminal/terminal.c
--
diff --git a/src/terminal/terminal.c b/src/terminal/terminal.c
index b24ec8e..5a106ad 100644
--- a/src/terminal/terminal.c
+++ b/src/terminal/terminal.c
@@ -1961,7 +1961,8 @@ int guac_terminal_next_tab(guac_terminal* term, int
column) {
return tabstop;
}
-void guac_terminal_pipe_stream_open(guac_terminal* term, const char* name) {
+void guac_terminal_pipe_stream_open(guac_terminal* term, const char* name,
+int flags) {
guac_client* client = term->client;
guac_socket* socket = client->socket;
@@ -1972,13 +1973,14 @@ void guac_terminal_pipe_stream_open(guac_terminal*
term, const char* name) {
/* Allocate and assign new pipe stream */
term->pipe_stream = guac_client_alloc_stream(client);
term->pipe_buffer_length = 0;
+term->pipe_stream_flags = flags;
/* Open new pipe stream */
guac_protocol_send_pipe(socket, term->pipe_stream, "text/plain", name);
/* Log redirect at debug level */
-guac_client_log(client, GUAC_LOG_DEBUG,
-"Terminal output now redirected to pipe '%s'.", name);
+guac_client_log(client, GUAC_LOG_DEBUG, "Terminal output now directed to "
+"pipe \"%s\" (flags=%i).", name, flags);
}
http://git-wip-us.apache.org/repos/asf/guacamole-server/blob/e02df8d5/src/terminal/terminal/terminal.h
--
diff --git a/src/terminal/terminal/terminal.h b/src/terminal/terminal/terminal.h
index adadc4f..e086392 100644
--- a/src/terminal/terminal/terminal.h
+++ b/src/terminal/terminal/terminal.h
@@ -216,6 +216,13 @@ struct guac_terminal {
guac_stream* pipe_stream;
/**
+ * Bitwise OR of all flags which apply to the currently-open pipe stream.
+ * If no pipe stream is open, this value has no meaning, and its contents
+ * are undefined.
+ */
+int pipe_stream_flags;
+
+/**
* Buffer of data pending write to the pipe_stream. Data within this buffer
* will be flushed to the pipe_stream when either (1) the buffer is full
* and another character needs to be written or (2) the pipe_stream is
@@ -920,8 +927,13 @@ int guac_terminal_next_tab(guac_terminal* term, int
column);
*
* @param name
* The name of the pipe stream to open.
+ *
+ * @param flags
+ * A bitwise OR of all integer flags which should apply to the new pipe
+ * stream.
*/
-void guac_terminal_pipe_stream_open(guac_terminal* term, const char* name);
+void guac_terminal_pipe_stream_open(guac_terminal* term, const char* name,
+int flags);
/**
* Writes a single byte of data to the pipe stream currently open and
http://git-wip-us.apache.org/repos/asf/guacamole-server/blob/e02df8d5/src/terminal/terminal_handlers.c
--
diff --git a/src/terminal/terminal_handlers.c b/src/terminal/terminal_handlers.c
index afbf20e..1437307 100644
--- a/src/terminal/terminal_handlers.c
+++ b/src/terminal/terminal_handlers.c
@@ -1141,27 +1141,44 @@ int guac_terminal_download(guac_terminal* term,
unsigned char c) {
int guac_terminal_open_pipe_stream(guac_terminal* term, unsigned char c) {
-static char stream_name[2048];
+static char param[2048];
static int length = 0;
+static int flags = 0;
/* Open pipe on ECMA-48 ST (String Terminator) */
if (c == 0x9C || c == 0x5C || c == 0x07) {
-/* End stream name string */
-stream_name[length++] = '\0';
+/* End parameter string */
+param[length++] = '\0';
length = 0;
-/* Open new pipe stream */
-guac_terminal_pipe_stream_open(term, stream_name);
+/* Open new pipe stream using final parameter as name */
+
[2/4] guacamole-server git commit: GUACAMOLE-597: Add flag which sends terminal output to both the user's display and the open pipe stream.
GUACAMOLE-597: Add flag which sends terminal output to both the user's display
and the open pipe stream.
Project: http://git-wip-us.apache.org/repos/asf/guacamole-server/repo
Commit: http://git-wip-us.apache.org/repos/asf/guacamole-server/commit/99b17b0a
Tree: http://git-wip-us.apache.org/repos/asf/guacamole-server/tree/99b17b0a
Diff: http://git-wip-us.apache.org/repos/asf/guacamole-server/diff/99b17b0a
Branch: refs/heads/master
Commit: 99b17b0ac46ab073fe78bc0fc335aa2d3fd15039
Parents: e02df8d
Author: Michael Jumper
Authored: Sun Jul 1 22:28:04 2018 -0700
Committer: Michael Jumper
Committed: Fri Jul 27 14:23:44 2018 -0700
--
src/terminal/terminal/terminal.h | 11 +++
src/terminal/terminal_handlers.c | 8 +++-
2 files changed, 18 insertions(+), 1 deletion(-)
--
http://git-wip-us.apache.org/repos/asf/guacamole-server/blob/99b17b0a/src/terminal/terminal/terminal.h
--
diff --git a/src/terminal/terminal/terminal.h b/src/terminal/terminal/terminal.h
index e086392..4e04fc7 100644
--- a/src/terminal/terminal/terminal.h
+++ b/src/terminal/terminal/terminal.h
@@ -98,6 +98,13 @@
*/
#define GUAC_TERMINAL_SCHEME_NUMBERED "color"
+/**
+ * Flag which specifies that terminal output should be sent to both the current
+ * pipe stream and the user's display. By default, terminal output will be sent
+ * only to the open pipe.
+ */
+#define GUAC_TERMINAL_PIPE_INTERPRET_OUTPUT 1
+
typedef struct guac_terminal guac_terminal;
/**
@@ -219,6 +226,8 @@ struct guac_terminal {
* Bitwise OR of all flags which apply to the currently-open pipe stream.
* If no pipe stream is open, this value has no meaning, and its contents
* are undefined.
+ *
+ * @see GUAC_TERMINAL_PIPE_INTERPRET_OUTPUT
*/
int pipe_stream_flags;
@@ -931,6 +940,8 @@ int guac_terminal_next_tab(guac_terminal* term, int column);
* @param flags
* A bitwise OR of all integer flags which should apply to the new pipe
* stream.
+ *
+ * @see GUAC_TERMINAL_PIPE_INTERPRET_OUTPUT
*/
void guac_terminal_pipe_stream_open(guac_terminal* term, const char* name,
int flags);
http://git-wip-us.apache.org/repos/asf/guacamole-server/blob/99b17b0a/src/terminal/terminal_handlers.c
--
diff --git a/src/terminal/terminal_handlers.c b/src/terminal/terminal_handlers.c
index 1437307..a6469ac 100644
--- a/src/terminal/terminal_handlers.c
+++ b/src/terminal/terminal_handlers.c
@@ -135,8 +135,14 @@ int guac_terminal_echo(guac_terminal* term, unsigned char
c) {
/* Echo to pipe stream if open and not starting an ESC sequence */
if (term->pipe_stream != NULL && c != 0x1B) {
+
guac_terminal_pipe_stream_write(term, c);
-return 0;
+
+/* Do not render output while pipe is open unless explicitly requested
+ * via flags */
+if (!(term->pipe_stream_flags & GUAC_TERMINAL_PIPE_INTERPRET_OUTPUT))
+return 0;
+
}
/* If using non-Unicode mapping, just map straight bytes */
[3/4] guacamole-server git commit: GUACAMOLE-597: Add flag for forcing automatic flushing of pipe stream.
GUACAMOLE-597: Add flag for forcing automatic flushing of pipe stream.
Project: http://git-wip-us.apache.org/repos/asf/guacamole-server/repo
Commit: http://git-wip-us.apache.org/repos/asf/guacamole-server/commit/e66178ff
Tree: http://git-wip-us.apache.org/repos/asf/guacamole-server/tree/e66178ff
Diff: http://git-wip-us.apache.org/repos/asf/guacamole-server/diff/e66178ff
Branch: refs/heads/master
Commit: e66178ff9abee8e38f11f4241068015cba6073f0
Parents: 99b17b0
Author: Michael Jumper
Authored: Sun Jul 1 22:45:01 2018 -0700
Committer: Michael Jumper
Committed: Fri Jul 27 14:23:50 2018 -0700
--
src/terminal/terminal.c | 4
src/terminal/terminal/terminal.h | 10 ++
2 files changed, 14 insertions(+)
--
http://git-wip-us.apache.org/repos/asf/guacamole-server/blob/e66178ff/src/terminal/terminal.c
--
diff --git a/src/terminal/terminal.c b/src/terminal/terminal.c
index 5a106ad..184a323 100644
--- a/src/terminal/terminal.c
+++ b/src/terminal/terminal.c
@@ -1551,6 +1551,10 @@ void guac_terminal_flush(guac_terminal* terminal) {
if (terminal->typescript != NULL)
guac_terminal_typescript_flush(terminal->typescript);
+/* Flush pipe stream if automatic flushing is enabled */
+if (terminal->pipe_stream_flags & GUAC_TERMINAL_PIPE_AUTOFLUSH)
+guac_terminal_pipe_stream_flush(terminal);
+
/* Flush display state */
guac_terminal_select_redraw(terminal);
guac_terminal_commit_cursor(terminal);
http://git-wip-us.apache.org/repos/asf/guacamole-server/blob/e66178ff/src/terminal/terminal/terminal.h
--
diff --git a/src/terminal/terminal/terminal.h b/src/terminal/terminal/terminal.h
index 4e04fc7..730deec 100644
--- a/src/terminal/terminal/terminal.h
+++ b/src/terminal/terminal/terminal.h
@@ -105,6 +105,14 @@
*/
#define GUAC_TERMINAL_PIPE_INTERPRET_OUTPUT 1
+/**
+ * Flag which forces the open pipe stream to be flushed automatically, whenever
+ * a new frame would be rendered, with only minimal buffering performed between
+ * frames. By default, the contents of the pipe stream will be flushed only
+ * when the buffer is full or the pipe stream is being closed.
+ */
+#define GUAC_TERMINAL_PIPE_AUTOFLUSH 2
+
typedef struct guac_terminal guac_terminal;
/**
@@ -228,6 +236,7 @@ struct guac_terminal {
* are undefined.
*
* @see GUAC_TERMINAL_PIPE_INTERPRET_OUTPUT
+ * @see GUAC_TERMINAL_PIPE_AUTOFLUSH
*/
int pipe_stream_flags;
@@ -942,6 +951,7 @@ int guac_terminal_next_tab(guac_terminal* term, int column);
* stream.
*
* @see GUAC_TERMINAL_PIPE_INTERPRET_OUTPUT
+ * @see GUAC_TERMINAL_PIPE_AUTOFLUSH
*/
void guac_terminal_pipe_stream_open(guac_terminal* term, const char* name,
int flags);
[2/4] guacamole-client git commit: GUACAMOLE-598: Add convenience promise callback for REST requests which displays a fatal error.
GUACAMOLE-598: Add convenience promise callback for REST requests which
displays a fatal error.
Project: http://git-wip-us.apache.org/repos/asf/guacamole-client/repo
Commit: http://git-wip-us.apache.org/repos/asf/guacamole-client/commit/c897c7eb
Tree: http://git-wip-us.apache.org/repos/asf/guacamole-client/tree/c897c7eb
Diff: http://git-wip-us.apache.org/repos/asf/guacamole-client/diff/c897c7eb
Branch: refs/heads/master
Commit: c897c7eb261a70f1c5d7bb8d839d7080b4cd0e24
Parents: 4bc7700
Author: Michael Jumper
Authored: Tue Jun 26 22:45:52 2018 -0700
Committer: Michael Jumper
Committed: Fri Jul 27 14:49:08 2018 -0700
--
.../webapp/app/rest/services/requestService.js | 20 ++--
1 file changed, 18 insertions(+), 2 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/guacamole-client/blob/c897c7eb/guacamole/src/main/webapp/app/rest/services/requestService.js
--
diff --git a/guacamole/src/main/webapp/app/rest/services/requestService.js
b/guacamole/src/main/webapp/app/rest/services/requestService.js
index 9aef124..8b13caf 100644
--- a/guacamole/src/main/webapp/app/rest/services/requestService.js
+++ b/guacamole/src/main/webapp/app/rest/services/requestService.js
@@ -25,8 +25,9 @@ angular.module('rest').factory('requestService', ['$injector',
function requestService($injector) {
// Required services
-var $http = $injector.get('$http');
-var $log = $injector.get('$log');
+var $http = $injector.get('$http');
+var $log = $injector.get('$log');
+var $rootScope = $injector.get('$rootScope');
// Required types
var Error = $injector.get('Error');
@@ -115,6 +116,21 @@ angular.module('rest').factory('requestService',
['$injector',
$log.warn(error.type, error.message || error.translatableMessage);
});
+/**
+ * Promise error callback which replaces the content of the page with a
+ * generic error message warning that the page could not be displayed. All
+ * rejections are logged to the browser console as errors. This callback
+ * should be used in favor of @link{WARN} if REST errors will result in the
+ * page being unusable.
+ *
+ * @constant
+ * @type Function
+ */
+service.DIE = service.createErrorCallback(function fatalPageError(error) {
+$rootScope.$broadcast('guacFatalPageError', error);
+$log.error(error.type, error.message || error.translatableMessage);
+});
+
return service;
}]);
[4/4] guacamole-client git commit: GUACAMOLE-598: Merge display fatal error if a page is unusable/nonfunctional.
GUACAMOLE-598: Merge display fatal error if a page is unusable/nonfunctional. Project: http://git-wip-us.apache.org/repos/asf/guacamole-client/repo Commit: http://git-wip-us.apache.org/repos/asf/guacamole-client/commit/5ce0c0f0 Tree: http://git-wip-us.apache.org/repos/asf/guacamole-client/tree/5ce0c0f0 Diff: http://git-wip-us.apache.org/repos/asf/guacamole-client/diff/5ce0c0f0 Branch: refs/heads/master Commit: 5ce0c0f0358096d87e19c7decdb4d6dfd21aeff5 Parents: 587c0c2 5866c7e Author: Nick Couchman Authored: Fri Jul 27 21:54:19 2018 -0400 Committer: Nick Couchman Committed: Fri Jul 27 21:54:19 2018 -0400 -- .../app/auth/service/authenticationService.js | 4 ++ .../app/groupList/directives/guacGroupList.js | 2 +- .../app/home/controllers/homeController.js | 2 +- .../app/index/controllers/indexController.js| 21 ++- .../app/index/styles/fatal-page-error.css | 61 .../controllers/manageConnectionController.js | 2 +- .../manageConnectionGroupController.js | 2 +- .../manageSharingProfileController.js | 2 +- .../manage/controllers/manageUserController.js | 2 +- .../directives/connectionPermissionEditor.js| 2 +- .../manage/directives/systemPermissionEditor.js | 2 +- .../app/navigation/directives/guacUserMenu.js | 2 +- .../app/navigation/services/userPageService.js | 8 +-- .../webapp/app/rest/services/requestService.js | 20 ++- .../directives/guacSettingsConnectionHistory.js | 2 +- .../directives/guacSettingsConnections.js | 4 +- .../directives/guacSettingsPreferences.js | 2 +- .../settings/directives/guacSettingsSessions.js | 4 +- .../settings/directives/guacSettingsUsers.js| 4 +- guacamole/src/main/webapp/index.html| 46 ++- guacamole/src/main/webapp/translations/en.json | 1 + 21 files changed, 155 insertions(+), 40 deletions(-) --
[1/4] guacamole-client git commit: GUACAMOLE-598: Add absolute, global, fatal error handling.
Repository: guacamole-client
Updated Branches:
refs/heads/master 587c0c207 -> 5ce0c0f03
GUACAMOLE-598: Add absolute, global, fatal error handling.
Project: http://git-wip-us.apache.org/repos/asf/guacamole-client/repo
Commit: http://git-wip-us.apache.org/repos/asf/guacamole-client/commit/4bc7700d
Tree: http://git-wip-us.apache.org/repos/asf/guacamole-client/tree/4bc7700d
Diff: http://git-wip-us.apache.org/repos/asf/guacamole-client/diff/4bc7700d
Branch: refs/heads/master
Commit: 4bc7700d575bcf7001997aa019b0c91768092673
Parents: 587c0c2
Author: Michael Jumper
Authored: Tue Jun 26 22:45:28 2018 -0700
Committer: Michael Jumper
Committed: Fri Jul 27 14:48:56 2018 -0700
--
.../app/index/controllers/indexController.js| 21 ++-
.../app/index/styles/fatal-page-error.css | 61
guacamole/src/main/webapp/index.html| 46 ++-
guacamole/src/main/webapp/translations/en.json | 1 +
4 files changed, 112 insertions(+), 17 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/guacamole-client/blob/4bc7700d/guacamole/src/main/webapp/app/index/controllers/indexController.js
--
diff --git a/guacamole/src/main/webapp/app/index/controllers/indexController.js
b/guacamole/src/main/webapp/app/index/controllers/indexController.js
index 5cff962..15e7819 100644
--- a/guacamole/src/main/webapp/app/index/controllers/indexController.js
+++ b/guacamole/src/main/webapp/app/index/controllers/indexController.js
@@ -28,7 +28,15 @@ angular.module('index').controller('indexController',
['$scope', '$injector',
var $window = $injector.get('$window');
var clipboardService = $injector.get('clipboardService');
var guacNotification = $injector.get('guacNotification');
-
+
+/**
+ * The error that prevents the current page from rendering at all. If no
+ * such error has occurred, this will be null.
+ *
+ * @type Error
+ */
+$scope.fatalError = null;
+
/**
* The notification service.
*/
@@ -159,6 +167,7 @@ angular.module('index').controller('indexController',
['$scope', '$injector',
$scope.loginHelpText = null;
$scope.acceptedCredentials = {};
$scope.expectedCredentials = error.expected;
+$scope.fatalError = null;
});
// Prompt for remaining credentials if provided credentials were not enough
@@ -168,6 +177,15 @@ angular.module('index').controller('indexController',
['$scope', '$injector',
$scope.loginHelpText = error.translatableMessage;
$scope.acceptedCredentials = parameters;
$scope.expectedCredentials = error.expected;
+$scope.fatalError = null;
+});
+
+// Replace absolutely all content with an error message if the page itself
+// cannot be displayed due to an error
+$scope.$on('guacFatalPageError', function fatalPageError(error) {
+$scope.page.title = 'APP.NAME';
+$scope.page.bodyClassName = '';
+$scope.fatalError = error;
});
// Update title and CSS class upon navigation
@@ -181,6 +199,7 @@ angular.module('index').controller('indexController',
['$scope', '$injector',
$scope.loginHelpText = null;
$scope.acceptedCredentials = null;
$scope.expectedCredentials = null;
+$scope.fatalError = null;
// Set title
var title = current.$$route.title;
http://git-wip-us.apache.org/repos/asf/guacamole-client/blob/4bc7700d/guacamole/src/main/webapp/app/index/styles/fatal-page-error.css
--
diff --git a/guacamole/src/main/webapp/app/index/styles/fatal-page-error.css
b/guacamole/src/main/webapp/app/index/styles/fatal-page-error.css
new file mode 100644
index 000..a6e28ba
--- /dev/null
+++ b/guacamole/src/main/webapp/app/index/styles/fatal-page-error.css
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+.fatal-page-error-outer {
+display: table;
+
[3/4] guacamole-client git commit: GUACAMOLE-598: Abort rendering of pages if critical data fails to load (data without which the page is non-functional).
GUACAMOLE-598: Abort rendering of pages if critical data fails to load (data
without which the page is non-functional).
Project: http://git-wip-us.apache.org/repos/asf/guacamole-client/repo
Commit: http://git-wip-us.apache.org/repos/asf/guacamole-client/commit/5866c7e2
Tree: http://git-wip-us.apache.org/repos/asf/guacamole-client/tree/5866c7e2
Diff: http://git-wip-us.apache.org/repos/asf/guacamole-client/diff/5866c7e2
Branch: refs/heads/master
Commit: 5866c7e251f05c9345f77215713d4549575db2df
Parents: c897c7e
Author: Michael Jumper
Authored: Tue Jun 26 22:49:06 2018 -0700
Committer: Michael Jumper
Committed: Fri Jul 27 14:50:17 2018 -0700
--
.../main/webapp/app/auth/service/authenticationService.js| 4
.../main/webapp/app/groupList/directives/guacGroupList.js| 2 +-
.../src/main/webapp/app/home/controllers/homeController.js | 2 +-
.../app/manage/controllers/manageConnectionController.js | 2 +-
.../manage/controllers/manageConnectionGroupController.js| 2 +-
.../app/manage/controllers/manageSharingProfileController.js | 2 +-
.../webapp/app/manage/controllers/manageUserController.js| 2 +-
.../app/manage/directives/connectionPermissionEditor.js | 2 +-
.../webapp/app/manage/directives/systemPermissionEditor.js | 2 +-
.../main/webapp/app/navigation/directives/guacUserMenu.js| 2 +-
.../main/webapp/app/navigation/services/userPageService.js | 8
.../app/settings/directives/guacSettingsConnectionHistory.js | 2 +-
.../app/settings/directives/guacSettingsConnections.js | 4 ++--
.../app/settings/directives/guacSettingsPreferences.js | 2 +-
.../webapp/app/settings/directives/guacSettingsSessions.js | 4 ++--
.../main/webapp/app/settings/directives/guacSettingsUsers.js | 4 ++--
16 files changed, 25 insertions(+), 21 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/guacamole-client/blob/5866c7e2/guacamole/src/main/webapp/app/auth/service/authenticationService.js
--
diff --git
a/guacamole/src/main/webapp/app/auth/service/authenticationService.js
b/guacamole/src/main/webapp/app/auth/service/authenticationService.js
index 53b10c6..d05a0d3 100644
--- a/guacamole/src/main/webapp/app/auth/service/authenticationService.js
+++ b/guacamole/src/main/webapp/app/auth/service/authenticationService.js
@@ -205,6 +205,10 @@ angular.module('auth').factory('authenticationService',
['$injector',
else if (error.type === Error.Type.INSUFFICIENT_CREDENTIALS)
$rootScope.$broadcast('guacInsufficientCredentials',
parameters, error);
+// Abort rendering of page if an internal error occurs
+else if (error.type === Error.Type.INTERNAL_ERROR)
+$rootScope.$broadcast('guacFatalPageError', error);
+
// Authentication failed
throw error;
http://git-wip-us.apache.org/repos/asf/guacamole-client/blob/5866c7e2/guacamole/src/main/webapp/app/groupList/directives/guacGroupList.js
--
diff --git
a/guacamole/src/main/webapp/app/groupList/directives/guacGroupList.js
b/guacamole/src/main/webapp/app/groupList/directives/guacGroupList.js
index a0515ea..16ff9dd 100644
--- a/guacamole/src/main/webapp/app/groupList/directives/guacGroupList.js
+++ b/guacamole/src/main/webapp/app/groupList/directives/guacGroupList.js
@@ -222,7 +222,7 @@ angular.module('groupList').directive('guacGroupList',
[function guacGroupList()
});
});
-}, requestService.WARN);
+}, requestService.DIE);
}
http://git-wip-us.apache.org/repos/asf/guacamole-client/blob/5866c7e2/guacamole/src/main/webapp/app/home/controllers/homeController.js
--
diff --git a/guacamole/src/main/webapp/app/home/controllers/homeController.js
b/guacamole/src/main/webapp/app/home/controllers/homeController.js
index 1cedead..6c2bd69 100644
--- a/guacamole/src/main/webapp/app/home/controllers/homeController.js
+++ b/guacamole/src/main/webapp/app/home/controllers/homeController.js
@@ -127,6 +127,6 @@ angular.module('home').controller('homeController',
['$scope', '$injector',
)
.then(function rootGroupsRetrieved(rootConnectionGroups) {
$scope.rootConnectionGroups = rootConnectionGroups;
-}, requestService.WARN);
+}, requestService.DIE);
}]);
http://git-wip-us.apache.org/repos/asf/guacamole-client/blob/5866c7e2/guacamole/src/main/webapp/app/manage/controllers/manageConnectionController.js
--
diff --git
a/guacamole/src/main/webapp/app/manage/controllers/manageConnectionController.js
[jira] [Commented] (GUACAMOLE-598) Fail cleanly if authentication backend is down / misconfigured
[
https://issues.apache.org/jira/browse/GUACAMOLE-598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16560381#comment-16560381
]
Michael Jumper commented on GUACAMOLE-598:
--
I have a set of changes which implement this through adding a
{{requestService.DIE}} constant (similar to
[{{requestService.WARN}}|https://github.com/apache/guacamole-client/blob/587c0c207327c24c94d253defafe864beec71598/guacamole/src/main/webapp/app/rest/services/requestService.js#L105-L116])
which replaces the contents of the current page with a generic error:
!guac-generic-error.png!
The idea behind {{requestService.DIE}} is to provide generic handling where a
simple logged warning is inappropriate, as the desired page will be useless or
nonfunctional if the request in question fails. Using this within the
client-side handling of authentication satisfies the high-level goal of this
issue:
https://github.com/mike-jumper/guacamole-client/tree/fatal-page-error
> Fail cleanly if authentication backend is down / misconfigured
> --
>
> Key: GUACAMOLE-598
> URL: https://issues.apache.org/jira/browse/GUACAMOLE-598
> Project: Guacamole
> Issue Type: Improvement
> Components: guacamole
>Reporter: Michael Jumper
>Assignee: Michael Jumper
>Priority: Major
> Attachments: guac-generic-error.png
>
>
> Depending on the extension in use, it is possible for a backend
> authentication system (such as a MySQL database, LDAP directory, etc.) to
> become unreachable or to be fatally misconfigured, resulting in an internal
> failure during authentication attempts. Because of the way such internal
> failures are handled, this can cause the Guacamole login screen to fail to
> display entirely, masking any notification that might advise the user of the
> failure.
> The authentication system should fail cleanly. As long as doing so does not
> reveal sensitive information about the system, the fact that an error has
> occurred should be relayed to the user such that they can contact their
> administrator or check the relevant logs.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (GUACAMOLE-598) Fail cleanly if authentication backend is down / misconfigured
[ https://issues.apache.org/jira/browse/GUACAMOLE-598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Jumper updated GUACAMOLE-598: - Attachment: guac-generic-error.png > Fail cleanly if authentication backend is down / misconfigured > -- > > Key: GUACAMOLE-598 > URL: https://issues.apache.org/jira/browse/GUACAMOLE-598 > Project: Guacamole > Issue Type: Improvement > Components: guacamole >Reporter: Michael Jumper >Assignee: Michael Jumper >Priority: Major > Attachments: guac-generic-error.png > > > Depending on the extension in use, it is possible for a backend > authentication system (such as a MySQL database, LDAP directory, etc.) to > become unreachable or to be fatally misconfigured, resulting in an internal > failure during authentication attempts. Because of the way such internal > failures are handled, this can cause the Guacamole login screen to fail to > display entirely, masking any notification that might advise the user of the > failure. > The authentication system should fail cleanly. As long as doing so does not > reveal sensitive information about the system, the fact that an error has > occurred should be relayed to the user such that they can contact their > administrator or check the relevant logs. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (GUACAMOLE-598) Fail cleanly if authentication backend is down / misconfigured
[ https://issues.apache.org/jira/browse/GUACAMOLE-598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Jumper reassigned GUACAMOLE-598: Assignee: Michael Jumper > Fail cleanly if authentication backend is down / misconfigured > -- > > Key: GUACAMOLE-598 > URL: https://issues.apache.org/jira/browse/GUACAMOLE-598 > Project: Guacamole > Issue Type: Improvement > Components: guacamole >Reporter: Michael Jumper >Assignee: Michael Jumper >Priority: Major > > Depending on the extension in use, it is possible for a backend > authentication system (such as a MySQL database, LDAP directory, etc.) to > become unreachable or to be fatally misconfigured, resulting in an internal > failure during authentication attempts. Because of the way such internal > failures are handled, this can cause the Guacamole login screen to fail to > display entirely, masking any notification that might advise the user of the > failure. > The authentication system should fail cleanly. As long as doing so does not > reveal sensitive information about the system, the fact that an error has > occurred should be relayed to the user such that they can contact their > administrator or check the relevant logs. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (GUACAMOLE-598) Fail cleanly if authentication backend is down / misconfigured
Michael Jumper created GUACAMOLE-598: Summary: Fail cleanly if authentication backend is down / misconfigured Key: GUACAMOLE-598 URL: https://issues.apache.org/jira/browse/GUACAMOLE-598 Project: Guacamole Issue Type: Improvement Components: guacamole Reporter: Michael Jumper Depending on the extension in use, it is possible for a backend authentication system (such as a MySQL database, LDAP directory, etc.) to become unreachable or to be fatally misconfigured, resulting in an internal failure during authentication attempts. Because of the way such internal failures are handled, this can cause the Guacamole login screen to fail to display entirely, masking any notification that might advise the user of the failure. The authentication system should fail cleanly. As long as doing so does not reveal sensitive information about the system, the fact that an error has occurred should be relayed to the user such that they can contact their administrator or check the relevant logs. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (GUACAMOLE-597) Allow fine-grained control of terminal output redirection via pipe streams
[ https://issues.apache.org/jira/browse/GUACAMOLE-597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Jumper reassigned GUACAMOLE-597: Assignee: Michael Jumper > Allow fine-grained control of terminal output redirection via pipe streams > -- > > Key: GUACAMOLE-597 > URL: https://issues.apache.org/jira/browse/GUACAMOLE-597 > Project: Guacamole > Issue Type: New Feature > Components: Terminal >Reporter: Michael Jumper >Assignee: Michael Jumper >Priority: Major > > While Guacamole's terminal emulator allows output to be redirected to a pipe > stream for the benefit of client-side JavaScript (see GUACAMOLE-17), doing so > currently has caveats: > * Redirecting output to a pipe stream results in _all_ output going solely to > that stream. No output is displayed on the terminal while the pipe stream > remains open. This is not always desirable. > * Data sent to the pipe stream is buffered. This works well for > non-interactive bulk transfers of data, but any client-side JavaScript > expecting to monitor output in real-time will be disappointed, particularly > code which must deal with the output of interactive commands. > There should be some option to allow output to go to both the pipe stream and > the terminal, and some option to allow the output to be automatically > flushed, whether that be through a new OSC code or through > backward-compatible modifications to the existing code. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GUACAMOLE-597) Allow fine-grained control of terminal output redirection via pipe streams
[
https://issues.apache.org/jira/browse/GUACAMOLE-597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16560349#comment-16560349
]
Michael Jumper commented on GUACAMOLE-597:
--
I have changes which implement this through adding an optional {{FLAGS}}
argument to the existing OSC sequence for pipe streams (originally defined by
GUACAMOLE-17). The following sequence can now be used:
{{ESC}} {{]}} {{482202}} {{;}} {{FLAGS}} {{;}} {{NAME}} {{ST}}
where {{FLAGS}} is the bitwise OR of any or all of the following flags:
|| Value || Description ||
| 1 | Send output to both the pipe stream *and* the user's display. By default,
output will be sent to only the pipe stream for as long as the pipe stream is
open. |
| 2 | Automatically flush the pipe stream when a frame would be rendered, only
buffering data between frames. By default, data sent to the pipe stream is
buffered until the buffer is full (roughly 6KB) or until the pipe stream is
closed. |
PR incoming.
> Allow fine-grained control of terminal output redirection via pipe streams
> --
>
> Key: GUACAMOLE-597
> URL: https://issues.apache.org/jira/browse/GUACAMOLE-597
> Project: Guacamole
> Issue Type: New Feature
> Components: Terminal
>Reporter: Michael Jumper
>Priority: Major
>
> While Guacamole's terminal emulator allows output to be redirected to a pipe
> stream for the benefit of client-side JavaScript (see GUACAMOLE-17), doing so
> currently has caveats:
> * Redirecting output to a pipe stream results in _all_ output going solely to
> that stream. No output is displayed on the terminal while the pipe stream
> remains open. This is not always desirable.
> * Data sent to the pipe stream is buffered. This works well for
> non-interactive bulk transfers of data, but any client-side JavaScript
> expecting to monitor output in real-time will be disappointed, particularly
> code which must deal with the output of interactive commands.
> There should be some option to allow output to go to both the pipe stream and
> the terminal, and some option to allow the output to be automatically
> flushed, whether that be through a new OSC code or through
> backward-compatible modifications to the existing code.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (GUACAMOLE-597) Allow fine-grained handling of terminal output via pipe streams
[ https://issues.apache.org/jira/browse/GUACAMOLE-597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Jumper updated GUACAMOLE-597: - Description: While Guacamole's terminal emulator allows output to be redirected to a pipe stream for the benefit of client-side JavaScript (see GUACAMOLE-17), doing so currently has caveats: * Redirecting output to a pipe stream results in _all_ output going solely to that stream. No output is displayed on the terminal while the pipe stream remains open. This is not always desirable. * Data sent to the pipe stream is buffered. This works well for non-interactive bulk transfers of data, but any client-side JavaScript expecting to monitor output in real-time will be disappointed, particularly code which must deal with the output of interactive commands. There should be some option to allow output to go to both the pipe stream and the terminal, and some option to allow the output to be automatically flushed, whether that be through a new OSC code or through backward-compatible modifications to the existing code. was: While Guacamole's terminal emulator allows output to be redirected to a pipe stream, doing so results in _all_ output going solely to that stream. No output is displayed on the terminal while the pipe stream remains open. There should be some option to allow output to go to both the pipe stream and the terminal, whether that be through a new OSC code or through backward-compatible modifications to the existing code. > Allow fine-grained handling of terminal output via pipe streams > --- > > Key: GUACAMOLE-597 > URL: https://issues.apache.org/jira/browse/GUACAMOLE-597 > Project: Guacamole > Issue Type: New Feature > Components: Terminal >Reporter: Michael Jumper >Priority: Major > > While Guacamole's terminal emulator allows output to be redirected to a pipe > stream for the benefit of client-side JavaScript (see GUACAMOLE-17), doing so > currently has caveats: > * Redirecting output to a pipe stream results in _all_ output going solely to > that stream. No output is displayed on the terminal while the pipe stream > remains open. This is not always desirable. > * Data sent to the pipe stream is buffered. This works well for > non-interactive bulk transfers of data, but any client-side JavaScript > expecting to monitor output in real-time will be disappointed, particularly > code which must deal with the output of interactive commands. > There should be some option to allow output to go to both the pipe stream and > the terminal, and some option to allow the output to be automatically > flushed, whether that be through a new OSC code or through > backward-compatible modifications to the existing code. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (GUACAMOLE-597) Allow fine-grained control of terminal output redirection via pipe streams
[ https://issues.apache.org/jira/browse/GUACAMOLE-597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Jumper updated GUACAMOLE-597: - Summary: Allow fine-grained control of terminal output redirection via pipe streams (was: Allow fine-grained handling of terminal output via pipe streams) > Allow fine-grained control of terminal output redirection via pipe streams > -- > > Key: GUACAMOLE-597 > URL: https://issues.apache.org/jira/browse/GUACAMOLE-597 > Project: Guacamole > Issue Type: New Feature > Components: Terminal >Reporter: Michael Jumper >Priority: Major > > While Guacamole's terminal emulator allows output to be redirected to a pipe > stream for the benefit of client-side JavaScript (see GUACAMOLE-17), doing so > currently has caveats: > * Redirecting output to a pipe stream results in _all_ output going solely to > that stream. No output is displayed on the terminal while the pipe stream > remains open. This is not always desirable. > * Data sent to the pipe stream is buffered. This works well for > non-interactive bulk transfers of data, but any client-side JavaScript > expecting to monitor output in real-time will be disappointed, particularly > code which must deal with the output of interactive commands. > There should be some option to allow output to go to both the pipe stream and > the terminal, and some option to allow the output to be automatically > flushed, whether that be through a new OSC code or through > backward-compatible modifications to the existing code. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (GUACAMOLE-597) Allow fine-grained handling of terminal output via pipe streams
[ https://issues.apache.org/jira/browse/GUACAMOLE-597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Jumper updated GUACAMOLE-597: - Summary: Allow fine-grained handling of terminal output via pipe streams (was: Allow terminal output to be both displayed and redirected) > Allow fine-grained handling of terminal output via pipe streams > --- > > Key: GUACAMOLE-597 > URL: https://issues.apache.org/jira/browse/GUACAMOLE-597 > Project: Guacamole > Issue Type: New Feature > Components: Terminal >Reporter: Michael Jumper >Priority: Major > > While Guacamole's terminal emulator allows output to be redirected to a pipe > stream, doing so results in _all_ output going solely to that stream. No > output is displayed on the terminal while the pipe stream remains open. > There should be some option to allow output to go to both the pipe stream and > the terminal, whether that be through a new OSC code or through > backward-compatible modifications to the existing code. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (GUACAMOLE-597) Allow terminal output to be both displayed and redirected
Michael Jumper created GUACAMOLE-597: Summary: Allow terminal output to be both displayed and redirected Key: GUACAMOLE-597 URL: https://issues.apache.org/jira/browse/GUACAMOLE-597 Project: Guacamole Issue Type: New Feature Components: Terminal Reporter: Michael Jumper While Guacamole's terminal emulator allows output to be redirected to a pipe stream, doing so results in _all_ output going solely to that stream. No output is displayed on the terminal while the pipe stream remains open. There should be some option to allow output to go to both the pipe stream and the terminal, whether that be through a new OSC code or through backward-compatible modifications to the existing code. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GUACAMOLE-595) Disconnected when using audio input
[
https://issues.apache.org/jira/browse/GUACAMOLE-595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16560135#comment-16560135
]
Nick Couchman commented on GUACAMOLE-595:
-
{quote}
I installed on a fresh server using this script:
https://github.com/MysticRyuujin/guac-install
{quote}
This script is not maintained by the Guacamole project, so we cannot offer
support on it.
At this point I'd suggest that you take this conversation to the mailing list
and provide detailed information, including logs from Guacamole Server in debug
mode (guacd -L debug). If guacd is crashing (segfault, etc.) then stack traces
or core dumps would also be useful. You can find information on the mailing
lists here:
http://guacamole.apache.org/support/
> Disconnected when using audio input
> ---
>
> Key: GUACAMOLE-595
> URL: https://issues.apache.org/jira/browse/GUACAMOLE-595
> Project: Guacamole
> Issue Type: Bug
> Components: RDP
>Affects Versions: 0.9.14
> Environment: Audio Input
>Reporter: João Ferreira
>Priority: Minor
> Attachments: Capture.PNG
>
>
> Hello.
> When I use audio input for Windows 10 I got disconnected. The idea is to use
> softphone apps.
> Tried other Windows 10 versions but not good.
>
> Thank you.
> João.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (GUACAMOLE-595) Disconnected when using audio input
[
https://issues.apache.org/jira/browse/GUACAMOLE-595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16560049#comment-16560049
]
João Ferreira edited comment on GUACAMOLE-595 at 7/27/18 5:44 PM:
--
Hello, thank you for your help.
I installed on a fresh server using this script:
https://github.com/MysticRyuujin/guac-install
I'm using.
Distributor ID: Ubuntu
Description: Ubuntu 18.04 LTS
Release: 18.04
Codename: bionic
FreeRDP:
libfreerdp-dev:
Installed: 1.1.0~git20140921.1.440916e+dfsg1-15ubuntu1
Candidate: 1.1.0~git20140921.1.440916e+dfsg1-15ubuntu1
Version table:
*
**
*** 1.1.0~git20140921.1.440916e+dfsg1-15ubuntu1 500
500 [http://azure.archive.ubuntu.com/ubuntu] bionic/universe amd64 Packages
100 /var/lib/dpkg/status
Guacamole Build:
Downloaded 0.9.14
Installed Packages:
apt-get -y install build-essential libcairo2-dev ${JPEGTURBO} ${LIBPNG}
libossp-uuid-dev libavcodec-dev libavutil-dev \
libswscale-dev libfreerdp-dev libpango1.0-dev libssh2-1-dev libtelnet-dev
libvncserver-dev libpulse-dev libssl-dev \
libvorbis-dev libwebp-dev mysql-server mysql-client mysql-common
mysql-utilities libmysql-java tomcat8 freerdp-x11 \
ghostscript wget dpkg-dev
was (Author: jpaferreira):
Hello, thank you for your help.
I'm using.
Distributor ID: Ubuntu
Description: Ubuntu 18.04 LTS
Release: 18.04
Codename: bionic
FreeRDP:
libfreerdp-dev:
Installed: 1.1.0~git20140921.1.440916e+dfsg1-15ubuntu1
Candidate: 1.1.0~git20140921.1.440916e+dfsg1-15ubuntu1
Version table:
*** 1.1.0~git20140921.1.440916e+dfsg1-15ubuntu1 500
500 http://azure.archive.ubuntu.com/ubuntu bionic/universe amd64 Packages
100 /var/lib/dpkg/status
Guacamole Build:
Downloaded 0.9.14
Installed Packages:
apt-get -y install build-essential libcairo2-dev ${JPEGTURBO} ${LIBPNG}
libossp-uuid-dev libavcodec-dev libavutil-dev \
libswscale-dev libfreerdp-dev libpango1.0-dev libssh2-1-dev libtelnet-dev
libvncserver-dev libpulse-dev libssl-dev \
libvorbis-dev libwebp-dev mysql-server mysql-client mysql-common
mysql-utilities libmysql-java tomcat8 freerdp-x11 \
ghostscript wget dpkg-dev
> Disconnected when using audio input
> ---
>
> Key: GUACAMOLE-595
> URL: https://issues.apache.org/jira/browse/GUACAMOLE-595
> Project: Guacamole
> Issue Type: Bug
> Components: RDP
>Affects Versions: 0.9.14
> Environment: Audio Input
>Reporter: João Ferreira
>Priority: Minor
> Attachments: Capture.PNG
>
>
> Hello.
> When I use audio input for Windows 10 I got disconnected. The idea is to use
> softphone apps.
> Tried other Windows 10 versions but not good.
>
> Thank you.
> João.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (GUACAMOLE-595) Disconnected when using audio input
[
https://issues.apache.org/jira/browse/GUACAMOLE-595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16560049#comment-16560049
]
João Ferreira commented on GUACAMOLE-595:
-
Hello, thank you for your help.
I'm using.
Distributor ID: Ubuntu
Description: Ubuntu 18.04 LTS
Release: 18.04
Codename: bionic
FreeRDP:
libfreerdp-dev:
Installed: 1.1.0~git20140921.1.440916e+dfsg1-15ubuntu1
Candidate: 1.1.0~git20140921.1.440916e+dfsg1-15ubuntu1
Version table:
*** 1.1.0~git20140921.1.440916e+dfsg1-15ubuntu1 500
500 http://azure.archive.ubuntu.com/ubuntu bionic/universe amd64 Packages
100 /var/lib/dpkg/status
Guacamole Build:
Downloaded 0.9.14
Installed Packages:
apt-get -y install build-essential libcairo2-dev ${JPEGTURBO} ${LIBPNG}
libossp-uuid-dev libavcodec-dev libavutil-dev \
libswscale-dev libfreerdp-dev libpango1.0-dev libssh2-1-dev libtelnet-dev
libvncserver-dev libpulse-dev libssl-dev \
libvorbis-dev libwebp-dev mysql-server mysql-client mysql-common
mysql-utilities libmysql-java tomcat8 freerdp-x11 \
ghostscript wget dpkg-dev
> Disconnected when using audio input
> ---
>
> Key: GUACAMOLE-595
> URL: https://issues.apache.org/jira/browse/GUACAMOLE-595
> Project: Guacamole
> Issue Type: Bug
> Components: RDP
>Affects Versions: 0.9.14
> Environment: Audio Input
>Reporter: João Ferreira
>Priority: Minor
> Attachments: Capture.PNG
>
>
> Hello.
> When I use audio input for Windows 10 I got disconnected. The idea is to use
> softphone apps.
> Tried other Windows 10 versions but not good.
>
> Thank you.
> João.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Closed] (GUACAMOLE-596) Not open use the LDAP account using the Apache Guacamole 0.9.14 version
[ https://issues.apache.org/jira/browse/GUACAMOLE-596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Couchman closed GUACAMOLE-596. --- Resolution: Invalid This is not a support forum. Please use the mailing lists for questions or problems configuring Guacamole: http://guacamole.apache.org/support/ > Not open use the LDAP account using the Apache Guacamole 0.9.14 version > --- > > Key: GUACAMOLE-596 > URL: https://issues.apache.org/jira/browse/GUACAMOLE-596 > Project: Guacamole > Issue Type: Bug >Reporter: Rajesh >Priority: Critical > > Hi Team, > > I am facing an issue with our current guacamole setup were the LDAP > authentication were not working . > Whereas the basic file authentication login is working fine . > Could you please check and let us know what was the exact cause for this > issue . > > guacd-hostname: localhost > guacd-port: 4822 > auth-provider: > net.sourceforge.guacamole.net.auth.ldap.LDAPAuthenticationProvider > lib-directory: /var/lib/tomcat/webapps/guacamole-0.9.14/WEB-INF/lib/ > ldap-hostname: *** > ldap-port: 389 > ldap-encryption-method: none > ldap-user-base-dn: DC=**,DC=*** > ldap-search-bind-dn: CN=ldapadmin,OU=SPL,OU=Users,OU=DCM,DC=**,DC=*** > ldap-search-bind-password: *** > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GUACAMOLE-596) Not open use the LDAP account using the Apache Guacamole 0.9.14 version
[ https://issues.apache.org/jira/browse/GUACAMOLE-596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16559708#comment-16559708 ] Rajesh commented on GUACAMOLE-596: -- Hi , The same LDAP Authentication were using for the Guacamale installed server login was successfull. But in case of the Apache Guacamole UI Login its prompts for the errror. While checking for the Apache Tomcat Logs i can able to see the below mentioned content alone in the server . 18:23:09.840 [http-bio-8080-exec-1] WARN o.a.g.r.auth.AuthenticationService - Authentication attempt from **.**.**.** for user Failed. Attached the Apache Tomcat logs along with this mail . Can you please check and help us . > Not open use the LDAP account using the Apache Guacamole 0.9.14 version > --- > > Key: GUACAMOLE-596 > URL: https://issues.apache.org/jira/browse/GUACAMOLE-596 > Project: Guacamole > Issue Type: Bug >Reporter: Rajesh >Priority: Critical > > Hi Team, > > I am facing an issue with our current guacamole setup were the LDAP > authentication were not working . > Whereas the basic file authentication login is working fine . > Could you please check and let us know what was the exact cause for this > issue . > > guacd-hostname: localhost > guacd-port: 4822 > auth-provider: > net.sourceforge.guacamole.net.auth.ldap.LDAPAuthenticationProvider > lib-directory: /var/lib/tomcat/webapps/guacamole-0.9.14/WEB-INF/lib/ > ldap-hostname: *** > ldap-port: 389 > ldap-encryption-method: none > ldap-user-base-dn: DC=**,DC=*** > ldap-search-bind-dn: CN=ldapadmin,OU=SPL,OU=Users,OU=DCM,DC=**,DC=*** > ldap-search-bind-password: *** > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (GUACAMOLE-596) Not open use the LDAP account using the Apache Guacamole 0.9.14 version
Rajesh created GUACAMOLE-596: Summary: Not open use the LDAP account using the Apache Guacamole 0.9.14 version Key: GUACAMOLE-596 URL: https://issues.apache.org/jira/browse/GUACAMOLE-596 Project: Guacamole Issue Type: Bug Reporter: Rajesh Hi Team, I am facing an issue with our current guacamole setup were the LDAP authentication were not working . Whereas the basic file authentication login is working fine . Could you please check and let us know what was the exact cause for this issue . guacd-hostname: localhost guacd-port: 4822 auth-provider: net.sourceforge.guacamole.net.auth.ldap.LDAPAuthenticationProvider lib-directory: /var/lib/tomcat/webapps/guacamole-0.9.14/WEB-INF/lib/ ldap-hostname: *** ldap-port: 389 ldap-encryption-method: none ldap-user-base-dn: DC=**,DC=*** ldap-search-bind-dn: CN=ldapadmin,OU=SPL,OU=Users,OU=DCM,DC=**,DC=*** ldap-search-bind-password: *** -- This message was sent by Atlassian JIRA (v7.6.3#76005)
