[jira] [Commented] (GUACAMOLE-526) Update Guacamole-Client Webapp to Angular 1.6.9
[ https://issues.apache.org/jira/browse/GUACAMOLE-526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709438#comment-16709438 ] Nick Couchman commented on GUACAMOLE-526: - Well, it was either the trailing comma or the ngRoute include, but cleaning that up seems to have resolved the issue! Submitting a PR. > Update Guacamole-Client Webapp to Angular 1.6.9 > --- > > Key: GUACAMOLE-526 > URL: https://issues.apache.org/jira/browse/GUACAMOLE-526 > Project: Guacamole > Issue Type: Improvement >Reporter: James Muehlner >Assignee: James Muehlner >Priority: Blocker > Fix For: 1.0.0 > > > The client webapp is currently running AngularJS version 1.3.16, which is > about 3 years old. > Upgrading to the new typescript-based Angular would be a very involved > change, but we should at least attempt to upgrade to the most recent version > of AngularJS, 1.6.9. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GUACAMOLE-526) Update Guacamole-Client Webapp to Angular 1.6.9
[ https://issues.apache.org/jira/browse/GUACAMOLE-526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709417#comment-16709417 ] Nick Couchman commented on GUACAMOLE-526: - Thanks for looking, Mike. I'll take a look at the errors in the JS console and see if there's any other clues. Not sure why this is being problematic. The only other exception I see is this: jquery.min.js:2 - [Violation] 'setTimeout' handler took 91ms > Update Guacamole-Client Webapp to Angular 1.6.9 > --- > > Key: GUACAMOLE-526 > URL: https://issues.apache.org/jira/browse/GUACAMOLE-526 > Project: Guacamole > Issue Type: Improvement >Reporter: James Muehlner >Assignee: James Muehlner >Priority: Blocker > Fix For: 1.0.0 > > > The client webapp is currently running AngularJS version 1.3.16, which is > about 3 years old. > Upgrading to the new typescript-based Angular would be a very involved > change, but we should at least attempt to upgrade to the most recent version > of AngularJS, 1.6.9. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GUACAMOLE-526) Update Guacamole-Client Webapp to Angular 1.6.9
[
https://issues.apache.org/jira/browse/GUACAMOLE-526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709306#comment-16709306
]
Michael Jumper commented on GUACAMOLE-526:
--
Looking over the CAS source, nothing looks odd to me except for an unnecessary
dependency on {{ngRoute}} with a trailing comma:
https://github.com/apache/guacamole-client/blob/fc457c080d813044e30e1f4e8fe855d6a5900259/extensions/guacamole-auth-cas/src/main/resources/casModule.js#L25
It hurts the eyes, but that shouldn't break anything. I'm not sure what could
be failing to result in the unhandled rejections. Presumably there must be some
exception occurring between when the field HTML is inserted into the DOM and
when the controller is attached (which would cause the redirect to occur), but
I'm not seeing such a failure with OpenID and the two extensions are
essentially identical.
[~nick.couch...@yahoo.com], are you able to see what is failing to result in
the unhandled rejection? An exception of some kind? Maybe enable "pause on
exceptions" in dev tools?
> Update Guacamole-Client Webapp to Angular 1.6.9
> ---
>
> Key: GUACAMOLE-526
> URL: https://issues.apache.org/jira/browse/GUACAMOLE-526
> Project: Guacamole
> Issue Type: Improvement
>Reporter: James Muehlner
>Assignee: James Muehlner
>Priority: Blocker
> Fix For: 1.0.0
>
>
> The client webapp is currently running AngularJS version 1.3.16, which is
> about 3 years old.
> Upgrading to the new typescript-based Angular would be a very involved
> change, but we should at least attempt to upgrade to the most recent version
> of AngularJS, 1.6.9.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (GUACAMOLE-526) Update Guacamole-Client Webapp to Angular 1.6.9
[ https://issues.apache.org/jira/browse/GUACAMOLE-526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709228#comment-16709228 ] Michael Jumper commented on GUACAMOLE-526: -- Just retested with OpenID and I'm not seeing the above. I see a brief "Please wait ..." message, confirmation from the IDP on the website I'm redirected to, and then I'm logged in to Guacamole after confirming. > Update Guacamole-Client Webapp to Angular 1.6.9 > --- > > Key: GUACAMOLE-526 > URL: https://issues.apache.org/jira/browse/GUACAMOLE-526 > Project: Guacamole > Issue Type: Improvement >Reporter: James Muehlner >Assignee: James Muehlner >Priority: Blocker > Fix For: 1.0.0 > > > The client webapp is currently running AngularJS version 1.3.16, which is > about 3 years old. > Upgrading to the new typescript-based Angular would be a very involved > change, but we should at least attempt to upgrade to the most recent version > of AngularJS, 1.6.9. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GUACAMOLE-526) Update Guacamole-Client Webapp to Angular 1.6.9
[ https://issues.apache.org/jira/browse/GUACAMOLE-526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16463146#comment-16463146 ] James Muehlner commented on GUACAMOLE-526: -- Yep! This is done now. > Update Guacamole-Client Webapp to Angular 1.6.9 > --- > > Key: GUACAMOLE-526 > URL: https://issues.apache.org/jira/browse/GUACAMOLE-526 > Project: Guacamole > Issue Type: Improvement >Reporter: James Muehlner >Assignee: James Muehlner >Priority: Minor > Fix For: 1.0.0 > > > The client webapp is currently running AngularJS version 1.3.16, which is > about 3 years old. > Upgrading to the new typescript-based Angular would be a very involved > change, but we should at least attempt to upgrade to the most recent version > of AngularJS, 1.6.9. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GUACAMOLE-526) Update Guacamole-Client Webapp to Angular 1.6.9
[ https://issues.apache.org/jira/browse/GUACAMOLE-526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462249#comment-16462249 ] Nick Couchman commented on GUACAMOLE-526: - Believe this issue is completed, correct? > Update Guacamole-Client Webapp to Angular 1.6.9 > --- > > Key: GUACAMOLE-526 > URL: https://issues.apache.org/jira/browse/GUACAMOLE-526 > Project: Guacamole > Issue Type: Improvement >Reporter: James Muehlner >Assignee: James Muehlner >Priority: Minor > Fix For: 1.0.0 > > > The client webapp is currently running AngularJS version 1.3.16, which is > about 3 years old. > Upgrading to the new typescript-based Angular would be a very involved > change, but we should at least attempt to upgrade to the most recent version > of AngularJS, 1.6.9. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GUACAMOLE-526) Update Guacamole-Client Webapp to Angular 1.6.9
[
https://issues.apache.org/jira/browse/GUACAMOLE-526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458791#comment-16458791
]
Michael Jumper commented on GUACAMOLE-526:
--
I'll take a look. {{orderBy}} was one of the things that changed between
AngularJS 1.3.x and 1.6.x, and was the reason a new [{{toArray}}
filter|https://github.com/apache/guacamole-client/blob/d22f065fea7acaa086ce9eb593c69d009aee3108/guacamole/src/main/webapp/app/index/filters/arrayFilter.js]
was added within Guacamole.
> Update Guacamole-Client Webapp to Angular 1.6.9
> ---
>
> Key: GUACAMOLE-526
> URL: https://issues.apache.org/jira/browse/GUACAMOLE-526
> Project: Guacamole
> Issue Type: Improvement
>Reporter: James Muehlner
>Assignee: James Muehlner
>Priority: Minor
> Fix For: 1.0.0
>
>
> The client webapp is currently running AngularJS version 1.3.16, which is
> about 3 years old.
> Upgrading to the new typescript-based Angular would be a very involved
> change, but we should at least attempt to upgrade to the most recent version
> of AngularJS, 1.6.9.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (GUACAMOLE-526) Update Guacamole-Client Webapp to Angular 1.6.9
[ https://issues.apache.org/jira/browse/GUACAMOLE-526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401375#comment-16401375 ] James Muehlner commented on GUACAMOLE-526: -- If upgrading to Angular 2+ is a real possibility that being worked on, we should probably do that instead of this. There are some issues in the way that promises are used by guacamole that may require a more significant change than the update I had originally imagined anyway. > Update Guacamole-Client Webapp to Angular 1.6.9 > --- > > Key: GUACAMOLE-526 > URL: https://issues.apache.org/jira/browse/GUACAMOLE-526 > Project: Guacamole > Issue Type: Improvement >Reporter: James Muehlner >Assignee: James Muehlner >Priority: Minor > > The client webapp is currently running AngularJS version 1.3.16, which is > about 3 years old. > Upgrading to the new typescript-based Angular would be a very involved > change, but we should at least attempt to upgrade to the most recent version > of AngularJS, 1.6.9. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GUACAMOLE-526) Update Guacamole-Client Webapp to Angular 1.6.9
[
https://issues.apache.org/jira/browse/GUACAMOLE-526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16399374#comment-16399374
]
Michael Jumper commented on GUACAMOLE-526:
--
{quote}
Upgrading to the new typescript-based Angular would be a very involved change
...
{quote}
Very true, however I wonder if this might still be a possibility. I'm not
saying we should toss out the work you've been doing with upgrading to 1.6.9,
especially since that's looking near complete, but there was also some
downstream work mentioned recently by [~jamhall] involving a port to Angular2:
https://lists.apache.org/thread.html/59c979ca95556903ae810aa700e7010c4ae645c1adb617559a1baab4@%3Cdev.guacamole.apache.org%3E
Perhaps there's some way to clean that work up and tie this together with
GUACAMOLE-59, separating the Angular-specific innards out into an actual
upstream library which the main Guacamole webapp (and downstream webapps) can
pull in?
> Update Guacamole-Client Webapp to Angular 1.6.9
> ---
>
> Key: GUACAMOLE-526
> URL: https://issues.apache.org/jira/browse/GUACAMOLE-526
> Project: Guacamole
> Issue Type: Improvement
>Reporter: James Muehlner
>Assignee: James Muehlner
>Priority: Minor
>
> The client webapp is currently running AngularJS version 1.3.16, which is
> about 3 years old.
> Upgrading to the new typescript-based Angular would be a very involved
> change, but we should at least attempt to upgrade to the most recent version
> of AngularJS, 1.6.9.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
