[jira] [Commented] (GUACAMOLE-657) Unexpected behaviour of modifier keys when opening Guacamole menu
[
https://issues.apache.org/jira/browse/GUACAMOLE-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682520#comment-16682520
]
Michael Jumper commented on GUACAMOLE-657:
--
When pressing Ctrl+Alt+Shift (in that order), the following events are sent by
the client:
* Ctrl down
* Alt down
* Shift up
* Ctrl up
* Alt up
This can be confirmed through adding logging to {{sendKeyEvent()}} of
{{Guacamole.Client}} using the browser's dev tools:
!sendkeyevent-ctrl-alt-shift.png!
Testing against VNC, those press and release events are correctly sent from
guacd to the VNC server (note that the Shift release is dropped by the VNC
server as it was not pressed in the first place - this is fine):
!vnc-xev-ctrl-alt-shift.png!
With RDP, again those press and release events are correctly sent from guacd to
the RDP server:
!rdp-key-viewer-ctrl-alt-shift.png!
> Unexpected behaviour of modifier keys when opening Guacamole menu
> -
>
> Key: GUACAMOLE-657
> URL: https://issues.apache.org/jira/browse/GUACAMOLE-657
> Project: Guacamole
> Issue Type: Bug
> Components: RDP
>Affects Versions: 0.9.14
> Environment: Host: macOS Mojave
> Browser: Chrome 70
> Guest: Kali Linux (VirtualBox 5.2.18)
>Reporter: Kaspar Hageman
>Priority: Minor
> Attachments: rdp-key-viewer-ctrl-alt-shift.png,
> sendkeyevent-ctrl-alt-shift.png, vnc-xev-ctrl-alt-shift.png
>
>
> When opening the Guacamole menu, during an RDP session with a VM, with the
> default key combination (Ctrl + Cmd + Shift), the VM does observe key events
> as expected.
> For instance, when pressing Ctrl + Cmd + Shift (in that order), the following
> key events can be observed (using Chrome's developer tools):
> * Ctrl pressed
> * Cmd pressed
> * Shift released
> * Ctrl released
> * Cmd released
> However, in the VM, the following key events can be observed (using xev):
> * Ctrl pressed
> Has been tested with both version 0.9.14 and the current master branch
> (d4f58f2c0d812b05c392e06438e659902e8121f8)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (GUACAMOLE-657) Unexpected behaviour of modifier keys when opening Guacamole menu
[ https://issues.apache.org/jira/browse/GUACAMOLE-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682396#comment-16682396 ] Thomas Kobber Panum commented on GUACAMOLE-657: --- I just tried running a virtual ubuntu server guest using KVM and access through VNC, and the issue still persist. _Ctrl -> Alt -> Shift_ makes the Ctrl in the guest become stuck. I tried swapping keyboard layouts on the host (Danish, US) and no difference. > Unexpected behaviour of modifier keys when opening Guacamole menu > - > > Key: GUACAMOLE-657 > URL: https://issues.apache.org/jira/browse/GUACAMOLE-657 > Project: Guacamole > Issue Type: Bug > Components: RDP >Affects Versions: 0.9.14 > Environment: Host: macOS Mojave > Browser: Chrome 70 > Guest: Kali Linux (VirtualBox 5.2.18) >Reporter: Kaspar Hageman >Priority: Minor > > When opening the Guacamole menu, during an RDP session with a VM, with the > default key combination (Ctrl + Cmd + Shift), the VM does observe key events > as expected. > For instance, when pressing Ctrl + Cmd + Shift (in that order), the following > key events can be observed (using Chrome's developer tools): > * Ctrl pressed > * Cmd pressed > * Shift released > * Ctrl released > * Cmd released > However, in the VM, the following key events can be observed (using xev): > * Ctrl pressed > Has been tested with both version 0.9.14 and the current master branch > (d4f58f2c0d812b05c392e06438e659902e8121f8) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GUACAMOLE-657) Unexpected behaviour of modifier keys when opening Guacamole menu
[ https://issues.apache.org/jira/browse/GUACAMOLE-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682271#comment-16682271 ] Thomas Kobber Panum commented on GUACAMOLE-657: --- I have the exact same issue as Kaspar describe, and my setup is as follows: * VirtualBox's RDP Solution (version 5.2.18r124319) * Virtual Guests: Two linux systems (one with GNOME and one with XFCE – tried also just accessing tty) * Guacamole version 0.9.14 * Browser: Firefox 62, Chromium 69 (running on Linux with just a window manager) When I use an RDP Client (Remmina 1.2.31) performing _Ctrl + Alt + Shift_ +*does not*+ make Ctrl become stuck in the virtual guest. When doing the same thing through Guacamole I see the keyup event (of Ctrl) being sent from the web client, but the ctrl is still stuck within the guest. The same happens on a Windows client running Chrome 69, but the problem also occurs there. In my use case it sadly creates a lot of frustration for the users, as using the clipboard feature simply makes their RDP solution become unusable afterwards. So as mentioned, I believe that the JavaScript client correctly handles the reset() correctly, but guacd does not pass it on correct to the RDP connection (since the issue does not occur using other RDP clients?) > Unexpected behaviour of modifier keys when opening Guacamole menu > - > > Key: GUACAMOLE-657 > URL: https://issues.apache.org/jira/browse/GUACAMOLE-657 > Project: Guacamole > Issue Type: Bug > Components: RDP >Affects Versions: 0.9.14 > Environment: Host: macOS Mojave > Browser: Chrome 70 > Guest: Kali Linux (VirtualBox 5.2.18) >Reporter: Kaspar Hageman >Priority: Minor > > When opening the Guacamole menu, during an RDP session with a VM, with the > default key combination (Ctrl + Cmd + Shift), the VM does observe key events > as expected. > For instance, when pressing Ctrl + Cmd + Shift (in that order), the following > key events can be observed (using Chrome's developer tools): > * Ctrl pressed > * Cmd pressed > * Shift released > * Ctrl released > * Cmd released > However, in the VM, the following key events can be observed (using xev): > * Ctrl pressed > Has been tested with both version 0.9.14 and the current master branch > (d4f58f2c0d812b05c392e06438e659902e8121f8) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GUACAMOLE-657) Unexpected behaviour of modifier keys when opening Guacamole menu
[
https://issues.apache.org/jira/browse/GUACAMOLE-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682188#comment-16682188
]
Michael Jumper commented on GUACAMOLE-657:
--
{quote}
Mapping the Windows key to Meta would solve this issue? Or is this a deliberate
design choice?
{quote}
It would result in a corresponding key event being received within the remote
desktop for the Command key. That said, I'm concerned that "fixing" the mapping
will result in real strange behavior for Mac users accessing Windows machines
when they reflexively type Command+Anything and end up opening the start menu.
Testing will need to be done before that deceptively minor change can be made
to the keymap.
{quote}
The "Ctrl" key release is not send from the browser to Guacamole as a WebSocket
frame (from what I can observe from the Chrome developer) and therefore will
never reach the VM in the first place. I would assume this is a legitimate bug.
{quote}
If this is true, then yes, but so far I am unable to reproduce what you
describe. Testing with a Mac, I see both a Ctrl press and release. I also don't
see how such a bug could exist given the way the Guacamole menu works - the
code that opens the menu also invokes {{reset()}} on the
{{Guacamole.Keyboard}}, sending release events for absolutely all pressed keys:
https://github.com/apache/guacamole-client/blob/823bbeace11063b249e3f05c2a1e5c5027107b96/guacamole/src/main/webapp/app/client/controllers/clientController.js#L540-L547
If a press event for any key was sent to the remote desktop, a corresponding
release event would then be sent when the menu is opened as a result of that
invocation of {{reset()}}. I'm thinking there must be some other cause behind
what you're seeing (an application within the remote desktop not receiving the
release event for Ctrl) which is not that Guacamole is not sending that event
(I expect it is).
> Unexpected behaviour of modifier keys when opening Guacamole menu
> -
>
> Key: GUACAMOLE-657
> URL: https://issues.apache.org/jira/browse/GUACAMOLE-657
> Project: Guacamole
> Issue Type: Bug
> Components: RDP
>Affects Versions: 0.9.14
> Environment: Host: macOS Mojave
> Browser: Chrome 70
> Guest: Kali Linux (VirtualBox 5.2.18)
>Reporter: Kaspar Hageman
>Priority: Minor
>
> When opening the Guacamole menu, during an RDP session with a VM, with the
> default key combination (Ctrl + Cmd + Shift), the VM does observe key events
> as expected.
> For instance, when pressing Ctrl + Cmd + Shift (in that order), the following
> key events can be observed (using Chrome's developer tools):
> * Ctrl pressed
> * Cmd pressed
> * Shift released
> * Ctrl released
> * Cmd released
> However, in the VM, the following key events can be observed (using xev):
> * Ctrl pressed
> Has been tested with both version 0.9.14 and the current master branch
> (d4f58f2c0d812b05c392e06438e659902e8121f8)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (GUACAMOLE-657) Unexpected behaviour of modifier keys when opening Guacamole menu
[ https://issues.apache.org/jira/browse/GUACAMOLE-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16681801#comment-16681801 ] Kaspar Hageman commented on GUACAMOLE-657: -- Right, so if I understand correctly, there are two mechanisms in play here: # The "Meta" key is not mapped to any RDP key and therefore will never reach the VM in the first place. Mapping the Windows key to Meta would solve this issue? Or is this a deliberate design choice? # The "Ctrl" key release is not send from the browser to Guacamole as a WebSocket frame (from what I can observe from the Chrome developer) and therefore will never reach the VM in the first place. I would assume this is a legitimate bug. > Unexpected behaviour of modifier keys when opening Guacamole menu > - > > Key: GUACAMOLE-657 > URL: https://issues.apache.org/jira/browse/GUACAMOLE-657 > Project: Guacamole > Issue Type: Bug > Components: RDP >Affects Versions: 0.9.14 > Environment: Host: macOS Mojave > Browser: Chrome 70 > Guest: Kali Linux (VirtualBox 5.2.18) >Reporter: Kaspar Hageman >Priority: Major > > When opening the Guacamole menu, during an RDP session with a VM, with the > default key combination (Ctrl + Cmd + Shift), the VM does observe key events > as expected. > For instance, when pressing Ctrl + Cmd + Shift (in that order), the following > key events can be observed (using Chrome's developer tools): > * Ctrl pressed > * Cmd pressed > * Shift released > * Ctrl released > * Cmd released > However, in the VM, the following key events can be observed (using xev): > * Ctrl pressed > Has been tested with both version 0.9.14 and the current master branch > (d4f58f2c0d812b05c392e06438e659902e8121f8) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GUACAMOLE-657) Unexpected behaviour of modifier keys when opening Guacamole menu
[ https://issues.apache.org/jira/browse/GUACAMOLE-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16681728#comment-16681728 ] Michael Jumper commented on GUACAMOLE-657: -- The Mac "Command" key is the "Meta" key, but Meta does not have a mapping in RDP and thus will not be sent. You should still see a release event for Ctrl, but will not see the press/release events for Cmd. It might be more correct to modify the mapping to use Meta for the Windows key: https://github.com/apache/guacamole-server/blob/6f491946408224a231324663938df36c756b09d2/src/protocols/rdp/keymaps/base.keymap#L87-L88 I do see at least Chrome mapping the Windows key to Meta within JavaScript key events. > Unexpected behaviour of modifier keys when opening Guacamole menu > - > > Key: GUACAMOLE-657 > URL: https://issues.apache.org/jira/browse/GUACAMOLE-657 > Project: Guacamole > Issue Type: Bug > Components: RDP >Affects Versions: 0.9.14 > Environment: Host: macOS Mojave > Browser: Chrome 70 > Guest: Kali Linux (VirtualBox 5.2.18) >Reporter: Kaspar Hageman >Priority: Major > > When opening the Guacamole menu, during an RDP session with a VM, with the > default key combination (Ctrl + Cmd + Shift), the VM does observe key events > as expected. > For instance, when pressing Ctrl + Cmd + Shift (in that order), the following > key events can be observed (using Chrome's developer tools): > * Ctrl pressed > * Cmd pressed > * Shift released > * Ctrl released > * Cmd released > However, in the VM, the following key events can be observed (using xev): > * Ctrl pressed > Has been tested with both version 0.9.14 and the current master branch > (d4f58f2c0d812b05c392e06438e659902e8121f8) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
