[42/51] [partial] hbase git commit: HBASE-17056 Remove checked in PB generated files Selective add of dependency on hbase-thirdparty jars. Update to READMEs on how protobuf is done (and update to refg
http://git-wip-us.apache.org/repos/asf/hbase/blob/1049025e/hbase-examples/README.txt
--
diff --git a/hbase-examples/README.txt b/hbase-examples/README.txt
index c47ed4f..22d1103 100644
--- a/hbase-examples/README.txt
+++ b/hbase-examples/README.txt
@@ -63,27 +63,8 @@ Example code.
3. Execute {./DemoClient}.
ON PROTOBUFS
-This maven module has protobuf definition files ('.protos') used by hbase
-Coprocessor Endpoints examples including tests. Coprocessor
-Endpoints are meant to be standalone, independent code not reliant on hbase
-internals. They define their Service using protobuf. The protobuf version
-they use can be distinct from that used by HBase internally since HBase started
-shading its protobuf references. Endpoints have no access to the shaded
protobuf
-hbase uses. They do have access to the content of hbase-protocol -- the
-.protos found in here -- but avoid using as much of this as you can as it is
-liable to change.
+This maven module has core protobuf definition files ('.protos') used by hbase
+examples.
-Generation of java files from protobuf .proto files included here is done apart
-from the build. Run the generation whenever you make changes to the .orotos
files
-and then check in the produced java (The reasoning is that change is infrequent
-so why pay the price of generating files anew on each build.
-
-To generate java files from protos run:
-
- $ mvn compile -Dcompile-protobuf
-or
- $ mvn compile -Pcompile-protobuf
-
-After you've done the above, check it and then check in changes (or post a
patch
-on a JIRA with your definition file changes and the generated files). Be
careful
-to notice new files and files removed and do appropriate git rm/adds.
+Generation of java files from protobuf .proto files included here is done as
+part of the build.
http://git-wip-us.apache.org/repos/asf/hbase/blob/1049025e/hbase-examples/pom.xml
--
diff --git a/hbase-examples/pom.xml b/hbase-examples/pom.xml
index cb32f11..817571d 100644
--- a/hbase-examples/pom.xml
+++ b/hbase-examples/pom.xml
@@ -29,7 +29,7 @@
hbase-examples
Apache HBase - Examples
Examples of HBase usage
-
+
@@ -46,20 +46,33 @@
true
-
-maven-surefire-plugin
-${surefire.version}
-
-
-${surefire.firstPartGroups}
-
-
-
-
- org.apache.maven.plugins
- maven-source-plugin
-
+ ${surefire.firstPartGroups}
+
+
+
+
+org.apache.maven.plugins
+maven-source-plugin
+
+
+org.xolstice.maven.plugins
+protobuf-maven-plugin
+
+
+compile-protoc
+generate-sources
+
+ compile
+
+
+
+
@@ -81,7 +94,7 @@
-
+
@@ -94,7 +107,7 @@
-
+
@@ -112,16 +125,16 @@
test
-org.apache.hbase
-hbase-common
+ org.apache.hbase
+ hbase-common
-org.apache.hbase
-hbase-protocol
+ org.apache.hbase
+ hbase-protocol
-org.apache.hbase
-hbase-client
+ org.apache.hbase
+ hbase-client
org.apache.hbase
@@ -136,11 +149,10 @@
hbase-thrift
-org.apache.hbase
-hbase-testing-util
-test
+ org.apache.hbase
+ hbase-testing-util
+ test
-
org.apache.thrift
libthrift
@@ -157,152 +169,126 @@
com.google.protobuf
protobuf-java
-
-
-
-
- skipExamplesTests
-
-
- skipExamplesTests
-
-
-
- true
- true
-
-
-
- compile-protobuf
-
-
- compile-protobuf
-
-
-
-
-
-org.xolstice.maven.plugins
-protobuf-maven-plugin
-
-
-compile-protoc
-generate-sources
-
- compile
-
-
-
-
-
-
-
-
-
-
+
+ skipExamplesTests
+
+
+ skipExamplesTests
+
+
+
+true
+true
+
+
+
+
-
-
[42/51] [partial] hbase git commit: HBASE-17056 Remove checked in PB generated files Selective add of dependency on hbase-thirdparty jars. Update to READMEs on how protobuf is done (and update to refg
http://git-wip-us.apache.org/repos/asf/hbase/blob/df93c13f/hbase-examples/README.txt
--
diff --git a/hbase-examples/README.txt b/hbase-examples/README.txt
index c47ed4f..22d1103 100644
--- a/hbase-examples/README.txt
+++ b/hbase-examples/README.txt
@@ -63,27 +63,8 @@ Example code.
3. Execute {./DemoClient}.
ON PROTOBUFS
-This maven module has protobuf definition files ('.protos') used by hbase
-Coprocessor Endpoints examples including tests. Coprocessor
-Endpoints are meant to be standalone, independent code not reliant on hbase
-internals. They define their Service using protobuf. The protobuf version
-they use can be distinct from that used by HBase internally since HBase started
-shading its protobuf references. Endpoints have no access to the shaded
protobuf
-hbase uses. They do have access to the content of hbase-protocol -- the
-.protos found in here -- but avoid using as much of this as you can as it is
-liable to change.
+This maven module has core protobuf definition files ('.protos') used by hbase
+examples.
-Generation of java files from protobuf .proto files included here is done apart
-from the build. Run the generation whenever you make changes to the .orotos
files
-and then check in the produced java (The reasoning is that change is infrequent
-so why pay the price of generating files anew on each build.
-
-To generate java files from protos run:
-
- $ mvn compile -Dcompile-protobuf
-or
- $ mvn compile -Pcompile-protobuf
-
-After you've done the above, check it and then check in changes (or post a
patch
-on a JIRA with your definition file changes and the generated files). Be
careful
-to notice new files and files removed and do appropriate git rm/adds.
+Generation of java files from protobuf .proto files included here is done as
+part of the build.
http://git-wip-us.apache.org/repos/asf/hbase/blob/df93c13f/hbase-examples/pom.xml
--
diff --git a/hbase-examples/pom.xml b/hbase-examples/pom.xml
index 3a30add..5c6acfa 100644
--- a/hbase-examples/pom.xml
+++ b/hbase-examples/pom.xml
@@ -29,7 +29,7 @@
hbase-examples
Apache HBase - Examples
Examples of HBase usage
-
+
@@ -46,20 +46,33 @@
true
-
-maven-surefire-plugin
-${surefire.version}
-
-
-${surefire.firstPartGroups}
-
-
-
-
- org.apache.maven.plugins
- maven-source-plugin
-
+ ${surefire.firstPartGroups}
+
+
+
+
+org.apache.maven.plugins
+maven-source-plugin
+
+
+org.xolstice.maven.plugins
+protobuf-maven-plugin
+
+
+compile-protoc
+generate-sources
+
+ compile
+
+
+
+
@@ -81,7 +94,7 @@
-
+
@@ -94,7 +107,7 @@
-
+
@@ -112,16 +125,16 @@
test
-org.apache.hbase
-hbase-common
+ org.apache.hbase
+ hbase-common
-org.apache.hbase
-hbase-protocol
+ org.apache.hbase
+ hbase-protocol
-org.apache.hbase
-hbase-client
+ org.apache.hbase
+ hbase-client
org.apache.hbase
@@ -136,11 +149,10 @@
hbase-thrift
-org.apache.hbase
-hbase-testing-util
-test
+ org.apache.hbase
+ hbase-testing-util
+ test
-
org.apache.thrift
libthrift
@@ -157,152 +169,126 @@
com.google.protobuf
protobuf-java
-
-
-
-
- skipExamplesTests
-
-
- skipExamplesTests
-
-
-
- true
- true
-
-
-
- compile-protobuf
-
-
- compile-protobuf
-
-
-
-
-
-org.xolstice.maven.plugins
-protobuf-maven-plugin
-
-
-compile-protoc
-generate-sources
-
- compile
-
-
-
-
-
-
-
-
-
-
+
+ skipExamplesTests
+
+
+ skipExamplesTests
+
+
+
+true
+true
+
+
+
+
-
-
