[hbase] 10/18: HBASE-26133 Backport HBASE-25591 "Upgrade opentelemetry to 0.17.1" to branch-2 (#3608)

2021-09-01 Thread taklwu
This is an automated email from the ASF dual-hosted git repository.

taklwu pushed a commit to branch branch-2
in repository https://gitbox.apache.org/repos/asf/hbase.git

commit d0a53e3f297cc7060782f94e02c86c10d6114af7
Author: Tak Lon (Stephen) Wu 
AuthorDate: Mon Aug 23 08:52:07 2021 -0700

HBASE-26133 Backport HBASE-25591 "Upgrade opentelemetry to 0.17.1" to 
branch-2 (#3608)

10/17 commits of HBASE-22120, original commit 
f6ff519dd0c7fe0e3ae3c175eefee27a26a065a4

Co-authored-by: Duo Zhang 

Signed-off-by: Duo Zhang 
Signed-off-by: Peter Somogyi 
---
 .../hadoop/hbase/client/TestAsyncTableTracing.java |  6 +++---
 hbase-common/pom.xml   |  4 
 .../org/apache/hadoop/hbase/trace/TraceUtil.java   | 25 +++---
 .../hadoop/hbase/mttr/IntegrationTestMTTR.java |  3 +--
 .../hadoop/hbase/ipc/ServerRpcConnection.java  |  4 ++--
 .../apache/hadoop/hbase/ipc/AbstractTestIPC.java   | 14 ++--
 .../hbase/regionserver/TestHRegionTracing.java | 15 ++---
 pom.xml| 18 +++-
 8 files changed, 44 insertions(+), 45 deletions(-)

diff --git 
a/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncTableTracing.java
 
b/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncTableTracing.java
index 07cdf0e..a3ad9df 100644
--- 
a/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncTableTracing.java
+++ 
b/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncTableTracing.java
@@ -24,7 +24,7 @@ import static org.mockito.ArgumentMatchers.anyLong;
 import static org.mockito.Mockito.doAnswer;
 import static org.mockito.Mockito.mock;
 
-import io.opentelemetry.api.trace.Span.Kind;
+import io.opentelemetry.api.trace.SpanKind;
 import io.opentelemetry.api.trace.StatusCode;
 import io.opentelemetry.sdk.testing.junit4.OpenTelemetryRule;
 import io.opentelemetry.sdk.trace.data.SpanData;
@@ -222,7 +222,7 @@ public class TestAsyncTableTracing {
 Waiter.waitFor(CONF, 1000,
   () -> traceRule.getSpans().stream()
 .anyMatch(span -> span.getName().equals("AsyncTable." + methodName) &&
-  span.getKind() == Kind.INTERNAL && span.hasEnded()));
+  span.getKind() == SpanKind.INTERNAL && span.hasEnded()));
 SpanData data = traceRule.getSpans().stream()
   .filter(s -> s.getName().equals("AsyncTable." + 
methodName)).findFirst().get();
 assertEquals(StatusCode.OK, data.getStatus().getStatusCode());
@@ -409,7 +409,7 @@ public class TestAsyncTableTracing {
 Waiter.waitFor(CONF, 1000,
   () -> traceRule.getSpans().stream()
 .anyMatch(span -> span.getName().equals("AsyncConnection.close") &&
-  span.getKind() == Kind.INTERNAL && span.hasEnded()));
+  span.getKind() == SpanKind.INTERNAL && span.hasEnded()));
 SpanData data = traceRule.getSpans().stream()
   .filter(s -> 
s.getName().equals("AsyncConnection.close")).findFirst().get();
 assertEquals(StatusCode.OK, data.getStatus().getStatusCode());
diff --git a/hbase-common/pom.xml b/hbase-common/pom.xml
index 62661b8..2212fd1 100644
--- a/hbase-common/pom.xml
+++ b/hbase-common/pom.xml
@@ -196,6 +196,10 @@
   opentelemetry-api
 
 
+  io.opentelemetry
+  opentelemetry-semconv
+
+
   org.apache.commons
   commons-crypto
 
diff --git 
a/hbase-common/src/main/java/org/apache/hadoop/hbase/trace/TraceUtil.java 
b/hbase-common/src/main/java/org/apache/hadoop/hbase/trace/TraceUtil.java
index 2a6b6b6..43c2e04 100644
--- a/hbase-common/src/main/java/org/apache/hadoop/hbase/trace/TraceUtil.java
+++ b/hbase-common/src/main/java/org/apache/hadoop/hbase/trace/TraceUtil.java
@@ -20,12 +20,12 @@ package org.apache.hadoop.hbase.trace;
 import io.opentelemetry.api.GlobalOpenTelemetry;
 import io.opentelemetry.api.common.AttributeKey;
 import io.opentelemetry.api.trace.Span;
-import io.opentelemetry.api.trace.Span.Kind;
+import io.opentelemetry.api.trace.SpanKind;
 import io.opentelemetry.api.trace.StatusCode;
 import io.opentelemetry.api.trace.Tracer;
-import io.opentelemetry.api.trace.attributes.SemanticAttributes;
 import io.opentelemetry.context.Context;
 import io.opentelemetry.context.Scope;
+import io.opentelemetry.semconv.trace.attributes.SemanticAttributes;
 import java.io.IOException;
 import java.util.List;
 import java.util.concurrent.CompletableFuture;
@@ -72,14 +72,14 @@ public final class TraceUtil {
   }
 
   /**
-   * Create a {@link Kind#INTERNAL} span.
+   * Create a {@link SpanKind#INTERNAL} span.
*/
   public static Span createSpan(String name) {
-return createSpan(name, Kind.INTERNAL);
+return createSpan(name, SpanKind.INTERNAL);
   }
 
   /**
-   * Create a {@link Kind#INTERNAL} span and set table related attributes.
+   * Create a {@link SpanKind#INTERNAL} span and set table related attributes.
*/
   public static Span createTableSpan(String 

[hbase] 10/18: HBASE-26133 Backport HBASE-25591 "Upgrade opentelemetry to 0.17.1" to branch-2 (#3608)

2021-08-27 Thread taklwu
This is an automated email from the ASF dual-hosted git repository.

taklwu pushed a commit to branch HBASE-25853
in repository https://gitbox.apache.org/repos/asf/hbase.git

commit c479baad8bca2978ff545ea90986342905977a47
Author: Tak Lon (Stephen) Wu 
AuthorDate: Mon Aug 23 08:52:07 2021 -0700

HBASE-26133 Backport HBASE-25591 "Upgrade opentelemetry to 0.17.1" to 
branch-2 (#3608)

10/17 commits of HBASE-22120, original commit 
f6ff519dd0c7fe0e3ae3c175eefee27a26a065a4

Co-authored-by: Duo Zhang 

Signed-off-by: Duo Zhang 
Signed-off-by: Peter Somogyi 
---
 .../hadoop/hbase/client/TestAsyncTableTracing.java |  6 +++---
 hbase-common/pom.xml   |  4 
 .../org/apache/hadoop/hbase/trace/TraceUtil.java   | 25 +++---
 .../hadoop/hbase/mttr/IntegrationTestMTTR.java |  3 +--
 .../hadoop/hbase/ipc/ServerRpcConnection.java  |  4 ++--
 .../apache/hadoop/hbase/ipc/AbstractTestIPC.java   | 14 ++--
 .../hbase/regionserver/TestHRegionTracing.java | 15 ++---
 pom.xml| 18 +++-
 8 files changed, 44 insertions(+), 45 deletions(-)

diff --git 
a/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncTableTracing.java
 
b/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncTableTracing.java
index 07cdf0e..a3ad9df 100644
--- 
a/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncTableTracing.java
+++ 
b/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncTableTracing.java
@@ -24,7 +24,7 @@ import static org.mockito.ArgumentMatchers.anyLong;
 import static org.mockito.Mockito.doAnswer;
 import static org.mockito.Mockito.mock;
 
-import io.opentelemetry.api.trace.Span.Kind;
+import io.opentelemetry.api.trace.SpanKind;
 import io.opentelemetry.api.trace.StatusCode;
 import io.opentelemetry.sdk.testing.junit4.OpenTelemetryRule;
 import io.opentelemetry.sdk.trace.data.SpanData;
@@ -222,7 +222,7 @@ public class TestAsyncTableTracing {
 Waiter.waitFor(CONF, 1000,
   () -> traceRule.getSpans().stream()
 .anyMatch(span -> span.getName().equals("AsyncTable." + methodName) &&
-  span.getKind() == Kind.INTERNAL && span.hasEnded()));
+  span.getKind() == SpanKind.INTERNAL && span.hasEnded()));
 SpanData data = traceRule.getSpans().stream()
   .filter(s -> s.getName().equals("AsyncTable." + 
methodName)).findFirst().get();
 assertEquals(StatusCode.OK, data.getStatus().getStatusCode());
@@ -409,7 +409,7 @@ public class TestAsyncTableTracing {
 Waiter.waitFor(CONF, 1000,
   () -> traceRule.getSpans().stream()
 .anyMatch(span -> span.getName().equals("AsyncConnection.close") &&
-  span.getKind() == Kind.INTERNAL && span.hasEnded()));
+  span.getKind() == SpanKind.INTERNAL && span.hasEnded()));
 SpanData data = traceRule.getSpans().stream()
   .filter(s -> 
s.getName().equals("AsyncConnection.close")).findFirst().get();
 assertEquals(StatusCode.OK, data.getStatus().getStatusCode());
diff --git a/hbase-common/pom.xml b/hbase-common/pom.xml
index 62661b8..2212fd1 100644
--- a/hbase-common/pom.xml
+++ b/hbase-common/pom.xml
@@ -196,6 +196,10 @@
   opentelemetry-api
 
 
+  io.opentelemetry
+  opentelemetry-semconv
+
+
   org.apache.commons
   commons-crypto
 
diff --git 
a/hbase-common/src/main/java/org/apache/hadoop/hbase/trace/TraceUtil.java 
b/hbase-common/src/main/java/org/apache/hadoop/hbase/trace/TraceUtil.java
index 2a6b6b6..43c2e04 100644
--- a/hbase-common/src/main/java/org/apache/hadoop/hbase/trace/TraceUtil.java
+++ b/hbase-common/src/main/java/org/apache/hadoop/hbase/trace/TraceUtil.java
@@ -20,12 +20,12 @@ package org.apache.hadoop.hbase.trace;
 import io.opentelemetry.api.GlobalOpenTelemetry;
 import io.opentelemetry.api.common.AttributeKey;
 import io.opentelemetry.api.trace.Span;
-import io.opentelemetry.api.trace.Span.Kind;
+import io.opentelemetry.api.trace.SpanKind;
 import io.opentelemetry.api.trace.StatusCode;
 import io.opentelemetry.api.trace.Tracer;
-import io.opentelemetry.api.trace.attributes.SemanticAttributes;
 import io.opentelemetry.context.Context;
 import io.opentelemetry.context.Scope;
+import io.opentelemetry.semconv.trace.attributes.SemanticAttributes;
 import java.io.IOException;
 import java.util.List;
 import java.util.concurrent.CompletableFuture;
@@ -72,14 +72,14 @@ public final class TraceUtil {
   }
 
   /**
-   * Create a {@link Kind#INTERNAL} span.
+   * Create a {@link SpanKind#INTERNAL} span.
*/
   public static Span createSpan(String name) {
-return createSpan(name, Kind.INTERNAL);
+return createSpan(name, SpanKind.INTERNAL);
   }
 
   /**
-   * Create a {@link Kind#INTERNAL} span and set table related attributes.
+   * Create a {@link SpanKind#INTERNAL} span and set table related attributes.
*/
   public static Span createTableSpan(String