[2/9] hbase git commit: HBASE-13310 Fix high priority findbugs warnings

2015-03-24 Thread mbertozzi 
HBASE-13310 Fix high priority findbugs warnings


Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/6e9ded51
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/6e9ded51
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/6e9ded51

Branch: refs/heads/hbase-12439
Commit: 6e9ded51fb2fc4c3e63fb0da5030246f3466db71
Parents: 1428a59
Author: zhangduo zhang...@wandoujia.com
Authored: Sun Mar 22 20:41:43 2015 +0800
Committer: zhangduo zhang...@wandoujia.com
Committed: Tue Mar 24 06:50:04 2015 +0800

--
 .../apache/hadoop/hbase/HColumnDescriptor.java  | 26 +++---
 .../apache/hadoop/hbase/util/PrettyPrinter.java |  2 +-
 .../org/apache/hadoop/hbase/util/Threads.java   | 92 ++--
 .../apache/hadoop/hbase/rest/RESTServer.java|  6 +-
 .../apache/hadoop/hbase/rest/RowResource.java   |  4 +-
 .../org/apache/hadoop/hbase/rest/RowSpec.java   |  8 +-
 .../hbase/rest/model/ColumnSchemaModel.java | 10 +--
 .../hadoop/hbase/rest/model/ScannerModel.java   |  2 +-
 .../rest/model/StorageClusterStatusModel.java   |  4 +-
 .../hbase/rest/model/TableRegionModel.java  |  2 +-
 .../hbase/rest/model/TableSchemaModel.java  | 16 ++--
 .../hadoop/hbase/io/hfile/HFileBlock.java   | 13 +++
 .../hadoop/hbase/master/HMasterCommandLine.java |  8 +-
 .../regionserver/RegionCoprocessorHost.java |  5 +-
 .../hbase/security/access/TableAuthManager.java | 11 +--
 .../org/apache/hadoop/hbase/util/HBaseFsck.java |  4 +-
 .../hbase/util/hbck/OfflineMetaRepair.java  |  2 +-
 .../apache/hadoop/hbase/util/TestHBaseFsck.java | 16 ++--
 .../hadoop/hbase/util/hbck/HbckTestingUtil.java |  2 +-
 19 files changed, 141 insertions(+), 92 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/hbase/blob/6e9ded51/hbase-client/src/main/java/org/apache/hadoop/hbase/HColumnDescriptor.java
--
diff --git 
a/hbase-client/src/main/java/org/apache/hadoop/hbase/HColumnDescriptor.java 
b/hbase-client/src/main/java/org/apache/hadoop/hbase/HColumnDescriptor.java
index 5335bef..d4d8ee4 100644
--- a/hbase-client/src/main/java/org/apache/hadoop/hbase/HColumnDescriptor.java
+++ b/hbase-client/src/main/java/org/apache/hadoop/hbase/HColumnDescriptor.java
@@ -734,7 +734,7 @@ public class HColumnDescriptor implements 
ComparableHColumnDescriptor {
 String compressTagsStr = getValue(COMPRESS_TAGS);
 boolean compressTags = DEFAULT_COMPRESS_TAGS;
 if (compressTagsStr != null) {
-  compressTags = Boolean.valueOf(compressTagsStr);
+  compressTags = Boolean.parseBoolean(compressTagsStr);
 }
 return compressTags;
   }
@@ -747,7 +747,7 @@ public class HColumnDescriptor implements 
ComparableHColumnDescriptor {
 String compressTagsStr = getValue(COMPRESS_TAGS);
 boolean compressTags = DEFAULT_COMPRESS_TAGS;
 if (compressTagsStr != null) {
-  compressTags = Boolean.valueOf(compressTagsStr);
+  compressTags = Boolean.parseBoolean(compressTagsStr);
 }
 return compressTags;
   }
@@ -778,8 +778,9 @@ public class HColumnDescriptor implements 
ComparableHColumnDescriptor {
*/
   public boolean isInMemory() {
 String value = getValue(HConstants.IN_MEMORY);
-if (value != null)
-  return Boolean.valueOf(value).booleanValue();
+if (value != null) {
+  return Boolean.parseBoolean(value);
+}
 return DEFAULT_IN_MEMORY;
   }
 
@@ -827,7 +828,7 @@ public class HColumnDescriptor implements 
ComparableHColumnDescriptor {
*/
   public int getTimeToLive() {
 String value = getValue(TTL);
-return (value != null)? Integer.valueOf(value).intValue(): DEFAULT_TTL;
+return (value != null)? Integer.parseInt(value) : DEFAULT_TTL;
   }
 
   /**
@@ -843,7 +844,7 @@ public class HColumnDescriptor implements 
ComparableHColumnDescriptor {
*/
   public int getMinVersions() {
 String value = getValue(MIN_VERSIONS);
-return (value != null)? Integer.valueOf(value).intValue(): 0;
+return (value != null)? Integer.parseInt(value) : 0;
   }
 
   /**
@@ -861,8 +862,9 @@ public class HColumnDescriptor implements 
ComparableHColumnDescriptor {
*/
   public boolean isBlockCacheEnabled() {
 String value = getValue(BLOCKCACHE);
-if (value != null)
-  return Boolean.valueOf(value).booleanValue();
+if (value != null) {
+  return Boolean.parseBoolean(value);
+}
 return DEFAULT_BLOCKCACHE;
   }
 
@@ -900,7 +902,7 @@ public class HColumnDescriptor implements 
ComparableHColumnDescriptor {
   public int getScope() {
 byte[] value = getValue(REPLICATION_SCOPE_BYTES);
 if (value != null) {
-  return Integer.valueOf(Bytes.toString(value));
+  return Integer.parseInt(Bytes.toString(value));
 }
 return DEFAULT_REPLICATION_SCOPE;
   }
@@ -966,7 +968,9 @@

hbase git commit: HBASE-13310 Fix high priority findbugs warnings

2015-03-23 Thread zhangduo 
Repository: hbase
Updated Branches:
  refs/heads/master 1428a59ca - 6e9ded51f


HBASE-13310 Fix high priority findbugs warnings


Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/6e9ded51
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/6e9ded51
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/6e9ded51

Branch: refs/heads/master
Commit: 6e9ded51fb2fc4c3e63fb0da5030246f3466db71
Parents: 1428a59
Author: zhangduo zhang...@wandoujia.com
Authored: Sun Mar 22 20:41:43 2015 +0800
Committer: zhangduo zhang...@wandoujia.com
Committed: Tue Mar 24 06:50:04 2015 +0800

--
 .../apache/hadoop/hbase/HColumnDescriptor.java  | 26 +++---
 .../apache/hadoop/hbase/util/PrettyPrinter.java |  2 +-
 .../org/apache/hadoop/hbase/util/Threads.java   | 92 ++--
 .../apache/hadoop/hbase/rest/RESTServer.java|  6 +-
 .../apache/hadoop/hbase/rest/RowResource.java   |  4 +-
 .../org/apache/hadoop/hbase/rest/RowSpec.java   |  8 +-
 .../hbase/rest/model/ColumnSchemaModel.java | 10 +--
 .../hadoop/hbase/rest/model/ScannerModel.java   |  2 +-
 .../rest/model/StorageClusterStatusModel.java   |  4 +-
 .../hbase/rest/model/TableRegionModel.java  |  2 +-
 .../hbase/rest/model/TableSchemaModel.java  | 16 ++--
 .../hadoop/hbase/io/hfile/HFileBlock.java   | 13 +++
 .../hadoop/hbase/master/HMasterCommandLine.java |  8 +-
 .../regionserver/RegionCoprocessorHost.java |  5 +-
 .../hbase/security/access/TableAuthManager.java | 11 +--
 .../org/apache/hadoop/hbase/util/HBaseFsck.java |  4 +-
 .../hbase/util/hbck/OfflineMetaRepair.java  |  2 +-
 .../apache/hadoop/hbase/util/TestHBaseFsck.java | 16 ++--
 .../hadoop/hbase/util/hbck/HbckTestingUtil.java |  2 +-
 19 files changed, 141 insertions(+), 92 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/hbase/blob/6e9ded51/hbase-client/src/main/java/org/apache/hadoop/hbase/HColumnDescriptor.java
--
diff --git 
a/hbase-client/src/main/java/org/apache/hadoop/hbase/HColumnDescriptor.java 
b/hbase-client/src/main/java/org/apache/hadoop/hbase/HColumnDescriptor.java
index 5335bef..d4d8ee4 100644
--- a/hbase-client/src/main/java/org/apache/hadoop/hbase/HColumnDescriptor.java
+++ b/hbase-client/src/main/java/org/apache/hadoop/hbase/HColumnDescriptor.java
@@ -734,7 +734,7 @@ public class HColumnDescriptor implements 
ComparableHColumnDescriptor {
 String compressTagsStr = getValue(COMPRESS_TAGS);
 boolean compressTags = DEFAULT_COMPRESS_TAGS;
 if (compressTagsStr != null) {
-  compressTags = Boolean.valueOf(compressTagsStr);
+  compressTags = Boolean.parseBoolean(compressTagsStr);
 }
 return compressTags;
   }
@@ -747,7 +747,7 @@ public class HColumnDescriptor implements 
ComparableHColumnDescriptor {
 String compressTagsStr = getValue(COMPRESS_TAGS);
 boolean compressTags = DEFAULT_COMPRESS_TAGS;
 if (compressTagsStr != null) {
-  compressTags = Boolean.valueOf(compressTagsStr);
+  compressTags = Boolean.parseBoolean(compressTagsStr);
 }
 return compressTags;
   }
@@ -778,8 +778,9 @@ public class HColumnDescriptor implements 
ComparableHColumnDescriptor {
*/
   public boolean isInMemory() {
 String value = getValue(HConstants.IN_MEMORY);
-if (value != null)
-  return Boolean.valueOf(value).booleanValue();
+if (value != null) {
+  return Boolean.parseBoolean(value);
+}
 return DEFAULT_IN_MEMORY;
   }
 
@@ -827,7 +828,7 @@ public class HColumnDescriptor implements 
ComparableHColumnDescriptor {
*/
   public int getTimeToLive() {
 String value = getValue(TTL);
-return (value != null)? Integer.valueOf(value).intValue(): DEFAULT_TTL;
+return (value != null)? Integer.parseInt(value) : DEFAULT_TTL;
   }
 
   /**
@@ -843,7 +844,7 @@ public class HColumnDescriptor implements 
ComparableHColumnDescriptor {
*/
   public int getMinVersions() {
 String value = getValue(MIN_VERSIONS);
-return (value != null)? Integer.valueOf(value).intValue(): 0;
+return (value != null)? Integer.parseInt(value) : 0;
   }
 
   /**
@@ -861,8 +862,9 @@ public class HColumnDescriptor implements 
ComparableHColumnDescriptor {
*/
   public boolean isBlockCacheEnabled() {
 String value = getValue(BLOCKCACHE);
-if (value != null)
-  return Boolean.valueOf(value).booleanValue();
+if (value != null) {
+  return Boolean.parseBoolean(value);
+}
 return DEFAULT_BLOCKCACHE;
   }
 
@@ -900,7 +902,7 @@ public class HColumnDescriptor implements 
ComparableHColumnDescriptor {
   public int getScope() {
 byte[] value = getValue(REPLICATION_SCOPE_BYTES);
 if (value != null) {
-  return Integer.valueOf(Bytes.toString(value));
+  return