hbase git commit: HBASE-17017 Remove the current per-region latency histogram metrics
Repository: hbase Updated Branches: refs/heads/branch-1.3 ca11c5870 -> 323768148 HBASE-17017 Remove the current per-region latency histogram metrics Project: http://git-wip-us.apache.org/repos/asf/hbase/repo Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/32376814 Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/32376814 Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/32376814 Branch: refs/heads/branch-1.3 Commit: 323768148ab062ae50ae22f4a60fe2c58e05ec2d Parents: ca11c58 Author: Enis SoztutarAuthored: Tue Nov 8 15:43:41 2016 -0800 Committer: Enis Soztutar Committed: Mon Nov 14 17:27:21 2016 -0800 -- .../regionserver/MetricsRegionServerSource.java | 5 +- .../hbase/regionserver/MetricsRegionSource.java | 12 - .../regionserver/MetricsRegionSourceImpl.java | 52 ++-- .../hadoop/hbase/regionserver/HRegion.java | 7 +-- .../hbase/regionserver/MetricsRegion.java | 8 --- .../hbase/regionserver/RSRpcServices.java | 1 - .../regionserver/TestRegionServerMetrics.java | 12 ++--- 7 files changed, 25 insertions(+), 72 deletions(-) -- http://git-wip-us.apache.org/repos/asf/hbase/blob/32376814/hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSource.java -- diff --git a/hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSource.java b/hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSource.java index 182122a..1991105 100644 --- a/hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSource.java +++ b/hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSource.java @@ -316,7 +316,7 @@ public interface MetricsRegionServerSource extends BaseSource { String BLOCK_CACHE_GENERAL_BLOOM_META_HIT_COUNT = "blockCacheGeneralBloomMetaHitCount"; String BLOCK_CACHE_DELETE_FAMILY_BLOOM_HIT_COUNT = "blockCacheDeleteFamilyBloomHitCount"; String BLOCK_CACHE_TRAILER_HIT_COUNT = "blockCacheTrailerHitCount"; - + String RS_START_TIME_NAME = "regionServerStartTime"; String ZOOKEEPER_QUORUM_NAME = "zookeeperQuorum"; String SERVER_NAME_NAME = "serverName"; @@ -335,6 +335,7 @@ public interface MetricsRegionServerSource extends BaseSource { String MUTATE_KEY = "mutate"; String APPEND_KEY = "append"; String REPLAY_KEY = "replay"; + String SCAN_KEY = "scan"; String SCAN_SIZE_KEY = "scanSize"; String SCAN_TIME_KEY = "scanTime"; @@ -446,6 +447,6 @@ public interface MetricsRegionServerSource extends BaseSource { String RPC_MUTATE_REQUEST_COUNT_DESC = "Number of rpc mutation requests this region server has answered."; String AVERAGE_REGION_SIZE = "averageRegionSize"; - String AVERAGE_REGION_SIZE_DESC = + String AVERAGE_REGION_SIZE_DESC = "Average region size over the region server including memstore and storefile sizes."; } http://git-wip-us.apache.org/repos/asf/hbase/blob/32376814/hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSource.java -- diff --git a/hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSource.java b/hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSource.java index 12ef07c..decf841 100644 --- a/hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSource.java +++ b/hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSource.java @@ -60,24 +60,12 @@ public interface MetricsRegionSource extends Comparable { void updateDelete(); /** - * Update count and sizes of gets. - * @param getSize size in bytes of the resulting key values for a get - */ - void updateGetSize(long getSize); - - /** * Update time of gets * @param mills time for this get operation. */ void updateGet(long mills); /** - * Update the count and sizes of resultScanner.next() - * @param scanSize Size in bytes of the resulting key values for a next() - */ - void updateScanSize(long scanSize); - - /** * Update time used of resultScanner.next(). * */ void updateScanTime(long mills); http://git-wip-us.apache.org/repos/asf/hbase/blob/32376814/hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSourceImpl.java -- diff --git a/hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSourceImpl.java
hbase git commit: HBASE-17017 Remove the current per-region latency histogram metrics
Repository: hbase Updated Branches: refs/heads/master 3b629d632 -> 03bc884ea HBASE-17017 Remove the current per-region latency histogram metrics Project: http://git-wip-us.apache.org/repos/asf/hbase/repo Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/03bc884e Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/03bc884e Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/03bc884e Branch: refs/heads/master Commit: 03bc884ea085197a651b50ddc21f575560854f1c Parents: 3b629d6 Author: Enis SoztutarAuthored: Tue Nov 8 15:43:41 2016 -0800 Committer: Enis Soztutar Committed: Tue Nov 8 18:31:53 2016 -0800 -- .../regionserver/MetricsRegionServerSource.java | 5 +- .../hbase/regionserver/MetricsRegionSource.java | 12 - .../regionserver/MetricsRegionSourceImpl.java | 52 ++-- .../hadoop/hbase/regionserver/HRegion.java | 11 + .../hbase/regionserver/MetricsRegion.java | 8 --- .../hbase/regionserver/RSRpcServices.java | 1 - .../regionserver/TestRegionServerMetrics.java | 11 ++--- 7 files changed, 25 insertions(+), 75 deletions(-) -- http://git-wip-us.apache.org/repos/asf/hbase/blob/03bc884e/hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSource.java -- diff --git a/hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSource.java b/hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSource.java index 1e9b7ef..0e7dd8d 100644 --- a/hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSource.java +++ b/hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSource.java @@ -321,7 +321,7 @@ public interface MetricsRegionServerSource extends BaseSource, JvmPauseMonitorSo String BLOCK_CACHE_GENERAL_BLOOM_META_HIT_COUNT = "blockCacheGeneralBloomMetaHitCount"; String BLOCK_CACHE_DELETE_FAMILY_BLOOM_HIT_COUNT = "blockCacheDeleteFamilyBloomHitCount"; String BLOCK_CACHE_TRAILER_HIT_COUNT = "blockCacheTrailerHitCount"; - + String RS_START_TIME_NAME = "regionServerStartTime"; String ZOOKEEPER_QUORUM_NAME = "zookeeperQuorum"; String SERVER_NAME_NAME = "serverName"; @@ -340,6 +340,7 @@ public interface MetricsRegionServerSource extends BaseSource, JvmPauseMonitorSo String MUTATE_KEY = "mutate"; String APPEND_KEY = "append"; String REPLAY_KEY = "replay"; + String SCAN_KEY = "scan"; String SCAN_SIZE_KEY = "scanSize"; String SCAN_TIME_KEY = "scanTime"; @@ -489,6 +490,6 @@ public interface MetricsRegionServerSource extends BaseSource, JvmPauseMonitorSo String RPC_MUTATE_REQUEST_COUNT_DESC = "Number of rpc mutation requests this region server has answered."; String AVERAGE_REGION_SIZE = "averageRegionSize"; - String AVERAGE_REGION_SIZE_DESC = + String AVERAGE_REGION_SIZE_DESC = "Average region size over the region server including memstore and storefile sizes."; } http://git-wip-us.apache.org/repos/asf/hbase/blob/03bc884e/hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSource.java -- diff --git a/hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSource.java b/hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSource.java index 12ef07c..decf841 100644 --- a/hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSource.java +++ b/hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSource.java @@ -60,24 +60,12 @@ public interface MetricsRegionSource extends Comparable { void updateDelete(); /** - * Update count and sizes of gets. - * @param getSize size in bytes of the resulting key values for a get - */ - void updateGetSize(long getSize); - - /** * Update time of gets * @param mills time for this get operation. */ void updateGet(long mills); /** - * Update the count and sizes of resultScanner.next() - * @param scanSize Size in bytes of the resulting key values for a next() - */ - void updateScanSize(long scanSize); - - /** * Update time used of resultScanner.next(). * */ void updateScanTime(long mills); http://git-wip-us.apache.org/repos/asf/hbase/blob/03bc884e/hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSourceImpl.java -- diff --git a/hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSourceImpl.java
hbase git commit: HBASE-17017 Remove the current per-region latency histogram metrics
Repository: hbase Updated Branches: refs/heads/branch-1 a70f73c1e -> 123d26ed9 HBASE-17017 Remove the current per-region latency histogram metrics Project: http://git-wip-us.apache.org/repos/asf/hbase/repo Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/123d26ed Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/123d26ed Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/123d26ed Branch: refs/heads/branch-1 Commit: 123d26ed907a9d1532386ce965ff2c388e44fe39 Parents: a70f73c Author: Enis SoztutarAuthored: Tue Nov 8 15:43:41 2016 -0800 Committer: Enis Soztutar Committed: Tue Nov 8 18:31:12 2016 -0800 -- .../regionserver/MetricsRegionServerSource.java | 5 +- .../hbase/regionserver/MetricsRegionSource.java | 12 - .../regionserver/MetricsRegionSourceImpl.java | 52 ++-- .../hadoop/hbase/regionserver/HRegion.java | 7 +-- .../hbase/regionserver/MetricsRegion.java | 8 --- .../hbase/regionserver/RSRpcServices.java | 1 - .../regionserver/TestRegionServerMetrics.java | 12 ++--- 7 files changed, 25 insertions(+), 72 deletions(-) -- http://git-wip-us.apache.org/repos/asf/hbase/blob/123d26ed/hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSource.java -- diff --git a/hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSource.java b/hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSource.java index 47fbee0..b826609 100644 --- a/hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSource.java +++ b/hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSource.java @@ -317,7 +317,7 @@ public interface MetricsRegionServerSource extends BaseSource, JvmPauseMonitorSo String BLOCK_CACHE_GENERAL_BLOOM_META_HIT_COUNT = "blockCacheGeneralBloomMetaHitCount"; String BLOCK_CACHE_DELETE_FAMILY_BLOOM_HIT_COUNT = "blockCacheDeleteFamilyBloomHitCount"; String BLOCK_CACHE_TRAILER_HIT_COUNT = "blockCacheTrailerHitCount"; - + String RS_START_TIME_NAME = "regionServerStartTime"; String ZOOKEEPER_QUORUM_NAME = "zookeeperQuorum"; String SERVER_NAME_NAME = "serverName"; @@ -336,6 +336,7 @@ public interface MetricsRegionServerSource extends BaseSource, JvmPauseMonitorSo String MUTATE_KEY = "mutate"; String APPEND_KEY = "append"; String REPLAY_KEY = "replay"; + String SCAN_KEY = "scan"; String SCAN_SIZE_KEY = "scanSize"; String SCAN_TIME_KEY = "scanTime"; @@ -447,6 +448,6 @@ public interface MetricsRegionServerSource extends BaseSource, JvmPauseMonitorSo String RPC_MUTATE_REQUEST_COUNT_DESC = "Number of rpc mutation requests this region server has answered."; String AVERAGE_REGION_SIZE = "averageRegionSize"; - String AVERAGE_REGION_SIZE_DESC = + String AVERAGE_REGION_SIZE_DESC = "Average region size over the region server including memstore and storefile sizes."; } http://git-wip-us.apache.org/repos/asf/hbase/blob/123d26ed/hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSource.java -- diff --git a/hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSource.java b/hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSource.java index 12ef07c..decf841 100644 --- a/hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSource.java +++ b/hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSource.java @@ -60,24 +60,12 @@ public interface MetricsRegionSource extends Comparable { void updateDelete(); /** - * Update count and sizes of gets. - * @param getSize size in bytes of the resulting key values for a get - */ - void updateGetSize(long getSize); - - /** * Update time of gets * @param mills time for this get operation. */ void updateGet(long mills); /** - * Update the count and sizes of resultScanner.next() - * @param scanSize Size in bytes of the resulting key values for a next() - */ - void updateScanSize(long scanSize); - - /** * Update time used of resultScanner.next(). * */ void updateScanTime(long mills); http://git-wip-us.apache.org/repos/asf/hbase/blob/123d26ed/hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSourceImpl.java -- diff --git a/hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSourceImpl.java