[GitHub] [incubator-heron] nicknezis commented on pull request #3555: zookeeper to 3.5.8
nicknezis commented on pull request #3555: URL: https://github.com/apache/incubator-heron/pull/3555#issuecomment-656626054 It worked for me after adding the missing package. Updating bazel_configure.py is a great idea. For this pull request, would it be sufficient to update the website documentation with the updated packages that are needed? It feels like that should happen in this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-heron] nicknezis commented on pull request #3555: zookeeper to 3.5.8
nicknezis commented on pull request #3555: URL: https://github.com/apache/incubator-heron/pull/3555#issuecomment-656176664 I'm getting this error when trying to build on `darwin` (OSX): ``` ERROR: /private/var/tmp/_bazel_nnezis/42af5204dd5936eb8287d40b2ccac539/external/org_apache_zookeeper/BUILD.bazel:7:8: Executing genrule @org_apache_zookeeper//:zookeeper-srcs failed (Exit 1) acinclude.m4:315: warning: macro 'AM_PATH_CPPUNIT' not found in library configure.ac:37: error: Missing AM_PATH_CPPUNIT or PKG_CHECK_MODULES m4 macro. acinclude.m4:327: CHECK_CPPUNIT is expanded from... configure.ac:37: the top level autom4te: /usr/bin/m4 failed with exit status: 1 aclocal: error: echo failed with exit status: 1 autoreconf: aclocal failed with exit status: 1 Buildfile: /private/var/folders/nv/s1d1vxld0c51bfkmxltp0zk8gn/T/zookeeper.X.urp0mbJd/build.xml ``` I even tried adding `--without-cppunit` to the `./configure` line, but without success. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-heron] nicknezis commented on pull request #3555: zookeeper to 3.5.8
nicknezis commented on pull request #3555: URL: https://github.com/apache/incubator-heron/pull/3555#issuecomment-654577804 I'm having issues compiling this on OSX with this command: `bazel build --config=darwin_nostyle heron/...` ``` ❯ ./bazel_configure.py Platform Darwin Using C compiler : /usr/bin/gcc (4.2.1) Using C++ compiler: /usr/bin/g++ (4.2.1) Using C preprocessor : /usr/bin/cpp (11.0.0) Using C++ preprocessor: /usr/bin/cpp (11.0.0) Using linker : /usr/bin/ld Using JDK : /System/Library/Frameworks/JavaVM.framework/Versions/A Using Automake: /usr/local/Cellar/automake/1.16.2/bin/automake (1.16.2) Using Autoconf: /usr/local/Cellar/autoconf/2.69/bin/autoconf (2.69) Using Make: /usr/bin/make (3.81) Using Python : /System/Library/Frameworks/Python.framework/Versions/2.7/bin/python2.7 (2.7.16) Using Libtool : /usr/local/Cellar/libtool/2.4.6_2/bin/glibtool (2.4.6) Using archiver: /usr/bin/ar Using coverage tool : /usr/bin/gcov dwp : not found, but ok Using nm : /usr/bin/nm objcopy : not found, but ok Using objdump : /usr/bin/objdump Using strip : /usr/bin/strip ``` The error I get: ``` INFO: From Linking heron/proto/libproto-cxx.a: /Library/Developer/CommandLineTools/usr/bin/libtool: file: bazel-out/darwin-fastbuild/bin/heron/proto/_objs/proto-cxx/empty.pic.o has no symbols warning: /Library/Developer/CommandLineTools/usr/bin/libtool: warning for library: bazel-out/darwin-fastbuild/bin/heron/proto/libproto-cxx.a the table of contents is empty (no object file members in the library define global symbols) ERROR: /private/var/tmp/_bazel_nnezis/42af5204dd5936eb8287d40b2ccac539/external/org_apache_zookeeper/BUILD.bazel:7:8: Executing genrule @org_apache_zookeeper//:zookeeper-srcs failed (Exit 1) /bin/bash: line 7: ./configure: No such file or directory INFO: Elapsed time: 80.026s, Critical Path: 28.42s INFO: 443 processes: 443 local. FAILED: Build did NOT complete successfully ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-heron] nicknezis commented on pull request #3555: zookeeper to 3.5.8
nicknezis commented on pull request #3555: URL: https://github.com/apache/incubator-heron/pull/3555#issuecomment-654572738 @huijunwu I just realized that you still need to run `bazel run @unpinned_maven//:pin` to update the `maven_install.json` file. Maybe we should move the comment listed here to right above the dependencies list. https://github.com/apache/incubator-heron/blob/f7715f3bbff4d7f0a00aea8962360ebd17624bb8/WORKSPACE#L153 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-heron] nicknezis commented on pull request #3555: zookeeper to 3.5.8
nicknezis commented on pull request #3555: URL: https://github.com/apache/incubator-heron/pull/3555#issuecomment-653719748 The Helm chart is challenging because Heron and Bookkeeper both use a shared Zookeeper. This makes updates like this challenging. I think it would be preferable we can update the Helm chart to use S3 instead of Bookkeeper for Upload/Download of the analytic artifacts. Other options would be to update the Helm chart to include another Zookeeper instance dedicated for Bookkeeper. Ideally with the official Bookkeeper Helm chart and not the current copy of yamls we are maintaining. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-heron] nicknezis commented on pull request #3555: zookeeper to 3.5.8
nicknezis commented on pull request #3555: URL: https://github.com/apache/incubator-heron/pull/3555#issuecomment-653363238 We will need to also update the Zookeeper included in the Dockerfiles. Also, do we know if the version of Bookkeeper used in the Helm chart will work with this version of Zookeeper? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
