[GitHub] [hudi] nsivabalan commented on pull request #2923: [HUDI-1864] Added support for Date, Timestamp, LocalDate and LocalDateTime in TimestampBasedAvroKeyGenerator
nsivabalan commented on pull request #2923: URL: https://github.com/apache/hudi/pull/2923#issuecomment-865486663 @n3nash : Can you please respond to the author. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hudi] nsivabalan commented on pull request #2923: [HUDI-1864] Added support for Date, Timestamp, LocalDate and LocalDateTime in TimestampBasedAvroKeyGenerator
nsivabalan commented on pull request #2923: URL: https://github.com/apache/hudi/pull/2923#issuecomment-865486663 @n3nash : Can you please respond to the author. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hudi] nsivabalan commented on pull request #2923: [HUDI-1864] Added support for Date, Timestamp, LocalDate and LocalDateTime in TimestampBasedAvroKeyGenerator
nsivabalan commented on pull request #2923: URL: https://github.com/apache/hudi/pull/2923#issuecomment-855236580 @vaibhav-sinha : I recreated this PR cleanly [here](https://github.com/apache/hudi/pull/3039). Have not made fixes to TestCopyOnWrite yet. will wait for flink experts to chime in. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hudi] nsivabalan commented on pull request #2923: [HUDI-1864] Added support for Date, Timestamp, LocalDate and LocalDateTime in TimestampBasedAvroKeyGenerator
nsivabalan commented on pull request #2923: URL: https://github.com/apache/hudi/pull/2923#issuecomment-855233374 @vaibhav-sinha : in the mean time, can you address nishith's feedback on test naming. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hudi] nsivabalan commented on pull request #2923: [HUDI-1864] Added support for Date, Timestamp, LocalDate and LocalDateTime in TimestampBasedAvroKeyGenerator
nsivabalan commented on pull request #2923: URL: https://github.com/apache/hudi/pull/2923#issuecomment-851480106 @vaibhav-sinha : Not sure how you rebased with master, but I see your commits are interleaved with commits in master. Also, I tried running TestWriteCopyOnWrite tests in apache master and its succeeding. Would you mind putting up a new PR with just the required changes from this PR. Start with a new branch from latest master. And we can go from there. And whenever you wanna rebase your feature branch w/ master, do the following. 1. ensure you are in your feature branch. I assume this is your own repo with upstream as apache/hudi 2. git fetch upstream master 3. git rebase upstream/master So, whenever you fetch and rebase, your commits will be rebased on top of latest master. in other words, all commits in your feature branch should be on top of latest master commit once. your commits should not be interleaved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hudi] nsivabalan commented on pull request #2923: [HUDI-1864] Added support for Date, Timestamp, LocalDate and LocalDateTime in TimestampBasedAvroKeyGenerator
nsivabalan commented on pull request #2923: URL: https://github.com/apache/hudi/pull/2923#issuecomment-847933890 Can you check CI failure please. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
