[GitHub] [incubator-hudi] Trevor-zhang commented on a change in pull request #1477: [HUDI-749] Fix hudi-timeline-server-bundle./run_server.sh start error

2020-04-01 Thread GitBox
Trevor-zhang commented on a change in pull request #1477: [HUDI-749] Fix 
hudi-timeline-server-bundle./run_server.sh start error
URL: https://github.com/apache/incubator-hudi/pull/1477#discussion_r401647927
 
 

 ##
 File path: packaging/hudi-timeline-server-bundle/run_server.sh
 ##
 @@ -19,7 +19,7 @@
 
 DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
 #Ensure we pick the right jar even for hive11 builds
-HOODIE_JAR=`ls -c $DIR/target/hudi-timeline-server-bundle-*.jar | grep -v test 
| head -1`
+HOODIE_JAR=`ls c $DIR/target/hudi-timeline-server-bundle*.jar | grep -v test | 
grep -v source | head -1`
 
 Review comment:
   > nit:
   > change to
   > HOODIE_JAR=`ls -c $DIR/target/hudi-timeline-server-bundle-*.jar | grep -v 
test | grep -v source | head -1` should be ok(just need add `| grep -v source`).
   
   It's my fault! 
   done.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-hudi] Trevor-zhang commented on a change in pull request #1477: [HUDI-749] Fix hudi-timeline-server-bundle./run_server.sh start error

2020-04-01 Thread GitBox
Trevor-zhang commented on a change in pull request #1477: [HUDI-749] Fix 
hudi-timeline-server-bundle./run_server.sh start error
URL: https://github.com/apache/incubator-hudi/pull/1477#discussion_r401647133
 
 

 ##
 File path: packaging/hudi-timeline-server-bundle/run_server.sh
 ##
 @@ -19,7 +19,7 @@
 
 DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
 #Ensure we pick the right jar even for hive11 builds
-HOODIE_JAR=`ls -c $DIR/target/hudi-timeline-server-bundle-*.jar | grep -v test 
| head -1`
+HOODIE_JAR=`ls c $DIR/target/hudi-timeline-server-bundle*.jar | grep -v test | 
grep -v source | head -1`
 
 Review comment:
   > nit: `ls c` to `ls -c`
   
   done.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services