[GitHub] [incubator-hudi] bvaradar commented on issue #918: [HUDI-121] : Address comments during RC2 voting

2019-09-26 Thread GitBox
bvaradar commented on issue #918: [HUDI-121] : Address comments during RC2 
voting
URL: https://github.com/apache/incubator-hudi/pull/918#issuecomment-535664328
 
 
   @vinothchandar @lresende : 
   Some Examples of NOTICE and LICENSE from other incubator projects that shows 
these files are generated for source release
   
   1. https://github.com/apache/incubator-gobblin/blob/master/LICENSE
   2. https://github.com/apache/incubator-gobblin/blob/master/NOTICE
   3. https://github.com/apache/incubator-heron/blob/master/LICENSE
   3. https://github.com/apache/incubator-heron/blob/master/NOTICE


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-hudi] bvaradar commented on issue #918: [HUDI-121] : Address comments during RC2 voting

2019-09-26 Thread GitBox
bvaradar commented on issue #918: [HUDI-121] : Address comments during RC2 
voting
URL: https://github.com/apache/incubator-hudi/pull/918#issuecomment-535585438
 
 
   @lresende : Updated based on review comments. Please take a look again and 
review.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-hudi] bvaradar commented on issue #918: [HUDI-121] : Address comments during RC2 voting

2019-09-24 Thread GitBox
bvaradar commented on issue #918: [HUDI-121] : Address comments during RC2 
voting
URL: https://github.com/apache/incubator-hudi/pull/918#issuecomment-534836536
 
 
   @lresende : Thanks a lot for reviewing 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-hudi] bvaradar commented on issue #918: [HUDI-121] : Address comments during RC2 voting

2019-09-24 Thread GitBox
bvaradar commented on issue #918: [HUDI-121] : Address comments during RC2 
voting
URL: https://github.com/apache/incubator-hudi/pull/918#issuecomment-534786793
 
 
   @vinothchandar : Updated. Please review when you get a chance
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-hudi] bvaradar commented on issue #918: HUDI-121 : Address comments during RC2 voting

2019-09-23 Thread GitBox
bvaradar commented on issue #918: HUDI-121 : Address comments during RC2 voting
URL: https://github.com/apache/incubator-hudi/pull/918#issuecomment-534202510
 
 
   @vinothchandar @lresende : Kindly review this 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services