[GitHub] [incubator-hudi] lamber-ken commented on a change in pull request #1079: [HUDI-379] Refactor the codes based on new JavadocStyle code style rule
lamber-ken commented on a change in pull request #1079: [HUDI-379] Refactor the codes based on new JavadocStyle code style rule URL: https://github.com/apache/incubator-hudi/pull/1079#discussion_r354337130 ## File path: style/checkstyle.xml ## @@ -271,9 +271,8 @@ - - - + + Review comment: > The default severity is `error`, is the time to change it? Yes, this pr fixed all codes based on JavadocStyle. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-hudi] lamber-ken commented on a change in pull request #1079: [HUDI-379] Refactor the codes based on new JavadocStyle code style rule
lamber-ken commented on a change in pull request #1079: [HUDI-379] Refactor the codes based on new JavadocStyle code style rule URL: https://github.com/apache/incubator-hudi/pull/1079#discussion_r354337249 ## File path: style/checkstyle.xml ## @@ -271,9 +271,8 @@ - - - + + Review comment: > Since the PR(#1081) does the similar thing. Right This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-hudi] lamber-ken commented on a change in pull request #1079: [HUDI-379] Refactor the codes based on new JavadocStyle code style rule
lamber-ken commented on a change in pull request #1079: [HUDI-379] Refactor the codes based on new JavadocStyle code style rule URL: https://github.com/apache/incubator-hudi/pull/1079#discussion_r354337249 ## File path: style/checkstyle.xml ## @@ -271,9 +271,8 @@ - - - + + Review comment: > Since the PR(#1081) does the similar thing. right This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-hudi] lamber-ken commented on a change in pull request #1079: [HUDI-379] Refactor the codes based on new JavadocStyle code style rule
lamber-ken commented on a change in pull request #1079: [HUDI-379] Refactor the codes based on new JavadocStyle code style rule URL: https://github.com/apache/incubator-hudi/pull/1079#discussion_r354337130 ## File path: style/checkstyle.xml ## @@ -271,9 +271,8 @@ - - - + + Review comment: > The default severity is `error`, is the time to change it? yes, I fix all codes based on JavadocStyle. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-hudi] lamber-ken commented on a change in pull request #1079: [HUDI-379] Refactor the codes based on new JavadocStyle code style rule
lamber-ken commented on a change in pull request #1079: [HUDI-379] Refactor the codes based on new JavadocStyle code style rule URL: https://github.com/apache/incubator-hudi/pull/1079#discussion_r354337130 ## File path: style/checkstyle.xml ## @@ -271,9 +271,8 @@ - - - + + Review comment: > The default severity is `error`, is the time to change it? Yes, I fix all codes based on JavadocStyle. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
