[GitHub] [incubator-hudi] lamber-ken commented on a change in pull request #1095: [HUDI-210] Implement prometheus metrics reporter
lamber-ken commented on a change in pull request #1095: [HUDI-210] Implement prometheus metrics reporter URL: https://github.com/apache/incubator-hudi/pull/1095#discussion_r356425369 ## File path: hudi-client/pom.xml ## @@ -117,6 +117,18 @@ io.dropwizard.metrics metrics-core + Review comment: hi, this dependency can remove. ``` io.prometheus simpleclient ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-hudi] lamber-ken commented on a change in pull request #1095: [HUDI-210] Implement prometheus metrics reporter
lamber-ken commented on a change in pull request #1095: [HUDI-210] Implement prometheus metrics reporter URL: https://github.com/apache/incubator-hudi/pull/1095#discussion_r356425369 ## File path: hudi-client/pom.xml ## @@ -117,6 +117,18 @@ io.dropwizard.metrics metrics-core + Review comment: hi, this dependency can remove. io.prometheus simpleclient This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-hudi] lamber-ken commented on a change in pull request #1095: [HUDI-210] Implement prometheus metrics reporter
lamber-ken commented on a change in pull request #1095: [HUDI-210] Implement prometheus metrics reporter URL: https://github.com/apache/incubator-hudi/pull/1095#discussion_r356425369 ## File path: hudi-client/pom.xml ## @@ -117,6 +117,18 @@ io.dropwizard.metrics metrics-core + Review comment: hi, this dependency can remove. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-hudi] lamber-ken commented on a change in pull request #1095: [HUDI-210] Implement prometheus metrics reporter
lamber-ken commented on a change in pull request #1095: [HUDI-210] Implement prometheus metrics reporter URL: https://github.com/apache/incubator-hudi/pull/1095#discussion_r356413234 ## File path: hudi-client/src/main/java/org/apache/hudi/config/HoodieMetricsConfig.java ## @@ -57,6 +57,14 @@ public static final String GRAPHITE_METRIC_PREFIX = GRAPHITE_PREFIX + ".metric.prefix"; + // Prometheus + public static final String PROMETHEUS_PUSHGATEWAY_PREFIX = METRIC_PREFIX + ".graphite"; + public static final String PROMETHEUS_PUSHGATEWAY_HOST = PROMETHEUS_PUSHGATEWAY_PREFIX + ".host"; + public static final String DEFAULT_PROMETHEUS_PUSHGATEWAY_HOST = "localhost"; + + public static final String PROMETHEUS_PUSHGATEWAY_PORT = PROMETHEUS_PUSHGATEWAY_PREFIX + ".port"; + public static final int DEFAULT_PROMETHEUS_PUSHGATEWAY_PORT = 8080; Review comment: Hi, default port is `9091`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
