[GitHub] [incubator-hudi] lamber-ken commented on a change in pull request #1167: [HUDI-484] Fix NPE when reading IncrementalPull.sqltemplate in HiveIncrementalPuller
lamber-ken commented on a change in pull request #1167: [HUDI-484] Fix NPE when reading IncrementalPull.sqltemplate in HiveIncrementalPuller URL: https://github.com/apache/incubator-hudi/pull/1167#discussion_r363073651 ## File path: hudi-utilities/src/test/java/org/apache/hudi/utilities/TestHiveIncrementalPuller.java ## @@ -0,0 +1,27 @@ +package org.apache.hudi.utilities; + +import org.junit.Assert; +import org.junit.Before; +import org.junit.Test; + +public class TestHiveIncrementalPuller { + + private HiveIncrementalPuller.Config config; + + @Before + public void setup() { +config = new HiveIncrementalPuller.Config(); + } + + @Test + public void testInitHiveIncrementalPuller() throws Exception { Review comment: Good catch . Sorry, I forgot to delete it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-hudi] lamber-ken commented on a change in pull request #1167: [HUDI-484] Fix NPE when reading IncrementalPull.sqltemplate in HiveIncrementalPuller
lamber-ken commented on a change in pull request #1167: [HUDI-484] Fix NPE when reading IncrementalPull.sqltemplate in HiveIncrementalPuller URL: https://github.com/apache/incubator-hudi/pull/1167#discussion_r363054144 ## File path: hudi-utilities/src/test/java/org/apache/hudi/utilities/TestHiveIncrementalPuller.java ## @@ -0,0 +1,24 @@ +package org.apache.hudi.utilities; + +import org.junit.Assert; +import org.junit.Before; +import org.junit.Test; + +public class TestHiveIncrementalPuller { + + private HiveIncrementalPuller.Config config; + + @Before + public void init() { +config = new HiveIncrementalPuller.Config(); + } + + @Test + public void testInitHiveIncrementalPuller() throws Exception { + +HiveIncrementalPuller puller = new HiveIncrementalPuller(config); Review comment: Done. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-hudi] lamber-ken commented on a change in pull request #1167: [HUDI-484] Fix NPE when reading IncrementalPull.sqltemplate in HiveIncrementalPuller
lamber-ken commented on a change in pull request #1167: [HUDI-484] Fix NPE when reading IncrementalPull.sqltemplate in HiveIncrementalPuller URL: https://github.com/apache/incubator-hudi/pull/1167#discussion_r363054122 ## File path: hudi-utilities/src/test/java/org/apache/hudi/utilities/TestHiveIncrementalPuller.java ## @@ -0,0 +1,24 @@ +package org.apache.hudi.utilities; + +import org.junit.Assert; +import org.junit.Before; +import org.junit.Test; + +public class TestHiveIncrementalPuller { + + private HiveIncrementalPuller.Config config; + + @Before + public void init() { Review comment: Done. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-hudi] lamber-ken commented on a change in pull request #1167: [HUDI-484] Fix NPE when reading IncrementalPull.sqltemplate in HiveIncrementalPuller
lamber-ken commented on a change in pull request #1167: [HUDI-484] Fix NPE when reading IncrementalPull.sqltemplate in HiveIncrementalPuller URL: https://github.com/apache/incubator-hudi/pull/1167#discussion_r362369737 ## File path: hudi-utilities/src/test/java/org/apache/hudi/utilities/TestHiveIncrementalPuller.java ## @@ -0,0 +1,24 @@ +package org.apache.hudi.utilities; + +import org.junit.Assert; +import org.junit.Before; +import org.junit.Test; + +public class TestHiveIncrementalPuller { + + private HiveIncrementalPuller.Config config; + + @Before + public void init() { +config = new HiveIncrementalPuller.Config(); + } + + @Test + public void testInitHiveIncrementalPuller() throws Exception { + +HiveIncrementalPuller puller = new HiveIncrementalPuller(config); Review comment: Got it, thank you for your guidance. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services