[GitHub] [incubator-hudi] smarthi commented on a change in pull request #1161: [HUDI-457]Redo hudi-common log statements using SLF4J

[GitBox]

smarthi commented on a change in pull request #1161: [HUDI-457]Redo hudi-common 
log statements using SLF4J
URL: https://github.com/apache/incubator-hudi/pull/1161#discussion_r362386992
 
 

 ##
 File path: 
hudi-common/src/main/java/org/apache/hudi/common/table/log/HoodieLogFormat.java
 ##
 @@ -222,8 +222,8 @@ public Writer build() throws IOException, 
InterruptedException {
   // Use rollover write token as write token to create new log file 
with tokens
   logWriteToken = rolloverLogWriteToken;
 }
-LOG.info("Computed the next log version for " + logFileId + " in " + 
parentPath + " as " + logVersion
-+ " with write-token " + logWriteToken);
+LOG.info("Computed the next log version for {} in {} as {} with 
write-token {}",
+logFileId, parentPath, logVersion, logWriteToken);
 
 Review comment:
   remove extra indent ???


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-hudi] smarthi commented on a change in pull request #1161: [HUDI-457]Redo hudi-common log statements using SLF4J

[GitBox]

smarthi commented on a change in pull request #1161: [HUDI-457]Redo hudi-common 
log statements using SLF4J
URL: https://github.com/apache/incubator-hudi/pull/1161#discussion_r362386748
 
 

 ##
 File path: 
hudi-common/src/main/java/org/apache/hudi/common/model/HoodiePartitionMetadata.java
 ##
 @@ -101,8 +101,8 @@ public void trySave(int taskPartitionId) {
 fs.rename(tmpMetaPath, metaPath);
   }
 } catch (IOException ioe) {
-  LOG.warn("Error trying to save partition metadata (this is okay, as long 
as atleast 1 of these succced), "
-  + partitionPath, ioe);
+  LOG.warn("Error trying to save partition metadata (this is okay, as long 
as atleast 1 of these succced), {}",
+  partitionPath, ioe);
 
 Review comment:
   remove extra indent ??


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services