[GitHub] [incubator-hudi] vinothchandar commented on pull request #1433: [HUDI-728]: Implement custom key generator

2020-05-14 Thread GitBox 


vinothchandar commented on pull request #1433:
URL: https://github.com/apache/incubator-hudi/pull/1433#issuecomment-628873883


   @nsivabalan  can you shepherd this one home from here> 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-hudi] vinothchandar commented on pull request #1433: [HUDI-728]: Implement custom key generator

2020-05-14 Thread GitBox 


vinothchandar commented on pull request #1433:
URL: https://github.com/apache/incubator-hudi/pull/1433#issuecomment-628873197


   @pratyakshsharma Rebased and removed the parquet files etc.. 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-hudi] vinothchandar commented on pull request #1433: [HUDI-728]: Implement custom key generator

2020-05-05 Thread GitBox 


vinothchandar commented on pull request #1433:
URL: https://github.com/apache/incubator-hudi/pull/1433#issuecomment-624117565


   @pratyakshsharma rebase again? I can take a final pass



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-hudi] vinothchandar commented on pull request #1433: [HUDI-728]: Implement custom key generator

2020-04-27 Thread GitBox 


vinothchandar commented on pull request #1433:
URL: https://github.com/apache/incubator-hudi/pull/1433#issuecomment-620204439


   >>Should I include that in this PR or should I go for a separate PR. Please 
suggest.
   
   Your call.. Doing it here is fine by me as well, since you are touching all 
those files anyway.. 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org