[GitHub] [incubator-hudi] zhedoubushishi commented on a change in pull request #1036: [HUDI-353] Add hive style partitioning path

2019-12-09 Thread GitBox 
zhedoubushishi commented on a change in pull request #1036: [HUDI-353] Add hive 
style partitioning path
URL: https://github.com/apache/incubator-hudi/pull/1036#discussion_r355619914
 
 

 ##
 File path: hudi-hive/src/main/java/org/apache/hudi/hive/HiveSyncConfig.java
 ##
 @@ -68,6 +68,10 @@
   @Parameter(names = {"--use-jdbc"}, description = "Hive jdbc connect url")
   public Boolean useJdbc = true;
 
+  @Parameter(names = "--use-hive-style-partitioning", description = "Use Hive 
style partitioning, the name of "
+  + "partition folders follow = 
format")
+  public Boolean useHiveStylePartitioning = false;
 
 Review comment:
   > @zhedoubushishi : Is this still being used ? If not, Can you remove it
   
   Oh its not. All related code is removed now.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-hudi] zhedoubushishi commented on a change in pull request #1036: [HUDI-353] Add hive style partitioning path

2019-12-09 Thread GitBox 
zhedoubushishi commented on a change in pull request #1036: [HUDI-353] Add hive 
style partitioning path
URL: https://github.com/apache/incubator-hudi/pull/1036#discussion_r355619914
 
 

 ##
 File path: hudi-hive/src/main/java/org/apache/hudi/hive/HiveSyncConfig.java
 ##
 @@ -68,6 +68,10 @@
   @Parameter(names = {"--use-jdbc"}, description = "Hive jdbc connect url")
   public Boolean useJdbc = true;
 
+  @Parameter(names = "--use-hive-style-partitioning", description = "Use Hive 
style partitioning, the name of "
+  + "partition folders follow = 
format")
+  public Boolean useHiveStylePartitioning = false;
 
 Review comment:
   > @zhedoubushishi : Is this still being used ? If not, Can you remove it
   
   Oh its not. All related code is removed now.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-hudi] zhedoubushishi commented on a change in pull request #1036: [HUDI-353] Add hive style partitioning path

2019-12-09 Thread GitBox 
zhedoubushishi commented on a change in pull request #1036: [HUDI-353] Add hive 
style partitioning path
URL: https://github.com/apache/incubator-hudi/pull/1036#discussion_r355619914
 
 

 ##
 File path: hudi-hive/src/main/java/org/apache/hudi/hive/HiveSyncConfig.java
 ##
 @@ -68,6 +68,10 @@
   @Parameter(names = {"--use-jdbc"}, description = "Hive jdbc connect url")
   public Boolean useJdbc = true;
 
+  @Parameter(names = "--use-hive-style-partitioning", description = "Use Hive 
style partitioning, the name of "
+  + "partition folders follow = 
format")
+  public Boolean useHiveStylePartitioning = false;
 
 Review comment:
   Oh its not. All related code is removed now.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-hudi] zhedoubushishi commented on a change in pull request #1036: [HUDI-353] Add hive style partitioning path

2019-12-03 Thread GitBox 
zhedoubushishi commented on a change in pull request #1036: [HUDI-353] Add hive 
style partitioning path
URL: https://github.com/apache/incubator-hudi/pull/1036#discussion_r353510140
 
 

 ##
 File path: hudi-hive/src/main/java/org/apache/hudi/hive/HiveSyncTool.java
 ##
 @@ -163,6 +163,11 @@ private void syncSchema(boolean tableExists, boolean 
isRealTime, MessageType sch
*/
   private void syncPartitions(List writtenPartitionsSince) {
 try {
+  if (cfg.useHiveStylePartitioning) {
+LOG.info("Sync partitions through MSCK Repair");
+hoodieHiveClient.syncPartitionsByMSCK();
 
 Review comment:
   I see. Then it seems we should not use "MSCK" here.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services