[jira] [Comment Edited] (HUDI-233) Redo log statements using SLF4J
[
https://issues.apache.org/jira/browse/HUDI-233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16994668#comment-16994668
]
lamber-ken edited comment on HUDI-233 at 12/12/19 1:50 PM:
---
Hi, [~xleesf] [~vinoth], I think we can use `maven-shade-plugin` to relocate
the slf4j and log4j, if so, it will work well with other framework. :D
For example
{code:java}
org.apache.maven.plugins
maven-shade-plugin
3.2.0
false
package
shade
org.apache.log4j
org.apache.hudi.shade.log.log4j
org.slf4j
org.apache.hudi.shade.log.slf4j
{code}
was (Author: lamber-ken):
Hi, [~xleesf] [~vinoth], I think we can use `maven-shade-plugin` to relocate
the slf4j and log4j, if so, it will work well with other framework. :D
For example
{code:java}
org.apache.maven.plugins
maven-shade-plugin
3.2.0
package
shade
org.apache.log4j
org.apache.hudi.shade.log.log4j
org.slf4j
org.apache.hudi.shade.log.slf4j
{code}
> Redo log statements using SLF4J
>
>
> Key: HUDI-233
> URL: https://issues.apache.org/jira/browse/HUDI-233
> Project: Apache Hudi (incubating)
> Issue Type: Bug
> Components: newbie
>Affects Versions: 0.5.0
>Reporter: Vinoth Chandar
>Assignee: leesf
>Priority: Major
>
> Currently we are not employing variable substitution aggresively in the
> project. ala
> {code:java}
> LogManager.getLogger(SomeName.class.getName()).info("Message: {}, Detail:
> {}", message, detail);
> {code}
> This can improve performance since the string concatenation is deferrable to
> when the logging is actually in effect.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (HUDI-233) Redo log statements using SLF4J
[
https://issues.apache.org/jira/browse/HUDI-233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16994668#comment-16994668
]
lamber-ken edited comment on HUDI-233 at 12/12/19 1:35 PM:
---
Hi, [~xleesf] [~vinoth], I think we can use `maven-shade-plugin` to relocate
the slf4j and log4j, if so, it will work well with other framework. :D
For example
{code:java}
org.apache.maven.plugins
maven-shade-plugin
3.2.0
package
shade
org.apache.log4j
org.apache.hudi.shade.log.log4j
org.slf4j
org.apache.hudi.shade.log.slf4j
{code}
was (Author: lamber-ken):
Hi, [~xleesf] [~vinoth], I think we can use `maven-shade-plugin` to relocate
the slf4j and log4j, if so, it will work well with other framework. :D
For example
{code:java}
org.apache.maven.plugins
maven-shade-plugin
3.2.0
package
shade
org.apache.log4j
org.apache.hudi.shade.log.log4j
org.slf4j
org.apache.hudi.shade.log.slf4j
{code}
> Redo log statements using SLF4J
>
>
> Key: HUDI-233
> URL: https://issues.apache.org/jira/browse/HUDI-233
> Project: Apache Hudi (incubating)
> Issue Type: Bug
> Components: newbie
>Affects Versions: 0.5.0
>Reporter: Vinoth Chandar
>Assignee: leesf
>Priority: Major
>
> Currently we are not employing variable substitution aggresively in the
> project. ala
> {code:java}
> LogManager.getLogger(SomeName.class.getName()).info("Message: {}, Detail:
> {}", message, detail);
> {code}
> This can improve performance since the string concatenation is deferrable to
> when the logging is actually in effect.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (HUDI-233) Redo log statements using SLF4J
[
https://issues.apache.org/jira/browse/HUDI-233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16958408#comment-16958408
]
leesf edited comment on HUDI-233 at 10/23/19 11:51 PM:
---
[~shivnarayan] Thanks for your interests. You could take some tickets once we
could be start the progress.
Also https://jira.apache.org/jira/projects/HUDI/issues/HUDI-302 is a startup if
you are interest.
was (Author: xleesf):
[~shivnarayan] Thanks for your interests. You could pick some tickets once we
could be start the progress.
Also https://jira.apache.org/jira/projects/HUDI/issues/HUDI-302 is a startup if
you are interest.
> Redo log statements using SLF4J
>
>
> Key: HUDI-233
> URL: https://issues.apache.org/jira/browse/HUDI-233
> Project: Apache Hudi (incubating)
> Issue Type: Bug
> Components: newbie, Performance
>Affects Versions: 0.5.0
>Reporter: Vinoth Chandar
>Assignee: leesf
>Priority: Major
>
> Currently we are not employing variable substitution aggresively in the
> project. ala
> {code:java}
> LogManager.getLogger(SomeName.class.getName()).info("Message: {}, Detail:
> {}", message, detail);
> {code}
> This can improve performance since the string concatenation is deferrable to
> when the logging is actually in effect.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
