(ignite-3) branch ignite-21964 updated (b2a84b869f -> 57af0a85f3)
This is an automated email from the ASF dual-hosted git repository. amashenkov pushed a change to branch ignite-21964 in repository https://gitbox.apache.org/repos/asf/ignite-3.git from b2a84b869f minor add 57af0a85f3 Styles. No new revisions were added by this update. Summary of changes: .../api/src/main/java/org/apache/ignite/lang/util/IgniteNameUtils.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
(ignite-3) branch ignite-21964 updated (036f88e74a -> b2a84b869f)
This is an automated email from the ASF dual-hosted git repository. amashenkov pushed a change to branch ignite-21964 in repository https://gitbox.apache.org/repos/asf/ignite-3.git from 036f88e74a Fix simple name parsing. add b2a84b869f minor No new revisions were added by this update. Summary of changes: .../main/java/org/apache/ignite/lang/util/IgniteNameUtils.java | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-)
(ignite-3) branch ignite-21964 updated (b6421e9c62 -> 036f88e74a)
This is an automated email from the ASF dual-hosted git repository. amashenkov pushed a change to branch ignite-21964 in repository https://gitbox.apache.org/repos/asf/ignite-3.git omit b6421e9c62 wip. add a7ad5b0cef IGNITE-22445 Fix flaky ItCatalogDslTest (#3897) add 00f5f69550 IGNITE-21969 Extend test coverage for SQL F031-04(Basic schema manipulation. ALTER TABLE statement: ADD COLUMN clause) (#3859) add 6351e34c5b IGNITE-22393 Fix incorrect BinaryMode in FieldAccessor for column data (#3892) add 76d8bd0799 IGNITE-21966: Extend test coverage for SQL E091-01(Set functions. AVG) (#3898) add 596ef0b592 IGNITE-20650 Fix case-sensitive field names resolution (#3850) add 120935474c IGNITE-21957 Sql. Extend test coverage for SQL E021-10 (Character string types. Implicit casting among the character string types) (#3896) add e7e0cb9e4b wip. add 42918b9ddc Add tests. add 036f88e74a Fix simple name parsing. This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (b6421e9c62) \ N -- N -- N refs/heads/ignite-21964 (036f88e74a) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. No new revisions were added by this update. Summary of changes: .../apache/ignite/lang/util/IgniteNameUtils.java | 45 ++- .../main/java/org/apache/ignite/table/Tuple.java | 6 +- .../java/org/apache/ignite/table/TupleImpl.java| 2 +- .../org/apache/ignite/table/mapper/Mapper.java | 14 - .../org/apache/ignite/table/TupleImplTest.java | 58 +++ .../ignite/table/AbstractImmutableTupleTest.java | 378 ++ .../ignite/table/AbstractMutableTupleTest.java | 141 +++ .../ignite/internal/catalog/ItCatalogDslTest.java | 3 +- .../table/MutableTupleBinaryTupleAdapter.java | 3 +- .../handler/requests/table/ClientHandlerTuple.java | 3 +- modules/client/build.gradle| 1 + .../org/apache/ignite/client/ClientTupleTest.java | 314 +-- .../ignite/internal/util/IgniteNameUtilsTest.java | 8 +- .../ignite/internal/marshaller/FieldAccessor.java | 21 +- .../runner/app/PlatformTestNodeRunner.java | 2 +- .../internal/table/ItColumnNameMappingTest.java| 212 ++ .../internal/table/ItThinClientColocationTest.java | 2 +- .../schema/marshaller/KvMarshallerTest.java| 23 +- .../schema/marshaller/RecordMarshallerTest.java| 22 +- .../sql/engine/ItAlterTableAlterColumnTest.java| 2 + .../internal/sql/engine/ItAlterTableDdlTest.java | 234 +++ .../internal/sql/engine/ItCreateTableDdlTest.java | 185 ++--- .../sql/aggregate/aggregates/test_avg.test | 35 +- .../sql/aggregate/aggregates/test_avg.test_ignored | 54 --- .../sql/types/char/test_char_length.test | 5 + .../sql/types/char/test_implicit_cast.test | 136 +++ .../schema/marshaller/TupleMarshallerImpl.java | 3 +- .../internal/table/AbstractRowTupleAdapter.java| 5 +- .../org/apache/ignite/internal/table/TableRow.java | 5 +- .../table/ColocationHashCalculationTest.java | 12 +- .../internal/table/MutableRowTupleAdapterTest.java | 430 ++--- .../internal/table/SchemaValidationTest.java | 26 +- .../table/type/NumericTypesSerializerTest.java | 34 +- .../org/apache/ignite/table/TupleImplTest.java | 314 --- 34 files changed, 1595 insertions(+), 1143 deletions(-) create mode 100644 modules/api/src/test/java/org/apache/ignite/table/TupleImplTest.java create mode 100644 modules/api/src/testFixtures/java/org/apache/ignite/table/AbstractImmutableTupleTest.java create mode 100644 modules/api/src/testFixtures/java/org/apache/ignite/table/AbstractMutableTupleTest.java create mode 100644 modules/runner/src/integrationTest/java/org/apache/ignite/internal/table/ItColumnNameMappingTest.java create mode 100644 modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItAlterTableDdlTest.java delete mode 100644 modules/sql-engine/src/integrationTest/sql/aggregate/aggregates/test_avg.test_ignored create mode 100644 modules/sql-engine/src/integrationTest/sql/types/char/test_implicit_cast.test delete mode 100644 modules/table/src/test/java/org/apache/ignite/table/TupleImplTest.java
(ignite-3) branch main updated: IGNITE-21957 Sql. Extend test coverage for SQL E021-10 (Character string types. Implicit casting among the character string types) (#3896)
This is an automated email from the ASF dual-hosted git repository.
amashenkov pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/ignite-3.git
The following commit(s) were added to refs/heads/main by this push:
new 120935474c IGNITE-21957 Sql. Extend test coverage for SQL E021-10
(Character string types. Implicit casting among the character string types)
(#3896)
120935474c is described below
commit 120935474cc135c5c82318f9657c04de85401a39
Author: Evgeniy Stanilovskiy
AuthorDate: Tue Jun 11 11:26:53 2024 +0300
IGNITE-21957 Sql. Extend test coverage for SQL E021-10 (Character string
types. Implicit casting among the character string types) (#3896)
---
.../sql/types/char/test_char_length.test | 5 +
.../sql/types/char/test_implicit_cast.test | 136 +
2 files changed, 141 insertions(+)
diff --git
a/modules/sql-engine/src/integrationTest/sql/types/char/test_char_length.test
b/modules/sql-engine/src/integrationTest/sql/types/char/test_char_length.test
index 0f2d1969a1..1fc32b2dbc 100644
---
a/modules/sql-engine/src/integrationTest/sql/types/char/test_char_length.test
+++
b/modules/sql-engine/src/integrationTest/sql/types/char/test_char_length.test
@@ -41,3 +41,8 @@ query T
SELECT char_length('閭')
1
+
+query T
+SELECT length('a'::CHAR(10))
+
+10
diff --git
a/modules/sql-engine/src/integrationTest/sql/types/char/test_implicit_cast.test
b/modules/sql-engine/src/integrationTest/sql/types/char/test_implicit_cast.test
new file mode 100644
index 00..024def72e9
--- /dev/null
+++
b/modules/sql-engine/src/integrationTest/sql/types/char/test_implicit_cast.test
@@ -0,0 +1,136 @@
+# name: test/sql/types/char/test_implicit_cast.test
+# description: E021-10 Character string types. Implicit casting among the
character string types.
+# group: [char]
+
+query T
+SELECT 'a'::char > 'b'::varchar;
+
+false
+
+query T
+SELECT 'a'::char < 'b'::varchar;
+
+true
+
+query T
+SELECT 'a'::char = 'b'::varchar;
+
+false
+
+query T
+SELECT 'a'::char >= 'b'::varchar;
+
+false
+
+query T
+SELECT 'a'::char <= 'b'::varchar;
+
+true
+
+query T
+SELECT 'a'::char(1) > 'b'::varchar(2);
+
+false
+
+query T
+SELECT 'a'::char(1) < 'b'::varchar(2);
+
+true
+
+statement ok
+create table tprec(v varchar(10));
+
+statement ok
+insert into tprec values('b');
+
+query T
+SELECT * FROM tprec WHERE v > 'a'::char(1);
+
+b
+
+statement ok
+create table t(v varchar);
+
+statement ok
+insert into t values('b');
+
+query T
+SELECT * FROM t WHERE v > 'a'::char(1);
+
+b
+
+statement ok
+create table tiny(v TINYINT);
+
+statement ok
+insert into tiny values('127');
+
+skipif ignite3
+# https://issues.apache.org/jira/browse/IGNITE-22444
+#Values of either the CHARACTER or CHARACTER VARYING data type can be assigned
to the other type, subject to truncation conditions
+query T
+SELECT * FROM tiny WHERE v = '300';
+
+
+skipif ignite3
+# https://issues.apache.org/jira/browse/IGNITE-22444
+#Values of either the CHARACTER or CHARACTER VARYING data type can be assigned
to the other type, subject to truncation conditions
+query T
+SELECT * FROM tiny WHERE v < '300';
+
+127
+
+query T
+SELECT length('a'::CHAR(10) || 'abc'::VARCHAR(10));
+
+13
+
+# ASSIGNMENT
+
+statement ok
+CREATE TABLE chars(c5 VARCHAR(5), c10 VARCHAR(10), c15 VARCHAR(15));
+
+# Preserve trailing whitespace
+statement ok
+INSERT INTO chars (c5) VALUES('a'::CHAR(5));
+
+query T
+SELECT length(c5) FROM chars;
+
+5
+
+statement ok
+UPDATE chars SET c10 = c5, c15 = c5
+
+query TTT
+SELECT length(c5), length(c10), length(c15) FROM chars;
+
+5 5 5
+
+
+statement ok
+INSERT INTO chars VALUES(repeat('b', 5), repeat('b', 10), repeat('b', 15));
+
+# Trailing whitespace is ignored
+statement ok
+UPDATE chars SET c5=c5::CHAR(10), c10 = c10::CHAR(15), c15 = c15::CHAR(20)
+
+query TTT
+SELECT length(c5), length(c10), length(c15) FROM chars WHERE c5 = 'b';
+
+5 10 15
+
+statement ok
+CREATE TABLE tmp (c5 VARCHAR(5), c10 VARCHAR(10));
+
+statement ok
+INSERT INTO tmp (c5) VALUES('a'::CHAR(5));
+
+statement ok
+INSERT INTO tmp (c5) VALUES('a'::CHAR(3));
+
+# https://issues.apache.org/jira/browse/IGNITE-22451
+# Error: Row has not been fully built. Index: 2, fields: 3
+skipif ignite3
+statement ok
+UPDATE tmp SET c5=c5::CHAR(6)
(ignite-3) branch ignite-20650 deleted (was 190485836e)
This is an automated email from the ASF dual-hosted git repository. amashenkov pushed a change to branch ignite-20650 in repository https://gitbox.apache.org/repos/asf/ignite-3.git was 190485836e wip. The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
(ignite-3) branch main updated (76d8bd0799 -> 596ef0b592)
This is an automated email from the ASF dual-hosted git repository. amashenkov pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/ignite-3.git from 76d8bd0799 IGNITE-21966: Extend test coverage for SQL E091-01(Set functions. AVG) (#3898) add 596ef0b592 IGNITE-20650 Fix case-sensitive field names resolution (#3850) No new revisions were added by this update. Summary of changes: .../main/java/org/apache/ignite/table/Tuple.java | 6 +- .../java/org/apache/ignite/table/TupleImpl.java| 2 +- .../org/apache/ignite/table/TupleImplTest.java | 58 +++ .../ignite/table/AbstractImmutableTupleTest.java | 378 ++ .../ignite/table/AbstractMutableTupleTest.java | 141 +++ .../table/MutableTupleBinaryTupleAdapter.java | 3 +- .../handler/requests/table/ClientHandlerTuple.java | 3 +- modules/client/build.gradle| 1 + .../org/apache/ignite/client/ClientTupleTest.java | 314 +-- .../runner/app/PlatformTestNodeRunner.java | 2 +- .../internal/table/ItColumnNameMappingTest.java| 212 ++ .../internal/table/ItThinClientColocationTest.java | 2 +- .../schema/marshaller/TupleMarshallerImpl.java | 3 +- .../internal/table/AbstractRowTupleAdapter.java| 5 +- .../org/apache/ignite/internal/table/TableRow.java | 5 +- .../table/ColocationHashCalculationTest.java | 12 +- .../internal/table/MutableRowTupleAdapterTest.java | 430 ++--- .../internal/table/SchemaValidationTest.java | 26 +- .../table/type/NumericTypesSerializerTest.java | 34 +- .../org/apache/ignite/table/TupleImplTest.java | 314 --- 20 files changed, 1055 insertions(+), 896 deletions(-) create mode 100644 modules/api/src/test/java/org/apache/ignite/table/TupleImplTest.java create mode 100644 modules/api/src/testFixtures/java/org/apache/ignite/table/AbstractImmutableTupleTest.java create mode 100644 modules/api/src/testFixtures/java/org/apache/ignite/table/AbstractMutableTupleTest.java create mode 100644 modules/runner/src/integrationTest/java/org/apache/ignite/internal/table/ItColumnNameMappingTest.java delete mode 100644 modules/table/src/test/java/org/apache/ignite/table/TupleImplTest.java
(ignite-3) branch ignite-21969 deleted (was bf249c04f4)
This is an automated email from the ASF dual-hosted git repository. amashenkov pushed a change to branch ignite-21969 in repository https://gitbox.apache.org/repos/asf/ignite-3.git was bf249c04f4 Minor after review. Styles. The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
(ignite-3) branch ignite-22393 deleted (was 277eaad5fa)
This is an automated email from the ASF dual-hosted git repository. amashenkov pushed a change to branch ignite-22393 in repository https://gitbox.apache.org/repos/asf/ignite-3.git was 277eaad5fa Drop non-implemented method from API. The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
(ignite-3) branch main updated: IGNITE-22393 Fix incorrect BinaryMode in FieldAccessor for column data (#3892)
This is an automated email from the ASF dual-hosted git repository.
amashenkov pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/ignite-3.git
The following commit(s) were added to refs/heads/main by this push:
new 6351e34c5b IGNITE-22393 Fix incorrect BinaryMode in FieldAccessor for
column data (#3892)
6351e34c5b is described below
commit 6351e34c5baa320c27187252cae90c50286894d7
Author: Andrew V. Mashenkov
AuthorDate: Mon Jun 10 15:20:27 2024 +0300
IGNITE-22393 Fix incorrect BinaryMode in FieldAccessor for column data
(#3892)
---
.../org/apache/ignite/table/mapper/Mapper.java | 14 -
.../ignite/internal/marshaller/FieldAccessor.java | 21 +++-
.../schema/marshaller/KvMarshallerTest.java| 23 +-
.../schema/marshaller/RecordMarshallerTest.java| 22 +
4 files changed, 52 insertions(+), 28 deletions(-)
diff --git
a/modules/api/src/main/java/org/apache/ignite/table/mapper/Mapper.java
b/modules/api/src/main/java/org/apache/ignite/table/mapper/Mapper.java
index 7ed141e7a1..64800ef068 100644
--- a/modules/api/src/main/java/org/apache/ignite/table/mapper/Mapper.java
+++ b/modules/api/src/main/java/org/apache/ignite/table/mapper/Mapper.java
@@ -24,8 +24,6 @@ import java.time.LocalTime;
import java.util.BitSet;
import java.util.Objects;
import java.util.UUID;
-import java.util.function.Function;
-import org.apache.ignite.table.Tuple;
/**
* Mapper interface defines marshaller methods for mapping class field names
to table columns.
@@ -116,18 +114,6 @@ public interface Mapper {
return builder(type).map(Objects.requireNonNull(fieldName),
Objects.requireNonNull(columnName), fieldColumnPairs).build();
}
-/**
- * Adds a manual functional mapping for an object and a row represented by
a tuple.
- *
- * @param objectToRow Object to tuple function.
- * @param rowToObject Tuple to object function.
- * @return {@code this} for chaining.
- */
-static Mapper of(Function objectToRow, Function
rowToObject) {
-// TODO: implement custom user mapping
https://issues.apache.org/jira/browse/IGNITE-16116
-throw new UnsupportedOperationException("Not implemented yet.");
-}
-
/**
* Creates a mapper builder for objects of a given class.
*
diff --git
a/modules/marshaller-common/src/main/java/org/apache/ignite/internal/marshaller/FieldAccessor.java
b/modules/marshaller-common/src/main/java/org/apache/ignite/internal/marshaller/FieldAccessor.java
index 8340ac4be1..bec0e86ccf 100644
---
a/modules/marshaller-common/src/main/java/org/apache/ignite/internal/marshaller/FieldAccessor.java
+++
b/modules/marshaller-common/src/main/java/org/apache/ignite/internal/marshaller/FieldAccessor.java
@@ -76,14 +76,14 @@ abstract class FieldAccessor {
validateColumnType(col, field.getType());
}
-BinaryMode mode = BinaryMode.forClass(field.getType());
+BinaryMode fieldAccessMode = BinaryMode.forClass(field.getType());
MethodHandles.Lookup lookup = MethodHandles.privateLookupIn(type,
MethodHandles.lookup());
VarHandle varHandle = lookup.unreflectVarHandle(field);
-assert mode != null : "Invalid mode for type: " + field.getType();
+assert fieldAccessMode != null : "Invalid fieldAccessMode for
type: " + field.getType();
-switch (mode) {
+switch (fieldAccessMode) {
case P_BOOLEAN:
return new BooleanPrimitiveAccessor(varHandle, colIdx);
@@ -123,10 +123,10 @@ abstract class FieldAccessor {
case DATETIME:
case TIMESTAMP:
case POJO:
-return new ReferenceFieldAccessor(varHandle, colIdx, mode,
col.scale(), typeConverter);
+return new ReferenceFieldAccessor(varHandle, colIdx,
col.type(), col.scale(), typeConverter);
default:
-assert false : "Invalid mode " + mode;
+assert false : "Invalid field access mode " +
fieldAccessMode;
}
throw new IllegalArgumentException("Failed to create accessor for
field [name=" + field.getName() + ']');
@@ -820,5 +820,16 @@ abstract class FieldAccessor {
throw new IllegalArgumentException(e);
}
}
+
+@Override
+Object value(Object obj) {
+Object value = get(Objects.requireNonNull(obj));
+
+try {
+return typeConverter == null ? value :
typeConverter.toColumnType(value);
+} catch (Exception e) {
+throw new IllegalArgumentException(e);
+}
+}
}
}
diff --git
a/modules/schema/src/test/java/org/apache/ignite/internal/schema/marshaller/KvMarshallerTest.java
(ignite-3) branch main updated: IGNITE-21969 Extend test coverage for SQL F031-04(Basic schema manipulation. ALTER TABLE statement: ADD COLUMN clause) (#3859)
This is an automated email from the ASF dual-hosted git repository.
amashenkov pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/ignite-3.git
The following commit(s) were added to refs/heads/main by this push:
new 00f5f69550 IGNITE-21969 Extend test coverage for SQL F031-04(Basic
schema manipulation. ALTER TABLE statement: ADD COLUMN clause) (#3859)
00f5f69550 is described below
commit 00f5f69550dc4ba75be02db4580313c99519535b
Author: Andrew V. Mashenkov
AuthorDate: Mon Jun 10 15:19:40 2024 +0300
IGNITE-21969 Extend test coverage for SQL F031-04(Basic schema
manipulation. ALTER TABLE statement: ADD COLUMN clause) (#3859)
---
.../sql/engine/ItAlterTableAlterColumnTest.java| 2 +
.../internal/sql/engine/ItAlterTableDdlTest.java | 234 +
.../internal/sql/engine/ItCreateTableDdlTest.java | 154 +-
3 files changed, 238 insertions(+), 152 deletions(-)
diff --git
a/modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItAlterTableAlterColumnTest.java
b/modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItAlterTableAlterColumnTest.java
index 6f5c68f58a..da6945e69b 100644
---
a/modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItAlterTableAlterColumnTest.java
+++
b/modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItAlterTableAlterColumnTest.java
@@ -46,6 +46,8 @@ import org.junit.jupiter.params.provider.MethodSource;
/**
* Integration test for ALTER TABLE ALTER COLUMN command.
+ *
+ * SQL F381 feature. Extended schema manipulation.
*/
public class ItAlterTableAlterColumnTest extends BaseSqlIntegrationTest {
@AfterEach
diff --git
a/modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItAlterTableDdlTest.java
b/modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItAlterTableDdlTest.java
new file mode 100644
index 00..903e135eb2
--- /dev/null
+++
b/modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItAlterTableDdlTest.java
@@ -0,0 +1,234 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.sql.engine;
+
+import static org.apache.ignite.internal.lang.IgniteStringFormatter.format;
+import static
org.apache.ignite.internal.sql.engine.util.SqlTestUtils.assertThrowsSqlException;
+import static org.apache.ignite.lang.ErrorGroups.Sql.STMT_PARSE_ERR;
+import static org.hamcrest.MatcherAssert.assertThat;
+import static org.hamcrest.Matchers.is;
+
+import java.time.LocalDate;
+import java.time.LocalDateTime;
+import java.time.LocalTime;
+import java.time.Month;
+import java.util.List;
+import java.util.Set;
+import org.apache.calcite.rel.type.RelDataType;
+import org.apache.ignite.internal.lang.IgniteStringBuilder;
+import org.apache.ignite.internal.schema.SchemaTestUtils;
+import org.apache.ignite.internal.sql.BaseSqlIntegrationTest;
+import org.apache.ignite.internal.sql.engine.util.Commons;
+import org.apache.ignite.internal.sql.engine.util.TypeUtils;
+import org.apache.ignite.internal.type.NativeType;
+import org.apache.ignite.internal.type.NativeTypeSpec;
+import org.junit.jupiter.api.AfterEach;
+import org.junit.jupiter.api.Test;
+
+/**
+ * Integration tests for ALTER TABLE DDL statements.
+ *
+ * SQL F031-04 feature. ALTER TABLE statement: ADD COLUMN clause
+ * SQL F033 feature. ALTER TABLE statement: DROP COLUMN clause
+ */
+public class ItAlterTableDdlTest extends BaseSqlIntegrationTest {
+@AfterEach
+public void dropTables() {
+dropAllTables();
+dropAllZonesExceptDefaultOne();
+}
+
+/** Test correct mapping schema after alter columns. */
+@Test
+public void testDropAndAddColumns() {
+sql("CREATE TABLE my (c1 INT PRIMARY KEY, c2 INT, c3 VARCHAR)");
+
+sql("INSERT INTO my VALUES (11, 2, '3')");
+assertQuery("SELECT * FROM my")
+.returns(11, 2, "3")
+.check();
+
+// Drop column. Table columns: c1, c3
+sql("ALTER
(ignite-3) branch ignite-20650 updated (8c58e407af -> 190485836e)
This is an automated email from the ASF dual-hosted git repository. amashenkov pushed a change to branch ignite-20650 in repository https://gitbox.apache.org/repos/asf/ignite-3.git from 8c58e407af Minor after review. add 190485836e wip. No new revisions were added by this update. Summary of changes: modules/api/src/main/java/org/apache/ignite/table/Tuple.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
(ignite-3) branch ignite-21964 updated (556811a124 -> b6421e9c62)
This is an automated email from the ASF dual-hosted git repository. amashenkov pushed a change to branch ignite-21964 in repository https://gitbox.apache.org/repos/asf/ignite-3.git omit 556811a124 wip. add 5e2f1c24ae IGNITE-21868 Moved the sql RO inflights handling from SqlQueryProcessor to QueryTransactionContext and QueryTransactionWrapper (#3511) add b3dad674a1 IGNITE-22384 Replace Conan package manager with direct dependency management using cmake (#3851) add 9823caf461 IGNITE-22244 Do not format configuration string (#3893) add 58bbc95677 Bump org.jctools:jctools-core from 4.0.3 to 4.0.5 (#3882) add 310ea0585e Bump com.google.guava:guava from 33.2.0-jre to 33.2.1-jre (#3889) add 129d918e9a IGNITE-20450 Add failure processor and failure handlers configuration. (#3862) add d21d91f0f4 Bump org.rocksdb:rocksdbjni from 9.1.1 to 9.2.1 (#3890) add b6421e9c62 wip. This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (556811a124) \ N -- N -- N refs/heads/ignite-21964 (b6421e9c62) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. No new revisions were added by this update. Summary of changes: gradle/libs.versions.toml |6 +- .../repl/executor/ItIgnitePicocliCommandsTest.java |3 +- .../apache/ignite/internal/cli/CliVersionInfo.java |2 +- .../internal/cli/core/style/AnsiStringSupport.java |4 +- .../cli/decorators/ClusterStatusDecorator.java | 21 +- .../cli/decorators/NodeStatusDecorator.java|9 +- .../highlighter/JsonAnsiHighlighterTest.java} | 33 +- modules/cluster-management/build.gradle|1 + .../internal/cluster/management/MockNode.java |3 +- modules/failure-handler/build.gradle |5 + .../ignite/internal/failure/FailureProcessor.java | 84 +- .../ignite/internal/failure/FailureType.java | 29 +- .../FailureProcessorConfigurationModule.java} | 28 +- .../FailureProcessorConfigurationSchema.java} | 12 +- .../failure/configuration}/package-info.java |5 +- .../failure/handlers/AbstractFailureHandler.java |1 + .../internal/failure/handlers/FailureHandler.java |7 + .../handlers/StopNodeOrHaltFailureHandler.java | 11 + .../FailureHandlerConfigurationSchema.java}| 28 +- .../configuration/IgnoredFailureTypes.java}|6 +- .../IgnoredFailureTypesValidator.java} | 37 +- .../NoOpFailureHandlerConfigurationSchema.java}| 12 +- ...StopNodeFailureHandlerConfigurationSchema.java} | 12 +- ...deOrHaltFailureHandlerConfigurationSchema.java} | 32 +- .../handlers/configuration}/package-info.java |5 +- .../internal/failure/handlers}/package-info.java |5 +- .../ignite/internal/failure}/package-info.java |5 +- .../ItMetaStorageMultipleNodesAbstractTest.java|3 +- .../metastorage/impl/ItMetaStorageWatchTest.java |2 +- modules/platforms/cpp/CMakeLists.txt | 48 +- modules/platforms/cpp/DEVNOTES.md | 56 +- modules/platforms/cpp/cmake/conan.cmake| 1026 modules/platforms/cpp/cmake/dependencies.cmake | 50 + modules/platforms/cpp/cmake/ignite_test.cmake | 31 +- modules/platforms/cpp/ignite/client/CMakeLists.txt |2 +- modules/platforms/cpp/ignite/common/CMakeLists.txt | 12 +- modules/platforms/cpp/ignite/odbc/CMakeLists.txt |8 +- .../platforms/cpp/ignite/protocol/CMakeLists.txt |4 +- modules/platforms/cpp/ignite/tuple/CMakeLists.txt |2 +- .../platforms/cpp/tests/client-test/CMakeLists.txt |6 +- .../platforms/cpp/tests/odbc-test/CMakeLists.txt |8 +- .../ItDistributedConfigurationPropertiesTest.java |3 +- .../ItDistributedConfigurationStorageTest.java |3 +- .../runner/app/ItIgniteNodeRestartTest.java|3 +- .../org/apache/ignite/internal/app/IgniteImpl.java |4 +- .../ignite/internal/sql/engine/ItDmlTest.java |6 +- .../internal/sql/engine/SqlQueryProcessor.java | 12 +- .../sql/engine/tx/QueryTransactionContextImpl.java | 30 +- .../sql/engine/tx/QueryTransactionWrapperImpl.java | 20 +- .../sql/engine/tx/ScriptTransactionContext.java|8 +- .../engine/tx/ScriptTransactionWrapperImpl.java| 13 +- .../engine/QueryTransactionWrapperSelfTest.java| 128 ++- .../sql/engine/exec/TxAwareCursorSelf
(ignite-3) branch ignite-21964 created (now 556811a124)
This is an automated email from the ASF dual-hosted git repository. amashenkov pushed a change to branch ignite-21964 in repository https://gitbox.apache.org/repos/asf/ignite-3.git at 556811a124 wip. This branch includes the following new commits: new 556811a124 wip. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
(ignite-3) 01/01: wip.
This is an automated email from the ASF dual-hosted git repository.
amashenkov pushed a commit to branch ignite-21964
in repository https://gitbox.apache.org/repos/asf/ignite-3.git
commit 556811a124bfceed8466b8137ac5a418739481d1
Author: amashenkov
AuthorDate: Mon Jun 10 14:43:59 2024 +0300
wip.
---
.../identifiers/test_delimited_identifiers.test| 173 +
1 file changed, 173 insertions(+)
diff --git
a/modules/sql-engine/src/integrationTest/sql/identifiers/test_delimited_identifiers.test
b/modules/sql-engine/src/integrationTest/sql/identifiers/test_delimited_identifiers.test
new file mode 100644
index 00..1811d7262d
--- /dev/null
+++
b/modules/sql-engine/src/integrationTest/sql/identifiers/test_delimited_identifiers.test
@@ -0,0 +1,173 @@
+# name: sql/identifiers/test_identifiers_trailing_underscore.test
+# description: SQL feature E031-01 (Identifiers. Delimited identifiers)
+# group: [identifiers]
+
+statement ok
+PRAGMA enable_verification
+
+statement ok
+CREATE TABLE "Table_Test" ("col_Id" INTEGER, "col_Val" INTEGER, PRIMARY KEY
("col_Id"))
+
+statement ok
+CREATE TABLE "Table Test" ("col Id" INTEGER, "col Val" INTEGER, PRIMARY KEY
("col Id"))
+
+statement ok
+CREATE TABLE "Table""Test""" ("col""Id""" INTEGER, "col""Val""" INTEGER,
PRIMARY KEY ("col""Id"""))
+
+
+
+statement error
+ALTER TABLE Table_Test ADD COLUMN (col1 INTEGER)
+
+statement error
+ALTER TABLE TableTest ADD COLUMN (col1 INTEGER)
+
+statement ok
+ALTER TABLE "Table_Test" ADD COLUMN ("Col_1" INTEGER)
+
+statement ok
+ALTER TABLE "Table Test" ADD COLUMN ("Col 1" INTEGER)
+
+statement ok
+ALTER TABLE "Table""Test""" ADD COLUMN ("Col""1""" INTEGER)
+
+
+
+statement ok
+INSERT INTO "Table_Test" VALUES (1, 1, 1)
+
+statement ok
+INSERT INTO "Table Test" VALUES (2, 2, 2)
+
+statement ok
+INSERT INTO "Table""Test""" VALUES (3, 3, 3)
+
+
+query II
+SELECT "col_Val", "Col_1" FROM "Table_Test"
+
+1 1
+
+query II
+SELECT "col Val", "Col 1" FROM "Table Test"
+
+2 2
+
+query II
+SELECT "col""Val""", "Col""1""" FROM "Table""Test"""
+
+3 3
+
+statement error: Object 'TABLE_TEST' not found
+SELECT "col_Val" FROM Table_Test
+
+statement error: Object 'TableTest' not found
+SELECT "col""Val""" FROM "TableTest"
+
+statement error: Column 'COL_VAL' not found
+SELECT col_Val FROM "Table_Test"
+
+statement error: Column 'colVal' not found
+SELECT "colVal" FROM "Table""Test"""
+
+
+
+statement ok
+CREATE INDEX "Index_Test" on "Table_Test" ("Col_1")
+
+statement ok
+CREATE INDEX "Index Test" on "Table Test" ("Col 1")
+
+statement ok
+CREATE INDEX "Index""Test""" on "Table""Test""" ("Col""1""")
+
+
+statement error: Index with name 'PUBLIC.INDEX_TEST' not found
+DROP INDEX Index_Test
+
+statement error: Index with name 'PUBLIC.IndexTest' not found
+DROP INDEX "IndexTest"
+
+statement ok
+DROP INDEX "Index_Test"
+
+statement ok
+DROP INDEX "Index Test"
+
+statement ok
+DROP INDEX "Index""Test"""
+
+
+
+statement error: Table with name 'PUBLIC.TABLE_TEST' not found
+DROP TABLE Table_Test;
+
+statement error: Table with name 'PUBLIC.TableTest' not found
+DROP TABLE "TableTest";
+
+statement ok
+DROP TABLE "Table_Test";
+
+statement ok
+DROP TABLE "Table Test";
+
+statement ok
+DROP TABLE "Table""Test""";
+
+
+
+statement ok
+CREATE ZONE "zone_Test" WITH STORAGE_PROFILES='default', PARTITIONS=1,
REPLICAS=3
+
+statement ok
+ALTER ZONE "zone_Test" SET REPLICAS = 4
+
+statement ok
+ALTER ZONE "zone_Test" RENAME TO "zone Test"
+
+statement error: Distribution zone with name 'zone_Test' not found
+ALTER ZONE "zone_Test" SET REPLICAS = 3
+
+statement error: Distribution zone with name 'zone_Test' not found
+DROP ZONE "zone_Test"
+
+statement ok
+DROP ZONE "zone Test"
+
+
+statement ok
+CREATE ZONE "zone Test" WITH STORAGE_PROFILES='default', PARTITIONS=1,
REPLICAS=3
+
+statement ok
+ALTER ZONE "zone Test" SET REPLICAS = 4
+
+statement ok
+ALTER ZONE "zone Test" RENAME TO "zone""Test"""
+
+statement error: Distribution zone with name 'zone Test' not found
+ALTER ZONE "zone Test" SET REPLICAS = 3
+
+statement error: Distribution zone with name 'zone Test' not found
+DROP ZONE "zone Test"
+
+statement ok
+DROP ZONE "zone""Test"""
+
+
+statement ok
+CREATE ZONE "zone""Test""" WITH STORAGE_PROFILES='default', PARTITIONS=1,
REPLICAS=3
+
+statement ok
+ALTER ZONE "zone""Test""" SET REPLICAS = 4
+
+statement ok
+ALTER ZONE "zone""Test""" RENAME TO "zone_Test"
+
+statement error: Distribution zone with name 'zone"Test"' not found
+ALTER ZONE "zone""Test""" SET REPLICAS = 3
+
+statement error: Distribution zone with name 'zone"Test"' not found
+DROP ZONE "zone""Test"""
+
+statement ok
+DROP ZONE "zone_Test"
(ignite-3) branch ignite-20650 updated (9355d7d6e8 -> 2b084d165b)
This is an automated email from the ASF dual-hosted git repository. amashenkov pushed a change to branch ignite-20650 in repository https://gitbox.apache.org/repos/asf/ignite-3.git from 9355d7d6e8 Fix tests add 2b084d165b Minor after review. No new revisions were added by this update. Summary of changes: modules/api/src/main/java/org/apache/ignite/table/Tuple.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
(ignite-3) branch ignite-20650 updated (2b084d165b -> 8c58e407af)
This is an automated email from the ASF dual-hosted git repository. amashenkov pushed a change to branch ignite-20650 in repository https://gitbox.apache.org/repos/asf/ignite-3.git from 2b084d165b Minor after review. add 8c58e407af Minor after review. No new revisions were added by this update. Summary of changes: .../apache/ignite/internal/schema/marshaller/TupleMarshallerImpl.java| 1 - 1 file changed, 1 deletion(-)
(ignite-3) branch ignite-22393 updated (8676a96304 -> 277eaad5fa)
This is an automated email from the ASF dual-hosted git repository. amashenkov pushed a change to branch ignite-22393 in repository https://gitbox.apache.org/repos/asf/ignite-3.git from 8676a96304 wip add 277eaad5fa Drop non-implemented method from API. No new revisions were added by this update. Summary of changes: .../main/java/org/apache/ignite/table/mapper/Mapper.java | 14 -- 1 file changed, 14 deletions(-)
(ignite-3) branch ignite-22393 updated (fa378ea4fb -> 8676a96304)
This is an automated email from the ASF dual-hosted git repository. amashenkov pushed a change to branch ignite-22393 in repository https://gitbox.apache.org/repos/asf/ignite-3.git from fa378ea4fb wip add 8676a96304 wip No new revisions were added by this update. Summary of changes: .../ignite/internal/marshaller/FieldAccessor.java | 11 ++ .../apache/ignite/internal/table/ItMapperTest.java | 138 - .../schema/marshaller/KvMarshallerTest.java| 23 +++- .../schema/marshaller/RecordMarshallerTest.java| 22 +++- 4 files changed, 47 insertions(+), 147 deletions(-) delete mode 100644 modules/runner/src/integrationTest/java/org/apache/ignite/internal/table/ItMapperTest.java
(ignite-3) branch ignite-22393 created (now fa378ea4fb)
This is an automated email from the ASF dual-hosted git repository. amashenkov pushed a change to branch ignite-22393 in repository https://gitbox.apache.org/repos/asf/ignite-3.git at fa378ea4fb wip This branch includes the following new commits: new fa378ea4fb wip The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
(ignite-3) 01/01: wip
This is an automated email from the ASF dual-hosted git repository.
amashenkov pushed a commit to branch ignite-22393
in repository https://gitbox.apache.org/repos/asf/ignite-3.git
commit fa378ea4fb1380de60d083e6ddc6537482c62fdd
Author: amashenkov
AuthorDate: Fri Jun 7 14:06:49 2024 +0300
wip
---
.../ignite/internal/marshaller/FieldAccessor.java | 10 +-
.../apache/ignite/internal/table/ItMapperTest.java | 138 +
2 files changed, 143 insertions(+), 5 deletions(-)
diff --git
a/modules/marshaller-common/src/main/java/org/apache/ignite/internal/marshaller/FieldAccessor.java
b/modules/marshaller-common/src/main/java/org/apache/ignite/internal/marshaller/FieldAccessor.java
index 8340ac4be1..75aee3f679 100644
---
a/modules/marshaller-common/src/main/java/org/apache/ignite/internal/marshaller/FieldAccessor.java
+++
b/modules/marshaller-common/src/main/java/org/apache/ignite/internal/marshaller/FieldAccessor.java
@@ -76,14 +76,14 @@ abstract class FieldAccessor {
validateColumnType(col, field.getType());
}
-BinaryMode mode = BinaryMode.forClass(field.getType());
+BinaryMode fieldAccessMode = BinaryMode.forClass(field.getType());
MethodHandles.Lookup lookup = MethodHandles.privateLookupIn(type,
MethodHandles.lookup());
VarHandle varHandle = lookup.unreflectVarHandle(field);
-assert mode != null : "Invalid mode for type: " + field.getType();
+assert fieldAccessMode != null : "Invalid fieldAccessMode for
type: " + field.getType();
-switch (mode) {
+switch (fieldAccessMode) {
case P_BOOLEAN:
return new BooleanPrimitiveAccessor(varHandle, colIdx);
@@ -123,10 +123,10 @@ abstract class FieldAccessor {
case DATETIME:
case TIMESTAMP:
case POJO:
-return new ReferenceFieldAccessor(varHandle, colIdx, mode,
col.scale(), typeConverter);
+return new ReferenceFieldAccessor(varHandle, colIdx,
col.type(), col.scale(), typeConverter);
default:
-assert false : "Invalid mode " + mode;
+assert false : "Invalid field access mode " +
fieldAccessMode;
}
throw new IllegalArgumentException("Failed to create accessor for
field [name=" + field.getName() + ']');
diff --git
a/modules/runner/src/integrationTest/java/org/apache/ignite/internal/table/ItMapperTest.java
b/modules/runner/src/integrationTest/java/org/apache/ignite/internal/table/ItMapperTest.java
new file mode 100644
index 00..42e0caf6de
--- /dev/null
+++
b/modules/runner/src/integrationTest/java/org/apache/ignite/internal/table/ItMapperTest.java
@@ -0,0 +1,138 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.table;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+import java.time.Instant;
+import java.time.LocalDate;
+import java.time.ZoneOffset;
+import java.util.Date;
+import java.util.Objects;
+import org.apache.ignite.catalog.ColumnType;
+import org.apache.ignite.catalog.definitions.ColumnDefinition;
+import org.apache.ignite.catalog.definitions.TableDefinition;
+import org.apache.ignite.internal.ClusterPerClassIntegrationTest;
+import org.apache.ignite.internal.app.IgniteImpl;
+import org.apache.ignite.table.mapper.Mapper;
+import org.apache.ignite.table.mapper.TypeConverter;
+import org.junit.jupiter.api.Test;
+
+/**
+ * POJO mappers test.
+ */
+public class ItMapperTest extends ClusterPerClassIntegrationTest {
+@Test
+void valueWithTypeConverter() throws Exception {
+IgniteImpl node = CLUSTER.node(0);
+
+var tableDef = TableDefinition.builder("PrimTestTable")
+.columns(
+ColumnDefinition.column("ID", ColumnType.INT32),
+ColumnDefinition.column("VAL", ColumnType.DATE)
+)
+.primaryKey("ID")
+.build();
+
+node
(ignite-3) branch ignite-21969 updated (7e3440847c -> bf249c04f4)
This is an automated email from the ASF dual-hosted git repository. amashenkov pushed a change to branch ignite-21969 in repository https://gitbox.apache.org/repos/asf/ignite-3.git from 7e3440847c Merge branch 'main' into ignite-21969 add bf249c04f4 Minor after review. Styles. No new revisions were added by this update. Summary of changes: .../sql/engine/ItAlterTableAlterColumnTest.java| 4 +- .../internal/sql/engine/ItAlterTableDdlTest.java | 69 +- .../internal/sql/engine/ItCreateTableDdlTest.java | 4 +- 3 files changed, 44 insertions(+), 33 deletions(-)
(ignite-3) branch ignite-20650 updated (5df65bbdc1 -> 9355d7d6e8)
This is an automated email from the ASF dual-hosted git repository. amashenkov pushed a change to branch ignite-20650 in repository https://gitbox.apache.org/repos/asf/ignite-3.git discard 5df65bbdc1 Fix tests discard ae54303dbf Fix tests discard 7f3ea9c69f Minor discard 3931ba6ff1 Styles. discard 2825393896 Minor discard dbe4ad0aa3 Fix Tuple.columnName contract. discard c56d7a482b Add missed tests. discard 0c3db79b18 Move tests to appropriate modules. discard 38c58ebf5e Fix Tuple.columnName method contract. discard d45d04f6ea Tuple tests refactoring. add a7ea529288 IGNITE-22271 Rename copying overload of Tuple.create to copy (#3873) add 2bdd91f92d Bump org.assertj:assertj-core from 3.25.3 to 3.26.0 (#3839) add 49ab1b248a IGNITE-22284 .NET: Fix tests on macOS (#3875) add 26c1fb27bc IGNITE-22411 Fix CLI package (#3877) add 1469191211 IGNITE-22275 forbid to alter partitions number. (#3838) add 7b9e845b68 IGNITE-22207 Fix a deadlock in the ReplicaService (#3874) add 4be3f4f83d IGNITE-21975: Extend test coverage for SQL F302-01(INTERSECT table operator. INTERSECT DISTINCT table operator) (#3872) add a760caf4f1 IGNITE-21967: Extend test coverage for SQL E091-06 (Set functions. ALL quantifier) (#3876) add 8d42d57a7d Bump net.bytebuddy:byte-buddy from 1.14.15 to 1.14.17 (#3849) add c962e757f8 Bump com.google.code.gson:gson from 2.10.1 to 2.11.0 (#3794) add 73a2c77d15 IGNITE-22272 Rework Catalog API (#3863) add 78353de462 IGNITE-22107 Properly encapsulate partition meta (#3815) add 8f9b321fee IGNITE-21805 Refactor TableManager and move all RAFT related pieces to Replica (#3633) add 868910cc4e Tuple tests refactoring. add 974f8b4b91 Fix Tuple.columnName method contract. add 89d73ae8c4 Move tests to appropriate modules. add 6478b3ad60 Add missed tests. add 3fb1632686 Fix Tuple.columnName contract. add 9355d7d6e8 Fix tests This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (5df65bbdc1) \ N -- N -- N refs/heads/ignite-20650 (9355d7d6e8) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. No new revisions were added by this update. Summary of changes: build.gradle | 5 +- gradle/libs.versions.toml | 6 +- .../src/main/java/org/apache/ignite/Ignite.java| 16 +- .../org/apache/ignite/catalog/IgniteCatalog.java | 27 +- .../java/org/apache/ignite/catalog/Options.java| 147 .../main/java/org/apache/ignite/table/Tuple.java | 2 +- .../apache/ignite/table/mapper/MapperBuilder.java | 4 +- .../org/apache/ignite/table/TupleImplTest.java | 8 +- modules/catalog-dsl/build.gradle | 1 + .../ignite/internal/catalog/ItCatalogDslTest.java | 80 +++-- .../internal/catalog/sql/AbstractCatalogQuery.java | 23 +- .../catalog/sql/CreateFromAnnotationsImpl.java | 23 +- .../catalog/sql/CreateFromDefinitionImpl.java | 33 +- .../internal/catalog/sql/CreateIndexImpl.java | 20 +- .../internal/catalog/sql/CreateTableImpl.java | 28 +- .../internal/catalog/sql/CreateZoneImpl.java | 16 +- .../ignite/internal/catalog/sql/DropTableImpl.java | 12 +- .../ignite/internal/catalog/sql/DropZoneImpl.java | 12 +- .../internal/catalog/sql/IgniteCatalogSqlImpl.java | 71 ++-- .../apache/ignite/internal/catalog/sql/Name.java | 3 +- .../apache/ignite/internal/catalog/sql}/Query.java | 15 +- .../ignite/internal/catalog/sql/QueryContext.java | 29 +- .../ignite/internal/catalog/sql/TableZoneId.java} | 30 +- .../catalog/sql/CreateFromAnnotationsTest.java | 107 ++ .../catalog/sql/CreateFromDefinitionTest.java | 60 +--- .../internal/catalog/sql/CreateTableTest.java | 149 +++-- .../internal/catalog/sql/CreateZoneTest.java | 40 +-- .../ignite/internal/catalog/sql/DropTableTest.java | 20 +- .../ignite/internal/catalog/sql/DropZoneTest.java | 20 +- .../ignite/internal/catalog/sql/QueryPartTest.java | 29 +- .../catalog/CatalogParamsValidationUtils.java | 11 + .../catalog/commands/AlterZoneCommand.java | 4 +- .../ignite/internal/catalog/CatalogZoneTest.java | 3 +- .../commands/AlterZoneCommandValidationTest.java | 24 +- .../table/MutableTupleBinaryTupleAdapter.java | 2 +- .../ignite/internal/client/TcpIgniteClient.java| 5 +- .../org/apache/ignite/client/f
(ignite-3) branch ignite-21969 updated (4c3e321c36 -> 7e3440847c)
This is an automated email from the ASF dual-hosted git repository.
amashenkov pushed a change to branch ignite-21969
in repository https://gitbox.apache.org/repos/asf/ignite-3.git
from 4c3e321c36 Minor.
add 6177e466a2 Minor after review.
add 87aefa39ea Bump com.github.spotbugs from 6.0.14 to 6.0.15 (#3810)
add f685363061 Bump netty from 4.1.109.Final to 4.1.110.Final (#3808)
add 8867d35821 IGNITE-21418 Add more logs to debug this issue (#3831)
add 67de2b4c25 IGNITE-22339 Fix cli startup script for deb/rpm (#3825)
add 20f1e002ed IGNITE-22357 Some integration tests don't close the client
(#3832)
add 4ae7895586 IGNITE-19546 .NET: Add Data Streamer with Receiver (#3833)
add 533d6c2917 IGNITE-22371 Increase Netty IO buffer size (#3841)
add eb5651679b IGNITE-22288 Fix the vacuum of persistent tx state before
tx cleanup completion (#3799)
add db35b214ef IGNITE-22266 Move IgniteTables to o.a.i.table package
(#3845)
add 185fe91104 IGNITE-22359 Fix
StripedDisruptorTest.testMultipleSubscriberBatching (#3834)
add e4c4da4adc IGNITE-22368 JDBC integration tests don't close the
connection (#3836)
add c8b888a586 IGNITE-22282 REST/CLI for disaster recovery:
restart-partitions (#3792)
add 74d264ae71 IGNITE-22387 Fix restart-partitions CLI unit tests (#3853)
add 9c94aaab8c IGNITE-22380 Add Windows start script (#3848)
add 603303421c IGNITE-22389 Get rid of CatalogUtils#collectIndexes (#3854)
add 308cefb453 IGNITE-21965: Extend test coverage for SQL E071-02(Basic
query expressions. UNION ALL table operator) (#3844)
add bb1bd8d2ed IGNITE-22386 Fix revision serialization where it is
required to be properly comparable (#3852)
add 78a976b112 IGNITE-22335 Add assertion in async
TxCleanupMessageResponse handler (#3855)
add 7152f2c7ac IGNITE-22355 TableManagerTest's static mocks from
#mockManagersAndCreateTableWithDelay don't work properly (#3843)
add 81db1d025a IGNITE-22058 Use paranoid leak detection in tests (#3826)
add 41007ff42d IGNITE-22395 Remove assertions for paranoid leak detection
property (#3864)
add d20ec21a79 IGNITE-22301 Fix test
CatalogManagerSelfTest.alwaysWaitForActivationTime (#3861)
add 83e8a2a0d5 IGNITE-22061 Use constant value when estimating decimal
size (#3837)
add a7ea529288 IGNITE-22271 Rename copying overload of Tuple.create to
copy (#3873)
add 2bdd91f92d Bump org.assertj:assertj-core from 3.25.3 to 3.26.0 (#3839)
add 49ab1b248a IGNITE-22284 .NET: Fix tests on macOS (#3875)
add 26c1fb27bc IGNITE-22411 Fix CLI package (#3877)
add 1469191211 IGNITE-22275 forbid to alter partitions number. (#3838)
add 7b9e845b68 IGNITE-22207 Fix a deadlock in the ReplicaService (#3874)
add 4be3f4f83d IGNITE-21975: Extend test coverage for SQL
F302-01(INTERSECT table operator. INTERSECT DISTINCT table operator) (#3872)
add a760caf4f1 IGNITE-21967: Extend test coverage for SQL E091-06 (Set
functions. ALL quantifier) (#3876)
add 8d42d57a7d Bump net.bytebuddy:byte-buddy from 1.14.15 to 1.14.17
(#3849)
add c962e757f8 Bump com.google.code.gson:gson from 2.10.1 to 2.11.0 (#3794)
add 73a2c77d15 IGNITE-22272 Rework Catalog API (#3863)
add 78353de462 IGNITE-22107 Properly encapsulate partition meta (#3815)
add 8f9b321fee IGNITE-21805 Refactor TableManager and move all RAFT
related pieces to Replica (#3633)
add 7e3440847c Merge branch 'main' into ignite-21969
No new revisions were added by this update.
Summary of changes:
build.gradle | 5 +-
buildscripts/java-integration-test.gradle | 3 +-
gradle/libs.versions.toml | 10 +-
.../src/main/java/org/apache/ignite/Ignite.java| 18 +-
.../org/apache/ignite/catalog/IgniteCatalog.java | 27 +-
.../java/org/apache/ignite/catalog/Options.java| 147
.../ignite/table/{manager => }/IgniteTables.java | 3 +-
.../main/java/org/apache/ignite/table/Tuple.java | 2 +-
.../internal/binarytuple/BinaryTupleBuilder.java | 11 +-
.../internal/binarytuple/BinaryTupleCommon.java| 23 ++
modules/catalog-dsl/build.gradle | 1 +
.../ignite/internal/catalog/ItCatalogDslTest.java | 82 +++--
.../internal/catalog/sql/AbstractCatalogQuery.java | 23 +-
.../catalog/sql/CreateFromAnnotationsImpl.java | 23 +-
.../catalog/sql/CreateFromDefinitionImpl.java | 33 +-
.../internal/catalog/sql/CreateIndexImpl.java | 20 +-
.../internal/catalog/sql/CreateTableImpl.java | 28 +-
.../internal/catalog/sql/CreateZoneImpl.java | 16 +-
.../ignite/internal/catalog/sql/DropTableImpl.java | 12 +-
.../ignite/internal/catalog/sql/DropZoneImpl.java | 12 +-
.../internal/catalog/sql/IgniteCatalogSqlImpl.java | 71 ++--
.../apache/ignite/internal/catalog/sql/Name.java | 3 +-
.../apache/ignite/internal/catalog/sql}/Query.java | 15 +-
.../ign
(ignite-3) branch ignite-20650 updated (ae54303dbf -> 5df65bbdc1)
This is an automated email from the ASF dual-hosted git repository. amashenkov pushed a change to branch ignite-20650 in repository https://gitbox.apache.org/repos/asf/ignite-3.git from ae54303dbf Fix tests add 5df65bbdc1 Fix tests No new revisions were added by this update. Summary of changes: .../org/apache/ignite/internal/runner/app/PlatformTestNodeRunner.java | 2 +- .../org/apache/ignite/internal/table/ItThinClientColocationTest.java| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
(ignite-3) branch ignite-20650 updated (7f3ea9c69f -> ae54303dbf)
This is an automated email from the ASF dual-hosted git repository. amashenkov pushed a change to branch ignite-20650 in repository https://gitbox.apache.org/repos/asf/ignite-3.git from 7f3ea9c69f Minor add ae54303dbf Fix tests No new revisions were added by this update. Summary of changes: .../table/ColocationHashCalculationTest.java | 12 .../internal/table/SchemaValidationTest.java | 26 - .../table/type/NumericTypesSerializerTest.java | 34 +++--- 3 files changed, 36 insertions(+), 36 deletions(-)
(ignite-3) branch ignite-20650 updated (3931ba6ff1 -> 7f3ea9c69f)
This is an automated email from the ASF dual-hosted git repository. amashenkov pushed a change to branch ignite-20650 in repository https://gitbox.apache.org/repos/asf/ignite-3.git from 3931ba6ff1 Styles. add 7f3ea9c69f Minor No new revisions were added by this update. Summary of changes: .../src/main/java/org/apache/ignite/table/mapper/MapperBuilder.java | 4 +++- .../ignite/internal/client/table/MutableTupleBinaryTupleAdapter.java | 3 --- .../ignite/client/handler/requests/table/ClientHandlerTuple.java | 3 ++- .../java/org/apache/ignite/internal/client/table/ClientTuple.java | 3 ++- 4 files changed, 7 insertions(+), 6 deletions(-)
(ignite-3) branch ignite-20650 updated (c70dc736f6 -> 3931ba6ff1)
This is an automated email from the ASF dual-hosted git repository.
amashenkov pushed a change to branch ignite-20650
in repository https://gitbox.apache.org/repos/asf/ignite-3.git
discard c70dc736f6 Styles.
discard c7f65b3dde Minor
discard 13a9c499d8 Fix Tuple.columnName contract.
discard ef130bdb33 Add missed tests.
discard 14f9106f8c Move tests to appropriate modules.
discard 91c5e50ba9 Fix Tuple.columnName method contract.
discard 67eb4c3ee0 Tuple tests refactoring.
add 87aefa39ea Bump com.github.spotbugs from 6.0.14 to 6.0.15 (#3810)
add f685363061 Bump netty from 4.1.109.Final to 4.1.110.Final (#3808)
add 8867d35821 IGNITE-21418 Add more logs to debug this issue (#3831)
add 67de2b4c25 IGNITE-22339 Fix cli startup script for deb/rpm (#3825)
add 20f1e002ed IGNITE-22357 Some integration tests don't close the client
(#3832)
add 4ae7895586 IGNITE-19546 .NET: Add Data Streamer with Receiver (#3833)
add 533d6c2917 IGNITE-22371 Increase Netty IO buffer size (#3841)
add eb5651679b IGNITE-22288 Fix the vacuum of persistent tx state before
tx cleanup completion (#3799)
add db35b214ef IGNITE-22266 Move IgniteTables to o.a.i.table package
(#3845)
add 185fe91104 IGNITE-22359 Fix
StripedDisruptorTest.testMultipleSubscriberBatching (#3834)
add e4c4da4adc IGNITE-22368 JDBC integration tests don't close the
connection (#3836)
add c8b888a586 IGNITE-22282 REST/CLI for disaster recovery:
restart-partitions (#3792)
add 74d264ae71 IGNITE-22387 Fix restart-partitions CLI unit tests (#3853)
add 9c94aaab8c IGNITE-22380 Add Windows start script (#3848)
add 603303421c IGNITE-22389 Get rid of CatalogUtils#collectIndexes (#3854)
add 308cefb453 IGNITE-21965: Extend test coverage for SQL E071-02(Basic
query expressions. UNION ALL table operator) (#3844)
add bb1bd8d2ed IGNITE-22386 Fix revision serialization where it is
required to be properly comparable (#3852)
add 78a976b112 IGNITE-22335 Add assertion in async
TxCleanupMessageResponse handler (#3855)
add 7152f2c7ac IGNITE-22355 TableManagerTest's static mocks from
#mockManagersAndCreateTableWithDelay don't work properly (#3843)
add 81db1d025a IGNITE-22058 Use paranoid leak detection in tests (#3826)
add 41007ff42d IGNITE-22395 Remove assertions for paranoid leak detection
property (#3864)
add d20ec21a79 IGNITE-22301 Fix test
CatalogManagerSelfTest.alwaysWaitForActivationTime (#3861)
add 83e8a2a0d5 IGNITE-22061 Use constant value when estimating decimal
size (#3837)
add d45d04f6ea Tuple tests refactoring.
add 38c58ebf5e Fix Tuple.columnName method contract.
add 0c3db79b18 Move tests to appropriate modules.
add c56d7a482b Add missed tests.
add dbe4ad0aa3 Fix Tuple.columnName contract.
add 2825393896 Minor
add 3931ba6ff1 Styles.
This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version. This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:
* -- * -- B -- O -- O -- O (c70dc736f6)
\
N -- N -- N refs/heads/ignite-20650 (3931ba6ff1)
You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.
Any revisions marked "omit" are not gone; other references still
refer to them. Any revisions marked "discard" are gone forever.
No new revisions were added by this update.
Summary of changes:
buildscripts/java-integration-test.gradle | 3 +-
gradle/libs.versions.toml | 4 +-
.../src/main/java/org/apache/ignite/Ignite.java| 2 +-
.../ignite/table/{manager => }/IgniteTables.java | 3 +-
.../apache/ignite/table/manager/package-info.java | 22 --
.../internal/binarytuple/BinaryTupleBuilder.java | 11 +-
.../internal/binarytuple/BinaryTupleCommon.java| 23 ++
.../ignite/internal/catalog/ItCatalogDslTest.java | 2 +-
.../internal/catalog/commands/CatalogUtils.java| 43 ---
.../internal/catalog/CatalogManagerSelfTest.java | 7 +
.../catalog/commands/CatalogUtilsTest.java | 225
modules/cli/build.gradle | 4 +
.../commands/recovery/ItPartitionStatesTest.java | 2 +-
.../commands/recovery/ItResetPartitionsTest.java | 8 +-
.../ItRestartPartitionsCommandTest.java} | 9 +-
.../ItRestartPartitionsReplCommandTest.java} | 13 +-
.../ItRestartPartitionsTest.java} | 81 +++--
.../cli/call/recovery/PartitionStatesCall.java | 26 +-
.../call/recovery/reset/ResetPartitionsCall.java | 6 +-
.../RestartPartitionsCall.java}| 25 +-
.../restart/RestartPartitionsCallInput.java| 149
.../cli/commands/recove
(ignite-3) branch ignite-20650 updated (c7f65b3dde -> c70dc736f6)
This is an automated email from the ASF dual-hosted git repository.
amashenkov pushed a change to branch ignite-20650
in repository https://gitbox.apache.org/repos/asf/ignite-3.git
from c7f65b3dde Minor
add c70dc736f6 Styles.
No new revisions were added by this update.
Summary of changes:
.../api/src/test/java/org/apache/ignite/table/TupleImplTest.java| 3 +++
.../src/test/java/org/apache/ignite/client/ClientTupleTest.java | 3 +++
.../{ItColumnMappingTest.java => ItColumnNameMappingTest.java} | 6 --
.../apache/ignite/internal/table/MutableRowTupleAdapterTest.java| 6 --
4 files changed, 14 insertions(+), 4 deletions(-)
rename
modules/runner/src/integrationTest/java/org/apache/ignite/internal/table/{ItColumnMappingTest.java
=> ItColumnNameMappingTest.java} (98%)
(ignite-3) branch ignite-20650 updated (9b7e39ca6f -> c7f65b3dde)
This is an automated email from the ASF dual-hosted git repository. amashenkov pushed a change to branch ignite-20650 in repository https://gitbox.apache.org/repos/asf/ignite-3.git omit 9b7e39ca6f Minor add c7f65b3dde Minor This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (9b7e39ca6f) \ N -- N -- N refs/heads/ignite-20650 (c7f65b3dde) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. No new revisions were added by this update. Summary of changes: .../java/org/apache/ignite/table/TupleImplTest.java| 18 -- .../client/table/MutableTupleBinaryTupleAdapter.java | 3 +++ .../ignite/internal/client/table/ClientTuple.java | 3 +-- .../schema/marshaller/TupleMarshallerImpl.java | 3 ++- 4 files changed, 18 insertions(+), 9 deletions(-)
(ignite-3) branch ignite-20650 updated (add2cc35bb -> 9b7e39ca6f)
This is an automated email from the ASF dual-hosted git repository. amashenkov pushed a change to branch ignite-20650 in repository https://gitbox.apache.org/repos/asf/ignite-3.git discard add2cc35bb Fix Tuple.columnName contract. discard a78189f8f0 minor discard 1444da2922 Add missed tests. discard 62ea1ed2b3 Move tests to appropriate modules. discard f52c50279a Client tuple tests. discard 56896aa05a Fix Tuple.columnName method contract. add 91c5e50ba9 Fix Tuple.columnName method contract. add 14f9106f8c Move tests to appropriate modules. add ef130bdb33 Add missed tests. add 13a9c499d8 Fix Tuple.columnName contract. add 9b7e39ca6f Minor This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (add2cc35bb) \ N -- N -- N refs/heads/ignite-20650 (9b7e39ca6f) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. No new revisions were added by this update. Summary of changes: .../java/org/apache/ignite/table/TupleImpl.java| 8 +- .../table/MutableTupleBinaryTupleAdapter.java | 9 +- .../org/apache/ignite/client/ClientTupleTest.java | 4 +- .../ignite/internal/table/ItColumnMappingTest.java | 153 ++--- .../internal/table/AbstractRowTupleAdapter.java| 8 +- .../internal/table/MutableRowTupleAdapterTest.java | 14 +- 6 files changed, 113 insertions(+), 83 deletions(-)
(ignite-3) branch ignite-20650 updated (1444da2922 -> add2cc35bb)
This is an automated email from the ASF dual-hosted git repository.
amashenkov pushed a change to branch ignite-20650
in repository https://gitbox.apache.org/repos/asf/ignite-3.git
from 1444da2922 Add missed tests.
add a78189f8f0 minor
add add2cc35bb Fix Tuple.columnName contract.
No new revisions were added by this update.
Summary of changes:
.../main/java/org/apache/ignite/table/Tuple.java | 6 +--
.../java/org/apache/ignite/table/TupleImpl.java| 4 ++
.../org/apache/ignite/table/TupleImplTest.java | 2 +-
...lfTest.java => AbstractImmutableTupleTest.java} | 27 ++---
...SelfTest.java => AbstractMutableTupleTest.java} | 47 --
.../table/MutableTupleBinaryTupleAdapter.java | 8 +++-
.../org/apache/ignite/client/ClientTupleTest.java | 4 +-
.../internal/table/AbstractRowTupleAdapter.java| 8 +++-
.../internal/table/MutableRowTupleAdapterTest.java | 6 +--
9 files changed, 64 insertions(+), 48 deletions(-)
rename
modules/api/src/testFixtures/java/org/apache/ignite/table/{AbstractTupleSelfTest.java
=> AbstractImmutableTupleTest.java} (94%)
rename
modules/api/src/testFixtures/java/org/apache/ignite/table/{AbstractMutableTupleSelfTest.java
=> AbstractMutableTupleTest.java} (90%)
(ignite-3) branch ignite-20650 updated (62ea1ed2b3 -> 1444da2922)
This is an automated email from the ASF dual-hosted git repository. amashenkov pushed a change to branch ignite-20650 in repository https://gitbox.apache.org/repos/asf/ignite-3.git from 62ea1ed2b3 Move tests to appropriate modules. add 1444da2922 Add missed tests. No new revisions were added by this update. Summary of changes: .../ignite/table/AbstractMutableTupleSelfTest.java | 4 +++ .../apache/ignite/table/AbstractTupleSelfTest.java | 4 ++- .../internal/table/MutableRowTupleAdapterTest.java | 30 +- 3 files changed, 36 insertions(+), 2 deletions(-)
(ignite-3) branch ignite-20650 updated (1320254bd3 -> 62ea1ed2b3)
This is an automated email from the ASF dual-hosted git repository.
amashenkov pushed a change to branch ignite-20650
in repository https://gitbox.apache.org/repos/asf/ignite-3.git
discard 1320254bd3 Client tuple tests.
add f52c50279a Client tuple tests.
add 62ea1ed2b3 Move tests to appropriate modules.
This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version. This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:
* -- * -- B -- O -- O -- O (1320254bd3)
\
N -- N -- N refs/heads/ignite-20650 (62ea1ed2b3)
You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.
Any revisions marked "omit" are not gone; other references still
refer to them. Any revisions marked "discard" are gone forever.
No new revisions were added by this update.
Summary of changes:
.../org/apache/ignite/table/TupleImplTest.java | 1 -
.../table/AbstractMutableTupleSelfTest.java| 3 +-
.../ignite}/table/AbstractTupleSelfTest.java | 53 ++---
modules/client/build.gradle| 1 +
.../org/apache/ignite/client/ClientTupleTest.java | 87 +-
.../internal/table/MutableRowTupleAdapterTest.java | 1 +
6 files changed, 60 insertions(+), 86 deletions(-)
rename modules/{table =>
api}/src/test/java/org/apache/ignite/table/TupleImplTest.java (96%)
rename modules/{table/src/testFixtures/java/org/apache/ignite/internal =>
api/src/testFixtures/java/org/apache/ignite}/table/AbstractMutableTupleSelfTest.java
(98%)
rename modules/{table/src/testFixtures/java/org/apache/ignite/internal =>
api/src/testFixtures/java/org/apache/ignite}/table/AbstractTupleSelfTest.java
(89%)
(ignite-3) branch main updated: IGNITE-22061 Use constant value when estimating decimal size (#3837)
This is an automated email from the ASF dual-hosted git repository.
amashenkov pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/ignite-3.git
The following commit(s) were added to refs/heads/main by this push:
new 83e8a2a0d5 IGNITE-22061 Use constant value when estimating decimal
size (#3837)
83e8a2a0d5 is described below
commit 83e8a2a0d582e71b6b7e857e742c367d06dcba7a
Author: Pavel Pereslegin
AuthorDate: Tue Jun 4 11:28:29 2024 +0300
IGNITE-22061 Use constant value when estimating decimal size (#3837)
---
.../internal/binarytuple/BinaryTupleBuilder.java | 11 +---
.../internal/binarytuple/BinaryTupleCommon.java| 23 +++
.../marshaller/reflection/ObjectStatistics.java| 43 +---
.../ignite/internal/schema/row/RowAssembler.java | 14 +++-
.../schema/marshaller/TupleMarshallerImpl.java | 36 +-
.../marshaller/TupleMarshallerStatisticsTest.java | 76 ++
6 files changed, 179 insertions(+), 24 deletions(-)
diff --git
a/modules/binary-tuple/src/main/java/org/apache/ignite/internal/binarytuple/BinaryTupleBuilder.java
b/modules/binary-tuple/src/main/java/org/apache/ignite/internal/binarytuple/BinaryTupleBuilder.java
index 0bf09c2f60..d6c19d7ae0 100644
---
a/modules/binary-tuple/src/main/java/org/apache/ignite/internal/binarytuple/BinaryTupleBuilder.java
+++
b/modules/binary-tuple/src/main/java/org/apache/ignite/internal/binarytuple/BinaryTupleBuilder.java
@@ -19,7 +19,6 @@ package org.apache.ignite.internal.binarytuple;
import java.math.BigDecimal;
import java.math.BigInteger;
-import java.math.RoundingMode;
import java.nio.ByteBuffer;
import java.nio.ByteOrder;
import java.nio.CharBuffer;
@@ -315,15 +314,7 @@ public class BinaryTupleBuilder {
* @return {@code this} for chaining.
*/
public BinaryTupleBuilder appendDecimalNotNull(BigDecimal value, int
scale) {
-if (value.scale() > scale) {
-value = value.setScale(scale, RoundingMode.HALF_UP);
-}
-
-BigDecimal noZeros = value.stripTrailingZeros();
-if (noZeros.scale() <= Short.MAX_VALUE && noZeros.scale() >=
Short.MIN_VALUE) {
-// Use more compact representation if possible.
-value = noZeros;
-}
+value = BinaryTupleCommon.shrinkDecimal(value, scale);
// See CatalogUtils.MAX_DECIMAL_SCALE = Short.MAX_VALUE
if (value.scale() > Short.MAX_VALUE) {
diff --git
a/modules/binary-tuple/src/main/java/org/apache/ignite/internal/binarytuple/BinaryTupleCommon.java
b/modules/binary-tuple/src/main/java/org/apache/ignite/internal/binarytuple/BinaryTupleCommon.java
index 45f71d8f24..9f97c8e16c 100644
---
a/modules/binary-tuple/src/main/java/org/apache/ignite/internal/binarytuple/BinaryTupleCommon.java
+++
b/modules/binary-tuple/src/main/java/org/apache/ignite/internal/binarytuple/BinaryTupleCommon.java
@@ -17,6 +17,8 @@
package org.apache.ignite.internal.binarytuple;
+import java.math.BigDecimal;
+import java.math.RoundingMode;
import org.apache.ignite.internal.lang.IgniteInternalException;
/**
@@ -100,4 +102,25 @@ public class BinaryTupleCommon {
throw new IgniteInternalException("Too big binary tuple size");
}
+
+/**
+ * Converts specified {@link BigDecimal} value to a more compact form, if
possible.
+ *
+ * @param value Field value.
+ * @param scale Maximum scale.
+ * @return Decimal with a scale reduced to the specified scale and trimmed
trailing zeros.
+ */
+public static BigDecimal shrinkDecimal(BigDecimal value, int scale) {
+if (value.scale() > scale) {
+value = value.setScale(scale, RoundingMode.HALF_UP);
+}
+
+BigDecimal noZeros = value.stripTrailingZeros();
+if (noZeros.scale() <= Short.MAX_VALUE && noZeros.scale() >=
Short.MIN_VALUE) {
+// Use more compact representation if possible.
+return noZeros;
+}
+
+return value;
+}
}
diff --git
a/modules/schema/src/main/java/org/apache/ignite/internal/schema/marshaller/reflection/ObjectStatistics.java
b/modules/schema/src/main/java/org/apache/ignite/internal/schema/marshaller/reflection/ObjectStatistics.java
index cc8f3c4aa6..6cb1f8c313 100644
---
a/modules/schema/src/main/java/org/apache/ignite/internal/schema/marshaller/reflection/ObjectStatistics.java
+++
b/modules/schema/src/main/java/org/apache/ignite/internal/schema/marshaller/reflection/ObjectStatistics.java
@@ -19,12 +19,15 @@ package
org.apache.ignite.internal.schema.marshaller.reflection;
import static
org.apache.ignite.internal.schema.marshaller.MarshallerUtil.getValueSize;
+import java.math.BigDecimal;
import java.util.List;
+import org.apache.ignite.internal.binarytuple.BinaryTupleCommon;
import org.apache.ignite.internal.marshaller.Marshaller;
import org.apache.ignite.internal.schema.Column;
import org.apache.i
(ignite-3) branch ignite-20650 updated (b39e1b7ab8 -> 1320254bd3)
This is an automated email from the ASF dual-hosted git repository. amashenkov pushed a change to branch ignite-20650 in repository https://gitbox.apache.org/repos/asf/ignite-3.git discard b39e1b7ab8 Client tuple tests. add 1320254bd3 Client tuple tests. This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (b39e1b7ab8) \ N -- N -- N refs/heads/ignite-20650 (1320254bd3) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. No new revisions were added by this update. Summary of changes: .../java/org/apache/ignite/client/ClientTupleTest.java | 1 + .../internal/table/MutableRowTupleAdapterTest.java | 18 +- 2 files changed, 10 insertions(+), 9 deletions(-)
(ignite-3) branch ignite-20650 updated (56896aa05a -> b39e1b7ab8)
This is an automated email from the ASF dual-hosted git repository. amashenkov pushed a change to branch ignite-20650 in repository https://gitbox.apache.org/repos/asf/ignite-3.git from 56896aa05a Fix Tuple.columnName method contract. add b39e1b7ab8 Client tuple tests. No new revisions were added by this update. Summary of changes: .../table/MutableTupleBinaryTupleAdapter.java | 2 +- .../org/apache/ignite/client/ClientTupleTest.java | 227 ++--- .../internal/table/MutableRowTupleAdapterTest.java | 11 +- .../table/AbstractMutableTupleSelfTest.java| 52 ++--- .../internal/table/AbstractTupleSelfTest.java | 9 +- 5 files changed, 87 insertions(+), 214 deletions(-)
(ignite-3) branch ignite-20650 updated (67eb4c3ee0 -> 56896aa05a)
This is an automated email from the ASF dual-hosted git repository. amashenkov pushed a change to branch ignite-20650 in repository https://gitbox.apache.org/repos/asf/ignite-3.git from 67eb4c3ee0 Tuple tests refactoring. add 56896aa05a Fix Tuple.columnName method contract. No new revisions were added by this update. Summary of changes: .../api/src/main/java/org/apache/ignite/table/Tuple.java | 9 ++--- .../src/main/java/org/apache/ignite/table/TupleImpl.java | 7 --- .../ignite/internal/table/AbstractRowTupleAdapter.java | 2 +- .../ignite/internal/table/MutableRowTupleAdapterTest.java | 6 -- .../internal/table/AbstractMutableTupleSelfTest.java | 2 +- .../ignite/internal/table/AbstractTupleSelfTest.java | 14 +++--- 6 files changed, 23 insertions(+), 17 deletions(-)
(ignite-3) branch ignite-21969 updated: Minor.
This is an automated email from the ASF dual-hosted git repository.
amashenkov pushed a commit to branch ignite-21969
in repository https://gitbox.apache.org/repos/asf/ignite-3.git
The following commit(s) were added to refs/heads/ignite-21969 by this push:
new 4c3e321c36 Minor.
4c3e321c36 is described below
commit 4c3e321c365e56e446e84fe2f7c3ee7f8de06838
Author: amashenkov
AuthorDate: Fri May 31 16:57:55 2024 +0300
Minor.
---
.../internal/sql/engine/ItAlterTableDdlTest.java | 23 ++
1 file changed, 23 insertions(+)
diff --git
a/modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItAlterTableDdlTest.java
b/modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItAlterTableDdlTest.java
index bdb67387cf..1236db968b 100644
---
a/modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItAlterTableDdlTest.java
+++
b/modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItAlterTableDdlTest.java
@@ -96,6 +96,29 @@ public class ItAlterTableDdlTest extends
BaseSqlIntegrationTest {
.check();
}
+/** Test add/drop column short syntax. */
+@Test
+public void testDropAndAddColumnShortSyntax() {
+sql("CREATE TABLE my (c1 INT PRIMARY KEY, c2 INT)");
+
+sql("ALTER TABLE my ADD (c3 VARCHAR)");
+sql("ALTER TABLE my ADD (c4 INT DEFAULT -1, c5 INT)");
+
+sql("INSERT INTO my (c1, c2, c3) VALUES (1, 2, '3')");
+
+sql("ALTER TABLE my DROP c2");
+
+assertQuery("SELECT * FROM my")
+.returns(1, "3", -1, null)
+.check();
+
+sql("ALTER TABLE my DROP c3, c5");
+
+assertQuery("SELECT * FROM my")
+.returns(1, -1)
+.check();
+}
+
/** Test that adding nullable column via ALTER TABLE ADD name type NULL
works. */
@Test
public void testNullableColumn() {
(ignite-3) branch ignite-20650 updated (c53204b48f -> 67eb4c3ee0)
This is an automated email from the ASF dual-hosted git repository.
amashenkov pushed a change to branch ignite-20650
in repository https://gitbox.apache.org/repos/asf/ignite-3.git
omit c53204b48f Tuple tests refactoring.
add 67eb4c3ee0 Tuple tests refactoring.
This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version. This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:
* -- * -- B -- O -- O -- O (c53204b48f)
\
N -- N -- N refs/heads/ignite-20650 (67eb4c3ee0)
You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.
Any revisions marked "omit" are not gone; other references still
refer to them. Any revisions marked "discard" are gone forever.
No new revisions were added by this update.
Summary of changes:
.../org/apache/ignite/client/ClientTupleTest.java | 2 -
.../internal/table/MutableRowTupleAdapterTest.java | 3 --
.../org/apache/ignite/table/TupleImplTest.java | 3 +-
.../table/AbstractMutableTupleSelfTest.java| 55 +++---
.../internal}/table/AbstractTupleSelfTest.java | 20 +++-
5 files changed, 57 insertions(+), 26 deletions(-)
rename modules/table/src/{test/java/org/apache/ignite =>
testFixtures/java/org/apache/ignite/internal}/table/AbstractMutableTupleSelfTest.java
(56%)
rename modules/table/src/{test/java/org/apache/ignite =>
testFixtures/java/org/apache/ignite/internal}/table/AbstractTupleSelfTest.java
(94%)
(ignite-3) branch ignite-20650 updated (b794f86e7f -> c53204b48f)
This is an automated email from the ASF dual-hosted git repository. amashenkov pushed a change to branch ignite-20650 in repository https://gitbox.apache.org/repos/asf/ignite-3.git omit b794f86e7f wip omit 1288724cf9 Tuple tests refactoring. add c53204b48f Tuple tests refactoring. This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (b794f86e7f) \ N -- N -- N refs/heads/ignite-20650 (c53204b48f) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. No new revisions were added by this update. Summary of changes:
(ignite-3) branch ignite-20650 updated (1288724cf9 -> b794f86e7f)
This is an automated email from the ASF dual-hosted git repository. amashenkov pushed a change to branch ignite-20650 in repository https://gitbox.apache.org/repos/asf/ignite-3.git from 1288724cf9 Tuple tests refactoring. add b794f86e7f wip No new revisions were added by this update. Summary of changes: .../ignite/internal/table/ItColumnMappingTest.java | 17 - .../internal/table/AbstractRowTupleAdapter.java| 3 +- .../org/apache/ignite/internal/table/TableRow.java | 5 +- .../internal/table/MutableRowTupleAdapterTest.java | 389 + .../ignite/table/AbstractMutableTupleSelfTest.java | 134 +++ .../apache/ignite/table/AbstractTupleSelfTest.java | 269 +- .../org/apache/ignite/table/TupleImplTest.java | 6 +- 7 files changed, 313 insertions(+), 510 deletions(-) create mode 100644 modules/table/src/test/java/org/apache/ignite/table/AbstractMutableTupleSelfTest.java
(ignite-3) branch gg-20650 deleted (was 1288724cf9)
This is an automated email from the ASF dual-hosted git repository. amashenkov pushed a change to branch gg-20650 in repository https://gitbox.apache.org/repos/asf/ignite-3.git was 1288724cf9 Tuple tests refactoring. The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
(ignite-3) branch ignite-20650 created (now 1288724cf9)
This is an automated email from the ASF dual-hosted git repository. amashenkov pushed a change to branch ignite-20650 in repository https://gitbox.apache.org/repos/asf/ignite-3.git at 1288724cf9 Tuple tests refactoring. No new revisions were added by this update.
(ignite-3) 01/01: Tuple tests refactoring.
This is an automated email from the ASF dual-hosted git repository.
amashenkov pushed a commit to branch gg-20650
in repository https://gitbox.apache.org/repos/asf/ignite-3.git
commit 1288724cf9e4749f09cb55ea4f8613a35831b7cd
Author: amashenkov
AuthorDate: Thu May 30 15:07:20 2024 +0300
Tuple tests refactoring.
---
.../main/java/org/apache/ignite/table/Tuple.java | 3 +-
.../java/org/apache/ignite/table/TupleImpl.java| 3 +-
.../ignite/internal/table/ItColumnMappingTest.java | 180
.../schema/marshaller/TupleMarshallerImpl.java | 3 +-
.../apache/ignite/table/AbstractTupleSelfTest.java | 456 +
.../org/apache/ignite/table/TupleImplTest.java | 275 +
6 files changed, 647 insertions(+), 273 deletions(-)
diff --git a/modules/api/src/main/java/org/apache/ignite/table/Tuple.java
b/modules/api/src/main/java/org/apache/ignite/table/Tuple.java
index 4526f9335b..545b4c47bb 100644
--- a/modules/api/src/main/java/org/apache/ignite/table/Tuple.java
+++ b/modules/api/src/main/java/org/apache/ignite/table/Tuple.java
@@ -155,7 +155,8 @@ public interface Tuple extends Iterable {
}
for (int idx = 0; idx < columns; idx++) {
-int idx2 = secondTuple.columnIndex(firstTuple.columnName(idx));
+// fix this hack
+int idx2 = secondTuple.columnIndex("\""+
firstTuple.columnName(idx) +"\"");
if (idx2 < 0) {
return false;
diff --git a/modules/api/src/main/java/org/apache/ignite/table/TupleImpl.java
b/modules/api/src/main/java/org/apache/ignite/table/TupleImpl.java
index 998afb2b51..6c7fd8ee9c 100644
--- a/modules/api/src/main/java/org/apache/ignite/table/TupleImpl.java
+++ b/modules/api/src/main/java/org/apache/ignite/table/TupleImpl.java
@@ -78,7 +78,8 @@ class TupleImpl implements Tuple, Serializable {
this(tuple.columnCount());
for (int i = 0, len = tuple.columnCount(); i < len; i++) {
-set(tuple.columnName(i), tuple.value(i));
+// fix this hack
+set("\"" + tuple.columnName(i) + "\"", tuple.value(i));
}
}
diff --git
a/modules/runner/src/integrationTest/java/org/apache/ignite/internal/table/ItColumnMappingTest.java
b/modules/runner/src/integrationTest/java/org/apache/ignite/internal/table/ItColumnMappingTest.java
new file mode 100644
index 00..6f0080f449
--- /dev/null
+++
b/modules/runner/src/integrationTest/java/org/apache/ignite/internal/table/ItColumnMappingTest.java
@@ -0,0 +1,180 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.table;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNotNull;
+import static org.junit.jupiter.api.Assertions.assertNull;
+import static org.junit.jupiter.api.Assertions.assertThrows;
+
+import javax.annotation.Nullable;
+import org.apache.ignite.internal.ClusterPerClassIntegrationTest;
+import org.apache.ignite.internal.app.IgniteImpl;
+import org.apache.ignite.lang.MarshallerException;
+import org.apache.ignite.table.KeyValueView;
+import org.apache.ignite.table.RecordView;
+import org.apache.ignite.table.Table;
+import org.apache.ignite.table.Tuple;
+import org.junit.jupit
(ignite-3) branch gg-20650 created (now 1288724cf9)
This is an automated email from the ASF dual-hosted git repository. amashenkov pushed a change to branch gg-20650 in repository https://gitbox.apache.org/repos/asf/ignite-3.git at 1288724cf9 Tuple tests refactoring. This branch includes the following new commits: new 1288724cf9 Tuple tests refactoring. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
(ignite-3) branch ignite-21969 created (now 78f069a0f7)
This is an automated email from the ASF dual-hosted git repository. amashenkov pushed a change to branch ignite-21969 in repository https://gitbox.apache.org/repos/asf/ignite-3.git at 78f069a0f7 minor This branch includes the following new commits: new 78f069a0f7 minor The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
(ignite-3) 01/01: minor
This is an automated email from the ASF dual-hosted git repository.
amashenkov pushed a commit to branch ignite-21969
in repository https://gitbox.apache.org/repos/asf/ignite-3.git
commit 78f069a0f7c9743d28cf8f65f1629f53a2025aed
Author: amashenkov
AuthorDate: Tue May 28 18:14:19 2024 +0300
minor
---
.../sql/engine/ItAlterTableAlterColumnTest.java| 2 +
.../internal/sql/engine/ItAlterTableDdlTest.java | 200 +
.../internal/sql/engine/ItCreateTableDdlTest.java | 154 +---
3 files changed, 204 insertions(+), 152 deletions(-)
diff --git
a/modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItAlterTableAlterColumnTest.java
b/modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItAlterTableAlterColumnTest.java
index 6f5c68f58a..f9ca05c409 100644
---
a/modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItAlterTableAlterColumnTest.java
+++
b/modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItAlterTableAlterColumnTest.java
@@ -46,6 +46,8 @@ import org.junit.jupiter.params.provider.MethodSource;
/**
* Integration test for ALTER TABLE ALTER COLUMN command.
+ *
+ * SQL F381 feature. Extended schema manipulation.
*/
public class ItAlterTableAlterColumnTest extends BaseSqlIntegrationTest {
@AfterEach
diff --git
a/modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItAlterTableDdlTest.java
b/modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItAlterTableDdlTest.java
new file mode 100644
index 00..bdb67387cf
--- /dev/null
+++
b/modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItAlterTableDdlTest.java
@@ -0,0 +1,200 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.sql.engine;
+
+import static org.apache.ignite.internal.lang.IgniteStringFormatter.format;
+import static
org.apache.ignite.internal.sql.engine.util.SqlTestUtils.assertThrowsSqlException;
+import static org.apache.ignite.lang.ErrorGroups.Sql.STMT_PARSE_ERR;
+import static org.hamcrest.MatcherAssert.assertThat;
+import static org.hamcrest.Matchers.is;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertFalse;
+
+import java.time.LocalDate;
+import java.time.LocalDateTime;
+import java.time.LocalTime;
+import java.time.Month;
+import java.util.List;
+import java.util.Set;
+import org.apache.calcite.rel.type.RelDataType;
+import org.apache.ignite.internal.lang.IgniteStringBuilder;
+import org.apache.ignite.internal.schema.SchemaTestUtils;
+import org.apache.ignite.internal.sql.BaseSqlIntegrationTest;
+import org.apache.ignite.internal.sql.engine.util.Commons;
+import org.apache.ignite.internal.sql.engine.util.TypeUtils;
+import org.apache.ignite.internal.type.NativeType;
+import org.apache.ignite.internal.type.NativeTypeSpec;
+import org.junit.jupiter.api.AfterEach;
+import org.junit.jupiter.api.Test;
+
+/**
+ * Integration tests for ALTER TABLE DDL statements.
+ *
+ * SQL F031-04 feature. ALTER TABLE statement: ADD COLUMN clause
+ * SQL F033 feature. ALTER TABLE statement: DROP COLUMN clause
+ */
+public class ItAlterTableDdlTest extends BaseSqlIntegrationTest {
+@AfterEach
+public void dropTables() {
+dropAllTables();
+dropAllZonesExceptDefaultOne();
+}
+
+/** Test correct mapping schema after alter columns. */
+@Test
+public void testDropAndAddColumns() {
+sql("CREATE TABLE my (c1 INT PRIMARY KEY, c2 INT, c3 VARCHAR)");
+
+sql("INSERT INTO my VALUES (1, 2, '3')");
+
+List> res = sql("SELECT c1, c3 FROM my");
+
+assertFalse(res.isEmpty());
+
+sql("ALTER TABLE my DROP COLUMN c2");
+
+res = sql("SELECT c1, c3 FROM my");
+
+assertFalse(res.isEmpty());
+
+sql("ALTER TABLE my ADD COLUMN (c2 INT, c4 VARCHAR)");
+
+sql("INSERT INTO my VALUES (2, '2', 2, '3')");
+
+res = sql("SELECT c2, c4 FROM my WHERE c1
(ignite-3) branch ignite-21972 deleted (was 53c84fb38b)
This is an automated email from the ASF dual-hosted git repository. amashenkov pushed a change to branch ignite-21972 in repository https://gitbox.apache.org/repos/asf/ignite-3.git was 53c84fb38b minor The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
(ignite-3) branch ignite-21970 deleted (was 821b502207)
This is an automated email from the ASF dual-hosted git repository. amashenkov pushed a change to branch ignite-21970 in repository https://gitbox.apache.org/repos/asf/ignite-3.git was 821b502207 IGNITE-21970 Sql. Extend test coverage for SQL F051-06, F051-07, F051-08 (Basic date and time) The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
(ignite-3) branch main updated: IGNITE-21970 Sql. Extend test coverage for SQL F051-06, F051-07, F051-08 (Basic date and time) (#3820)
This is an automated email from the ASF dual-hosted git repository.
amashenkov pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/ignite-3.git
The following commit(s) were added to refs/heads/main by this push:
new 4a1f0b1607 IGNITE-21970 Sql. Extend test coverage for SQL F051-06,
F051-07, F051-08 (Basic date and time) (#3820)
4a1f0b1607 is described below
commit 4a1f0b16078161f07bfe8d2bf05e27fbfcfd5a3c
Author: Andrew V. Mashenkov
AuthorDate: Tue May 28 12:57:14 2024 +0300
IGNITE-21970 Sql. Extend test coverage for SQL F051-06, F051-07, F051-08
(Basic date and time) (#3820)
---
.../java/org/apache/ignite/internal/sql/engine/ItFunctionsTest.java | 5 +
.../src/integrationTest/sql/function/timestamp/current_time.test| 6 --
2 files changed, 5 insertions(+), 6 deletions(-)
diff --git
a/modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItFunctionsTest.java
b/modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItFunctionsTest.java
index 2e3356084e..8657456186 100644
---
a/modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItFunctionsTest.java
+++
b/modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItFunctionsTest.java
@@ -82,6 +82,11 @@ public class ItFunctionsTest extends BaseSqlIntegrationTest {
assertQuery("SELECT OCTET_LENGTH(NULL)").returns(NULL_RESULT).check();
}
+/**
+ * SQL F051-06 feature. Basic date and time. CURRENT_DATE.
+ * SQL F051-07 feature. Basic date and time. LOCALTIME.
+ * SQL F051-08 feature. Basic date and time. LOCALTIMESTAMP.
+ */
@ParameterizedTest(name = "use default time zone: {0}")
@ValueSource(booleans = {true, false})
public void testCurrentDateTimeTimeStamp(boolean useDefaultTimeZone) {
diff --git
a/modules/sql-engine/src/integrationTest/sql/function/timestamp/current_time.test
b/modules/sql-engine/src/integrationTest/sql/function/timestamp/current_time.test
deleted file mode 100644
index a33d330f60..00
---
a/modules/sql-engine/src/integrationTest/sql/function/timestamp/current_time.test
+++ /dev/null
@@ -1,6 +0,0 @@
-# name: test/sql/function/timestamp/current_time.test
-# description: Test current_time/current_date/etc
-# group: [timestamp]
-
-statement ok
-SELECT CAST(CURRENT_TIME AS VARCHAR), CAST(CURRENT_DATE AS VARCHAR),
CAST(CURRENT_TIMESTAMP AS VARCHAR), CAST({fn NOW()} AS VARCHAR)
(ignite-3) 01/01: minor
This is an automated email from the ASF dual-hosted git repository.
amashenkov pushed a commit to branch ignite-21972
in repository https://gitbox.apache.org/repos/asf/ignite-3.git
commit 53c84fb38be5d1dd2610cb60dbb905b3b6616fb1
Author: amashenkov
AuthorDate: Mon May 27 14:32:22 2024 +0300
minor
---
.../java/org/apache/ignite/internal/sql/engine/ItFunctionsTest.java | 3 +++
.../src/integrationTest/sql/function/timestamp/current_time.test | 4 ++--
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git
a/modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItFunctionsTest.java
b/modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItFunctionsTest.java
index 2e3356084e..c0d04cad14 100644
---
a/modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItFunctionsTest.java
+++
b/modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItFunctionsTest.java
@@ -82,6 +82,9 @@ public class ItFunctionsTest extends BaseSqlIntegrationTest {
assertQuery("SELECT OCTET_LENGTH(NULL)").returns(NULL_RESULT).check();
}
+/**
+ * SQL F051-08 feature. Basic date and time. LOCALTIMESTAMP.
+ */
@ParameterizedTest(name = "use default time zone: {0}")
@ValueSource(booleans = {true, false})
public void testCurrentDateTimeTimeStamp(boolean useDefaultTimeZone) {
diff --git
a/modules/sql-engine/src/integrationTest/sql/function/timestamp/current_time.test
b/modules/sql-engine/src/integrationTest/sql/function/timestamp/current_time.test
index a33d330f60..91a0d88b18 100644
---
a/modules/sql-engine/src/integrationTest/sql/function/timestamp/current_time.test
+++
b/modules/sql-engine/src/integrationTest/sql/function/timestamp/current_time.test
@@ -1,6 +1,6 @@
# name: test/sql/function/timestamp/current_time.test
-# description: Test current_time/current_date/etc
+# description: SQL feature F051-08(Basic date and time. LOCALTIMESTAMP).
# group: [timestamp]
statement ok
-SELECT CAST(CURRENT_TIME AS VARCHAR), CAST(CURRENT_DATE AS VARCHAR),
CAST(CURRENT_TIMESTAMP AS VARCHAR), CAST({fn NOW()} AS VARCHAR)
+SELECT CAST(CURRENT_TIME AS VARCHAR), CAST(CURRENT_DATE AS VARCHAR),
CAST(CURRENT_TIMESTAMP AS VARCHAR), CAST({fn NOW()} AS VARCHAR),
CAST(LOCALTIMESTAMP AS VARCHAR)
(ignite-3) branch ignite-21972 created (now 53c84fb38b)
This is an automated email from the ASF dual-hosted git repository. amashenkov pushed a change to branch ignite-21972 in repository https://gitbox.apache.org/repos/asf/ignite-3.git at 53c84fb38b minor This branch includes the following new commits: new 53c84fb38b minor The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
(ignite-3) branch ignite-21970 created (now 24c70cbeb4)
This is an automated email from the ASF dual-hosted git repository. amashenkov pushed a change to branch ignite-21970 in repository https://gitbox.apache.org/repos/asf/ignite-3.git at 24c70cbeb4 minor This branch includes the following new commits: new 24c70cbeb4 minor The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
(ignite-3) 01/01: minor
This is an automated email from the ASF dual-hosted git repository.
amashenkov pushed a commit to branch ignite-21970
in repository https://gitbox.apache.org/repos/asf/ignite-3.git
commit 24c70cbeb4f46e15be7c6ecc0f44fa5b23ae36dc
Author: amashenkov
AuthorDate: Mon May 27 14:12:54 2024 +0300
minor
---
.../java/org/apache/ignite/internal/sql/engine/ItFunctionsTest.java| 3 +++
.../src/integrationTest/sql/function/timestamp/current_time.test | 2 +-
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git
a/modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItFunctionsTest.java
b/modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItFunctionsTest.java
index 2e3356084e..22ff63b54b 100644
---
a/modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItFunctionsTest.java
+++
b/modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItFunctionsTest.java
@@ -82,6 +82,9 @@ public class ItFunctionsTest extends BaseSqlIntegrationTest {
assertQuery("SELECT OCTET_LENGTH(NULL)").returns(NULL_RESULT).check();
}
+/**
+ * SQL F051-06 feature. Basic date and time. CURRENT_DATE.
+ */
@ParameterizedTest(name = "use default time zone: {0}")
@ValueSource(booleans = {true, false})
public void testCurrentDateTimeTimeStamp(boolean useDefaultTimeZone) {
diff --git
a/modules/sql-engine/src/integrationTest/sql/function/timestamp/current_time.test
b/modules/sql-engine/src/integrationTest/sql/function/timestamp/current_time.test
index a33d330f60..5d51f758a6 100644
---
a/modules/sql-engine/src/integrationTest/sql/function/timestamp/current_time.test
+++
b/modules/sql-engine/src/integrationTest/sql/function/timestamp/current_time.test
@@ -1,5 +1,5 @@
# name: test/sql/function/timestamp/current_time.test
-# description: Test current_time/current_date/etc
+# description: SQL feature F051-06(Basic date and time. CURRENT_DATE).
# group: [timestamp]
statement ok
(ignite-3) branch ignite-19331 deleted (was 73fc69b6c0)
This is an automated email from the ASF dual-hosted git repository. amashenkov pushed a change to branch ignite-19331 in repository https://gitbox.apache.org/repos/asf/ignite-3.git was 73fc69b6c0 Merge branch 'main' into ignite-19331 The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
(ignite-3) branch main updated (6afc371a05 -> a87451c280)
This is an automated email from the ASF dual-hosted git repository. amashenkov pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/ignite-3.git from 6afc371a05 IGNITE-22164 Sql. Fixed conversion from SqlMerge AST to relational expression when columns defined in different order. add a87451c280 IGNITE-19331 Sql. Improve CAST with Boolean operations tests (#3806) No new revisions were added by this update. Summary of changes: .../sql/cast/test_boolean_cast.test| 74 ++ .../sql/cast/test_boolean_cast.test_ignore | 160 - 2 files changed, 47 insertions(+), 187 deletions(-) delete mode 100644 modules/sql-engine/src/integrationTest/sql/cast/test_boolean_cast.test_ignore
(ignite-3) branch ignite-19331 updated (9d887148b6 -> 73fc69b6c0)
This is an automated email from the ASF dual-hosted git repository.
amashenkov pushed a change to branch ignite-19331
in repository https://gitbox.apache.org/repos/asf/ignite-3.git
from 9d887148b6 minor
add 0bb1e4eadb IGNITE-21980: Extend test coverage for SQL F861(Top-level
in ) (#3780)
add 1ae5d75b97 IGNITE-22149 Java thin: Implement partition API (#3764)
add bbe3306849 IGNITE-22120: Sql. Possibility set zero length for
character string type (#3782)
add 639fc32d71 IGNITE-21983 Extend test coverage for SQL T031(BOOLEAN data
type) (#3802)
add 73fc69b6c0 Merge branch 'main' into ignite-19331
No new revisions were added by this update.
Summary of changes:
.../org/apache/ignite/network/NodeMetadata.java| 9 ++
.../internal/catalog/commands/ColumnParams.java| 12 +-
.../catalog/ColumnConstructionValidatorTest.java | 17 ++-
.../ignite/internal/client/proto/ClientOp.java | 3 +
.../handler/ClientInboundMessageHandler.java | 3 +
.../cluster/ClientClusterGetNodesRequest.java | 25 ++-
...blePartitionPrimaryReplicasNodesGetRequest.java | 65
.../apache/ignite/client/ClientOperationType.java | 8 +-
.../org/apache/ignite/client/RetryReadPolicy.java | 1 +
.../apache/ignite/internal/client/ClientUtils.java | 3 +
.../ignite/internal/client/TcpIgniteClient.java| 27 +++-
.../client/table/ClientPartitionManager.java | 169 +
.../ignite/internal/client/table/ClientTable.java | 13 +-
.../internal/table/partition/HashPartition.java| 0
.../ItAbstractPartitionManagerTest.java} | 59 +--
.../ItStandalonePartitionManagerTest.java} | 13 +-
.../ItThinClientPartitionManagerTest.java} | 22 +--
.../internal/sql/engine/ItCreateTableDdlTest.java | 27
.../internal/sql/engine/ItDataTypesTest.java | 36 +
.../sql/cast/test_boolean_cast.test| 2 +-
.../sql/function/string/test_char_length.test | 19 +++
.../function/string/test_char_length.test_ignore | 9 --
.../src/integrationTest/sql/order/test_offset.test | 50 ++
.../integrationTest/sql/types/blob/test_blob.test | 12 ++
.../sql/types/boolean/test_boolean_type.test | 120 +++
.../sql/types/char/test_char_length.test | 20 ++-
.../sql/types/null/test_boolean_null.test | 2 +-
.../sql/engine/prepare/IgniteSqlValidator.java | 5 +
.../internal/sql/engine/util/IgniteResource.java | 3 +
29 files changed, 681 insertions(+), 73 deletions(-)
create mode 100644
modules/client-handler/src/main/java/org/apache/ignite/client/handler/requests/table/partition/ClientTablePartitionPrimaryReplicasNodesGetRequest.java
create mode 100644
modules/client/src/main/java/org/apache/ignite/internal/client/table/ClientPartitionManager.java
rename modules/{table =>
core}/src/main/java/org/apache/ignite/internal/table/partition/HashPartition.java
(100%)
rename
modules/runner/src/integrationTest/java/org/apache/ignite/internal/table/{ItPartitionManagerTest.java
=> partition/ItAbstractPartitionManagerTest.java} (64%)
copy
modules/{cli/src/main/java/org/apache/ignite/internal/cli/core/repl/ConnectionRestoredEvent.java
=>
runner/src/integrationTest/java/org/apache/ignite/internal/table/partition/ItStandalonePartitionManagerTest.java}
(67%)
copy
modules/{sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItNotNullConstraintClientTest.java
=>
runner/src/integrationTest/java/org/apache/ignite/internal/table/partition/ItThinClientPartitionManagerTest.java}
(69%)
delete mode 100644
modules/sql-engine/src/integrationTest/sql/function/string/test_char_length.test_ignore
create mode 100644
modules/sql-engine/src/integrationTest/sql/order/test_offset.test
create mode 100644
modules/sql-engine/src/integrationTest/sql/types/boolean/test_boolean_type.test
(ignite-3) branch ignite-21983 deleted (was e3a7be1190)
This is an automated email from the ASF dual-hosted git repository. amashenkov pushed a change to branch ignite-21983 in repository https://gitbox.apache.org/repos/asf/ignite-3.git was e3a7be1190 minor The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
(ignite-3) branch main updated: IGNITE-21983 Extend test coverage for SQL T031(BOOLEAN data type) (#3802)
This is an automated email from the ASF dual-hosted git repository. amashenkov pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/ignite-3.git The following commit(s) were added to refs/heads/main by this push: new 639fc32d71 IGNITE-21983 Extend test coverage for SQL T031(BOOLEAN data type) (#3802) 639fc32d71 is described below commit 639fc32d71f293954dbdf5af9da1a3409c39254e Author: Andrew V. Mashenkov AuthorDate: Thu May 23 11:27:14 2024 +0300 IGNITE-21983 Extend test coverage for SQL T031(BOOLEAN data type) (#3802) --- .../sql/cast/test_boolean_cast.test| 2 +- .../sql/cast/test_boolean_cast.test_ignore | 2 +- .../sql/types/boolean/test_boolean_type.test | 120 + .../sql/types/null/test_boolean_null.test | 2 +- 4 files changed, 123 insertions(+), 3 deletions(-) diff --git a/modules/sql-engine/src/integrationTest/sql/cast/test_boolean_cast.test b/modules/sql-engine/src/integrationTest/sql/cast/test_boolean_cast.test index 05f24475c4..6aa541a340 100644 --- a/modules/sql-engine/src/integrationTest/sql/cast/test_boolean_cast.test +++ b/modules/sql-engine/src/integrationTest/sql/cast/test_boolean_cast.test @@ -1,5 +1,5 @@ # name: test/sql/cast/test_boolean_cast.test -# description: Test boolean casts +# description: SQL feature T031(BOOLEAN data type). Cast operator. # group: [cast] # Ignored with https://issues.apache.org/jira/browse/IGNITE-19331 diff --git a/modules/sql-engine/src/integrationTest/sql/cast/test_boolean_cast.test_ignore b/modules/sql-engine/src/integrationTest/sql/cast/test_boolean_cast.test_ignore index 9a90c2a5cb..3827986b3a 100644 --- a/modules/sql-engine/src/integrationTest/sql/cast/test_boolean_cast.test_ignore +++ b/modules/sql-engine/src/integrationTest/sql/cast/test_boolean_cast.test_ignore @@ -1,5 +1,5 @@ # name: test/sql/cast/test_boolean_cast.test -# description: Test boolean casts +# description: SQL feature T031(BOOLEAN data type). Cast operator. # group: [cast] # Ignored with https://issues.apache.org/jira/browse/IGNITE-19331 diff --git a/modules/sql-engine/src/integrationTest/sql/types/boolean/test_boolean_type.test b/modules/sql-engine/src/integrationTest/sql/types/boolean/test_boolean_type.test new file mode 100644 index 00..01fdd81f78 --- /dev/null +++ b/modules/sql-engine/src/integrationTest/sql/types/boolean/test_boolean_type.test @@ -0,0 +1,120 @@ +# name: test/sql/cast/test_boolean_type.test +# description: SQL feature T031(BOOLEAN data type) +# group: [cast] + +statement ok +CREATE TABLE test (a INTEGER, b BOOLEAN); + +# Specification does not make a distinction between the null value of the boolean data type and the truth value Unknown. +# They may be used interchangeably to mean exactly the same thing. +# ::= +# TRUE +#| FALSE +#| UNKNOWN +statement ok +INSERT INTO test VALUES (1, TRUE), (2, FALSE), (3, NULL); + +# IS [NOT] (TRUE|FALSE|UNKNOWN) +query TT +SELECT b IS TRUE, b IS NOT TRUE FROM test ORDER BY a; + +true false +false true +false true + +query TT +SELECT b IS FALSE, b IS NOT FALSE FROM test ORDER BY a; + +false true +true false +false true + +skipif ignite3 +# Ignored: lack of supporting UNKNOWN keyword https://issues.apache.org/jira/browse/IGNITE-22297 +query TT +SELECT b IS UNKNOWN, b IS NOT UNKNOWN FROM test ORDER BY a; + +false true +false true +true false + +# IS [NOT] NULL +query TT +SELECT b IS NULL, b IS NOT NULL FROM test ORDER BY a; + +false true +false true +true false + + +# Comparison to null is always unknown +query T +SELECT a FROM test WHERE b = NULL ORDER BY a; + + +# The correct way to search NULLs +query T +SELECT a FROM test WHERE b IS NULL ORDER BY a; + +3 + +skipif ignite3 +# Ignored: lack of supporting UNKNOWN keyword https://issues.apache.org/jira/browse/IGNITE-22297 +query T +SELECT a FROM test WHERE b IS UNKNOWN ORDER BY a; + +3 + +# P or not P is not always true. +# The result of the comparison col = null is UNKNOWN in both cases; +# NOT(UNKNOWN) is also UNKNOWN; +# OR only evaluates as true if one operand is true. +query T +SELECT a FROM test WHERE (b = NULL) OR NOT (b = NULL) ORDER BY a; + + +# NOT IN (NULL, …) is never true +query T +SELECT a FROM test WHERE b NOT IN (NULL, TRUE) ORDER BY a; + + +query T +SELECT a FROM test WHERE b NOT IN (NULL, FALSE) ORDER BY a; + + + +# AND +skipif ignite3 +# Ignored: lack of supporting UNKNOWN keyword https://issues.apache.org/jira/browse/IGNITE-22297 +query TTT +SELECT b AND TRUE, b AND FALSE, b AND UNKNOWN FROM test ORDER BY a; + +true false null +false false false +true false null + + +query TTT +SELECT b AND TRUE, b AND FALSE, b AND (1 = NULL) FROM test ORDER BY a; + +true false null +false false false +null false null + + +# OR +skipif ignite3 +# Ignored: lack of supporting UNKNOWN keyword https://issues.apache.org/jira/browse/IGNITE-22297 +query TTT
(ignite-3) branch ignite-19331 updated (a1f2bc6d44 -> 9d887148b6)
This is an automated email from the ASF dual-hosted git repository. amashenkov pushed a change to branch ignite-19331 in repository https://gitbox.apache.org/repos/asf/ignite-3.git discard a1f2bc6d44 minor add 9d887148b6 minor This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (a1f2bc6d44) \ N -- N -- N refs/heads/ignite-19331 (9d887148b6) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. No new revisions were added by this update. Summary of changes: modules/sql-engine/src/integrationTest/sql/cast/test_boolean_cast.test | 3 +++ 1 file changed, 3 insertions(+)
(ignite-3) branch ignite-19331 updated (b03bdb7a92 -> a1f2bc6d44)
This is an automated email from the ASF dual-hosted git repository. amashenkov pushed a change to branch ignite-19331 in repository https://gitbox.apache.org/repos/asf/ignite-3.git from b03bdb7a92 wip add a1f2bc6d44 minor No new revisions were added by this update. Summary of changes: .../src/integrationTest/sql/cast/test_boolean_cast.test| 10 -- 1 file changed, 10 deletions(-)
(ignite-3) 01/01: wip
This is an automated email from the ASF dual-hosted git repository.
amashenkov pushed a commit to branch ignite-19331
in repository https://gitbox.apache.org/repos/asf/ignite-3.git
commit b03bdb7a9258c23b11e30696ec28152fc11950e4
Author: amashenkov
AuthorDate: Wed May 22 16:00:42 2024 +0300
wip
---
.../sql/cast/test_boolean_cast.test| 81 +++
.../sql/cast/test_boolean_cast.test_ignore | 160 -
2 files changed, 54 insertions(+), 187 deletions(-)
diff --git
a/modules/sql-engine/src/integrationTest/sql/cast/test_boolean_cast.test
b/modules/sql-engine/src/integrationTest/sql/cast/test_boolean_cast.test
index 05f24475c4..9a2fc2a0d5 100644
--- a/modules/sql-engine/src/integrationTest/sql/cast/test_boolean_cast.test
+++ b/modules/sql-engine/src/integrationTest/sql/cast/test_boolean_cast.test
@@ -1,7 +1,6 @@
# name: test/sql/cast/test_boolean_cast.test
# description: Test boolean casts
# group: [cast]
-# Ignored with https://issues.apache.org/jira/browse/IGNITE-19331
statement ok
PRAGMA enable_verification
@@ -36,60 +35,88 @@ SELECT CAST('FALSE' AS BOOLEAN)
false
-statement error
-SELECT CAST('12345' AS BOOLEAN)
+query T
+SELECT CAST(NULL AS BOOLEAN)
+
+null
+
+query T
+SELECT CAST(NULL AS BOOLEAN)
+
+null
+
+query T
+SELECT CAST((1 = NULL) AS BOOLEAN)
+
+null
-statement error
-SELECT CAST(CAST('12345' AS INTEGER) AS BOOLEAN)
+query T
+SELECT CAST((1 = NULL) AS BOOLEAN)
+
+null
-statement error
-SELECT CAST(CAST('0' AS INTEGER) AS BOOLEAN)
+statement error: Invalid character for cast: 1
+SELECT CAST('1' AS BOOLEAN)
-statement error
+statement error: Cast function cannot convert value of type TINYINT to type
BOOLEAN
SELECT CAST(CAST('1' AS tinyint) AS BOOLEAN)
-statement error
+statement error: Cast function cannot convert value of type TINYINT to type
BOOLEAN
SELECT CAST(CAST('0' AS tinyint) AS BOOLEAN)
-statement error
+statement error: Cast function cannot convert value of type SMALLINT to type
BOOLEAN
SELECT CAST(CAST('1' AS smallint) AS BOOLEAN)
-statement error
+statement error: Cast function cannot convert value of type SMALLINT to type
BOOLEAN
SELECT CAST(CAST('0' AS smallint) AS BOOLEAN)
-statement error
+statement error: Cast function cannot convert value of type INTEGER to type
BOOLEAN
SELECT CAST(CAST('1' AS integer) AS BOOLEAN)
-statement error
+statement error: Cast function cannot convert value of type INTEGER to type
BOOLEAN
SELECT CAST(CAST('0' AS integer) AS BOOLEAN)
-statement error
+statement error: Cast function cannot convert value of type BIGINT to type
BOOLEAN
SELECT CAST(CAST('1' AS bigint) AS BOOLEAN)
-statement error
+statement error: Cast function cannot convert value of type BIGINT to type
BOOLEAN
SELECT CAST(CAST('0' AS bigint) AS BOOLEAN)
-statement error
+statement error: Cast function cannot convert value of type DECIMAL(32767, 0)
to type BOOLEAN
SELECT CAST(CAST('1' AS decimal) AS BOOLEAN)
-statement error
+statement error: Cast function cannot convert value of type DECIMAL(32767, 0)
to type BOOLEAN
SELECT CAST(CAST('0' AS decimal) AS BOOLEAN)
-statement error
+statement error: Cast function cannot convert value of type DECIMAL(1, 0) to
type BOOLEAN
SELECT CAST(CAST('1' AS decimal(1,0)) AS BOOLEAN)
-statement error
+statement error: Cast function cannot convert value of type DECIMAL(1, 0) to
type BOOLEAN
SELECT CAST(CAST('0' AS decimal(1,0)) AS BOOLEAN)
-statement error
-SELECT CAST(CAST('1' AS decimal(9,0)) AS BOOLEAN)
+statement error: Cast function cannot convert value of type FLOAT to type
BOOLEAN
+SELECT CAST(CAST('1' AS float) AS BOOLEAN)
+
+statement error: Cast function cannot convert value of type FLOAT to type
BOOLEAN
+SELECT CAST(CAST('0' AS float) AS BOOLEAN)
+
+statement error: Cast function cannot convert value of type DOUBLE to type
BOOLEAN
+SELECT CAST(CAST('1' AS double) AS BOOLEAN)
+
+statement error: Cast function cannot convert value of type DOUBLE to type
BOOLEAN
+SELECT CAST(CAST('0' AS double) AS BOOLEAN)
+
+statement error: Cast function cannot convert value of type DATE to type
BOOLEAN
+SELECT CAST(CAST('1970-1-1' AS date) AS BOOLEAN)
-statement error
-SELECT CAST(CAST('0' AS decimal(9,0)) AS BOOLEAN)
+statement error: Cast function cannot convert value of type TIME(0) to type
BOOLEAN
+SELECT CAST(CAST('00:00:00' AS time) AS BOOLEAN)
-statement error
-SELECT CAST(CAST('1' AS decimal(38,0)) AS BOOLEAN)
+statement error: Cast function cannot convert value of type TIME(9) to type
BOOLEAN
+SELECT CAST(CAST('00:00:00.0' AS time(9)) AS BOOLEAN)
-statement error
-SELECT CAST(CAST('0' AS decimal(38,0)) AS BOOLEAN)
+statement error: Cast function cannot convert value of type TIMESTAMP(6) to
type BOOLEAN
+SELECT CAST(CAST('1970-1-1 00:00:00' AS timestamp) AS BOOLEAN)
+statement error: Cast function cannot convert value of type TIMESTAMP(9) to
type BOOLEAN
+SELECT CAST(CAST('1970-1-1 00:00
(ignite-3) branch ignite-19331 created (now b03bdb7a92)
This is an automated email from the ASF dual-hosted git repository. amashenkov pushed a change to branch ignite-19331 in repository https://gitbox.apache.org/repos/asf/ignite-3.git at b03bdb7a92 wip This branch includes the following new commits: new b03bdb7a92 wip The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
(ignite-3) branch ignite-21983 updated (14eba2c7be -> e3a7be1190)
This is an automated email from the ASF dual-hosted git repository. amashenkov pushed a change to branch ignite-21983 in repository https://gitbox.apache.org/repos/asf/ignite-3.git from 14eba2c7be minor add 5fb15c2cb3 IGNITE-22108 Rename options in CLI (#3750) add 16caf8f396 IGNITE-19103 Sql. Change implicit primary key column's type to UUID (#3786) add d3b98e7f14 Merge branch 'main' into ignite-21983 add e3a7be1190 minor No new revisions were added by this update. Summary of changes: DEVNOTES.md| 4 +- README.md | 4 +- assembly/README.md | 4 +- .../administrators-guide/config/memory-quotas.adoc | 6 +- docs/_docs/ignite-cli-tool.adoc| 60 +- docs/_docs/quick-start/getting-started-guide.adoc | 8 +- docs/_docs/sql-reference/grammar-reference.adoc| 6 +- .../ignite/example/sql/jdbc/SqlJdbcExample.java| 2 +- .../PersistentPageMemoryStorageExample.java| 2 +- .../example/storage/RocksDbStorageExample.java | 2 +- .../storage/VolatilePageMemoryStorageExample.java | 2 +- .../ignite/example/table/KeyValueViewExample.java | 2 +- .../example/table/KeyValueViewPojoExample.java | 2 +- .../ignite/example/table/RecordViewExample.java| 2 +- .../example/table/RecordViewPojoExample.java | 2 +- .../ignite/example/tx/TransactionsExample.java | 2 +- .../commands/AlterTableAlterColumnCommand.java | 2 +- .../internal/catalog/commands/CatalogUtils.java| 24 ++-- .../catalog/commands/CreateTableCommand.java | 2 +- .../AlterTableAddColumnCommandValidationTest.java | 2 +- ...AlterTableAlterColumnCommandValidationTest.java | 13 +-- .../commands/CreateTableCommandValidationTest.java | 3 +- modules/cli/README.md | 8 +- .../internal/cli/commands/ItNodeNameTest.java | 6 +- .../ItClusterConfigCommandNotInitializedTest.java | 2 +- .../commands/cluster/init/ItClusterInitTest.java | 4 +- .../ItClusterStatusCommandInitializedTest.java | 2 +- .../ItClusterStatusCommandNotInitializedTest.java | 2 +- .../ItTopologyCommandInitializedClusterTest.java | 4 +- ...ItTopologyCommandNotInitializedClusterTest.java | 4 +- .../configuration/ItConfigCommandTest.java | 34 +++--- .../metric/ItEnabledNodeMetricCommandTest.java | 4 +- .../commands/metric/ItNodeMetricCommandTest.java | 6 +- .../cli/commands/node/NodeVersionCommandTest.java | 2 +- .../cli/commands/sql/ItSqlCommandTest.java | 4 +- .../cli/commands/sql/ItSqlReplCommandTest.java | 4 +- .../cli/commands/unit/ItDeploymentUnitTest.java| 8 +- .../repl/executor/ItIgnitePicocliCommandsTest.java | 60 +- .../ignite/internal/cli/commands/Options.java | 125 - .../ignite/internal/cli/commands/ProfileMixin.java | 3 +- .../profile/CliConfigProfileCreateCommand.java | 6 +- .../cli/commands/cluster/ClusterUrlMixin.java | 3 +- .../commands/cluster/init/ClusterInitOptions.java | 17 +-- .../cluster/unit/ClusterUnitUndeployCommand.java | 5 +- .../unit/ClusterUnitUndeployReplCommand.java | 5 +- .../cluster/unit/UnitDeployOptionsMixin.java | 14 +-- .../internal/cli/commands/node/NodeUrlMixin.java | 3 +- .../cli/commands/node/NodeUrlProfileMixin.java | 3 +- .../internal/cli/commands/sql/SqlCommand.java | 7 +- .../internal/cli/commands/sql/SqlReplCommand.java | 9 +- .../cli/core/repl/completer/CompleterConf.java | 2 +- .../cluster/ClusterUrlDynamicCompleterFactory.java | 2 +- .../completer/filter/DynamicCompleterFilter.java | 5 +- .../node/NodeNameDynamicCompleterFactory.java | 2 +- .../internal/cli/commands/ProfileMixinTest.java| 12 +- .../cli/commands/UrlOptionsNegativeTest.java | 39 --- .../cli/commands/cluster/ClusterInitTest.java | 38 +++ .../commands/cluster/config/ClusterConfigTest.java | 12 +- .../cli/commands/node/config/NodeConfigTest.java | 12 +- .../cli/commands/node/metric/NodeMetricTest.java | 8 +- .../internal/cli/commands/sql/SqlCommandTest.java | 10 +- .../core/repl/SessionDefaultValueProviderTest.java | 3 +- .../repl/completer/HoconDynamicCompleterTest.java | 8 +- .../filter/DynamicCompleterFilterTest.java | 14 +-- .../filter/NonRepeatableOptionsFilterTest.java | 6 +- .../internal/schema/DefaultValueGenerator.java | 10 +- .../CatalogToSchemaDescriptorConverterTest.java| 2 +- .../sql/engine/ItAlterTableAlterColumnTest.java| 10 +- .../internal/sql/engine/ItCreateTableDdlTest.java | 8 +- .../sql/engine/ItHashSpoolIntegrationTest.java | 6 +- .../sql/types/null/test_boolean_null.test | 6 +- .../sql/engine/exec/exp/IgniteSqlFunctions.java| 6 +- .../internal/sql/engine/exec
(ignite-3) branch ignite-21983 updated (84e58f0dda -> 14eba2c7be)
This is an automated email from the ASF dual-hosted git repository. amashenkov pushed a change to branch ignite-21983 in repository https://gitbox.apache.org/repos/asf/ignite-3.git omit 84e58f0dda minor omit a67d4d92fd minor This update removed existing revisions from the reference, leaving the reference pointing at a previous point in the repository history. * -- * -- N refs/heads/ignite-21983 (14eba2c7be) \ O -- O -- O (84e58f0dda) Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. No new revisions were added by this update. Summary of changes: .../sql/cast/test_boolean_cast.test| 56 .../sql/cast/test_boolean_cast.test_ignore | 160 + 2 files changed, 216 insertions(+) create mode 100644 modules/sql-engine/src/integrationTest/sql/cast/test_boolean_cast.test_ignore
(ignite-3) branch ignite-21983 updated (a67d4d92fd -> 84e58f0dda)
This is an automated email from the ASF dual-hosted git repository. amashenkov pushed a change to branch ignite-21983 in repository https://gitbox.apache.org/repos/asf/ignite-3.git from a67d4d92fd minor add 84e58f0dda minor No new revisions were added by this update. Summary of changes: .../sql/cast/test_boolean_cast.test| 168 - 1 file changed, 168 deletions(-)
(ignite-3) branch ignite-21983 updated (14eba2c7be -> a67d4d92fd)
This is an automated email from the ASF dual-hosted git repository. amashenkov pushed a change to branch ignite-21983 in repository https://gitbox.apache.org/repos/asf/ignite-3.git from 14eba2c7be minor add a67d4d92fd minor No new revisions were added by this update. Summary of changes: .../sql/cast/test_boolean_cast.test| 150 --- .../sql/cast/test_boolean_cast.test_ignore | 160 - 2 files changed, 131 insertions(+), 179 deletions(-) delete mode 100644 modules/sql-engine/src/integrationTest/sql/cast/test_boolean_cast.test_ignore
(ignite-3) branch ignite-21983 updated (dfc16c0e80 -> 14eba2c7be)
This is an automated email from the ASF dual-hosted git repository. amashenkov pushed a change to branch ignite-21983 in repository https://gitbox.apache.org/repos/asf/ignite-3.git omit dfc16c0e80 minor add 14eba2c7be minor This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (dfc16c0e80) \ N -- N -- N refs/heads/ignite-21983 (14eba2c7be) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. No new revisions were added by this update. Summary of changes: .../java/org/apache/ignite/internal/sql/sqllogic/ItSqlLogicTest.java| 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
(ignite-3) branch ignite-21983 updated (e3225fd3b8 -> dfc16c0e80)
This is an automated email from the ASF dual-hosted git repository. amashenkov pushed a change to branch ignite-21983 in repository https://gitbox.apache.org/repos/asf/ignite-3.git from e3225fd3b8 minor add dfc16c0e80 minor No new revisions were added by this update. Summary of changes: .../java/org/apache/ignite/internal/sql/sqllogic/ItSqlLogicTest.java| 2 +- .../src/integrationTest/sql/types/null/test_boolean_null.test | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
(ignite-3) branch ignite-21983 updated (607529f94b -> e3225fd3b8)
This is an automated email from the ASF dual-hosted git repository. amashenkov pushed a change to branch ignite-21983 in repository https://gitbox.apache.org/repos/asf/ignite-3.git from 607529f94b wip add e3225fd3b8 minor No new revisions were added by this update. Summary of changes: .../src/integrationTest/sql/types/boolean/test_boolean_type.test | 8 1 file changed, 4 insertions(+), 4 deletions(-)
(ignite-3) 01/01: wip
This is an automated email from the ASF dual-hosted git repository. amashenkov pushed a commit to branch ignite-21983 in repository https://gitbox.apache.org/repos/asf/ignite-3.git commit 607529f94b1572a49b398ec9354b21436e65f643 Author: amashenkov AuthorDate: Tue May 21 19:23:17 2024 +0300 wip --- .../sql/cast/test_boolean_cast.test| 2 +- .../sql/cast/test_boolean_cast.test_ignore | 2 +- .../sql/types/boolean/test_boolean_type.test | 120 + .../sql/types/null/test_boolean_null.test | 6 +- 4 files changed, 125 insertions(+), 5 deletions(-) diff --git a/modules/sql-engine/src/integrationTest/sql/cast/test_boolean_cast.test b/modules/sql-engine/src/integrationTest/sql/cast/test_boolean_cast.test index 05f24475c4..6aa541a340 100644 --- a/modules/sql-engine/src/integrationTest/sql/cast/test_boolean_cast.test +++ b/modules/sql-engine/src/integrationTest/sql/cast/test_boolean_cast.test @@ -1,5 +1,5 @@ # name: test/sql/cast/test_boolean_cast.test -# description: Test boolean casts +# description: SQL feature T031(BOOLEAN data type). Cast operator. # group: [cast] # Ignored with https://issues.apache.org/jira/browse/IGNITE-19331 diff --git a/modules/sql-engine/src/integrationTest/sql/cast/test_boolean_cast.test_ignore b/modules/sql-engine/src/integrationTest/sql/cast/test_boolean_cast.test_ignore index 9a90c2a5cb..3827986b3a 100644 --- a/modules/sql-engine/src/integrationTest/sql/cast/test_boolean_cast.test_ignore +++ b/modules/sql-engine/src/integrationTest/sql/cast/test_boolean_cast.test_ignore @@ -1,5 +1,5 @@ # name: test/sql/cast/test_boolean_cast.test -# description: Test boolean casts +# description: SQL feature T031(BOOLEAN data type). Cast operator. # group: [cast] # Ignored with https://issues.apache.org/jira/browse/IGNITE-19331 diff --git a/modules/sql-engine/src/integrationTest/sql/types/boolean/test_boolean_type.test b/modules/sql-engine/src/integrationTest/sql/types/boolean/test_boolean_type.test new file mode 100644 index 00..0b32409abb --- /dev/null +++ b/modules/sql-engine/src/integrationTest/sql/types/boolean/test_boolean_type.test @@ -0,0 +1,120 @@ +# name: test/sql/cast/test_boolean_type.test +# description: SQL feature T031(BOOLEAN data type) +# group: [cast] + +statement ok +CREATE TABLE test (a INTEGER, b BOOLEAN); + +# Specification does not make a distinction between the null value of the boolean data type and the truth value Unknown. +# They may be used interchangeably to mean exactly the same thing. +# ::= +# TRUE +#| FALSE +#| UNKNOWN +statement ok +INSERT INTO test VALUES (1, TRUE), (2, FALSE), (3, NULL); + +# IS [NOT] (TRUE|FALSE|UNKNOWN) +query TT +SELECT b IS TRUE, b IS NOT TRUE FROM test ORDER BY a; + +true false +false true +false true + +query TT +SELECT b IS FALSE, b IS NOT FALSE FROM test ORDER BY a; + +false true +true false +false true + +skipif ignite3 +# Ignored: lack of supporting UNKNOWN keyword +query TT +SELECT b IS UNKNOWN, b IS NOT UNKNOWN FROM test ORDER BY a; + +false true +false true +true false + +# IS [NOT] NULL +query TT +SELECT b IS NULL, b IS NOT NULL FROM test ORDER BY a; + +false true +false true +true false + + +# Comparison to null is always unknown +query T +SELECT a FROM test WHERE b = NULL ORDER BY a; + + +# The correct way to search NULLs +query T +SELECT a FROM test WHERE b IS NULL ORDER BY a; + +3 + +skipif ignite3 +# Ignored: lack of supporting UNKNOWN keyword +query T +SELECT a FROM test WHERE b IS UNKNOWN ORDER BY a; + +3 + +# P or not P is not always true. +# The result of the comparison col = null is UNKNOWN in both cases; +# NOT(UNKNOWN) is also UNKNOWN; +# OR only evaluates as true if one operand is true. +query T +SELECT a FROM test WHERE (b = NULL) OR NOT (b = NULL) ORDER BY a; + + +# NOT IN (NULL, …) is never true +query T +SELECT a FROM test WHERE b NOT IN (NULL, TRUE) ORDER BY a; + + +query T +SELECT a FROM test WHERE b NOT IN (NULL, FALSE) ORDER BY a; + + + +# AND +skipif ignite3 +# Ignored: lack of supporting UNKNOWN keyword +query TTT +SELECT b AND TRUE, b AND FALSE, b AND UNKNOWN FROM test ORDER BY a; + +true false null +false false false +true false null + + +query TTT +SELECT b AND TRUE, b AND FALSE, b AND (1 = NULL) FROM test ORDER BY a; + +true false null +false false false +null false null + + +# OR +skipif ignite3 +# Ignored: lack of supporting UNKNOWN keyword +query TTT +SELECT b OR TRUE, b OR FALSE, b OR UNKNOWN FROM test ORDER BY a; + +true truetrue +true false null +true nullnull + +query TTT +SELECT b OR TRUE, b OR FALSE, b OR NULL FROM test ORDER BY a; + +true truetrue +true false null +true nullnull diff --git a/modules/sql-engine/src/integrationTest/sql/types/null/test_boolean_null.test b/modules/sql-engine/src/integrationTest/sql/types/null/test_boolean_null.test index 0f39ce1fa5
(ignite-3) branch ignite-21983 created (now 607529f94b)
This is an automated email from the ASF dual-hosted git repository. amashenkov pushed a change to branch ignite-21983 in repository https://gitbox.apache.org/repos/asf/ignite-3.git at 607529f94b wip This branch includes the following new commits: new 607529f94b wip The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
(ignite-3) branch main updated (7ae9ab763e -> 044ac6deca)
This is an automated email from the ASF dual-hosted git repository. amashenkov pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/ignite-3.git from 7ae9ab763e Bump jackson from 2.17.0 to 2.17.1 (#3706) add 044ac6deca IGNITE-19670: Improve CatalogService test coverage. (#3751) No new revisions were added by this update. Summary of changes: .../ignite/internal/catalog/CatalogIndexTest.java | 872 ++ .../internal/catalog/CatalogManagerSelfTest.java | 2763 ++-- .../ignite/internal/catalog/CatalogSchemaTest.java | 49 + .../ignite/internal/catalog/CatalogTableTest.java | 1168 + .../ignite/internal/catalog/CatalogZoneTest.java | 503 .../internal/catalog/BaseCatalogManagerTest.java | 48 +- 6 files changed, 2811 insertions(+), 2592 deletions(-) create mode 100644 modules/catalog/src/test/java/org/apache/ignite/internal/catalog/CatalogIndexTest.java create mode 100644 modules/catalog/src/test/java/org/apache/ignite/internal/catalog/CatalogSchemaTest.java create mode 100644 modules/catalog/src/test/java/org/apache/ignite/internal/catalog/CatalogTableTest.java create mode 100644 modules/catalog/src/test/java/org/apache/ignite/internal/catalog/CatalogZoneTest.java
(ignite-3) branch main updated: IGNITE-21942 Cover SQL F393(Unicode escapes in literals) feature by tests (#3746)
This is an automated email from the ASF dual-hosted git repository. amashenkov pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/ignite-3.git The following commit(s) were added to refs/heads/main by this push: new dc741be3b6 IGNITE-21942 Cover SQL F393(Unicode escapes in literals) feature by tests (#3746) dc741be3b6 is described below commit dc741be3b6bd9136d00a38a4999c0644e567f570 Author: Andrew V. Mashenkov AuthorDate: Wed May 15 23:09:13 2024 +0300 IGNITE-21942 Cover SQL F393(Unicode escapes in literals) feature by tests (#3746) --- .../test_unicode_escapes_in_literals.test_ignored | 51 ++ 1 file changed, 51 insertions(+) diff --git a/modules/sql-engine/src/integrationTest/sql/types/string/test_unicode_escapes_in_literals.test_ignored b/modules/sql-engine/src/integrationTest/sql/types/string/test_unicode_escapes_in_literals.test_ignored new file mode 100644 index 00..86c2af763f --- /dev/null +++ b/modules/sql-engine/src/integrationTest/sql/types/string/test_unicode_escapes_in_literals.test_ignored @@ -0,0 +1,51 @@ +# name: test/sql/types/string/test_unicode_escapes_in_literals.test +# description: SQL feature F393 (Unicode escapes in literals) +# group: [string] +# Ignore: https://issues.apache.org/jira/browse/IGNITE-1 + +# insert unicode strings into the database +statement ok +CREATE TABLE t(id INTEGER, s VARCHAR); + +statement ok +INSERT INTO t VALUES (1, U&'d\0061t\0061'), (2, U&'d\+61t\+61') + +# retrieve unicode strings again +query IT +SELECT * FROM t ORDER BY id + +1 data +2 data + +query IT +SELECT * FROM t WHERE s = U&'d\0061t\0061' ORDER BY id + +1 data +2 data + +query IT +SELECT * FROM t WHERE s = U&'d\+61t\+61' ORDER BY id + +1 data +2 data + + +# substring on t +query TT +SELECT substring(s, 1, 2), substring(s, 3, 2) FROM t ORDER BY id + +da ta +da ta + +# length on t +query I +SELECT length(s) FROM t ORDER BY id + +4 +4 + +query I +SELECT octet_length(s) FROM t ORDER BY id + +4 +4
(ignite-3) branch ignite-21942 deleted (was e66cbdbdbe)
This is an automated email from the ASF dual-hosted git repository. amashenkov pushed a change to branch ignite-21942 in repository https://gitbox.apache.org/repos/asf/ignite-3.git was e66cbdbdbe minor The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
(ignite-3) branch ignite-21942 updated (65e2184a5a -> e66cbdbdbe)
This is an automated email from the ASF dual-hosted git repository. amashenkov pushed a change to branch ignite-21942 in repository https://gitbox.apache.org/repos/asf/ignite-3.git from 65e2184a5a minor add e66cbdbdbe minor No new revisions were added by this update. Summary of changes: .../test_unicode_escapes_in_literals.test_ignored | 27 +++--- 1 file changed, 8 insertions(+), 19 deletions(-)
(ignite-3) branch ignite-21942 updated (7eabcaeec5 -> 65e2184a5a)
This is an automated email from the ASF dual-hosted git repository. amashenkov pushed a change to branch ignite-21942 in repository https://gitbox.apache.org/repos/asf/ignite-3.git discard 7eabcaeec5 minor discard cfc8192f51 wip. discard 470ac2db9d IGNITE-22184 Fix race in ItClusterManagerTest#testJoinInvalidTag (#3719) discard 1ef1a65d47 IGNITE-21977 Sql. Extend test coverage for SQL feature F661(Simple tables) (#3705) discard 135230f9cb IGNITE-21992 Fix remove-after-insert in Data Streamer within the same batch (#3713) discard 5df9f1738b IGNITE-21945 Sql. Cover SQL F855(Nested in ) (#3708) discard 8abf003d2f IGNITE-19091 Sql. Fix ItIgniteNodeRestartTest::testQueryCorrectnessAfterNodeRestart (#3712) discard 3d5bba7c75 Bump org.slf4j:slf4j-jdk14 from 2.0.12 to 2.0.13 (#3676) discard 39ff595e6b Bump com.github.spotbugs from 6.0.12 to 6.0.14 (#3707) discard 55f0396134 IGNITE-22175 Improve handling for RocksDb resources on RocksDbKeyValueStorage (#3709) discard 9ea610e7f4 IGNITE-22156 Replace inheritance with delegation for UpgradingRowAdapter class. (#3696) discard 72ecd1e0b8 IGNITE-22159: unmute tests (#3695) discard 434b9654ff IGNITE-22163 Fix potential NPE in IndexManager (#3699) discard 74af728bb7 IGNITE-21300 Implement disaster recovery for secondary indexes (#3698) discard 24c5a75cbf [IGNITE-21295] Implement REST API for manual raft group configuration update (#3701) discard 404afe35e5 [IGNITE-21999] Merge partition free-lists into one (#3615) discard 523b2ebf28 IGNITE-22128 Balancing partitions across stripes (#3690) discard 74aea836b3 [IGNITE-22091] Implement CLI for disaster recovery: partition states (#3668) discard 210af2bdb2 IGNITE-21962 Fix client tests relying on specific product version (#3693) discard e422c70e9f IGNITE-21732: Sql. Split TableRowConverterImpl on two different implementations (#3687) discard 1409d453dd IGNITE-22064 General MapReduce API (#3665) discard 2b2fa3de86 Bump com.netflix.nebula.ospackage from 11.8.1 to 11.9.0 (#3682) discard 0ef4f0ce7d IGNITE-21908 Add metrics of distribution among stripes in disruptor (#3645) discard 1db7a2afaf [IGNITE-22121] Change parameters for disaster recovery partition states api (#3671) discard f9dda4a9b2 IGNITE-21731 Sql. Split TableRowConverter#toBinaryRow on two methods (#3688) discard 0b2331b791 IGNITE-22147 Disabled ItTxResourcesVacuumTest.testRecoveryAfterPersistentStateVacuumized (#3686) discard af7c260189 IGNITE-18275 Remove obsolete TODOs (#3685) discard 423bba6c29 IGNITE-22086 Thin client: initialize observableTimestamp in handshake (#3679) discard 70d6f94c4f Bump io.github.bonede:tree-sitter from 0.22.2 to 0.22.5 (#3661) discard a0ff68cbff IGNITE-21763 Adjust TxnResourceVacuumTask in order to vacuum persistent txn state (#3591) discard ebf89c6c60 IGNITE-21859 Causality token stays 0 for default zone (#3653) discard 723fde0915 IGNITE-19762 Remove data region remnants from RocksDb storage (#3677) discard 214a0ee0b5 IGNITE-21720 Sql. Implement hash join (#3608) discard f5a5c64905 Bump io.github.bonede:tree-sitter-json from 0.20.1 to 0.21.0 (#3664) discard bbf995f868 IGNITE-22039 Getting rid of InconsistentIndexStateException for SortedIndexStorage#tolerantScan (#3674) discard 856fb0c080 IGNITE-22097 JobContext is not closed when job execution fails (#3656) discard dc7dc77897 IGNITE-21953: Cover SQL E021-01(Character string types. CHARACTER data type) feature by tests (#3660) discard 82349834ac IGNITE-22071 Async component stop (#3629) discard 57dc47d47e IGNITE-22113 Remove unused MetaStorageManagerImpl getAnd<> methods (#3670) discard b8d8939790 IGNITE-21938 Sql. Cover SQL F041-07 feature by tests (#3642) discard 5d4abc8b2c IGNITE-22116 Include underlying exception when reporting occupied port issue (#3667) discard 69e4c21c60 [IGNITE-21404] Do not wrap SqlException into RuntimeException for PlannerHelper.optimize. (#3625) discard 396981a953 Bump net.bytebuddy:byte-buddy from 1.14.12 to 1.14.14 (#3658) discard 2eded4f762 Bump org.openapi.generator from 7.4.0 to 7.5.0 (#3662) discard 2696c7dce1 Bump bouncycastle from 1.76 to 1.78.1 (#3663) discard 0978e1e6df Bump netty from 4.1.108.Final to 4.1.109.Final (#3657) discard 2402ff97e8 Bump org.threeten:threetenbp from 1.6.8 to 1.6.9 (#3494) discard 54b1beb46d Bump com.github.johnrengelman.shadow from 7.1.2 to 8.1.1 (#3397) discard e4da753dc1 IGNITE-22105 Add busy lock to RocksDbClusterStateStorage (#3659) discard 1153c61888 IGNITE-22095 Remove compute job jars from the repo (#3655) discard e61946b88f IGNITE-22093: Sql. Rename PlannerPhase::HEP_DECORRELATE (#3652) discard 7592b10137 IGNITE-21850 Enable LogSinkTest (#3646) discard 548e9e9b50 IGNITE-22075 GC doesn't wait for RO transactions (#3650) discard 2f4684818c IGNITE-21824 Revert workaround for jline bug (#3647) discard f950dd2f5c Bump org.rocksdb:rocksdbjni from 8.11.3 to 9.1.1 (#3654) discard 77cef26ade IGNITE-21435: Sql. Catalog Defaul
(ignite-3) branch ignite-21942 updated (fecf0b5f2c -> 7eabcaeec5)
This is an automated email from the ASF dual-hosted git repository. amashenkov pushed a change to branch ignite-21942 in repository https://gitbox.apache.org/repos/asf/ignite-3.git omit fecf0b5f2c minor omit a14e5b8c28 wip. omit 0a3ac8d91a IGNITE-22184 Fix race in ItClusterManagerTest#testJoinInvalidTag (#3719) omit 231b61e467 IGNITE-21977 Sql. Extend test coverage for SQL feature F661(Simple tables) (#3705) omit dac9b46b74 IGNITE-21992 Fix remove-after-insert in Data Streamer within the same batch (#3713) omit 865c02bf0b IGNITE-21945 Sql. Cover SQL F855(Nested in ) (#3708) omit 636a03c4d1 IGNITE-19091 Sql. Fix ItIgniteNodeRestartTest::testQueryCorrectnessAfterNodeRestart (#3712) omit b5d5999871 Bump org.slf4j:slf4j-jdk14 from 2.0.12 to 2.0.13 (#3676) omit 43c00984cf Bump com.github.spotbugs from 6.0.12 to 6.0.14 (#3707) omit 3182188010 IGNITE-22175 Improve handling for RocksDb resources on RocksDbKeyValueStorage (#3709) omit 8aabfa8277 IGNITE-22156 Replace inheritance with delegation for UpgradingRowAdapter class. (#3696) omit 6de12ae35e IGNITE-22159: unmute tests (#3695) omit e1012bf1b0 IGNITE-22163 Fix potential NPE in IndexManager (#3699) omit 80ff031014 IGNITE-21300 Implement disaster recovery for secondary indexes (#3698) omit 054ef3e484 [IGNITE-21295] Implement REST API for manual raft group configuration update (#3701) omit 7f93d63d09 [IGNITE-21999] Merge partition free-lists into one (#3615) omit 654a11a4a0 IGNITE-22128 Balancing partitions across stripes (#3690) omit 0a46272fa6 [IGNITE-22091] Implement CLI for disaster recovery: partition states (#3668) omit ef50f41d93 IGNITE-21962 Fix client tests relying on specific product version (#3693) omit 78e1ae6fca IGNITE-21732: Sql. Split TableRowConverterImpl on two different implementations (#3687) omit cb34325ecc IGNITE-22064 General MapReduce API (#3665) omit e034ed0e9b Bump com.netflix.nebula.ospackage from 11.8.1 to 11.9.0 (#3682) omit b02882dd7a IGNITE-21908 Add metrics of distribution among stripes in disruptor (#3645) omit 8749e4da5a [IGNITE-22121] Change parameters for disaster recovery partition states api (#3671) omit d65970556f IGNITE-21731 Sql. Split TableRowConverter#toBinaryRow on two methods (#3688) omit 193173cc92 IGNITE-22147 Disabled ItTxResourcesVacuumTest.testRecoveryAfterPersistentStateVacuumized (#3686) omit f7c25c937d IGNITE-18275 Remove obsolete TODOs (#3685) omit 66172ffc2c IGNITE-22086 Thin client: initialize observableTimestamp in handshake (#3679) omit 1aec35c848 Bump io.github.bonede:tree-sitter from 0.22.2 to 0.22.5 (#3661) omit 4bab4fa9c6 IGNITE-21763 Adjust TxnResourceVacuumTask in order to vacuum persistent txn state (#3591) omit 76d95724c8 IGNITE-21859 Causality token stays 0 for default zone (#3653) omit 6705eb6f36 IGNITE-19762 Remove data region remnants from RocksDb storage (#3677) omit e20961ff4d IGNITE-21720 Sql. Implement hash join (#3608) omit 1ee67f4cc9 Bump io.github.bonede:tree-sitter-json from 0.20.1 to 0.21.0 (#3664) omit 6cb005b220 IGNITE-22039 Getting rid of InconsistentIndexStateException for SortedIndexStorage#tolerantScan (#3674) omit 2dcb552102 IGNITE-22097 JobContext is not closed when job execution fails (#3656) omit 0574391709 IGNITE-21953: Cover SQL E021-01(Character string types. CHARACTER data type) feature by tests (#3660) omit fbf070b41f IGNITE-22071 Async component stop (#3629) omit bca08752e6 IGNITE-22113 Remove unused MetaStorageManagerImpl getAnd<> methods (#3670) omit bb7e31f6c7 IGNITE-21938 Sql. Cover SQL F041-07 feature by tests (#3642) omit c78b3e9a69 IGNITE-22116 Include underlying exception when reporting occupied port issue (#3667) omit 675e2e8781 [IGNITE-21404] Do not wrap SqlException into RuntimeException for PlannerHelper.optimize. (#3625) omit d92f8b4ad3 Bump net.bytebuddy:byte-buddy from 1.14.12 to 1.14.14 (#3658) omit f69cbcdd68 Bump org.openapi.generator from 7.4.0 to 7.5.0 (#3662) omit 55bd75a065 Bump bouncycastle from 1.76 to 1.78.1 (#3663) omit 126fc94467 Bump netty from 4.1.108.Final to 4.1.109.Final (#3657) omit 2db00e109c Bump org.threeten:threetenbp from 1.6.8 to 1.6.9 (#3494) omit da852ab811 Bump com.github.johnrengelman.shadow from 7.1.2 to 8.1.1 (#3397) omit 4871350087 IGNITE-22105 Add busy lock to RocksDbClusterStateStorage (#3659) omit a3bd2e5b6d IGNITE-22095 Remove compute job jars from the repo (#3655) omit b39659f90d IGNITE-22093: Sql. Rename PlannerPhase::HEP_DECORRELATE (#3652) omit 694f43b5be IGNITE-21850 Enable LogSinkTest (#3646) omit cfea5baaf2 IGNITE-22075 GC doesn't wait for RO transactions (#3650) omit d593e6487a IGNITE-21824 Revert workaround for jline bug (#3647) omit 478ee5de9f Bump org.rocksdb:rocksdbjni from 8.11.3 to 9.1.1 (#3654) omit 0f5618fde0 IGNITE-21435: Sql. Catalog Defaul
(ignite-3) branch ignite-21942 updated (a14e5b8c28 -> fecf0b5f2c)
This is an automated email from the ASF dual-hosted git repository. amashenkov pushed a change to branch ignite-21942 in repository https://gitbox.apache.org/repos/asf/ignite-3.git from a14e5b8c28 wip. add fecf0b5f2c minor No new revisions were added by this update. Summary of changes: .../sql/types/string/test_unicode_escapes_in_literals.test_ignored | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
(ignite-3) branch main updated: IGNITE-21941 Cover SQL F391(Long identifiers) feature by tests (#3734)
This is an automated email from the ASF dual-hosted git repository. amashenkov pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/ignite-3.git The following commit(s) were added to refs/heads/main by this push: new f46d40b444 IGNITE-21941 Cover SQL F391(Long identifiers) feature by tests (#3734) f46d40b444 is described below commit f46d40b444c3e3605b59ba79e192563731b62b92 Author: Andrew V. Mashenkov AuthorDate: Tue May 14 11:00:04 2024 +0300 IGNITE-21941 Cover SQL F391(Long identifiers) feature by tests (#3734) --- .../sql/identifiers/test_long_identifiers.test | 227 + 1 file changed, 227 insertions(+) diff --git a/modules/sql-engine/src/integrationTest/sql/identifiers/test_long_identifiers.test b/modules/sql-engine/src/integrationTest/sql/identifiers/test_long_identifiers.test new file mode 100644 index 00..84ea70023c --- /dev/null +++ b/modules/sql-engine/src/integrationTest/sql/identifiers/test_long_identifiers.test @@ -0,0 +1,227 @@ +# name: sql/identifiers/test_long_identifiers.test +# description: SQL feature F391 (Long identifiers) +# group: [identifiers] + +# TODO: IGNITE-19703 Add cases for long identifiers for schema names. + +statement ok +PRAGMA enable_verification + +# Create table with short identifiers for test simplicity purpose +statement ok +CREATE TABLE t (id INTEGER, val INTEGER, PRIMARY KEY (id)) + +# Create table with long identifiers +statement ok +CREATE TABLE tableName_veryLoongIdentifierOf128Characters (keyColumnName_veryLoongIdentifierOf128Characters INTEGER, valueColumnName_veryLngIdentifierOf128Characters INTEGER, PRIMARY KEY (keyColumnName_veryLo [...] + +statement error: Failed to parse query: Length of identifier +CREATE TABLE tableName_veryLooongIdentifierOf129Characters (key INTEGER, val INTEGER, PRIMARY KEY (key)); + + +# Rename table with long identifiers +skipif ignite3 +# Ignored: https://issues.apache.org/jira/browse/IGNITE-19484 +statement error: Failed to parse query: Length of identifier +ALTER TABLE t RENAME TO tableName_veryLooongIdentifierOf129Characters; + +skipif ignite3 +# Ignored: https://issues.apache.org/jira/browse/IGNITE-19484 +statement ok +ALTER TABLE t RENAME TO tableName_veryLoongIdentifierOf128Characters; + +skipif ignite3 +# Ignored: https://issues.apache.org/jira/browse/IGNITE-19484 +statement ok +ALTER TABLE tableName_veryLoongIdentifierOf128Characters RENAME TO tableName; + + +# Alter table add/drop column with long identifier +statement ok +ALTER TABLE t ADD COLUMN (columnName_veryLongIdentifierOf128Characters INTEGER); + +statement error: Failed to parse query: Length of identifier +ALTER TABLE t ADD COLUMN (columnName_veryLoongIdentifierOf129Characters INTEGER); + +statement ok +ALTER TABLE t DROP COLUMN (columnName_veryLongIdentifierOf128Characters); + + +# Alter table rename column with long identifier +skipif ignite3 +# Ignored: https://issues.apache.org/jira/browse/IGNITE-19485 +statement error: Failed to parse query: Length of identifier +ALTER TABLE t RENAME COLUMN val TO columnName_veryLoongIdentifierOf129Characters; + +skipif ignite3 +# Ignored: https://issues.apache.org/jira/browse/IGNITE-19485 +statement ok +ALTER TABLE t RENAME COLUMN val TO columnName_veryLongIdentifierOf128Characters; + +skipif ignite3 +# Ignored: https://issues.apache.org/jira/browse/IGNITE-19485 +statement ok +ALTER TABLE t RENAME COLUMN columnName_veryLongIdentifierOf128Characters TO val; + + +# Alter table with long identifier +statement ok +ALTER TABLE tableName_veryLoongIdentifierOf128Characters ADD COLUMN columnName INTEGER; + +statement ok +ALTER TABLE
(ignite-3) branch ignite-21941 deleted (was c05635763a)
This is an automated email from the ASF dual-hosted git repository. amashenkov pushed a change to branch ignite-21941 in repository https://gitbox.apache.org/repos/asf/ignite-3.git was c05635763a Minor after review The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
(ignite-3) branch ignite-21942 updated (2730c3245f -> a14e5b8c28)
This is an automated email from the ASF dual-hosted git repository. amashenkov pushed a change to branch ignite-21942 in repository https://gitbox.apache.org/repos/asf/ignite-3.git discard 2730c3245f wip. new a14e5b8c28 wip. This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (2730c3245f) \ N -- N -- N refs/heads/ignite-21942 (a14e5b8c28) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../test_unicode_escapes_in_literals.test_ignored | 25 +- 1 file changed, 20 insertions(+), 5 deletions(-)
(ignite-3) 01/01: wip.
This is an automated email from the ASF dual-hosted git repository. amashenkov pushed a commit to branch ignite-21942 in repository https://gitbox.apache.org/repos/asf/ignite-3.git commit a14e5b8c28dc31fa5c00c9b217fd2b83f1002c93 Author: amashenkov AuthorDate: Mon May 13 18:52:20 2024 +0300 wip. --- .../test_unicode_escapes_in_literals.test_ignored | 62 ++ 1 file changed, 62 insertions(+) diff --git a/modules/sql-engine/src/integrationTest/sql/types/string/test_unicode_escapes_in_literals.test_ignored b/modules/sql-engine/src/integrationTest/sql/types/string/test_unicode_escapes_in_literals.test_ignored new file mode 100644 index 00..e39c87117f --- /dev/null +++ b/modules/sql-engine/src/integrationTest/sql/types/string/test_unicode_escapes_in_literals.test_ignored @@ -0,0 +1,62 @@ +# name: test/sql/types/string/test_unicode_escapes_on_literals.test +# description: SQL feature F393 (Unicode escapes in literals) +# group: [string] +# Ignore: https://issues.apache.org/jira/browse/IGNITE-21942 + +# insert unicode strings into the database +statement ok +CREATE TABLE t(id INTEGER, s VARCHAR); + +statement ok +INSERT INTO t VALUES (1, U&'d\\0061t\\+61'), (2, N'd\\0061t\\+61'), (3, 'd\\x61t\\x0061'), (4, 'd\\u0061t\\U0061') + +# retrieve unicode strings again +query IT +SELECT * FROM t ORDER BY id + +1 data +2 d\\0061t\+61 +3 data +4 data + +query IT +SELECT * FROM t WHERE s = U&'d\\0061t\\+61' ORDER BY id + +1 data +2 d\0061t\+61 +3 data +4 data + +query IT +SELECT * FROM t WHERE s = 'd\\x61t\\x0061' ORDER BY id + +1 data +2 d\0061t\+61 +3 data +4 data + +# substring on t +query TT +SELECT substring(s, 1, 2), substring(s, 3, 2) FROM t ORDER BY id + +da ta +d\ 00 +da ta +da ta + +# length on t +query I +SELECT length(s) FROM t ORDER BY id + +4 +4 +4 +4 + +query I +SELECT octet_length(s) FROM t ORDER BY id + +4 +4 +4 +4
(ignite-3) branch ignite-21942 created (now 2730c3245f)
This is an automated email from the ASF dual-hosted git repository. amashenkov pushed a change to branch ignite-21942 in repository https://gitbox.apache.org/repos/asf/ignite-3.git at 2730c3245f wip. This branch includes the following new commits: new 2730c3245f wip. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
(ignite-3) 01/01: wip.
This is an automated email from the ASF dual-hosted git repository. amashenkov pushed a commit to branch ignite-21942 in repository https://gitbox.apache.org/repos/asf/ignite-3.git commit 2730c3245f02ca90c60e9f886f7a14ef4c005b98 Author: amashenkov AuthorDate: Mon May 13 18:52:20 2024 +0300 wip. --- .../test_unicode_escapes_in_literals.test_ignored | 47 ++ 1 file changed, 47 insertions(+) diff --git a/modules/sql-engine/src/integrationTest/sql/types/string/test_unicode_escapes_in_literals.test_ignored b/modules/sql-engine/src/integrationTest/sql/types/string/test_unicode_escapes_in_literals.test_ignored new file mode 100644 index 00..b80ea868f7 --- /dev/null +++ b/modules/sql-engine/src/integrationTest/sql/types/string/test_unicode_escapes_in_literals.test_ignored @@ -0,0 +1,47 @@ +# name: test/sql/types/string/test_unicode_escapes_on_literals.test +# description: SQL feature F393 (Unicode escapes in literals) +# group: [string] +# Ignore: https://issues.apache.org/jira/browse/IGNITE-21962 + +# insert unicode strings into the database +statement ok +CREATE TABLE t(id INTEGER, s VARCHAR); + +statement ok +INSERT INTO t VALUES (1, U&'d\0061t\+61'), (2, N'd\0061t\+61') +INSERT INTO t VALUES (3, 'd\x61t\x0061'), (4, 'd\u0061t\U0061') + +# retrieve unicode strings again +query IT +SELECT * FROM t ORDER BY id + +1 data +2 data +3 data +4 data + +# substring on t +query TT +SELECT substring(s, 1, 2), substring(s, 3, 2) FROM t ORDER BY id + +da ta +da ta +da ta +da ta + +# length on t +query I +SELECT length(s) FROM t ORDER BY id + +4 +4 +4 +4 + +query I +SELECT octet_length(s) FROM t ORDER BY id + +4 +4 +4 +4
(ignite-3) branch ignite-21941 updated (d22485eba2 -> c05635763a)
This is an automated email from the ASF dual-hosted git repository. amashenkov pushed a change to branch ignite-21941 in repository https://gitbox.apache.org/repos/asf/ignite-3.git discard d22485eba2 Minor after review add c05635763a Minor after review This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (d22485eba2) \ N -- N -- N refs/heads/ignite-21941 (c05635763a) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. No new revisions were added by this update. Summary of changes: .../sql/identifiers/test_long_identifiers.test | 32 +++--- 1 file changed, 16 insertions(+), 16 deletions(-)
(ignite-3) branch ignite-21941 updated (405c7c1fe9 -> d22485eba2)
This is an automated email from the ASF dual-hosted git repository. amashenkov pushed a change to branch ignite-21941 in repository https://gitbox.apache.org/repos/asf/ignite-3.git from 405c7c1fe9 Add todo add d22485eba2 Minor after review No new revisions were added by this update. Summary of changes: .../sql/identifiers/test_long_identifiers.test | 80 +- 1 file changed, 49 insertions(+), 31 deletions(-)
(ignite-3) branch main updated: IGNITE-22161 Sql. Fix infinity loop after query validation failure (#3702)
This is an automated email from the ASF dual-hosted git repository.
amashenkov pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/ignite-3.git
The following commit(s) were added to refs/heads/main by this push:
new 54f75768bb IGNITE-22161 Sql. Fix infinity loop after query validation
failure (#3702)
54f75768bb is described below
commit 54f75768bb30e1d5415c0b3587a96e9bb98f3c2e
Author: Andrew V. Mashenkov
AuthorDate: Fri May 10 12:30:38 2024 +0300
IGNITE-22161 Sql. Fix infinity loop after query validation failure (#3702)
---
.../commands/AlterTableAddColumnCommand.java | 2 +
.../commands/AlterTableAlterColumnCommand.java | 15 +++
.../internal/catalog/commands/CatalogUtils.java| 59 ++
.../catalog/commands/CreateTableCommand.java | 8 +-
.../AlterTableAddColumnCommandValidationTest.java | 27 +
...AlterTableAlterColumnCommandValidationTest.java | 126 +
.../commands/CreateTableCommandValidationTest.java | 21 +++-
.../internal/schema/DefaultValueGenerator.java | 1 +
.../sql/engine/ItAlterTableAlterColumnTest.java| 60 ++
.../internal/sql/engine/ItCreateTableDdlTest.java | 72 +++-
.../internal/sql/engine/sql/SqlDdlParserTest.java | 67 +++
11 files changed, 449 insertions(+), 9 deletions(-)
diff --git
a/modules/catalog/src/main/java/org/apache/ignite/internal/catalog/commands/AlterTableAddColumnCommand.java
b/modules/catalog/src/main/java/org/apache/ignite/internal/catalog/commands/AlterTableAddColumnCommand.java
index dd21a5c32d..57a2d1a1f4 100644
---
a/modules/catalog/src/main/java/org/apache/ignite/internal/catalog/commands/AlterTableAddColumnCommand.java
+++
b/modules/catalog/src/main/java/org/apache/ignite/internal/catalog/commands/AlterTableAddColumnCommand.java
@@ -104,6 +104,8 @@ public class AlterTableAddColumnCommand extends
AbstractTableCommand {
if (!columnNames.add(column.name())) {
throw new CatalogValidationException(format("Column with name
'{}' specified more than once", column.name()));
}
+
+CatalogUtils.ensureNonFunctionalDefault(column.name(),
column.defaultValueDefinition());
}
}
diff --git
a/modules/catalog/src/main/java/org/apache/ignite/internal/catalog/commands/AlterTableAlterColumnCommand.java
b/modules/catalog/src/main/java/org/apache/ignite/internal/catalog/commands/AlterTableAlterColumnCommand.java
index 392e6f35f3..1a06cc1691 100644
---
a/modules/catalog/src/main/java/org/apache/ignite/internal/catalog/commands/AlterTableAlterColumnCommand.java
+++
b/modules/catalog/src/main/java/org/apache/ignite/internal/catalog/commands/AlterTableAlterColumnCommand.java
@@ -102,6 +102,8 @@ public class AlterTableAlterColumnCommand extends
AbstractTableCommand {
if (table.isPrimaryKeyColumn(origin.name())) {
validatePkColumnChange(origin);
+} else {
+validateValueColumnChange(origin);
}
validateColumnChange(origin);
@@ -147,6 +149,19 @@ public class AlterTableAlterColumnCommand extends
AbstractTableCommand {
if (nullable != null && nullable) {
throw new CatalogValidationException("Dropping NOT NULL constraint
on key column is not allowed");
}
+if (deferredDefault != null) {
+DefaultValue defaultValue = deferredDefault.derive(origin.type());
+
+CatalogUtils.ensureSupportedDefault(columnName, defaultValue);
+}
+}
+
+private void validateValueColumnChange(CatalogTableColumnDescriptor
origin) {
+if (deferredDefault != null) {
+DefaultValue defaultValue = deferredDefault.derive(origin.type());
+
+CatalogUtils.ensureNonFunctionalDefault(columnName, defaultValue);
+}
}
private void validateColumnChange(CatalogTableColumnDescriptor origin) {
diff --git
a/modules/catalog/src/main/java/org/apache/ignite/internal/catalog/commands/CatalogUtils.java
b/modules/catalog/src/main/java/org/apache/ignite/internal/catalog/commands/CatalogUtils.java
index d785e7b2b4..269ec442b9 100644
---
a/modules/catalog/src/main/java/org/apache/ignite/internal/catalog/commands/CatalogUtils.java
+++
b/modules/catalog/src/main/java/org/apache/ignite/internal/catalog/commands/CatalogUtils.java
@@ -19,12 +19,14 @@ package org.apache.ignite.internal.catalog.commands;
import static java.util.stream.Collectors.toList;
import static
org.apache.ignite.internal.catalog.CatalogService.SYSTEM_SCHEMA_NAME;
+import static
org.apache.ignite.internal.catalog.commands.DefaultValue.Type.FUNCTION_CALL;
import static org.apache.ignite.internal.lang.IgniteStringFormatter.format;
import it.unimi.dsi.fastutil.ints.Int2ObjectOpenHashMap;
import java.util.Collection;
import java.util.EnumMap;
import java.util.EnumSet;
+import java.util.HashSet;
import java.util.List;
i
(ignite-3) branch ignite-22161 deleted (was 2e7bc44a24)
This is an automated email from the ASF dual-hosted git repository. amashenkov pushed a change to branch ignite-22161 in repository https://gitbox.apache.org/repos/asf/ignite-3.git was 2e7bc44a24 Minor. The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
(ignite-3) branch ignite-22161 updated (735c66e058 -> 2e7bc44a24)
This is an automated email from the ASF dual-hosted git repository. amashenkov pushed a change to branch ignite-22161 in repository https://gitbox.apache.org/repos/asf/ignite-3.git from 735c66e058 Fix alter column command and tests. add 2e7bc44a24 Minor. No new revisions were added by this update. Summary of changes: .../internal/sql/engine/ItAlterTableAlterColumnTest.java | 16 .../ignite/internal/sql/engine/ItCreateTableDdlTest.java | 10 +- 2 files changed, 13 insertions(+), 13 deletions(-)
(ignite-3) branch ignite-21941 updated: Add todo
This is an automated email from the ASF dual-hosted git repository. amashenkov pushed a commit to branch ignite-21941 in repository https://gitbox.apache.org/repos/asf/ignite-3.git The following commit(s) were added to refs/heads/ignite-21941 by this push: new 405c7c1fe9 Add todo 405c7c1fe9 is described below commit 405c7c1fe99bc1ef085fb404e5f56c4e0b48e9aa Author: amashenkov AuthorDate: Wed May 8 14:05:24 2024 +0300 Add todo --- .../src/integrationTest/sql/identifiers/test_long_identifiers.test | 2 ++ 1 file changed, 2 insertions(+) diff --git a/modules/sql-engine/src/integrationTest/sql/identifiers/test_long_identifiers.test b/modules/sql-engine/src/integrationTest/sql/identifiers/test_long_identifiers.test index 39c69ee6a1..f1039f7d0c 100644 --- a/modules/sql-engine/src/integrationTest/sql/identifiers/test_long_identifiers.test +++ b/modules/sql-engine/src/integrationTest/sql/identifiers/test_long_identifiers.test @@ -2,6 +2,8 @@ # description: SQL feature F391 (Long identifiers) # group: [identifiers] +# TODO: IGNITE-19703 Add cases for long identifiers for schema names. + statement ok PRAGMA enable_verification
(ignite-3) branch ignite-21941 updated: Minor
This is an automated email from the ASF dual-hosted git repository. amashenkov pushed a commit to branch ignite-21941 in repository https://gitbox.apache.org/repos/asf/ignite-3.git The following commit(s) were added to refs/heads/ignite-21941 by this push: new d5ae5e6f6c Minor d5ae5e6f6c is described below commit d5ae5e6f6cd8c93109b9fe464934b0ad18a97598 Author: amashenkov AuthorDate: Wed May 8 14:03:51 2024 +0300 Minor --- .../sql/identifiers/test_long_identifiers.test | 158 ++--- 1 file changed, 136 insertions(+), 22 deletions(-) diff --git a/modules/sql-engine/src/integrationTest/sql/identifiers/test_long_identifiers.test b/modules/sql-engine/src/integrationTest/sql/identifiers/test_long_identifiers.test index 8a3c039af3..39c69ee6a1 100644 --- a/modules/sql-engine/src/integrationTest/sql/identifiers/test_long_identifiers.test +++ b/modules/sql-engine/src/integrationTest/sql/identifiers/test_long_identifiers.test @@ -5,89 +5,203 @@ statement ok PRAGMA enable_verification +# Create table with short identifiers for test simplicity purpose statement ok -CREATE TABLE someTableNameLongIdentifier (keyColumnLongIdentifier INTEGER, valueColumnLongIdentifier INTEGER, PRIMARY KEY (keyColumnLongIdentifier)); +CREATE TABLE t (id INTEGER, val INTEGER, PRIMARY KEY (id)) +# Create table with long identifiers statement ok -ALTER TABLE someTableNameLongIdentifier ADD COLUMN (newValueColumnLongIdentifier INTEGER); +CREATE TABLE tableName_veryLoongIdentifierOf128Characters (keyColumnName_veryLoongIdentifierOf128Characters INTEGER, valueColumnName_veryLngIdentifierOf128Characters INTEGER, PRIMARY KEY (keyColumnName_veryLo [...] +statement error +CREATE TABLE tableName_veryLooongIdentifierOf129Characters (key INTEGER, val INTEGER, PRIMARY KEY (key)); + + +# Rename table with long identifiers +# TODO: Enable after https://issues.apache.org/jira/browse/IGNITE-19484 is fixed. +# statement error +# ALTER TABLE t RENAME TO tableName_veryLooongIdentifierOf129Characters; +# TODO: Enable after https://issues.apache.org/jira/browse/IGNITE-19484 is fixed. +# statement ok +# ALTER TABLE t RENAME TO tableName_veryLoongIdentifierOf128Characters; +# TODO: Enable after https://issues.apache.org/jira/browse/IGNITE-19484 is fixed. +# statement ok +# ALTER TABLE tableName_veryLoongIdentifierOf128Characters RENAME TO tableName; + + +# Alter table add/drop column with long identifier statement ok -ALTER TABLE someTableNameLongIdentifier DROP COLUMN newValueColumnLongIdentifier; +ALTER TABLE t ADD COLUMN (columnName_veryLongIdentifierOf128Characters INTEGER); + +statement error +ALTER TABLE t ADD COLUMN (columnName_veryLoongIdentifierOf129Characters INTEGER); statement ok -INSERT INTO someTableNameLongIdentifier (keyColumnLongIdentifier, valueColumnLongIdentifier) VALUES (1, 1), (2, 1); +ALTER TABLE t DROP COLUMN (columnName_veryLongIdentifierOf128Characters); + + +# Alter table rename column with long identifier +# TODO: IGNITE-19485, IGNITE-20315 - Uncomment this after column rename support gets aded. +# statement error +# ALTER TABLE t RENAME COLUMN val TO columnName_veryLoongIdentifierOf129Characters; +# TODO: IGNITE-19485, IGNITE-20315 - Uncomment this after column rename support gets aded. +# statement ok +# ALTER TABLE t RENAME COLUMN val TO columnName_veryLongIdentifierOf128Characters; +# TODO: IGNITE-19485, IGNITE-20315 - Uncomment this after column rename support gets aded. +# statement ok +# ALTER TABLE t RENAME COLUMN columnName_veryLongIdentifierOf128Characters TO val; + + +# Alter table with long identifier +statement ok +ALTER TABLE tableName_veryLoongIdentifierOf128Characters ADD COLUMN columnName INTEGER; + +statement ok +ALTER TABLE
(ignite-3) 01/02: wip
This is an automated email from the ASF dual-hosted git repository. amashenkov pushed a commit to branch ignite-21941 in repository https://gitbox.apache.org/repos/asf/ignite-3.git commit bd2cb1b62f5b73fd39125e057f1b8080022d3ef5 Author: amashenkov AuthorDate: Tue May 7 15:21:21 2024 +0300 wip --- .../sql/identifiers/test_long_identifiers.test | 68 ++ 1 file changed, 68 insertions(+) diff --git a/modules/sql-engine/src/integrationTest/sql/identifiers/test_long_identifiers.test b/modules/sql-engine/src/integrationTest/sql/identifiers/test_long_identifiers.test new file mode 100644 index 00..7851690c99 --- /dev/null +++ b/modules/sql-engine/src/integrationTest/sql/identifiers/test_long_identifiers.test @@ -0,0 +1,68 @@ +# name: sql/identifiers/test_long_identifiers.test +# description: SQL feature F391 (Long identifiers) +# group: [identifiers] + +statement ok +PRAGMA enable_verification + +statement ok +CREATE TABLE tableNameLongIdentifier (keyColumnLongIdentifier INTEGER, valueColumnLongIdentifier INTEGER, PRIMARY KEY (keyColumnLongIdentifier)) + +statement ok +ALTER TABLE tableNameLongIdentifier ADD COLUMN (newValueColumnLongIdentifier INTEGER) + +statement ok +ALTER TABLE tableNameLongIdentifier DROP COLUMN newValueColumnLongIdentifier + +query I +SELECT col_ FROM (VALUES (1), (2)) t(col_) + +1 +2 + +query I +SELECT 1 as col_ + +1 + +query I +SELECT 1 col_ + +1 + +query I +SELECT col_ FROM (SELECT 1 as col_) + +1 + +query I +SELECT col_ FROM (SELECT 1 col_) + +1 + +query I +SELECT col__ FROM (VALUES (1), (2)) t(col__) + +1 +2 + +statement ok +CREATE INDEX t_some_idx_ on t_ (val) + +statement ok +DROP INDEX t_some_idx_ + +statement ok +DROP TABLE t_ + +statement ok +CREATE ZONE zone_ WITH STORAGE_PROFILES='default', PARTITIONS=1, REPLICAS=3 + +statement ok +ALTER ZONE zone_ SET REPLICAS = 4 + +statement ok +ALTER ZONE zone_ RENAME TO another_zone_ + +statement ok +DROP ZONE another_zone_
(ignite-3) 02/02: Add feature tests
This is an automated email from the ASF dual-hosted git repository. amashenkov pushed a commit to branch ignite-21941 in repository https://gitbox.apache.org/repos/asf/ignite-3.git commit 4d054e9edd934bbd6b1181d10c9e96c7bd538959 Author: amashenkov AuthorDate: Tue May 7 18:17:24 2024 +0300 Add feature tests --- .../sql/identifiers/test_long_identifiers.test | 57 -- 1 file changed, 41 insertions(+), 16 deletions(-) diff --git a/modules/sql-engine/src/integrationTest/sql/identifiers/test_long_identifiers.test b/modules/sql-engine/src/integrationTest/sql/identifiers/test_long_identifiers.test index 7851690c99..8a3c039af3 100644 --- a/modules/sql-engine/src/integrationTest/sql/identifiers/test_long_identifiers.test +++ b/modules/sql-engine/src/integrationTest/sql/identifiers/test_long_identifiers.test @@ -6,63 +6,88 @@ statement ok PRAGMA enable_verification statement ok -CREATE TABLE tableNameLongIdentifier (keyColumnLongIdentifier INTEGER, valueColumnLongIdentifier INTEGER, PRIMARY KEY (keyColumnLongIdentifier)) +CREATE TABLE someTableNameLongIdentifier (keyColumnLongIdentifier INTEGER, valueColumnLongIdentifier INTEGER, PRIMARY KEY (keyColumnLongIdentifier)); statement ok -ALTER TABLE tableNameLongIdentifier ADD COLUMN (newValueColumnLongIdentifier INTEGER) +ALTER TABLE someTableNameLongIdentifier ADD COLUMN (newValueColumnLongIdentifier INTEGER); statement ok -ALTER TABLE tableNameLongIdentifier DROP COLUMN newValueColumnLongIdentifier +ALTER TABLE someTableNameLongIdentifier DROP COLUMN newValueColumnLongIdentifier; + +statement ok +INSERT INTO someTableNameLongIdentifier (keyColumnLongIdentifier, valueColumnLongIdentifier) VALUES (1, 1), (2, 1); query I -SELECT col_ FROM (VALUES (1), (2)) t(col_) +SELECT columnAliasLongIdentifier FROM (VALUES (1), (2)) tableAliasLongIdentifier(columnAliasLongIdentifier); 1 2 query I -SELECT 1 as col_ +SELECT 1 as columnAliasLongIdentifier 1 query I -SELECT 1 col_ +SELECT 1 columnAliasLongIdentifier 1 query I -SELECT col_ FROM (SELECT 1 as col_) +SELECT columnAliasLongIdentifier FROM (SELECT 1 as columnAliasLongIdentifier); 1 query I -SELECT col_ FROM (SELECT 1 col_) +SELECT columnAliasLongIdentifier FROM (SELECT 1 columnAliasLongIdentifier); 1 + query I -SELECT col__ FROM (VALUES (1), (2)) t(col__) +SELECT someTableNameLongIdentifier.keyColumnLongIdentifier FROM someTableNameLongIdentifier; 1 2 +query II +SELECT keyColumnLongIdentifier, valueColumnLongIdentifier FROM someTableNameLongIdentifier ORDER BY keyColumnLongIdentifier DESC; + +2 1 +1 1 + +query II +SELECT valueColumnLongIdentifier, SUM(keyColumnLongIdentifier) FROM someTableNameLongIdentifier GROUP BY valueColumnLongIdentifier; + +1 3 + +query II +SELECT * FROM someTableNameLongIdentifier WHERE keyColumnLongIdentifier = 2; + +2 1 + +query I +SELECT columnAliasLongIdentifier FROM (SELECT 1 columnAliasLongIdentifier) WHERE columnAliasLongIdentifier = 1; + +1 + statement ok -CREATE INDEX t_some_idx_ on t_ (val) +CREATE INDEX someIndexNameLongIdentifier on someTableNameLongIdentifier (valueColumnLongIdentifier); statement ok -DROP INDEX t_some_idx_ +DROP INDEX someIndexNameLongIdentifier; statement ok -DROP TABLE t_ +DROP TABLE someTableNameLongIdentifier; statement ok -CREATE ZONE zone_ WITH STORAGE_PROFILES='default', PARTITIONS=1, REPLICAS=3 +CREATE ZONE someZoneNameLongIdentifier WITH STORAGE_PROFILES='default', PARTITIONS=1, REPLICAS=3; statement ok -ALTER ZONE zone_ SET REPLICAS = 4 +ALTER ZONE someZoneNameLongIdentifier SET REPLICAS = 4; statement ok -ALTER ZONE zone_ RENAME TO another_zone_ +ALTER ZONE someZoneNameLongIdentifier RENAME TO anotherZoneNameLongIdentifier; statement ok -DROP ZONE another_zone_ +DROP ZONE anotherZoneNameLongIdentifier;
(ignite-3) branch ignite-21941 created (now 4d054e9edd)
This is an automated email from the ASF dual-hosted git repository. amashenkov pushed a change to branch ignite-21941 in repository https://gitbox.apache.org/repos/asf/ignite-3.git at 4d054e9edd Add feature tests This branch includes the following new commits: new bd2cb1b62f wip new 4d054e9edd Add feature tests The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
(ignite-3) branch igntie-22156 deleted (was 2f0c56d605)
This is an automated email from the ASF dual-hosted git repository. amashenkov pushed a change to branch igntie-22156 in repository https://gitbox.apache.org/repos/asf/ignite-3.git was 2f0c56d605 Minor. The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
(ignite-3) branch main updated: IGNITE-22156 Replace inheritance with delegation for UpgradingRowAdapter class. (#3696)
This is an automated email from the ASF dual-hosted git repository.
amashenkov pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/ignite-3.git
The following commit(s) were added to refs/heads/main by this push:
new 8aabfa8277 IGNITE-22156 Replace inheritance with delegation for
UpgradingRowAdapter class. (#3696)
8aabfa8277 is described below
commit 8aabfa8277988d0af1a87fd8ca35fcbdac19601d
Author: Andrew V. Mashenkov
AuthorDate: Tue May 7 17:18:55 2024 +0300
IGNITE-22156 Replace inheritance with delegation for UpgradingRowAdapter
class. (#3696)
---
.../requests/table/ClientHandlerTupleTests.java| 6 +-
.../schema/registry/UpgradingRowAdapter.java | 121 +
.../org/apache/ignite/internal/schema/row/Row.java | 144 +++--
.../internal/schema/row/{Row.java => RowImpl.java} | 60 +++--
.../schema/registry/UpgradingRowAdapterTest.java | 137 +++-
.../internal/table/MutableRowTupleAdapter.java | 4 +-
.../ignite/internal/table/RecordViewImpl.java | 6 +-
7 files changed, 184 insertions(+), 294 deletions(-)
diff --git
a/modules/client-handler/src/test/java/org/apache/ignite/client/handler/requests/table/ClientHandlerTupleTests.java
b/modules/client-handler/src/test/java/org/apache/ignite/client/handler/requests/table/ClientHandlerTupleTests.java
index 93c94e5c52..a2e653afe7 100644
---
a/modules/client-handler/src/test/java/org/apache/ignite/client/handler/requests/table/ClientHandlerTupleTests.java
+++
b/modules/client-handler/src/test/java/org/apache/ignite/client/handler/requests/table/ClientHandlerTupleTests.java
@@ -40,7 +40,7 @@ import java.time.LocalTime;
import java.time.Month;
import java.util.Random;
import java.util.UUID;
-import org.apache.ignite.internal.schema.BinaryTuple;
+import org.apache.ignite.internal.binarytuple.BinaryTupleReader;
import org.apache.ignite.internal.schema.Column;
import org.apache.ignite.internal.schema.SchemaDescriptor;
import org.apache.ignite.internal.schema.marshaller.TupleMarshallerException;
@@ -91,7 +91,7 @@ public class ClientHandlerTupleTests {
public void testTupleEquality() throws TupleMarshallerException {
Tuple tuple = createTuple();
-BinaryTuple binaryTuple = new
TupleMarshallerImpl(fullSchema).marshal(tuple).binaryTuple();
+BinaryTupleReader binaryTuple = new
TupleMarshallerImpl(fullSchema).marshal(tuple).binaryTuple();
Tuple clientHandlerTuple = new ClientHandlerTuple(fullSchema, null,
binaryTuple, false);
assertEquals(tuple, clientHandlerTuple);
@@ -101,7 +101,7 @@ public class ClientHandlerTupleTests {
public void testTupleEqualityKeyOnly() throws TupleMarshallerException {
Tuple tuple = createKeyTuple();
-BinaryTuple binaryTuple = new
TupleMarshallerImpl(fullSchema).marshalKey(tuple).binaryTuple();
+BinaryTupleReader binaryTuple = new
TupleMarshallerImpl(fullSchema).marshalKey(tuple).binaryTuple();
Tuple clientHandlerTuple = new ClientHandlerTuple(fullSchema, null,
binaryTuple, true);
assertEquals(tuple, clientHandlerTuple);
diff --git
a/modules/schema/src/main/java/org/apache/ignite/internal/schema/registry/UpgradingRowAdapter.java
b/modules/schema/src/main/java/org/apache/ignite/internal/schema/registry/UpgradingRowAdapter.java
index b3753a14cb..0f11ab677a 100644
---
a/modules/schema/src/main/java/org/apache/ignite/internal/schema/registry/UpgradingRowAdapter.java
+++
b/modules/schema/src/main/java/org/apache/ignite/internal/schema/registry/UpgradingRowAdapter.java
@@ -47,7 +47,7 @@ import org.jetbrains.annotations.Nullable;
/**
* Adapter for row of older schema.
*/
-public class UpgradingRowAdapter extends Row {
+public class UpgradingRowAdapter implements Row {
/** Column mapper. */
private final ColumnMapper mapper;
@@ -56,8 +56,11 @@ public class UpgradingRowAdapter extends Row {
private final BinaryTupleSchema newBinaryTupleSchema;
+/** Row of previous version. */
+private final Row row;
+
private UpgradingRowAdapter(SchemaDescriptor newSchema, BinaryTupleSchema
newBinaryTupleSchema, Row row, ColumnMapper mapper) {
-super(false, row.schema(), row.binaryTupleSchema(), row);
+this.row = row;
this.newSchema = newSchema;
this.mapper = mapper;
@@ -100,6 +103,12 @@ public class UpgradingRowAdapter extends Row {
return newSchema.version();
}
+/** {@inheritDoc} */
+@Override
+public boolean keyOnly() {
+return false;
+}
+
/**
* Map column.
*
@@ -125,13 +134,13 @@ public class UpgradingRowAdapter extends Row {
public boolean booleanValue(int colIdx) {
int mappedId = mapColumn(colIdx);
-Column column = mappedId < 0 ? mapper.mappedColumn(colIdx) :
super.schema().column(mappedId);
+Column column = mappedId < 0 ? mapper.mappedColumn(colIdx) :
r
(ignite-3) branch ignite-22161 updated (e89f016c51 -> 735c66e058)
This is an automated email from the ASF dual-hosted git repository. amashenkov pushed a change to branch ignite-22161 in repository https://gitbox.apache.org/repos/asf/ignite-3.git from e89f016c51 styles add 735c66e058 Fix alter column command and tests. No new revisions were added by this update. Summary of changes: .../commands/AlterTableAddColumnCommand.java | 2 + .../commands/AlterTableAlterColumnCommand.java | 15 +++ .../internal/catalog/commands/CatalogUtils.java| 46 +++- .../catalog/commands/CreateTableCommand.java | 22 +--- .../AlterTableAddColumnCommandValidationTest.java | 27 + ...AlterTableAlterColumnCommandValidationTest.java | 126 + .../sql/engine/ItAlterTableAlterColumnTest.java| 60 ++ .../internal/sql/engine/ItCreateTableDdlTest.java | 47 +++- 8 files changed, 323 insertions(+), 22 deletions(-)
(ignite-3) branch ignite-22161 updated (8f027fb968 -> e89f016c51)
This is an automated email from the ASF dual-hosted git repository. amashenkov pushed a change to branch ignite-22161 in repository https://gitbox.apache.org/repos/asf/ignite-3.git from 8f027fb968 minor add e89f016c51 styles No new revisions were added by this update. Summary of changes: .../java/org/apache/ignite/internal/schema/DefaultValueGenerator.java| 1 + 1 file changed, 1 insertion(+)
(ignite-3) branch ignite-22161 updated (9f5051c9e4 -> 8f027fb968)
This is an automated email from the ASF dual-hosted git repository. amashenkov pushed a change to branch ignite-22161 in repository https://gitbox.apache.org/repos/asf/ignite-3.git from 9f5051c9e4 revert unrelated change add 8f027fb968 minor No new revisions were added by this update. Summary of changes: .../internal/catalog/commands/CatalogUtils.java | 15 +++ .../catalog/commands/CreateTableCommand.java| 3 +-- .../commands/CreateTableCommandValidationTest.java | 21 - 3 files changed, 36 insertions(+), 3 deletions(-)
