This is an automated email from the ASF dual-hosted git repository.

ahuber pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/isis.git


The following commit(s) were added to refs/heads/master by this push:
     new 43a2034  ISIS-1949: java-doc fix
43a2034 is described below

commit 43a20344d9c275c933ef7e847b2c33d1edb7ab31
Author: Andi Huber <ahu...@apache.org>
AuthorDate: Sat May 19 17:35:06 2018 +0200

    ISIS-1949: java-doc fix
    
    Task-Url: https://issues.apache.org/jira/browse/ISIS-1949
---
 .../runtime/plugins/codegen/ProxyFactoryPluginUsingJavassist.java  | 2 +-
 .../org/apache/isis/core/runtime/plugins/codegen/ProxyFactory.java | 7 ++-----
 2 files changed, 3 insertions(+), 6 deletions(-)

diff --git 
a/core/plugins/codegen-javassist/src/main/java/org/apache/isis/core/runtime/plugins/codegen/ProxyFactoryPluginUsingJavassist.java
 
b/core/plugins/codegen-javassist/src/main/java/org/apache/isis/core/runtime/plugins/codegen/ProxyFactoryPluginUsingJavassist.java
index 2bb6a8f..5c92541 100644
--- 
a/core/plugins/codegen-javassist/src/main/java/org/apache/isis/core/runtime/plugins/codegen/ProxyFactoryPluginUsingJavassist.java
+++ 
b/core/plugins/codegen-javassist/src/main/java/org/apache/isis/core/runtime/plugins/codegen/ProxyFactoryPluginUsingJavassist.java
@@ -59,8 +59,8 @@ public class ProxyFactoryPluginUsingJavassist implements 
ProxyFactoryPlugin {
                        @Override
                        public T createInstance(InvocationHandler handler, 
Object[] constructorArgs) {
                                
-                               ensureSameSize(constructorArgTypes, 
constructorArgs);
                                ensureNonEmtpy(constructorArgs);
+                               ensureSameSize(constructorArgTypes, 
constructorArgs);
 
                                try {
                                        return _Casts.uncheckedCast( 
createUsingConstructor(handler, constructorArgs) );
diff --git 
a/core/runtime/src/main/java/org/apache/isis/core/runtime/plugins/codegen/ProxyFactory.java
 
b/core/runtime/src/main/java/org/apache/isis/core/runtime/plugins/codegen/ProxyFactory.java
index b7c0ed2..b44936b 100644
--- 
a/core/runtime/src/main/java/org/apache/isis/core/runtime/plugins/codegen/ProxyFactory.java
+++ 
b/core/runtime/src/main/java/org/apache/isis/core/runtime/plugins/codegen/ProxyFactory.java
@@ -33,21 +33,18 @@ public interface ProxyFactory<T> {
        // -- INTERFACE
        
        /**
-        * 
         * @param handler
         * @param initialize whether to call a constructor on object 
instantiation 
-        * @return
+        * @return new proxy instance of type T
         * @throws IllegalArgumentException when using initialize=true and the 
number of 
         * constructorArgTypes specified while building this factory is greater 
than 0.
         */
        public T createInstance(InvocationHandler handler, boolean initialize);
        
        /**
-        * 
         * @param handler
         * @param constructorArgs passed to the constructor with matching 
signature on object instantiation
-        * @param initialize whether to call a constructor on object 
instantiation
-        * @return
+        * @return new proxy instance of type T (always uses a constructor)
         * @throws IllegalArgumentException if constructorArgs is null or empty 
or does not 
         * conform to the number of constructorArgTypes specified while 
building this factory.
         */

-- 
To stop receiving notification emails like this one, please contact
ahu...@apache.org.

Reply via email to