[GitHub] [karaf] jbonofre commented on a diff in pull request #1626: [KARAF-7068] add instance:package command to compress an instance into zip/tar.gz

[GitBox]

jbonofre commented on code in PR #1626:
URL: https://github.com/apache/karaf/pull/1626#discussion_r995722441


##
assemblies/features/standard/src/main/feature/feature.xml:
##
@@ -630,6 +630,7 @@ update = manager
 
 
 
+mvn:org.apache.commons/commons-compress/${commons-compress.version}

Review Comment:
   I think it's fine to only generate zip archive (not need to create tar.gz).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@karaf.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [karaf] jbonofre commented on a diff in pull request #1626: [KARAF-7068] add instance:package command to compress an instance into zip/tar.gz

[GitBox]

jbonofre commented on code in PR #1626:
URL: https://github.com/apache/karaf/pull/1626#discussion_r994228664


##
assemblies/features/standard/src/main/feature/feature.xml:
##
@@ -630,6 +630,7 @@ update = manager
 
 
 
+mvn:org.apache.commons/commons-compress/${commons-compress.version}

Review Comment:
   @awrb any update about removing `commons-compress` and using only zip ? I 
can do that if you prefer. Thanks !



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@karaf.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org