[madlib] branch master updated: indicate optional param in elastic net
This is an automated email from the ASF dual-hosted git repository. fmcquillan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/madlib.git The following commit(s) were added to refs/heads/master by this push: new 62e2a46 indicate optional param in elastic net 62e2a46 is described below commit 62e2a46173761e1d6ef4db8304e15506f724a708 Author: Frank McQuillan AuthorDate: Wed Feb 12 17:30:19 2020 -0800 indicate optional param in elastic net --- src/ports/postgres/modules/elastic_net/elastic_net.sql_in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ports/postgres/modules/elastic_net/elastic_net.sql_in b/src/ports/postgres/modules/elastic_net/elastic_net.sql_in index 157851d..c1aaebf 100644 --- a/src/ports/postgres/modules/elastic_net/elastic_net.sql_in +++ b/src/ports/postgres/modules/elastic_net/elastic_net.sql_in @@ -163,7 +163,7 @@ empty string, no columns are excluded. max_iter (optional) INTEGER, default: 1000. The maximum number of iterations allowed. -tolerance +tolerance (optional) FLOAT8, default: 1e-6. This is the criterion to stop iterating. Both the 'fista' and 'igd' optimizers compute the difference between the log likelihood of two consecutive iterations, and when the difference is smaller
[madlib] branch master updated: Check -mno-sse2 is available for GNU CXX
This is an automated email from the ASF dual-hosted git repository.
okislal pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/madlib.git
The following commit(s) were added to refs/heads/master by this push:
new 05a6e51 Check -mno-sse2 is available for GNU CXX
05a6e51 is described below
commit 05a6e51463fdd619151a8ecaabc1e659b9dfa3c0
Author: Ivan Leskin
AuthorDate: Wed Feb 12 17:13:30 2020 +0300
Check -mno-sse2 is available for GNU CXX
Jira: MADLIB-1410
Implement a check that '-mno-sse2' flag is available for the chosen GNU
CXX compiler.
This requires a new CMake module, 'CheckCXXCompilerFlag'. This is
available in CMake 2.8.4
(https://cmake.org/cmake/help/v2.8.4/cmake.html), which is the lowest
currently supported CMake version.
An extra CMake variable, 'SSE_DISABLE_OPTIONS', is introduced to hold
options required for GNU CXX compilers that support SSE-specific flags.
---
CMakeLists.txt | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 8670600..5ea7732 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -18,6 +18,7 @@ project(MADlib)
cmake_minimum_required(VERSION 2.8.4 FATAL_ERROR)
include(ExternalProject)
+include(CheckCXXCompilerFlag)
# -- Local definitions (filenames, paths, etc.)
@@ -92,13 +93,20 @@ if(CMAKE_COMPILER_IS_GNUCXX)
OUTPUT_VARIABLE GNUCXX_VERSION
OUTPUT_STRIP_TRAILING_WHITESPACE)
+# This flag is specific for i386 and x86-64 families
+# https://gcc.gnu.org/onlinedocs/gcc-4.8.5/gcc/i386-and-x86-64-Options.html
+CHECK_CXX_COMPILER_FLAG(-mno-sse2 SSE_DISABLE_OPTIONS_AVAILABLE)
+if (SSE_DISABLE_OPTIONS_AVAILABLE)
+set(SSE_DISABLE_OPTIONS "-mno-sse2")
+endif()
+
# We need the 1998 standard plus amendments (ISO/IEC 14882:2003) plus TR1
# Unfortunately, we only get this with gnu++98
# Special notes:
# - long long is not part of the C++ 1998/2003 standard, but it is such a
# common (and useful) extension that we do not want to hear warnings about
# it.
-set(CMAKE_CXX_FLAGS "-std=gnu++98 -D_GLIBCXX_USE_CXX11_ABI=0
-fdiagnostics-show-option -Wall -Wextra -pedantic -Wconversion -Wno-long-long
-Wno-clobbered -mno-sse2 -fstrict-aliasing"
+set(CMAKE_CXX_FLAGS "-std=gnu++98 -D_GLIBCXX_USE_CXX11_ABI=0
-fdiagnostics-show-option -Wall -Wextra -pedantic -Wconversion -Wno-long-long
-Wno-clobbered ${SSE_DISABLE_OPTIONS} -fstrict-aliasing"
CACHE STRING
"Flags used by the compiler during all build types." FORCE)
[madlib] branch master updated: indicate optional params in DR and RF
This is an automated email from the ASF dual-hosted git repository. fmcquillan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/madlib.git The following commit(s) were added to refs/heads/master by this push: new ac30a3c indicate optional params in DR and RF ac30a3c is described below commit ac30a3c508509a6996f872b0a7505b215c94fd85 Author: Frank McQuillan AuthorDate: Wed Feb 12 17:06:19 2020 -0800 indicate optional params in DR and RF --- .../postgres/modules/recursive_partitioning/decision_tree.sql_in| 6 +++--- .../postgres/modules/recursive_partitioning/random_forest.sql_in| 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/ports/postgres/modules/recursive_partitioning/decision_tree.sql_in b/src/ports/postgres/modules/recursive_partitioning/decision_tree.sql_in index 2408770..04f7b82 100644 --- a/src/ports/postgres/modules/recursive_partitioning/decision_tree.sql_in +++ b/src/ports/postgres/modules/recursive_partitioning/decision_tree.sql_in @@ -537,7 +537,7 @@ tree_predict(tree_model, 'estimated_prob_dep_value', where dep_value represents each value of the response variable. - type + type (optional) TEXT, optional, default: 'response'. For regression trees, the output is always the predicted value of the dependent variable. For classification trees, the type variable can be 'response', giving the @@ -580,10 +580,10 @@ split for a tuple. tree_model TEXT. Name of the table containing the decision tree model. -dot_format +dot_format (optional) BOOLEAN, default = TRUE. Output can either be in a dot format or a text format. If TRUE, the result is in the dot format, else output is in text format. -verbosity +verbosity (optional) BOOLEAN, default = FALSE. If set to TRUE, the dot format output will contain additional information (impurity, sample size, number of weighted rows for each response variable, classification or prediction if the tree diff --git a/src/ports/postgres/modules/recursive_partitioning/random_forest.sql_in b/src/ports/postgres/modules/recursive_partitioning/random_forest.sql_in index 251dfbc..888388c 100644 --- a/src/ports/postgres/modules/recursive_partitioning/random_forest.sql_in +++ b/src/ports/postgres/modules/recursive_partitioning/random_forest.sql_in @@ -545,7 +545,7 @@ forest_predict(random_forest_model, 'estimated_prob_dep_value', where dep_value represents each value of the response variable. - type + type (optional) TEXT, optional, default: 'response'. For regression trees, the output is always the predicted value of the dependent variable. For classification trees, the type variable can be 'response', giving the
