[GitHub] zhreshold commented on issue #11872: "socket.error: [Errno 111] Connection refused" while training with multiple workers
zhreshold commented on issue #11872: "socket.error: [Errno 111] Connection refused" while training with multiple workers URL: https://github.com/apache/incubator-mxnet/issues/11872#issuecomment-413429662 @ifeherva `docker run --shm-size xxx`, if not specified, docker has no shared memory This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ifeherva commented on issue #11872: "socket.error: [Errno 111] Connection refused" while training with multiple workers
ifeherva commented on issue #11872: "socket.error: [Errno 111] Connection refused" while training with multiple workers URL: https://github.com/apache/incubator-mxnet/issues/11872#issuecomment-413429373 I am using the latest master and the issue still persists in docker. Even num_workers = 1 causes a hang in the dataloader's while True loop This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] haojin2 opened a new pull request #12194: Fixing typo in python/mxnet/symbol/image.py
haojin2 opened a new pull request #12194: Fixing typo in python/mxnet/symbol/image.py URL: https://github.com/apache/incubator-mxnet/pull/12194 ## Description ## Fix for #12179. ## Checklist ## ### Essentials ### - [x] Changes are complete (i.e. I finished coding on this PR) - [x] All changes have test coverage: - Unit tests are added for small changes to verify correctness (e.g. adding a new operator) - Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore) - Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL) - [x] Code is well-documented: - For user-facing API changes, API doc string has been updated. - For new C++ functions in header files, their functionalities and arguments are documented. - For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable - Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html - [x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change ### Changes ### - [x] Fix typo ## Comments ## This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] haojin2 closed pull request #12194: Fixing typo in python/mxnet/symbol/image.py
haojin2 closed pull request #12194: Fixing typo in python/mxnet/symbol/image.py URL: https://github.com/apache/incubator-mxnet/pull/12194 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/python/mxnet/symbol/image.py b/python/mxnet/symbol/image.py index 7624bcced21..db03ca49a30 100644 --- a/python/mxnet/symbol/image.py +++ b/python/mxnet/symbol/image.py @@ -19,7 +19,7 @@ # pylint: disable=wildcard-import, unused-wildcard-import """Image Symbol API of MXNet.""" try: -from .gen_iamge import * +from .gen_image import * except ImportError: pass This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] anirudh2290 closed issue #11998: Flaky test MKLDNN_BASE.MKLDNNSum
anirudh2290 closed issue #11998: Flaky test MKLDNN_BASE.MKLDNNSum URL: https://github.com/apache/incubator-mxnet/issues/11998 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] anirudh2290 commented on issue #11998: Flaky test MKLDNN_BASE.MKLDNNSum
anirudh2290 commented on issue #11998: Flaky test MKLDNN_BASE.MKLDNNSum URL: https://github.com/apache/incubator-mxnet/issues/11998#issuecomment-413425388 Fixed by #12080 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] anirudh2290 closed pull request #12080: Fix MKLDNNSum cpp test failure
anirudh2290 closed pull request #12080: Fix MKLDNNSum cpp test failure
URL: https://github.com/apache/incubator-mxnet/pull/12080
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/tests/cpp/operator/mkldnn.cc b/tests/cpp/operator/mkldnn.cc
index 6cb1400149e..59bd3a547b7 100644
--- a/tests/cpp/operator/mkldnn.cc
+++ b/tests/cpp/operator/mkldnn.cc
@@ -1268,8 +1268,6 @@ TEST(IMPERATIVE, PoolingOp) {
}
}
-// Disabling Flaky Test. Tracked at
https://github.com/apache/incubator-mxnet/issues/11998
-/*
TEST(MKLDNN_BASE, MKLDNNSum) {
std::vector in_arrs = GetTestInputArrays();
std::vector in_arrs2 = GetTestInputArrays(true);
@@ -1310,6 +1308,7 @@ TEST(MKLDNN_BASE, MKLDNNSum) {
auto input_mem = in_arr.arr.GetMKLDNNData();
auto input_mem2 = in_arr2.arr.GetMKLDNNData();
NDArrayAttrs orig_arr(in_arr.arr.Copy(in_arr.arr.ctx()), "In Place Copy");
+orig_arr.arr.WaitToRead();
PrintVerifyMsg(orig_arr, in_arr);
InitMKLDNNArray(_arr.arr, input_mem->get_primitive_desc());
orig_arr.arr.CopyFrom(*input_mem);
@@ -1318,7 +1317,6 @@ TEST(MKLDNN_BASE, MKLDNNSum) {
VerifySumResult({_arr.arr, _arr2.arr}, {_arr.arr});
}
}
-*/
TEST(MKLDNN_BASE, CreateMKLDNNMem) {
std::vector in_arrs = GetTestInputArrays();
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[incubator-mxnet] branch master updated: Fix MKLDNNSum cpp test failure (#12080)
This is an automated email from the ASF dual-hosted git repository.
anirudh2290 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git
The following commit(s) were added to refs/heads/master by this push:
new ab92fd8 Fix MKLDNNSum cpp test failure (#12080)
ab92fd8 is described below
commit ab92fd80b10805fd103217df0569513289db4625
Author: Jin Huang <34262351+jinhuang...@users.noreply.github.com>
AuthorDate: Thu Aug 16 12:49:38 2018 +0800
Fix MKLDNNSum cpp test failure (#12080)
---
tests/cpp/operator/mkldnn.cc | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/tests/cpp/operator/mkldnn.cc b/tests/cpp/operator/mkldnn.cc
index 6cb1400..59bd3a5 100644
--- a/tests/cpp/operator/mkldnn.cc
+++ b/tests/cpp/operator/mkldnn.cc
@@ -1268,8 +1268,6 @@ TEST(IMPERATIVE, PoolingOp) {
}
}
-// Disabling Flaky Test. Tracked at
https://github.com/apache/incubator-mxnet/issues/11998
-/*
TEST(MKLDNN_BASE, MKLDNNSum) {
std::vector in_arrs = GetTestInputArrays();
std::vector in_arrs2 = GetTestInputArrays(true);
@@ -1310,6 +1308,7 @@ TEST(MKLDNN_BASE, MKLDNNSum) {
auto input_mem = in_arr.arr.GetMKLDNNData();
auto input_mem2 = in_arr2.arr.GetMKLDNNData();
NDArrayAttrs orig_arr(in_arr.arr.Copy(in_arr.arr.ctx()), "In Place Copy");
+orig_arr.arr.WaitToRead();
PrintVerifyMsg(orig_arr, in_arr);
InitMKLDNNArray(_arr.arr, input_mem->get_primitive_desc());
orig_arr.arr.CopyFrom(*input_mem);
@@ -1318,7 +1317,6 @@ TEST(MKLDNN_BASE, MKLDNNSum) {
VerifySumResult({_arr.arr, _arr2.arr}, {_arr.arr});
}
}
-*/
TEST(MKLDNN_BASE, CreateMKLDNNMem) {
std::vector in_arrs = GetTestInputArrays();
[GitHub] haojin2 commented on a change in pull request #12091: [MXNET-792] Fix for issue #9816 with dropout operator and RNG
haojin2 commented on a change in pull request #12091: [MXNET-792] Fix for issue #9816 with dropout operator and RNG URL: https://github.com/apache/incubator-mxnet/pull/12091#discussion_r210476089 ## File path: tests/python/unittest/test_operator.py ## @@ -5514,7 +5514,7 @@ def test_stack(): # test fails with seed 990952066: 0 output seen with dropout ratio=0. See issue #9816 Review comment: If no longer flaky please get rid of this line too. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] cclauss commented on issue #11904: 47 undefined variable errors with Pylint
cclauss commented on issue #11904: 47 undefined variable errors with Pylint URL: https://github.com/apache/incubator-mxnet/issues/11904#issuecomment-413424888 Pylint finds no undefined names when running on Python 2 and when running on Python 3? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sandeep-krishnamurthy closed issue #12066: Unable to library the package "mxnet" in R 3.5.1 on Mac
sandeep-krishnamurthy closed issue #12066: Unable to library the package "mxnet" in R 3.5.1 on Mac URL: https://github.com/apache/incubator-mxnet/issues/12066 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sandeep-krishnamurthy closed issue #10267: Continue train in R: what is begin_round?
sandeep-krishnamurthy closed issue #10267: Continue train in R: what is begin_round? URL: https://github.com/apache/incubator-mxnet/issues/10267 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sandeep-krishnamurthy closed issue #7590: Gradient function not returning enough gradient
sandeep-krishnamurthy closed issue #7590: Gradient function not returning enough gradient URL: https://github.com/apache/incubator-mxnet/issues/7590 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sandeep-krishnamurthy closed issue #10906: transforms.Compose not working as expected.
sandeep-krishnamurthy closed issue #10906: transforms.Compose not working as expected. URL: https://github.com/apache/incubator-mxnet/issues/10906 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sandeep-krishnamurthy closed issue #8415: python api docs: links to external resources broken
sandeep-krishnamurthy closed issue #8415: python api docs: links to external resources broken URL: https://github.com/apache/incubator-mxnet/issues/8415 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sandeep-krishnamurthy closed issue #11718: test_operator.test_laop has fixed seed that can mask flakiness
sandeep-krishnamurthy closed issue #11718: test_operator.test_laop has fixed seed that can mask flakiness URL: https://github.com/apache/incubator-mxnet/issues/11718 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sandeep-krishnamurthy closed issue #11716: test_operator.test_elementwise_sum has fixed seed that can mask flakiness
sandeep-krishnamurthy closed issue #11716: test_operator.test_elementwise_sum has fixed seed that can mask flakiness URL: https://github.com/apache/incubator-mxnet/issues/11716 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sandeep-krishnamurthy closed issue #11692: test_loss.test_ce_loss has fixed seed that can mask flakiness
sandeep-krishnamurthy closed issue #11692: test_loss.test_ce_loss has fixed seed that can mask flakiness URL: https://github.com/apache/incubator-mxnet/issues/11692 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sandeep-krishnamurthy closed issue #11691: test_loss.test_bce_loss has fixed seed that can mask flakiness
sandeep-krishnamurthy closed issue #11691: test_loss.test_bce_loss has fixed seed that can mask flakiness URL: https://github.com/apache/incubator-mxnet/issues/11691 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sandeep-krishnamurthy closed issue #11697: test_loss.test_kl_loss has fixed seed that can mask flakiness
sandeep-krishnamurthy closed issue #11697: test_loss.test_kl_loss has fixed seed that can mask flakiness URL: https://github.com/apache/incubator-mxnet/issues/11697 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sandeep-krishnamurthy closed issue #11694: test_loss.test_ctc_loss_train has fixed seed that can mask flakiness
sandeep-krishnamurthy closed issue #11694: test_loss.test_ctc_loss_train has fixed seed that can mask flakiness URL: https://github.com/apache/incubator-mxnet/issues/11694 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sandeep-krishnamurthy closed issue #11698: test_loss.test_l1_loss has fixed seed that can mask flakiness
sandeep-krishnamurthy closed issue #11698: test_loss.test_l1_loss has fixed seed that can mask flakiness URL: https://github.com/apache/incubator-mxnet/issues/11698 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sandeep-krishnamurthy closed issue #11702: test_loss.test_squared_hinge_loss has fixed seed that can mask flakiness
sandeep-krishnamurthy closed issue #11702: test_loss.test_squared_hinge_loss has fixed seed that can mask flakiness URL: https://github.com/apache/incubator-mxnet/issues/11702 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sandeep-krishnamurthy closed issue #11700: test_loss.test_sample_weight_loss has fixed seed that can mask flakiness
sandeep-krishnamurthy closed issue #11700: test_loss.test_sample_weight_loss has fixed seed that can mask flakiness URL: https://github.com/apache/incubator-mxnet/issues/11700 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sandeep-krishnamurthy closed issue #11703: test_loss.test_triplet_loss has fixed seed that can mask flakiness
sandeep-krishnamurthy closed issue #11703: test_loss.test_triplet_loss has fixed seed that can mask flakiness URL: https://github.com/apache/incubator-mxnet/issues/11703 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sandeep-krishnamurthy closed issue #11695: test_loss.test_hinge_loss has fixed seed that can mask flakiness
sandeep-krishnamurthy closed issue #11695: test_loss.test_hinge_loss has fixed seed that can mask flakiness URL: https://github.com/apache/incubator-mxnet/issues/11695 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sandeep-krishnamurthy closed issue #11704: test_module.test_factorization_machine_module has fixed seed that can mask flakiness
sandeep-krishnamurthy closed issue #11704: test_module.test_factorization_machine_module has fixed seed that can mask flakiness URL: https://github.com/apache/incubator-mxnet/issues/11704 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sandeep-krishnamurthy closed issue #11738: test_optimizer.test_signum has fixed seed that can mask flakiness
sandeep-krishnamurthy closed issue #11738: test_optimizer.test_signum has fixed seed that can mask flakiness URL: https://github.com/apache/incubator-mxnet/issues/11738 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sandeep-krishnamurthy closed issue #11740: test_sparse_ndarray.test_sparse_nd_pickle has fixed seed that can mask flakiness
sandeep-krishnamurthy closed issue #11740: test_sparse_ndarray.test_sparse_nd_pickle has fixed seed that can mask flakiness URL: https://github.com/apache/incubator-mxnet/issues/11740 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sandeep-krishnamurthy closed issue #11734: test_operator_gpu.test_psroipooling_with_type has fixed seed that can mask flakiness
sandeep-krishnamurthy closed issue #11734: test_operator_gpu.test_psroipooling_with_type has fixed seed that can mask flakiness URL: https://github.com/apache/incubator-mxnet/issues/11734 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sandeep-krishnamurthy closed issue #8049: Enable the test test_ndarray.test_cached after fixing the crash.
sandeep-krishnamurthy closed issue #8049: Enable the test test_ndarray.test_cached after fixing the crash. URL: https://github.com/apache/incubator-mxnet/issues/8049 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] vandanavk closed issue #11904: 47 undefined variable errors with Pylint
vandanavk closed issue #11904: 47 undefined variable errors with Pylint URL: https://github.com/apache/incubator-mxnet/issues/11904 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] vandanavk commented on issue #11904: 47 undefined variable errors with Pylint
vandanavk commented on issue #11904: 47 undefined variable errors with Pylint URL: https://github.com/apache/incubator-mxnet/issues/11904#issuecomment-413418000 All the errors in this list have been fixed. Closing this bug. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] eric-haibin-lin commented on issue #12197: topk regression
eric-haibin-lin commented on issue #12197: topk regression URL: https://github.com/apache/incubator-mxnet/issues/12197#issuecomment-413417215 @ciyongch thanks for looking into this. Your help is much appreciated This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] aaronmarkham commented on issue #11916: [MXNET-744] Sphinx error reduction
aaronmarkham commented on issue #11916: [MXNET-744] Sphinx error reduction URL: https://github.com/apache/incubator-mxnet/pull/11916#issuecomment-413415525 Need to rebase and test after recent updates! Let me do that before merging. Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wkcn edited a comment on issue #11913: Unexpectedly poor copy() performance
wkcn edited a comment on issue #11913: Unexpectedly poor copy() performance URL: https://github.com/apache/incubator-mxnet/issues/11913#issuecomment-413410094 @safrooze You are right. Sorry that I didn't know how many times the operator executes. I did a simple experiment [Code](https://gist.github.com/wkcn/63e11870c0d0e48e6fda95716b7171e4). It seems that the computation graph will not erased when reassign `b`. I ran your test on a server (28 cores), ``` copy: elapsed: 4.09 copy via add: elapsed: 0.39 ``` I think `copy via add` uses all cores, however `copy` uses restricted cores (less than all cores) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] aaronmarkham commented on issue #12195: [MXNet-744] Fix website build pipeline Python 3 issues
aaronmarkham commented on issue #12195: [MXNet-744] Fix website build pipeline Python 3 issues URL: https://github.com/apache/incubator-mxnet/pull/12195#issuecomment-413411307 Login to Jenkins and look at test-website-build. That's what points to the Jenkinsfile-dev version. Email notifications for failures are off and it doesn't run code on restricted nodes. Might be a better way to do it, but seemed best for the situation. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wkcn commented on issue #11913: Unexpectedly poor copy() performance
wkcn commented on issue #11913: Unexpectedly poor copy() performance URL: https://github.com/apache/incubator-mxnet/issues/11913#issuecomment-413410094 @safrooze You are right. Sorry that I didn't know how many times the operator executes. I did a simple experiment [Code](https://gist.github.com/wkcn/63e11870c0d0e48e6fda95716b7171e4). It seems that the computation graph will not erased when reassign `b`. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DuCheng2018 commented on issue #12041: Bug in v1.2.0 ?
DuCheng2018 commented on issue #12041: Bug in v1.2.0 ? URL: https://github.com/apache/incubator-mxnet/issues/12041#issuecomment-413408554 No one answer my question? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] nswamy closed pull request #12195: [MXNet-744] Fix website build pipeline Python 3 issues
nswamy closed pull request #12195: [MXNet-744] Fix website build pipeline
Python 3 issues
URL: https://github.com/apache/incubator-mxnet/pull/12195
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/ci/docker/Dockerfile.build.ubuntu_cpu
b/ci/docker/Dockerfile.build.ubuntu_cpu
index 76df3dfc1c1..08fb04df03e 100644
--- a/ci/docker/Dockerfile.build.ubuntu_cpu
+++ b/ci/docker/Dockerfile.build.ubuntu_cpu
@@ -61,6 +61,7 @@ COPY install/ubuntu_onnx.sh /work/
RUN /work/ubuntu_onnx.sh
COPY install/ubuntu_docs.sh /work/
+COPY install/docs_requirements /work/
RUN /work/ubuntu_docs.sh
ARG USER_ID=0
diff --git a/ci/docker/Dockerfile.build.ubuntu_gpu
b/ci/docker/Dockerfile.build.ubuntu_gpu
index 8b4cd1e5a3f..d99dafb0bd0 100644
--- a/ci/docker/Dockerfile.build.ubuntu_gpu
+++ b/ci/docker/Dockerfile.build.ubuntu_gpu
@@ -64,6 +64,7 @@ COPY install/ubuntu_onnx.sh /work/
RUN /work/ubuntu_onnx.sh
COPY install/ubuntu_docs.sh /work/
+COPY install/docs_requirements /work/
RUN /work/ubuntu_docs.sh
COPY install/ubuntu_tutorials.sh /work/
diff --git a/ci/docker/Dockerfile.build.ubuntu_nightly_cpu
b/ci/docker/Dockerfile.build.ubuntu_nightly_cpu
index c803188263f..834710c4ceb 100644
--- a/ci/docker/Dockerfile.build.ubuntu_nightly_cpu
+++ b/ci/docker/Dockerfile.build.ubuntu_nightly_cpu
@@ -58,6 +58,7 @@ COPY install/ubuntu_onnx.sh /work/
RUN /work/ubuntu_onnx.sh
COPY install/ubuntu_docs.sh /work/
+COPY install/docs_requirements /work/
RUN /work/ubuntu_docs.sh
COPY install/ubuntu_nightly_tests.sh /work/
diff --git a/ci/docker/Dockerfile.build.ubuntu_nightly_gpu
b/ci/docker/Dockerfile.build.ubuntu_nightly_gpu
index c0e31e2c15e..fb34307063a 100644
--- a/ci/docker/Dockerfile.build.ubuntu_nightly_gpu
+++ b/ci/docker/Dockerfile.build.ubuntu_nightly_gpu
@@ -64,6 +64,7 @@ COPY install/ubuntu_onnx.sh /work/
RUN /work/ubuntu_onnx.sh
COPY install/ubuntu_docs.sh /work/
+COPY install/docs_requirements /work/
RUN /work/ubuntu_docs.sh
COPY install/ubuntu_tutorials.sh /work/
diff --git a/docs/build_version_doc/requirements.txt
b/ci/docker/install/docs_requirements
similarity index 51%
rename from docs/build_version_doc/requirements.txt
rename to ci/docker/install/docs_requirements
index 4f3f4d065c9..7407223b3ee 100644
--- a/docs/build_version_doc/requirements.txt
+++ b/ci/docker/install/docs_requirements
@@ -1,15 +1,16 @@
-beautifulsoup4
-breathe
+beautifulsoup4==4.6.3
+breathe==4.10.0
cpplint==1.3.0
CommonMark==0.5.4
h5py==2.8.0rc1
-mock==1.0.1
-nose
-nose-timer
+mock==2.0.0
+nose==1.3.7
+nose-timer==0.7.3
numpy<1.15.0,>=1.8.2
pylint==1.8.3
-pypandoc
-recommonmark==0.4.0
+pypandoc==1.4
+recommonmark==0.4.0
requests<2.19.0,>=2.18.4
scipy==1.0.1
+six==1.11.0
sphinx==1.5.6
diff --git a/ci/docker/install/ubuntu_docs.sh b/ci/docker/install/ubuntu_docs.sh
index ee121962ee0..a709b3de784 100755
--- a/ci/docker/install/ubuntu_docs.sh
+++ b/ci/docker/install/ubuntu_docs.sh
@@ -27,15 +27,7 @@ apt-get install -y \
doxygen \
pandoc
-echo 'Installing python packages...'
-pip install --upgrade pip && pip install \
-beautifulsoup4 \
-breathe \
-CommonMark==0.5.4 \
-h5py \
-mock==1.0.1 \
-pypandoc \
-recommonmark==0.4.0 \
-sphinx==1.5.6
+pip3 install -r /work/docs_requirements
+pip2 install -r /work/docs_requirements
echo 'Dependency installation complete.'
diff --git a/docs/Jenkinsfile-dev b/docs/Jenkinsfile-dev
new file mode 100644
index 000..b93eba6489d
--- /dev/null
+++ b/docs/Jenkinsfile-dev
@@ -0,0 +1,54 @@
+// -*- mode: groovy -*-
+
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+// Jenkins pipeline
+// See documents at https://jenkins.io/doc/book/pipeline/jenkinsfile/
+
+// timeout in minutes
+max_time = 60
+
+node('mxnetlinux-cpu') {
+ // Loading the utilities requires a node context unfortunately
+ checkout scm
+ utils = load('ci/Jenkinsfile_utils.groovy')
+}
+utils.assign_node_labels(linux_cpu: 'mxnetlinux-cpu', linux_gpu:
'mxnetlinux-gpu', linux_gpu_p3:
[incubator-mxnet] branch master updated: [MXNet-744] Fix website build pipeline Python 3 issues (#12195)
This is an automated email from the ASF dual-hosted git repository. nswamy pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git The following commit(s) were added to refs/heads/master by this push: new 7cb28f2 [MXNet-744] Fix website build pipeline Python 3 issues (#12195) 7cb28f2 is described below commit 7cb28f21e2720afd8dec9f54dd6a61d023a018f2 Author: Aaron Markham AuthorDate: Wed Aug 15 19:44:24 2018 -0700 [MXNet-744] Fix website build pipeline Python 3 issues (#12195) * Fix website build pipeline Python 3 issues (#12195) --- ci/docker/Dockerfile.build.ubuntu_cpu | 1 + ci/docker/Dockerfile.build.ubuntu_gpu | 1 + ci/docker/Dockerfile.build.ubuntu_nightly_cpu | 1 + ci/docker/Dockerfile.build.ubuntu_nightly_gpu | 1 + .../docker/install/docs_requirements | 15 +++--- ci/docker/install/ubuntu_docs.sh | 12 + docs/Jenkinsfile-dev | 54 ++ docs/build_version_doc/setup_docs_ubuntu.sh| 4 +- docs/mxdoc.py | 11 ++--- 9 files changed, 75 insertions(+), 25 deletions(-) diff --git a/ci/docker/Dockerfile.build.ubuntu_cpu b/ci/docker/Dockerfile.build.ubuntu_cpu index 76df3df..08fb04d 100644 --- a/ci/docker/Dockerfile.build.ubuntu_cpu +++ b/ci/docker/Dockerfile.build.ubuntu_cpu @@ -61,6 +61,7 @@ COPY install/ubuntu_onnx.sh /work/ RUN /work/ubuntu_onnx.sh COPY install/ubuntu_docs.sh /work/ +COPY install/docs_requirements /work/ RUN /work/ubuntu_docs.sh ARG USER_ID=0 diff --git a/ci/docker/Dockerfile.build.ubuntu_gpu b/ci/docker/Dockerfile.build.ubuntu_gpu index 8b4cd1e..d99dafb 100644 --- a/ci/docker/Dockerfile.build.ubuntu_gpu +++ b/ci/docker/Dockerfile.build.ubuntu_gpu @@ -64,6 +64,7 @@ COPY install/ubuntu_onnx.sh /work/ RUN /work/ubuntu_onnx.sh COPY install/ubuntu_docs.sh /work/ +COPY install/docs_requirements /work/ RUN /work/ubuntu_docs.sh COPY install/ubuntu_tutorials.sh /work/ diff --git a/ci/docker/Dockerfile.build.ubuntu_nightly_cpu b/ci/docker/Dockerfile.build.ubuntu_nightly_cpu index c803188..834710c 100644 --- a/ci/docker/Dockerfile.build.ubuntu_nightly_cpu +++ b/ci/docker/Dockerfile.build.ubuntu_nightly_cpu @@ -58,6 +58,7 @@ COPY install/ubuntu_onnx.sh /work/ RUN /work/ubuntu_onnx.sh COPY install/ubuntu_docs.sh /work/ +COPY install/docs_requirements /work/ RUN /work/ubuntu_docs.sh COPY install/ubuntu_nightly_tests.sh /work/ diff --git a/ci/docker/Dockerfile.build.ubuntu_nightly_gpu b/ci/docker/Dockerfile.build.ubuntu_nightly_gpu index c0e31e2..fb34307 100644 --- a/ci/docker/Dockerfile.build.ubuntu_nightly_gpu +++ b/ci/docker/Dockerfile.build.ubuntu_nightly_gpu @@ -64,6 +64,7 @@ COPY install/ubuntu_onnx.sh /work/ RUN /work/ubuntu_onnx.sh COPY install/ubuntu_docs.sh /work/ +COPY install/docs_requirements /work/ RUN /work/ubuntu_docs.sh COPY install/ubuntu_tutorials.sh /work/ diff --git a/docs/build_version_doc/requirements.txt b/ci/docker/install/docs_requirements similarity index 51% rename from docs/build_version_doc/requirements.txt rename to ci/docker/install/docs_requirements index 4f3f4d0..7407223 100644 --- a/docs/build_version_doc/requirements.txt +++ b/ci/docker/install/docs_requirements @@ -1,15 +1,16 @@ -beautifulsoup4 -breathe +beautifulsoup4==4.6.3 +breathe==4.10.0 cpplint==1.3.0 CommonMark==0.5.4 h5py==2.8.0rc1 -mock==1.0.1 -nose -nose-timer +mock==2.0.0 +nose==1.3.7 +nose-timer==0.7.3 numpy<1.15.0,>=1.8.2 pylint==1.8.3 -pypandoc -recommonmark==0.4.0 +pypandoc==1.4 +recommonmark==0.4.0 requests<2.19.0,>=2.18.4 scipy==1.0.1 +six==1.11.0 sphinx==1.5.6 diff --git a/ci/docker/install/ubuntu_docs.sh b/ci/docker/install/ubuntu_docs.sh index ee12196..a709b3d 100755 --- a/ci/docker/install/ubuntu_docs.sh +++ b/ci/docker/install/ubuntu_docs.sh @@ -27,15 +27,7 @@ apt-get install -y \ doxygen \ pandoc -echo 'Installing python packages...' -pip install --upgrade pip && pip install \ -beautifulsoup4 \ -breathe \ -CommonMark==0.5.4 \ -h5py \ -mock==1.0.1 \ -pypandoc \ -recommonmark==0.4.0 \ -sphinx==1.5.6 +pip3 install -r /work/docs_requirements +pip2 install -r /work/docs_requirements echo 'Dependency installation complete.' diff --git a/docs/Jenkinsfile-dev b/docs/Jenkinsfile-dev new file mode 100644 index 000..b93eba6 --- /dev/null +++ b/docs/Jenkinsfile-dev @@ -0,0 +1,54 @@ +// -*- mode: groovy -*- + +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +//
[GitHub] nswamy commented on issue #12195: [MXNet-744] Fix website build pipeline Python 3 issues
nswamy commented on issue #12195: [MXNet-744] Fix website build pipeline Python 3 issues URL: https://github.com/apache/incubator-mxnet/pull/12195#issuecomment-413406357 LGTM, but I am not sure where is the new Jenkinsfile-dev used. I will merge this to unblock CI and can continue to follow up. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] nswamy commented on a change in pull request #12195: [MXNet-744] Fix website build pipeline Python 3 issues
nswamy commented on a change in pull request #12195: [MXNet-744] Fix website build pipeline Python 3 issues URL: https://github.com/apache/incubator-mxnet/pull/12195#discussion_r210462918 ## File path: docs/Jenkinsfile-dev ## @@ -0,0 +1,54 @@ +// -*- mode: groovy -*- Review comment: where is this file used? why is it called Jenkinsfile-dev? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] nswamy commented on issue #11990: [MXNET-744] Docs build tools update
nswamy commented on issue #11990: [MXNET-744] Docs build tools update URL: https://github.com/apache/incubator-mxnet/pull/11990#issuecomment-413403016 aaronmarkham understand CI changing to Py3 caused your code to break, however we cannot have CI blocked. Thanks for acting swiftly on this. I'll review #12195 and merge once it passes CI This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ciyongch commented on issue #12197: topk regression
ciyongch commented on issue #12197: topk regression URL: https://github.com/apache/incubator-mxnet/issues/12197#issuecomment-413401932 @leezu Thanks for reporting the issue, I'm looking into this now. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] aaronmarkham commented on issue #11990: [MXNET-744] Docs build tools update
aaronmarkham commented on issue #11990: [MXNET-744] Docs build tools update URL: https://github.com/apache/incubator-mxnet/pull/11990#issuecomment-413400855 It was actually the switch to Python 3 in CI that overlapped on this PR. Docs has been building in Python 2 prior to last week. Anyways, I believe I fixed it. Here's my test run: http://jenkins.mxnet-ci.amazon-ml.com/job/test-website-build/22/console See #12195. It needs a review. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] indhub closed issue #10571: Gluon not mentioned in Symbol API tutorial
indhub closed issue #10571: Gluon not mentioned in Symbol API tutorial URL: https://github.com/apache/incubator-mxnet/issues/10571 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] indhub closed issue #8969: A couple of issues in benchmark_score.py
indhub closed issue #8969: A couple of issues in benchmark_score.py URL: https://github.com/apache/incubator-mxnet/issues/8969 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] gigasquid opened a new pull request #12198: Add Codeowner for Clojure Package
gigasquid opened a new pull request #12198: Add Codeowner for Clojure Package URL: https://github.com/apache/incubator-mxnet/pull/12198 ## Description ## Add gigasquid (Carin Meier) to the Clojure language binding ## Checklist ## ### Essentials ### Please feel free to remove inapplicable items for your PR. - [X] Changes are complete (i.e. I finished coding on this PR) - [X ] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] leezu opened a new issue #12197: topk regression
leezu opened a new issue #12197: topk regression
URL: https://github.com/apache/incubator-mxnet/issues/12197
## Description
https://github.com/apache/incubator-mxnet/pull/12085/ introduced a bug into
the topk operator. Below code example will output `[ 274232. 179574. 274233.
274231.]` with mxnet-cu90==1.3.0b20180810 but `[ 274232. 179574. 274232.
274232.]` with mxnet-cu90==1.3.0b20180814.
@szha @ciyongch @eric-haibin-lin
## Steps to reproduce
(Paste the commands you ran that produced the error.)
1. `wget https://s3.amazonaws.com/lllausen-public/topk/array.npy`
2. `python3 -c 'import mxnet as mx;import numpy as np;
print(mx.nd.topk(mx.nd.array(np.load("/tmp/array.npy")), k=4)[80])'`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] gigasquid opened a new pull request #12196: Adding Clojure Tests to Increase Coverage
gigasquid opened a new pull request #12196: Adding Clojure Tests to Increase Coverage URL: https://github.com/apache/incubator-mxnet/pull/12196 ## Description ## This adds to the Clojure unit tests to increase coverage ## Checklist ## ### Essentials ### Please feel free to remove inapplicable items for your PR. - [X] Changes are complete (i.e. I finished coding on this PR) - [X] All changes have test coverage: - [X] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change ### Changes ### - Unit tests have been added - Text change to Visualization README ## Comments ## Old cloverage results: ``` |-+-+-| | Namespace | % Forms | % Lines | |-+-+-| | dev.generator | 93.07 | 94.33 | | org.apache.clojure-mxnet.base | 100.00 | 100.00 | | org.apache.clojure-mxnet.callback | 100.00 | 100.00 | |org.apache.clojure-mxnet.context | 76.00 | 85.71 | | org.apache.clojure-mxnet.dtype | 100.00 | 100.00 | |org.apache.clojure-mxnet.eval-metric | 95.00 | 100.00 | | org.apache.clojure-mxnet.executor | 89.66 | 95.00 | |org.apache.clojure-mxnet.initializer | 25.00 | 43.75 | | org.apache.clojure-mxnet.io | 71.71 | 80.00 | |org.apache.clojure-mxnet.kvstore | 82.91 | 76.00 | | org.apache.clojure-mxnet.kvstore-server | 58.73 | 50.00 | | org.apache.clojure-mxnet.lr-scheduler | 22.22 | 66.67 | | org.apache.clojure-mxnet.module | 74.99 | 88.62 | |org.apache.clojure-mxnet.monitor | 100.00 | 100.00 | |org.apache.clojure-mxnet.ndarray | 90.86 | 91.38 | | org.apache.clojure-mxnet.optimizer | 91.21 | 88.24 | | org.apache.clojure-mxnet.profiler | 20.00 | 40.00 | | org.apache.clojure-mxnet.random | 100.00 | 100.00 | | org.apache.clojure-mxnet.shape | 94.44 | 90.00 | | org.apache.clojure-mxnet.symbol | 48.87 | 54.62 | | org.apache.clojure-mxnet.util | 98.86 | 99.16 | | org.apache.clojure-mxnet.visualization |6.82 | 20.00 | |-+-+-| | ALL FILES | 80.01 | 84.14 | |-+-+-| ``` New cloverage results: ``` |-+-+-| | Namespace | % Forms | % Lines | |-+-+-| | dev.generator | 99.19 | 100.00 | | org.apache.clojure-mxnet.base | 100.00 | 100.00 | | org.apache.clojure-mxnet.callback | 100.00 | 100.00 | |org.apache.clojure-mxnet.context | 76.00 | 85.71 | | org.apache.clojure-mxnet.dtype | 100.00 | 100.00 | |org.apache.clojure-mxnet.eval-metric | 95.00 | 100.00 | | org.apache.clojure-mxnet.executor | 89.66 | 95.00 | |org.apache.clojure-mxnet.initializer | 100.00 | 100.00 | | org.apache.clojure-mxnet.io | 71.71 | 80.00 | |org.apache.clojure-mxnet.kvstore | 82.91 | 76.00 | | org.apache.clojure-mxnet.kvstore-server | 58.73 | 50.00 | | org.apache.clojure-mxnet.lr-scheduler | 100.00 | 100.00 | | org.apache.clojure-mxnet.module | 75.30 | 89.00 | |org.apache.clojure-mxnet.monitor | 100.00 | 100.00 | |org.apache.clojure-mxnet.ndarray | 90.86 | 91.38 | | org.apache.clojure-mxnet.optimizer | 91.21 | 88.24 | | org.apache.clojure-mxnet.profiler | 85.00 | 90.00 | | org.apache.clojure-mxnet.random | 100.00 | 100.00 | | org.apache.clojure-mxnet.shape | 94.44 | 90.00 | | org.apache.clojure-mxnet.symbol | 51.13 | 57.14 | | org.apache.clojure-mxnet.util | 98.86 | 99.16 | | org.apache.clojure-mxnet.visualization | 54.55 | 73.33 | |-+-+-| | ALL FILES | 82.50 | 87.26 | |-+-+-| ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-mxnet] 01/01: add initializer test
This is an automated email from the ASF dual-hosted git repository.
cmeier pushed a commit to branch more-clojure-tests
in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git
commit e80765f4929caa5f65050b43eb89e7684b220ded
Author: gigasquid
AuthorDate: Fri Aug 3 14:50:52 2018 -0400
add initializer test
add profiler and lr-scheduler tests
basic symbol test
add more symbol tests
re-enable deeper visualization graph example and add simple test
running cljfmt
add license - fix typo
---
.../examples/tutorial/src/tutorial/symbol.clj | 1 -
.../examples/visualization/README.md | 2 +
.../visualization/src/visualization/core.clj | 18 +
.../clojure-package/examples/visualization/testviz | 32 +++
.../src/org/apache/clojure_mxnet/profiler.clj | 2 +-
.../org/apache/clojure_mxnet/initializer_test.clj | 45 ++
.../org/apache/clojure_mxnet/lr_scheduler_test.clj | 24
.../org/apache/clojure_mxnet/profiler_test.clj | 31 +++
.../test/org/apache/clojure_mxnet/symbol_test.clj | 32 ++-
.../apache/clojure_mxnet/visualization_test.clj| 38 ++
10 files changed, 214 insertions(+), 11 deletions(-)
diff --git a/contrib/clojure-package/examples/tutorial/src/tutorial/symbol.clj
b/contrib/clojure-package/examples/tutorial/src/tutorial/symbol.clj
index 0dd0e4d..bec71de 100644
--- a/contrib/clojure-package/examples/tutorial/src/tutorial/symbol.clj
+++ b/contrib/clojure-package/examples/tutorial/src/tutorial/symbol.clj
@@ -50,7 +50,6 @@ net ;=> #object[org.apache.mxnet.Symbol 0x5c78c8c2
"org.apache.mxnet.Symbol@5c78
(def b (sym/variable "b"))
(def c (sym/+ a b))
-
;; Each symbol takes a (unique) string name. NDArray and Symbol both represent
a single tensor. Operators represent the computation between tensors. Operators
take symbol (or NDArray) as inputs and might also additionally accept other
hyperparameters such as the number of hidden neurons (num_hidden) or the
activation type (act_type) and produce the output.
;; We can view a symbol simply as a function taking several arguments. And we
can retrieve those arguments with the following method call:
diff --git a/contrib/clojure-package/examples/visualization/README.md
b/contrib/clojure-package/examples/visualization/README.md
index 8c6e2c2..54ece37 100644
--- a/contrib/clojure-package/examples/visualization/README.md
+++ b/contrib/clojure-package/examples/visualization/README.md
@@ -1,4 +1,6 @@
# visualization
+You must have graphviz installed to be able to run this.
+
Run `lein run` to have a sample network visualization printed for you
"testviz.pdf"
diff --git
a/contrib/clojure-package/examples/visualization/src/visualization/core.clj
b/contrib/clojure-package/examples/visualization/src/visualization/core.clj
index 31cce92..8e51d87 100644
--- a/contrib/clojure-package/examples/visualization/src/visualization/core.clj
+++ b/contrib/clojure-package/examples/visualization/src/visualization/core.clj
@@ -22,16 +22,18 @@
(defn get-symbol []
(as-> (sym/variable "data") data
-#_(sym/convolution "conv1" {:data data :kernel [3 3] :num-filter 32
:stride [2 2]})
-#_(sym/batch-norm "bn1" {:data data})
-#_(sym/activation "relu1" {:data data :act-type "relu"})
-#_(sym/pooling "mp1" {:data data :kernel [2 2] :pool-type "max" :stride [2
2]}) #_(sym/convolution "conv2" {:data data :kernel [3 3] :num-filter 32
:stride [2 2]})
-#_(sym/batch-norm "bn2" {:data data})
-#_(sym/activation "relu2" {:data data :act-type "relu"})
-#_(sym/pooling "mp2" {:data data :kernel [2 2] :pool-type "max" :stride [2
2]})
+(sym/convolution "conv1" {:data data :kernel [3 3] :num-filter 32 :stride
[2 2]})
+
+(sym/batch-norm "bn1" {:data data})
+(sym/activation "relu1" {:data data :act-type "relu"})
+(sym/pooling "mp1" {:data data :kernel [2 2] :pool-type "max" :stride [2
2]})
+(sym/convolution "conv2" {:data data :kernel [3 3] :num-filter 32 :stride
[2 2]})
+(sym/batch-norm "bn2" {:data data})
+(sym/activation "relu2" {:data data :act-type "relu"})
+(sym/pooling "mp2" {:data data :kernel [2 2] :pool-type "max" :stride [2
2]})
(sym/flatten "fl" {:data data})
-#_(sym/fully-connected "fc2" {:data data :num-hidden 10})
+(sym/fully-connected "fc2" {:data data :num-hidden 10})
(sym/softmax-output "softmax" {:data data})))
(defn test-viz []
diff --git a/contrib/clojure-package/examples/visualization/testviz
b/contrib/clojure-package/examples/visualization/testviz
new file mode 100644
index 000..c0161e9
--- /dev/null
+++ b/contrib/clojure-package/examples/visualization/testviz
@@ -0,0 +1,32 @@
+digraph foo{
+ data [label=data fixedsize=false style=filled height=0.8034
fillcolor="#8dd3c7" shape=oval width=1.3]
+ conv1 [label="Convolution\n3x3/2x2, 32" fixedsize=false style=filled
[incubator-mxnet] branch more-clojure-tests updated (41b9a26 -> e80765f)
This is an automated email from the ASF dual-hosted git repository. cmeier pushed a change to branch more-clojure-tests in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git. discard 41b9a26 add license - fix typo discard 8805ef7 running cljfmt discard ac7e714 re-enable deeper visualization graph example and add simple test discard d4a257a add more symbol tests discard af5d0b8 basic symbol test discard 2408802 add profiler and lr-scheduler tests discard 132c87d add initializer test new e80765f add initializer test This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (41b9a26) \ N -- N -- N refs/heads/more-clojure-tests (e80765f) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes:
[GitHub] sandeep-krishnamurthy closed issue #7652: Need a clear and thorough tutorial for writing custom operators in c++ with nnvm
sandeep-krishnamurthy closed issue #7652: Need a clear and thorough tutorial for writing custom operators in c++ with nnvm URL: https://github.com/apache/incubator-mxnet/issues/7652 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sandeep-krishnamurthy closed issue #11733: test_operator_gpu.test_pooling_with_type has fixed seed that can mask flakiness
sandeep-krishnamurthy closed issue #11733: test_operator_gpu.test_pooling_with_type has fixed seed that can mask flakiness URL: https://github.com/apache/incubator-mxnet/issues/11733 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sandeep-krishnamurthy closed issue #11729: test_operator_gpu.test_deformable_psroipooling_with_type has fixed seed that can mask flakiness
sandeep-krishnamurthy closed issue #11729: test_operator_gpu.test_deformable_psroipooling_with_type has fixed seed that can mask flakiness URL: https://github.com/apache/incubator-mxnet/issues/11729 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sandeep-krishnamurthy closed issue #11410: Flaky test: test_operator_gpu.test_rnnrelu_bidirectional
sandeep-krishnamurthy closed issue #11410: Flaky test: test_operator_gpu.test_rnnrelu_bidirectional URL: https://github.com/apache/incubator-mxnet/issues/11410 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sandeep-krishnamurthy closed issue #11456: test_quantization.test_get_optimal_thresholds sometimes fails during testing.
sandeep-krishnamurthy closed issue #11456: test_quantization.test_get_optimal_thresholds sometimes fails during testing. URL: https://github.com/apache/incubator-mxnet/issues/11456 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] merrymercy commented on issue #11325: [MXNET-703] TensorRT runtime integration
merrymercy commented on issue #11325: [MXNET-703] TensorRT runtime integration URL: https://github.com/apache/incubator-mxnet/pull/11325#issuecomment-413390917 @mkolod The link to README is broken. Can you update it? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-mxnet] branch more-clojure-tests updated (ac7e714 -> 41b9a26)
This is an automated email from the ASF dual-hosted git repository. cmeier pushed a change to branch more-clojure-tests in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git. from ac7e714 re-enable deeper visualization graph example and add simple test new 8805ef7 running cljfmt new 41b9a26 add license - fix typo The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../examples/tutorial/src/tutorial/symbol.clj | 1 - .../test/org/apache/clojure_mxnet/profiler_test.clj | 1 - .../org/apache/clojure_mxnet/visualization_test.clj | 19 ++- 3 files changed, 18 insertions(+), 3 deletions(-)
[incubator-mxnet] 02/02: add license - fix typo
This is an automated email from the ASF dual-hosted git repository.
cmeier pushed a commit to branch more-clojure-tests
in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git
commit 41b9a262e01f9e8a051d518424c185501c317202
Author: gigasquid
AuthorDate: Wed Aug 15 21:11:38 2018 -0400
add license - fix typo
---
.../org/apache/clojure_mxnet/visualization_test.clj | 19 ++-
1 file changed, 18 insertions(+), 1 deletion(-)
diff --git
a/contrib/clojure-package/test/org/apache/clojure_mxnet/visualization_test.clj
b/contrib/clojure-package/test/org/apache/clojure_mxnet/visualization_test.clj
index 945d74b..2332941 100644
---
a/contrib/clojure-package/test/org/apache/clojure_mxnet/visualization_test.clj
+++
b/contrib/clojure-package/test/org/apache/clojure_mxnet/visualization_test.clj
@@ -1,10 +1,27 @@
+;;
+;; Licensed to the Apache Software Foundation (ASF) under one or more
+;; contributor license agreements. See the NOTICE file distributed with
+;; this work for additional information regarding copyright ownership.
+;; The ASF licenses this file to You under the Apache License, Version 2.0
+;; (the "License"); you may not use this file except in compliance with
+;; the License. You may obtain a copy of the License at
+;;
+;;http://www.apache.org/licenses/LICENSE-2.0
+;;
+;; Unless required by applicable law or agreed to in writing, software
+;; distributed under the License is distributed on an "AS IS" BASIS,
+;; WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+;; See the License for the specific language governing permissions and
+;; limitations under the License.
+;;
+
(ns org.apache.clojure-mxnet.visualization-test
(:require [org.apache.clojure-mxnet.symbol :as sym]
[org.apache.clojure-mxnet.visualization :as viz]
[clojure.test :refer :all])
(:import (org.apache.mxnet Visualization$Dot)))
-(defn test-plot-network
+(deftest test-plot-network
(let [to-plot-sym (as-> (sym/variable "data") data
(sym/convolution "conv1" {:data data
:kernel [3 3]
[incubator-mxnet] 01/02: running cljfmt
This is an automated email from the ASF dual-hosted git repository. cmeier pushed a commit to branch more-clojure-tests in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git commit 8805ef7f02e98b266f608d4fb49f3c1826c1744a Author: gigasquid AuthorDate: Wed Aug 15 21:08:16 2018 -0400 running cljfmt --- contrib/clojure-package/examples/tutorial/src/tutorial/symbol.clj | 1 - contrib/clojure-package/test/org/apache/clojure_mxnet/profiler_test.clj | 1 - 2 files changed, 2 deletions(-) diff --git a/contrib/clojure-package/examples/tutorial/src/tutorial/symbol.clj b/contrib/clojure-package/examples/tutorial/src/tutorial/symbol.clj index 0dd0e4d..bec71de 100644 --- a/contrib/clojure-package/examples/tutorial/src/tutorial/symbol.clj +++ b/contrib/clojure-package/examples/tutorial/src/tutorial/symbol.clj @@ -50,7 +50,6 @@ net ;=> #object[org.apache.mxnet.Symbol 0x5c78c8c2 "org.apache.mxnet.Symbol@5c78 (def b (sym/variable "b")) (def c (sym/+ a b)) - ;; Each symbol takes a (unique) string name. NDArray and Symbol both represent a single tensor. Operators represent the computation between tensors. Operators take symbol (or NDArray) as inputs and might also additionally accept other hyperparameters such as the number of hidden neurons (num_hidden) or the activation type (act_type) and produce the output. ;; We can view a symbol simply as a function taking several arguments. And we can retrieve those arguments with the following method call: diff --git a/contrib/clojure-package/test/org/apache/clojure_mxnet/profiler_test.clj b/contrib/clojure-package/test/org/apache/clojure_mxnet/profiler_test.clj index d45a993..f4b7434 100644 --- a/contrib/clojure-package/test/org/apache/clojure_mxnet/profiler_test.clj +++ b/contrib/clojure-package/test/org/apache/clojure_mxnet/profiler_test.clj @@ -19,7 +19,6 @@ (:require [org.apache.clojure-mxnet.profiler :as profiler] [clojure.test :refer :all])) - ;; Just excercising the interop (deftest test-profiler
[GitHub] szha closed issue #9587: metric.F1 doc needs clarification
szha closed issue #9587: metric.F1 doc needs clarification URL: https://github.com/apache/incubator-mxnet/issues/9587 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] szha closed issue #11728: test_operator_gpu.test_deformable_convolution_with_type has fixed seed that can mask flakiness
szha closed issue #11728: test_operator_gpu.test_deformable_convolution_with_type has fixed seed that can mask flakiness URL: https://github.com/apache/incubator-mxnet/issues/11728 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rahul003 commented on a change in pull request #11234: [MXNET-535] Fix bugs in LR Schedulers and add warmup
rahul003 commented on a change in pull request #11234: [MXNET-535] Fix bugs in
LR Schedulers and add warmup
URL: https://github.com/apache/incubator-mxnet/pull/11234#discussion_r210452043
##
File path: python/mxnet/lr_scheduler.py
##
@@ -138,33 +171,73 @@ def __call__(self, num_update):
return self.base_lr
class PolyScheduler(LRScheduler):
+""" Reduce the learning rate according to a polynomial of given power.
+
+Calculate the new learning rate by::
+
+ final_lr + (start_lr - final_lr) * (1-nup/max_nup)^pwr
+ if nup < max_nup, 0 otherwise.
+
+Parameters
+--
+ max_update: maximum number of updates before the decay reaches final
learning rate.
+ base_lr:base learning rate to start from
+ pwr: power of the decay term as a function of the current number of
updates.
+ final_lr: final learning rate after all steps
+ warmup_steps: number of warmup steps used before this scheduler starts
decay
+"""
+
+def __init__(self, max_update, base_lr=0.01, pwr=2, final_lr=0,
+ warmup_steps=0, warmup_begin_lr=0, warmup_mode='linear'):
+super(PolyScheduler, self).__init__(base_lr, warmup_steps,
warmup_begin_lr, warmup_mode)
+assert isinstance(max_update, int)
+if max_update < 1:
+raise ValueError("maximum number of updates must be strictly
positive")
+self.power = pwr
+self.base_lr_orig = self.base_lr
+self.max_update = max_update
+self.final_lr = final_lr
+self.max_steps = self.max_update - self.warmup_steps
+
+def __call__(self, num_update):
+if num_update < self.warmup_steps:
+return self.get_warmup_lr(num_update)
+if num_update <= self.max_update:
+self.base_lr = self.final_lr + (self.base_lr_orig - self.final_lr)
* \
+pow(1 - float(num_update - self.warmup_steps) /
float(self.max_steps), self.power)
+return self.base_lr
+
+class CosineScheduler(LRScheduler):
""" Reduce the learning rate by given a list of steps.
Calculate the new learning rate by::
- base_lr * (1-nup/max_nup)^pwr
+ final_lr + (start_lr - final_lr) * (1+cos(pi * nup/max_nup))/2
if nup < max_nup, 0 otherwise.
Parameters
--
- max_update: maximum number of updates before the decay reaches 0.
+ max_update: maximum number of updates before the decay reaches 0
base_lr:base learning rate
- pwr: power of the decay term as a funtion of the current number of
updates.
-
+ final_lr: final learning rate after all steps
+ warmup_steps: number of warmup steps used before this scheduler starts
decay
"""
-def __init__(self, max_update, base_lr=0.01, pwr=2):
-super(PolyScheduler, self).__init__(base_lr)
+def __init__(self, max_update, base_lr=0.01, final_lr=0,
Review comment:
I've not removed it. Git is getting confused :/ It thinks I've changed
PolyScheduler to CosineScheduler when in fact I've modified PolyScheduler and
added a new CosineScheduler.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rahul003 commented on a change in pull request #11234: [MXNET-535] Fix bugs in LR Schedulers and add warmup
rahul003 commented on a change in pull request #11234: [MXNET-535] Fix bugs in
LR Schedulers and add warmup
URL: https://github.com/apache/incubator-mxnet/pull/11234#discussion_r210452043
##
File path: python/mxnet/lr_scheduler.py
##
@@ -138,33 +171,73 @@ def __call__(self, num_update):
return self.base_lr
class PolyScheduler(LRScheduler):
+""" Reduce the learning rate according to a polynomial of given power.
+
+Calculate the new learning rate by::
+
+ final_lr + (start_lr - final_lr) * (1-nup/max_nup)^pwr
+ if nup < max_nup, 0 otherwise.
+
+Parameters
+--
+ max_update: maximum number of updates before the decay reaches final
learning rate.
+ base_lr:base learning rate to start from
+ pwr: power of the decay term as a function of the current number of
updates.
+ final_lr: final learning rate after all steps
+ warmup_steps: number of warmup steps used before this scheduler starts
decay
+"""
+
+def __init__(self, max_update, base_lr=0.01, pwr=2, final_lr=0,
+ warmup_steps=0, warmup_begin_lr=0, warmup_mode='linear'):
+super(PolyScheduler, self).__init__(base_lr, warmup_steps,
warmup_begin_lr, warmup_mode)
+assert isinstance(max_update, int)
+if max_update < 1:
+raise ValueError("maximum number of updates must be strictly
positive")
+self.power = pwr
+self.base_lr_orig = self.base_lr
+self.max_update = max_update
+self.final_lr = final_lr
+self.max_steps = self.max_update - self.warmup_steps
+
+def __call__(self, num_update):
+if num_update < self.warmup_steps:
+return self.get_warmup_lr(num_update)
+if num_update <= self.max_update:
+self.base_lr = self.final_lr + (self.base_lr_orig - self.final_lr)
* \
+pow(1 - float(num_update - self.warmup_steps) /
float(self.max_steps), self.power)
+return self.base_lr
+
+class CosineScheduler(LRScheduler):
""" Reduce the learning rate by given a list of steps.
Calculate the new learning rate by::
- base_lr * (1-nup/max_nup)^pwr
+ final_lr + (start_lr - final_lr) * (1+cos(pi * nup/max_nup))/2
if nup < max_nup, 0 otherwise.
Parameters
--
- max_update: maximum number of updates before the decay reaches 0.
+ max_update: maximum number of updates before the decay reaches 0
base_lr:base learning rate
- pwr: power of the decay term as a funtion of the current number of
updates.
-
+ final_lr: final learning rate after all steps
+ warmup_steps: number of warmup steps used before this scheduler starts
decay
"""
-def __init__(self, max_update, base_lr=0.01, pwr=2):
-super(PolyScheduler, self).__init__(base_lr)
+def __init__(self, max_update, base_lr=0.01, final_lr=0,
Review comment:
I've not removed it. Git is getting confused. It thinks I've changed
PolyScheduler to CosineScheduler when in fact I've modified PolyScheduler and
added a new CosineScheduler.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] aaronmarkham commented on issue #12195: [MXNet-744] Fix website build pipeline Python 3 issues
aaronmarkham commented on issue #12195: [MXNet-744] Fix website build pipeline Python 3 issues URL: https://github.com/apache/incubator-mxnet/pull/12195#issuecomment-413386236 @marcoabreu @larroy Please take a look. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] aaronmarkham opened a new pull request #12195: [MXNet-744] Fix website build pipeline Python 3 issues
aaronmarkham opened a new pull request #12195: [MXNet-744] Fix website build pipeline Python 3 issues URL: https://github.com/apache/incubator-mxnet/pull/12195 ## Description ## Some Python 3 incompatibilities existed in the website build pipeline. When CI was updated to run docs build in Python 3 mode these surfaced. This PR addresses it and locks in the Python dependency versions to help prevent future breakage. ## Checklist ## ### Essentials ### Please feel free to remove inapplicable items for your PR. - [x] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny changes) - [x] Changes are complete (i.e. I finished coding on this PR) - [x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change ### Changes ### * Fixed Sphinx plugin mxdoc.py Python 3 issues by using `six`. * Added `six` to dependencies * Consolidated Python requirements for docs to one file in `ci/docker/install` * Pinned dependencies to specific version numbers * `mock` was not pinned upstream from docs, so we were getting a later version than what docs had been pinned to, so this is upgraded. * "Upgraded" a variety of packages that were not pinned to the latest in PyPI. Tests indicate things are good, and I'd rather pin things now to prevent future breakage. * Added a separate `Jenkinsfile-dev` so I don't have to keep hacking the Jenkinsfile every time I need to test something from my fork. This way I can just point to it from the test Jenkins jobs directly, and no more code updates. * Updated CI's docker images to use the new Python requirements file ## Comments ## * We can break out a separate requirements file if some split in deps appears between Python 2/3. For now the packages are the same. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] haojin2 commented on issue #11456: test_quantization.test_get_optimal_thresholds sometimes fails during testing.
haojin2 commented on issue #11456: test_quantization.test_get_optimal_thresholds sometimes fails during testing. URL: https://github.com/apache/incubator-mxnet/issues/11456#issuecomment-413384134 @sandeep-krishnamurthy Related PR is merged, should be good to close. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] haojin2 commented on issue #11410: Flaky test: test_operator_gpu.test_rnnrelu_bidirectional
haojin2 commented on issue #11410: Flaky test: test_operator_gpu.test_rnnrelu_bidirectional URL: https://github.com/apache/incubator-mxnet/issues/11410#issuecomment-413382974 @sandeep-krishnamurthy Related PR is merged, should be good to close. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] haojin2 commented on issue #8049: Enable the test test_ndarray.test_cached after fixing the crash.
haojin2 commented on issue #8049: Enable the test test_ndarray.test_cached after fixing the crash. URL: https://github.com/apache/incubator-mxnet/issues/8049#issuecomment-413382913 @sandeep-krishnamurthy Related PR is merged, should be good to close. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] haojin2 commented on issue #11728: test_operator_gpu.test_deformable_convolution_with_type has fixed seed that can mask flakiness
haojin2 commented on issue #11728: test_operator_gpu.test_deformable_convolution_with_type has fixed seed that can mask flakiness URL: https://github.com/apache/incubator-mxnet/issues/11728#issuecomment-413382830 @sandeep-krishnamurthy Related PR is merged, should be good to close. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] haojin2 commented on issue #11729: test_operator_gpu.test_deformable_psroipooling_with_type has fixed seed that can mask flakiness
haojin2 commented on issue #11729: test_operator_gpu.test_deformable_psroipooling_with_type has fixed seed that can mask flakiness URL: https://github.com/apache/incubator-mxnet/issues/11729#issuecomment-413382812 @sandeep-krishnamurthy Related PR is merged, should be good to close. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] haojin2 commented on issue #11734: test_operator_gpu.test_psroipooling_with_type has fixed seed that can mask flakiness
haojin2 commented on issue #11734: test_operator_gpu.test_psroipooling_with_type has fixed seed that can mask flakiness URL: https://github.com/apache/incubator-mxnet/issues/11734#issuecomment-413382691 @sandeep-krishnamurthy Related PR is merged, should be good to close. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] haojin2 commented on issue #11733: test_operator_gpu.test_pooling_with_type has fixed seed that can mask flakiness
haojin2 commented on issue #11733: test_operator_gpu.test_pooling_with_type has fixed seed that can mask flakiness URL: https://github.com/apache/incubator-mxnet/issues/11733#issuecomment-413382666 @sandeep-krishnamurthy Related PR is merged, should be good to close. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] haojin2 commented on issue #11738: test_optimizer.test_signum has fixed seed that can mask flakiness
haojin2 commented on issue #11738: test_optimizer.test_signum has fixed seed that can mask flakiness URL: https://github.com/apache/incubator-mxnet/issues/11738#issuecomment-413382532 @sandeep-krishnamurthy Related PR is merged, should be good to close. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] haojin2 commented on issue #11704: test_module.test_factorization_machine_module has fixed seed that can mask flakiness
haojin2 commented on issue #11704: test_module.test_factorization_machine_module has fixed seed that can mask flakiness URL: https://github.com/apache/incubator-mxnet/issues/11704#issuecomment-413382440 @sandeep-krishnamurthy Related PR is merged, should be good to close. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] haojin2 commented on issue #11740: test_sparse_ndarray.test_sparse_nd_pickle has fixed seed that can mask flakiness
haojin2 commented on issue #11740: test_sparse_ndarray.test_sparse_nd_pickle has fixed seed that can mask flakiness URL: https://github.com/apache/incubator-mxnet/issues/11740#issuecomment-413382270 @sandeep-krishnamurthy Related PR is merged, should be good to close. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] haojin2 commented on issue #11702: test_loss.test_squared_hinge_loss has fixed seed that can mask flakiness
haojin2 commented on issue #11702: test_loss.test_squared_hinge_loss has fixed seed that can mask flakiness URL: https://github.com/apache/incubator-mxnet/issues/11702#issuecomment-413382228 @sandeep-krishnamurthy Related PR is merged, should be good to close. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] haojin2 commented on issue #11703: test_loss.test_triplet_loss has fixed seed that can mask flakiness
haojin2 commented on issue #11703: test_loss.test_triplet_loss has fixed seed that can mask flakiness URL: https://github.com/apache/incubator-mxnet/issues/11703#issuecomment-413382252 @sandeep-krishnamurthy Related PR is merged, should be good to close. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] haojin2 commented on issue #11695: test_loss.test_hinge_loss has fixed seed that can mask flakiness
haojin2 commented on issue #11695: test_loss.test_hinge_loss has fixed seed that can mask flakiness URL: https://github.com/apache/incubator-mxnet/issues/11695#issuecomment-413382212 @sandeep-krishnamurthy Related PR is merged, should be good to close. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] haojin2 commented on issue #11700: test_loss.test_sample_weight_loss has fixed seed that can mask flakiness
haojin2 commented on issue #11700: test_loss.test_sample_weight_loss has fixed seed that can mask flakiness URL: https://github.com/apache/incubator-mxnet/issues/11700#issuecomment-413382080 @sandeep-krishnamurthy Related PR is merged, should be good to close. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] haojin2 commented on issue #11694: test_loss.test_ctc_loss_train has fixed seed that can mask flakiness
haojin2 commented on issue #11694: test_loss.test_ctc_loss_train has fixed seed that can mask flakiness URL: https://github.com/apache/incubator-mxnet/issues/11694#issuecomment-413382053 @sandeep-krishnamurthy Related PR is merged, should be good to close. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] haojin2 commented on issue #11698: test_loss.test_l1_loss has fixed seed that can mask flakiness
haojin2 commented on issue #11698: test_loss.test_l1_loss has fixed seed that can mask flakiness URL: https://github.com/apache/incubator-mxnet/issues/11698#issuecomment-413381757 @sandeep-krishnamurthy Related PR is merged, should be good to close. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] haojin2 commented on issue #11697: test_loss.test_kl_loss has fixed seed that can mask flakiness
haojin2 commented on issue #11697: test_loss.test_kl_loss has fixed seed that can mask flakiness URL: https://github.com/apache/incubator-mxnet/issues/11697#issuecomment-413381713 @sandeep-krishnamurthy Related PR is merged, should be good to close. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] haojin2 commented on issue #11692: test_loss.test_ce_loss has fixed seed that can mask flakiness
haojin2 commented on issue #11692: test_loss.test_ce_loss has fixed seed that can mask flakiness URL: https://github.com/apache/incubator-mxnet/issues/11692#issuecomment-413381573 @sandeep-krishnamurthy Related fix is merged, should be good to close. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] haojin2 commented on issue #11691: test_loss.test_bce_loss has fixed seed that can mask flakiness
haojin2 commented on issue #11691: test_loss.test_bce_loss has fixed seed that can mask flakiness URL: https://github.com/apache/incubator-mxnet/issues/11691#issuecomment-413381613 @sandeep-krishnamurthy Related fix is merged, should be good to close. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] haojin2 commented on issue #11718: test_operator.test_laop has fixed seed that can mask flakiness
haojin2 commented on issue #11718: test_operator.test_laop has fixed seed that can mask flakiness URL: https://github.com/apache/incubator-mxnet/issues/11718#issuecomment-413381475 @sandeep-krishnamurthy Related fix is merged, should be good to close. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] haojin2 commented on issue #11716: test_operator.test_elementwise_sum has fixed seed that can mask flakiness
haojin2 commented on issue #11716: test_operator.test_elementwise_sum has fixed seed that can mask flakiness URL: https://github.com/apache/incubator-mxnet/issues/11716#issuecomment-413381383 @sandeep-krishnamurthy Related fix is merged, should be good to close. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] haojin2 commented on issue #11990: [MXNET-744] Docs build tools update
haojin2 commented on issue #11990: [MXNET-744] Docs build tools update URL: https://github.com/apache/incubator-mxnet/pull/11990#issuecomment-413380408 This commit is causing problems on CI: http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/incubator-mxnet/detail/PR-12188/1/pipeline http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/incubator-mxnet/detail/PR-12192/1/pipeline http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/incubator-mxnet/detail/PR-12184/2/pipeline @aaronmarkham Can you take a look? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] haojin2 commented on issue #12179: Spelling mistake in "mxnet/symbol/image.py" in which "gen_image" is written to be "gen_iamge"
haojin2 commented on issue #12179: Spelling mistake in "mxnet/symbol/image.py" in which "gen_image" is written to be "gen_iamge" URL: https://github.com/apache/incubator-mxnet/issues/12179#issuecomment-413379540 It's a pure typo, see the ndarray counterpart: https://github.com/apache/incubator-mxnet/blob/master/python/mxnet/ndarray/image.py#L22 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] haojin2 opened a new pull request #12194: Fixing typo in python/mxnet/symbol/image.py
haojin2 opened a new pull request #12194: Fixing typo in python/mxnet/symbol/image.py URL: https://github.com/apache/incubator-mxnet/pull/12194 ## Description ## Fix for #12179. ## Checklist ## ### Essentials ### - [x] Changes are complete (i.e. I finished coding on this PR) - [x] All changes have test coverage: - Unit tests are added for small changes to verify correctness (e.g. adding a new operator) - Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore) - Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL) - [x] Code is well-documented: - For user-facing API changes, API doc string has been updated. - For new C++ functions in header files, their functionalities and arguments are documented. - For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable - Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html - [x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change ### Changes ### - [x] Fix typo ## Comments ## This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] junrushao1994 commented on issue #11599: Autograd fails when using `take` operator repeatedly
junrushao1994 commented on issue #11599: Autograd fails when using `take` operator repeatedly URL: https://github.com/apache/incubator-mxnet/issues/11599#issuecomment-413378649 Closed since #11983 is merged. Thank you @haojin2! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] junrushao1994 closed issue #11599: Autograd fails when using `take` operator repeatedly
junrushao1994 closed issue #11599: Autograd fails when using `take` operator repeatedly URL: https://github.com/apache/incubator-mxnet/issues/11599 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] thomelane commented on issue #7873: Issues on training CIFAR10 with official example code
thomelane commented on issue #7873: Issues on training CIFAR10 with official example code URL: https://github.com/apache/incubator-mxnet/issues/7873#issuecomment-413378360 @stoneyang I couldn't replicate this issue unfortunately. Can you still reproduce this issue? It doesn't look like there have been many changes to this file since you tried to run, but there may have been improvements to RecordIO loading which have fixed this. Or could it be something like corrupted data that was downloaded? If so, deleting the files and downloading again might fix it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] lanking520 commented on a change in pull request #11844: [MXNET-689] add DataDesc type for the Scala Package
lanking520 commented on a change in pull request #11844: [MXNET-689] add
DataDesc type for the Scala Package
URL: https://github.com/apache/incubator-mxnet/pull/11844#discussion_r210445749
##
File path: scala-package/core/src/main/scala/org/apache/mxnet/IO.scala
##
@@ -228,15 +264,14 @@ object DataBatch {
/**
* Provide the shape of a data.
- * @param name data name.
- * @param shape data shape.
+ * @param dataDesc DataDescriptor
* @return this.
*/
-def provideDataShape(name: String, shape: Shape): Builder = {
- if (datatShapes == null) {
-datatShapes = ListMap((name, shape))
+def provideDataShape(dataDesc: DataDesc): Builder = {
+ if (dataShapes == null) {
+dataShapes = IndexedSeq(dataDesc)
} else {
-datatShapes = datatShapes.updated(name, shape)
+dataShapes = dataShapes ++ IndexedSeq(dataDesc)
Review comment:
@yzhliu the previous builder only allows single dataDesc (shape, name) input
for the DataBatch. However, the data passed in is a IndexedSeq, in the new
design, I changed them into indexedSeq and remove the old method.
@nswamy About NDArrayIter, they are single input for both data and DataDesc,
I am not planning to do the same thing there.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] junrushao1994 commented on issue #12192: Fix flaky tests in control flow
junrushao1994 commented on issue #12192: Fix flaky tests in control flow URL: https://github.com/apache/incubator-mxnet/pull/12192#issuecomment-413378255 @haojin2 It is very helpful of you! (especially when I have no access to ec2) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] haojin2 commented on issue #12090: [MXNET-791] Pick with negative indices
haojin2 commented on issue #12090: [MXNET-791] Pick with negative indices URL: https://github.com/apache/incubator-mxnet/pull/12090#issuecomment-413377269 Please rebase with the latest master, then do a `git submodule update --init --recursive`, then do a `git push --force origin ` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] stu1130 commented on a change in pull request #12131: [MXNET-737][WIP] Add last batch handle for imageiter
stu1130 commented on a change in pull request #12131: [MXNET-737][WIP] Add last batch handle for imageiter URL: https://github.com/apache/incubator-mxnet/pull/12131#discussion_r210444730 ## File path: python/mxnet/image/image.py ## @@ -1207,8 +1230,25 @@ def next(self): except StopIteration: if not i: raise StopIteration +return i -return io.DataBatch([batch_data], [batch_label], batch_size - i) +def next(self): +"""Returns the next batch of data.""" +batch_size = self.batch_size +c, h, w = self.data_shape +batch_data = nd.empty((batch_size, c, h, w)) +batch_label = nd.empty(self.provide_label[0][1]) +i = self._batchify(batch_data, batch_label) +# calculate the padding +pad = batch_size - i +# handle padding for 'pad' and 'roll_over' for the last batch +if pad != 0: Review comment: refactor the padding logic here This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] stu1130 commented on a change in pull request #12131: [MXNET-737][WIP] Add last batch handle for imageiter
stu1130 commented on a change in pull request #12131: [MXNET-737][WIP] Add last batch handle for imageiter URL: https://github.com/apache/incubator-mxnet/pull/12131#discussion_r210444554 ## File path: python/mxnet/image/image.py ## @@ -1207,8 +1230,25 @@ def next(self): except StopIteration: if not i: raise StopIteration +return i -return io.DataBatch([batch_data], [batch_label], batch_size - i) +def next(self): +"""Returns the next batch of data.""" +batch_size = self.batch_size +c, h, w = self.data_shape +batch_data = nd.empty((batch_size, c, h, w)) +batch_label = nd.empty(self.provide_label[0][1]) +i = self._batchify(batch_data, batch_label) +# calculate the padding +pad = batch_size - i +# handle padding for 'pad' and 'roll_over' for the last batch +if pad != 0: +if self.last_batch == 'discard': Review comment: change the padding logic here This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
