[GitHub] [incubator-mxnet] Bidski opened a new issue #17554: Calling optimizer.create_state on block parameters throws an AttributeError

2020-02-07 Thread GitBox
Bidski opened a new issue #17554: Calling optimizer.create_state on block 
parameters throws an AttributeError
URL: https://github.com/apache/incubator-mxnet/issues/17554
 
 
   ## Description
   (A clear and concise description of what the bug is.)
   I am using `mxnet.optimizer.Adam` but this appears to apply to all of the 
optimizers.
   
   I have called `collect_params` on my block and I am passing each one to the 
`create_state` function of my optimizer, but this throws an `AttributeError` as 
shown below.
   
   ### Error Message
   (Paste the complete error message. Please also include stack trace by 
setting environment variable `DMLC_LOG_STACK_TRACE_DEPTH=10` before running 
your script.)
   ```
   Traceback (most recent call last):
 File "./train.py", line 233, in 
   main()
 File "./train.py", line 159, in main
   generator_state = {i: generator_optimiser.create_state(i, weight) for i, 
weight in enumerate(generator_weights)}
 File "./train.py", line 159, in 
   generator_state = {i: generator_optimiser.create_state(i, weight) for i, 
weight in enumerate(generator_weights)}
 File "/usr/lib/python3.8/site-packages/mxnet/optimizer/optimizer.py", line 
1202, in create_state
   stype = weight.stype if self.lazy_update else 'default'
   AttributeError: 'Parameter' object has no attribute 'stype'
   ```
   
   Having a look at `mxnet/gluon/parameter.py` it seems that `context` is also 
an attribute that `Parameter` does not have.
   
   
   ## Environment
   ```
   --Python Info--
   Version  : 3.8.1
   Compiler : GCC 9.2.0
   Build: ('default', 'Jan 22 2020 06:38:00')
   Arch : ('64bit', 'ELF')
   Pip Info---
   Version  : 19.3
   Directory: /usr/lib/python3.8/site-packages/pip
   --MXNet Info---
   Version  : 1.5.1
   Directory: /usr/lib/python3.8/site-packages/mxnet
   Num GPUs : 1
   Hashtag not found. Not installed from pre-built package.
   --System Info--
   Platform : Linux-5.5.2-arch1-1-x86_64-with-glibc2.2.5
   system   : Linux
   node : bidski-laptop
   release  : 5.5.2-arch1-1
   version  : #1 SMP PREEMPT Tue, 04 Feb 2020 18:56:18 +
   --Hardware Info--
   machine  : x86_64
   processor: 
   Architecture:x86_64
   CPU op-mode(s):  32-bit, 64-bit
   Byte Order:  Little Endian
   Address sizes:   39 bits physical, 48 bits virtual
   CPU(s):  8
   On-line CPU(s) list: 0-7
   Thread(s) per core:  2
   Core(s) per socket:  4
   Socket(s):   1
   NUMA node(s):1
   Vendor ID:   GenuineIntel
   CPU family:  6
   Model:   142
   Model name:  Intel(R) Core(TM) i7-8550U CPU @ 1.80GHz
   Stepping:10
   CPU MHz: 1579.400
   CPU max MHz: 4000.
   CPU min MHz: 400.
   BogoMIPS:4001.60
   Virtualization:  VT-x
   L1d cache:   128 KiB
   L1i cache:   128 KiB
   L2 cache:1 MiB
   L3 cache:8 MiB
   NUMA node0 CPU(s):   0-7
   Vulnerability Itlb multihit: KVM: Mitigation: Split huge pages
   Vulnerability L1tf:  Mitigation; PTE Inversion; VMX conditional 
cache flushes, SMT vulnerable
   Vulnerability Mds:   Mitigation; Clear CPU buffers; SMT 
vulnerable
   Vulnerability Meltdown:  Mitigation; PTI
   Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass 
disabled via prctl and seccomp
   Vulnerability Spectre v1:Mitigation; usercopy/swapgs barriers and 
__user pointer sanitization
   Vulnerability Spectre v2:Mitigation; Full generic retpoline, IBPB 
conditional, IBRS_FW, STIBP conditional, RSB
 filling
   Vulnerability Tsx async abort:   Not affected
   Flags:   fpu vme de pse tsc msr pae mce cx8 apic sep 
mtrr pge mca cmov pat pse36 clflush dts a
cpi mmx fxsr sse sse2 ss ht tm pbe syscall 
nx pdpe1gb rdtscp lm constant_tsc art arch
_perfmon pebs bts rep_good nopl xtopology 
nonstop_tsc cpuid aperfmperf pni pclmulqdq 
dtes64 monitor ds_cpl vmx est tm2 ssse3 
sdbg fma cx16 xtpr pdcm pcid sse4_1 sse4_2 x2
apic movbe popcnt tsc_deadline_timer aes 
xsave avx f16c rdrand lahf_lm abm 3dnowprefe
tch cpuid_fault epb invpcid_single pti ssbd 
ibrs ibpb stibp tpr_shadow vnmi flexprior
ity ept vpid ept_ad fs

[GitHub] [incubator-mxnet] Tommliu opened a new pull request #17553: Operator diag_indices_from [Numpy]

2020-02-07 Thread GitBox
Tommliu opened a new pull request #17553: Operator diag_indices_from [Numpy]
URL: https://github.com/apache/incubator-mxnet/pull/17553
 
 
   ## Description ##
   Pr for DeepNumPy Operator diag_indices_from
   
   ## Checklist ##
   ### Essentials ###
   Please feel free to remove inapplicable items for your PR.
   - [ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to 
the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) 
created (except PRs with tiny changes)
   - [ ] Changes are complete (i.e. I finished coding on this PR)
   - [ ] All changes have test coverage:
   - Unit tests are added for small changes to verify correctness (e.g. adding 
a new operator)
   - Nightly tests are added for complicated/long-running ones (e.g. changing 
distributed kvstore)
   - Build tests will be added for build configuration changes (e.g. adding a 
new build option with NCCL)
   - [ ] Code is well-documented: 
   - For user-facing API changes, API doc string has been updated. 
   - For new C++ functions in header files, their functionalities and arguments 
are documented. 
   - For new examples, README.md is added to explain the what the example does, 
the source of the dataset, expected performance on test set and reference to 
the original paper if applicable
   - Check the API doc at 
https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
   - [ ] To the best of my knowledge, examples are either not affected by this 
change, or have been fixed to be compatible with this change
   
   ### Changes ###
   - [ ] Feature1, tests, (and when applicable, API doc)
   - [ ] Feature2, tests, (and when applicable, API doc)
   
   ## Comments ##
   - If this change is a backward incompatible change, why must this change be 
made.
   - Interesting edge cases to note here
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[incubator-mxnet-site] branch asf-site updated: Bump the publish timestamp.

2020-02-07 Thread aaronmarkham
This is an automated email from the ASF dual-hosted git repository.

aaronmarkham pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/incubator-mxnet-site.git


The following commit(s) were added to refs/heads/asf-site by this push:
 new 46d06b3  Bump the publish timestamp.
46d06b3 is described below

commit 46d06b3d58fbb51b53da0077e39aee7c31118a66
Author: mxnet-ci 
AuthorDate: Sat Feb 8 06:42:40 2020 +

Bump the publish timestamp.
---
 date.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/date.txt b/date.txt
new file mode 100644
index 000..c0c10cf
--- /dev/null
+++ b/date.txt
@@ -0,0 +1 @@
+Sat Feb  8 06:42:40 UTC 2020



[GitHub] [incubator-mxnet] leezu opened a new pull request #17552: Fixcmakegpubuild

2020-02-07 Thread GitBox
leezu opened a new pull request #17552: Fixcmakegpubuild
URL: https://github.com/apache/incubator-mxnet/pull/17552
 
 
   ## Description ##
   Fixes regression introduced by 
https://github.com/apache/incubator-mxnet/pull/16654 tracked and adds tests.
   
   Fixes https://github.com/apache/incubator-mxnet/issues/17545
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[incubator-mxnet] branch master updated (6533258 -> 5b50600)

2020-02-07 Thread haoj
This is an automated email from the ASF dual-hosted git repository.

haoj pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git.


from 6533258  [OpPerf] Implement remaining GEMM ops (#17501)
 add 5b50600  pin Markdown version to 3.1 in Julia doc build (#17549)

No new revisions were added by this update.

Summary of changes:
 julia/docs/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)



[incubator-mxnet] branch master updated (6533258 -> 5b50600)

2020-02-07 Thread haoj
This is an automated email from the ASF dual-hosted git repository.

haoj pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git.


from 6533258  [OpPerf] Implement remaining GEMM ops (#17501)
 add 5b50600  pin Markdown version to 3.1 in Julia doc build (#17549)

No new revisions were added by this update.

Summary of changes:
 julia/docs/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)



[GitHub] [incubator-mxnet] haojin2 merged pull request #17549: Pin Markdown version to 3.1 in Julia doc build

2020-02-07 Thread GitBox
haojin2 merged pull request #17549: Pin Markdown version to 3.1 in Julia doc 
build
URL: https://github.com/apache/incubator-mxnet/pull/17549
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] anirudh2290 commented on issue #17545: CMake GPU build broken by #16654

2020-02-07 Thread GitBox
anirudh2290 commented on issue #17545: CMake GPU build broken by #16654
URL: 
https://github.com/apache/incubator-mxnet/issues/17545#issuecomment-583695336
 
 
   Thanks @leezu . Also, need another test on the CI to build with 
ENABLE_CUDA_RTC OFF. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] pengzhao-intel commented on issue #17265: Add bfloat16 floating-point format support based on AMP

2020-02-07 Thread GitBox
pengzhao-intel commented on issue #17265: Add bfloat16 floating-point format 
support based on AMP 
URL: https://github.com/apache/incubator-mxnet/pull/17265#issuecomment-583694595
 
 
   @ptrendx thanks for your review.  Feel free to let me know if you have other 
concerns, we are going to merge PR recently. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] leezu commented on issue #17545: CMake GPU build broken by #16654

2020-02-07 Thread GitBox
leezu commented on issue #17545: CMake GPU build broken by #16654
URL: 
https://github.com/apache/incubator-mxnet/issues/17545#issuecomment-583693582
 
 
   Root cause seems to be the change in preprocessor logic. Compare 
   
   
https://github.com/apache/incubator-mxnet/commit/b1e491182fa9c15da89f1b701778de3a1421811b#diff-ca9cfe7afd877e3f6a1601e9f9894ea1R233
   
   
https://github.com/apache/incubator-mxnet/commit/b1e491182fa9c15da89f1b701778de3a1421811b#diff-b7c9df82199fd093bf767c1635607088L170
   
   Another thing exposed by this PR is that the config.cmake should include 
`set(ENABLE_CUDA_RTC ON` instead of OFF. It's set off by default based on a 
misunderstanding on my side that this feature is not commonly used anymore.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] szha opened a new pull request #17551: [CD] fix CD and remove leftover from #15990

2020-02-07 Thread GitBox
szha opened a new pull request #17551: [CD] fix CD and remove leftover from 
#15990
URL: https://github.com/apache/incubator-mxnet/pull/17551
 
 
   ## Description ##
   fix CD and remove leftover from #15990
   
   ## Checklist ##
   ### Essentials ###
   Please feel free to remove inapplicable items for your PR.
   - [x] Changes are complete (i.e. I finished coding on this PR)
   - [x] To the best of my knowledge, examples are either not affected by this 
change, or have been fixed to be compatible with this change
   
   ### Changes ###
   - [x] fix CD since python2 support is dropped
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] szha commented on issue #17537: Outdated mxnet nightly build wheel instructions

2020-02-07 Thread GitBox
szha commented on issue #17537: Outdated mxnet nightly build wheel instructions 
URL: 
https://github.com/apache/incubator-mxnet/issues/17537#issuecomment-583687831
 
 
   CD was fixed but was failing again after #15990 as it didn't take CD into 
account. 
http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/restricted-mxnet-cd%2Fmxnet-cd-release-job/detail/mxnet-cd-release-job/656/pipeline#step-487-log-408
   
   I think we should focus on fixing and maintaining one solution instead of 
creating more distraction


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] haojin2 commented on issue #17549: Pin Markdown version to 3.1 in Julia doc build

2020-02-07 Thread GitBox
haojin2 commented on issue #17549: Pin Markdown version to 3.1 in Julia doc 
build
URL: https://github.com/apache/incubator-mxnet/pull/17549#issuecomment-583674915
 
 
   unix-gpu build timing out again, just re-triggered, will merge this myself 
when I see this has passed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] zachgk commented on a change in pull request #17550: Adding scripts for nightly pip wheel builds

2020-02-07 Thread GitBox
zachgk commented on a change in pull request #17550: Adding scripts for nightly 
pip wheel builds
URL: https://github.com/apache/incubator-mxnet/pull/17550#discussion_r376662245
 
 

 ##
 File path: tools/buildspec/cpu.yml
 ##
 @@ -0,0 +1,38 @@
+version: 0.2
+
+env:
+  variables:
+mxnet_variant: "cpu"
 
 Review comment:
   You can specify the mxnet_variant using the console instead of the 
buildspec. Then, the same buildspec could be used for all variants.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] samskalicky commented on issue #17537: Outdated mxnet nightly build wheel instructions

2020-02-07 Thread GitBox
samskalicky commented on issue #17537: Outdated mxnet nightly build wheel 
instructions 
URL: 
https://github.com/apache/incubator-mxnet/issues/17537#issuecomment-583666917
 
 
   @leezu I dont think that matters. The bucket will contain the nightly pip 
wheels regardless of where they are built from. If they are built from a 
proprietary system or a publicly accessible one they will go to the 
same/similar location in the bucket and the webpage will just show them. 
   
   This is like saying I wont drive a BMW because its built in [Spartanburg, 
South Carolina](https://www.bmwgroup-plants.com/spartanburg/en.html) instead of 
[Munich, Germany](https://www.bmw-welt.com/en/locations/plant.html). 
   
   Irregardless, ive started a PR to add the scripts used in the current 
CodeBuild system: #17550
   
   If having these scripts in the repo is sufficient, we can finish adding the 
rest of the scripts and updating the CodeBuild projects to execute these 
scripts. We can also make build logs and other status updates available to the 
community as well. Heres one build badge for the plain mxnet build flavor:
   
![](https://codebuild.us-west-2.amazonaws.com/badges?uuid=eyJlbmNyeXB0ZWREYXRhIjoib2ZpVHY3NTdFZEpBZ21VZVFNNVVVUjVWbjJHQVJCRHVlclVkRGFiU2ZuOSsyUXhPazREQkI4dWRGMW0yV1o1bzNZVS9mQTlVRlFUcjlGZk1QMVB2NEhvPSIsIml2UGFyYW1ldGVyU3BlYyI6IkY5RGVkRkZLOTA3TCtEY20iLCJtYXRlcmlhbFNldFNlcmlhbCI6MX0%3D&branch=master)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] samskalicky opened a new pull request #17550: Adding scripts for nightly pip wheel builds

2020-02-07 Thread GitBox
samskalicky opened a new pull request #17550: Adding scripts for nightly pip 
wheel builds
URL: https://github.com/apache/incubator-mxnet/pull/17550
 
 
   ## Description ##
   Adds scripts that are currently running to generate the nightly wheels in 
https://apache-mxnet.s3-us-west-2.amazonaws.com/dist/index.html
   
   ## Checklist ##
   ### Essentials ###
   Please feel free to remove inapplicable items for your PR.
   - [ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to 
the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) 
created (except PRs with tiny changes)
   - [ ] Changes are complete (i.e. I finished coding on this PR)
   - [ ] All changes have test coverage:
   - Unit tests are added for small changes to verify correctness (e.g. adding 
a new operator)
   - Nightly tests are added for complicated/long-running ones (e.g. changing 
distributed kvstore)
   - Build tests will be added for build configuration changes (e.g. adding a 
new build option with NCCL)
   - [ ] Code is well-documented: 
   - For user-facing API changes, API doc string has been updated. 
   - For new C++ functions in header files, their functionalities and arguments 
are documented. 
   - For new examples, README.md is added to explain the what the example does, 
the source of the dataset, expected performance on test set and reference to 
the original paper if applicable
   - Check the API doc at 
https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
   - [ ] To the best of my knowledge, examples are either not affected by this 
change, or have been fixed to be compatible with this change
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] access2rohit commented on issue #17549: Pin Markdown version to 3.1 in Julia doc build

2020-02-07 Thread GitBox
access2rohit commented on issue #17549: Pin Markdown version to 3.1 in Julia 
doc build
URL: https://github.com/apache/incubator-mxnet/pull/17549#issuecomment-583654018
 
 
   @mxnet-label-bot add [pr-awaiting-merge]


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] access2rohit commented on issue #17546: enabling build stage gpu_int64 to enable large tensor nightly runs

2020-02-07 Thread GitBox
access2rohit commented on issue #17546: enabling build stage gpu_int64 to 
enable large tensor nightly runs
URL: https://github.com/apache/incubator-mxnet/pull/17546#issuecomment-583637749
 
 
   @apeforest updated the PR after incorporating your suggestions as discussed 
offline.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] haojin2 opened a new pull request #17549: Pin Markdown version to 3.1 in Julia doc build

2020-02-07 Thread GitBox
haojin2 opened a new pull request #17549: Pin Markdown version to 3.1 in Julia 
doc build
URL: https://github.com/apache/incubator-mxnet/pull/17549
 
 
   ## Description ##
   Fix for #16146 
   
   ## Checklist ##
   ### Essentials ###
   Please feel free to remove inapplicable items for your PR.
   - [ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to 
the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) 
created (except PRs with tiny changes)
   - [ ] Changes are complete (i.e. I finished coding on this PR)
   - [ ] All changes have test coverage:
   - Unit tests are added for small changes to verify correctness (e.g. adding 
a new operator)
   - Nightly tests are added for complicated/long-running ones (e.g. changing 
distributed kvstore)
   - Build tests will be added for build configuration changes (e.g. adding a 
new build option with NCCL)
   - [ ] Code is well-documented: 
   - For user-facing API changes, API doc string has been updated. 
   - For new C++ functions in header files, their functionalities and arguments 
are documented. 
   - For new examples, README.md is added to explain the what the example does, 
the source of the dataset, expected performance on test set and reference to 
the original paper if applicable
   - Check the API doc at 
https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
   - [ ] To the best of my knowledge, examples are either not affected by this 
change, or have been fixed to be compatible with this change
   
   ### Changes ###
   - [ ] Feature1, tests, (and when applicable, API doc)
   - [ ] Feature2, tests, (and when applicable, API doc)
   
   ## Comments ##
   - If this change is a backward incompatible change, why must this change be 
made.
   - Interesting edge cases to note here
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] access2rohit commented on a change in pull request #17546: enabling build stage gpu_int64 to enable large tensor nightly runs

2020-02-07 Thread GitBox
access2rohit commented on a change in pull request #17546: enabling build stage 
gpu_int64 to enable large tensor nightly runs
URL: https://github.com/apache/incubator-mxnet/pull/17546#discussion_r376625403
 
 

 ##
 File path: tests/nightly/JenkinsfileForBinaries
 ##
 @@ -49,7 +49,7 @@ core_logic: {
   utils.pack_lib('cpu_int64', mx_cmake_lib)
 }
   }
-},
+}*/,
 
 Review comment:
   I can change “GPU: USE_INT64_TENSOR_SIZE” -> “USE_INT64_TENSOR_SIZE” to 
enable first.
   
   Changing instance type is a temp fix. Theoritically everything should be 
able to run on CPU. So, fixing MXNet memory management would be the ideal 
solution but that would take lot of time. Switching to R5 will bump up our 
costs a bit too.
   
   Let me know if "USE_INT64_TENSOR_SIZE" makes sense as interim solution to 
enable LT on nightly first.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] samskalicky closed pull request #16927: Anirudh Subramanian's changes for multithreaded inference

2020-02-07 Thread GitBox
samskalicky closed pull request #16927: Anirudh Subramanian's changes for 
multithreaded inference
URL: https://github.com/apache/incubator-mxnet/pull/16927
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #17546: enabling build stage gpu_int64 to enable large tensor nightly runs

2020-02-07 Thread GitBox
apeforest commented on a change in pull request #17546: enabling build stage 
gpu_int64 to enable large tensor nightly runs
URL: https://github.com/apache/incubator-mxnet/pull/17546#discussion_r376622564
 
 

 ##
 File path: tests/nightly/JenkinsfileForBinaries
 ##
 @@ -49,7 +49,7 @@ core_logic: {
   utils.pack_lib('cpu_int64', mx_cmake_lib)
 }
   }
-},
+}*/,
 
 Review comment:
   I think this is a little bit confusing. We are actually testing cpu context 
on GPU platforms here. The reason we don't use CPU node is simply the CPU node 
type does not have big enough memory as GPU node. 
   
   We should either modify the CPU node type with a memory optimized one such 
as R5 (this is the ideal solution)
   
   Or we rename the pipeline stage so that it's clear to people these are tests 
running on CPUs and remove the commented CPU test here.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #17546: enabling build stage gpu_int64 to enable large tensor nightly runs

2020-02-07 Thread GitBox
apeforest commented on a change in pull request #17546: enabling build stage 
gpu_int64 to enable large tensor nightly runs
URL: https://github.com/apache/incubator-mxnet/pull/17546#discussion_r376622564
 
 

 ##
 File path: tests/nightly/JenkinsfileForBinaries
 ##
 @@ -49,7 +49,7 @@ core_logic: {
   utils.pack_lib('cpu_int64', mx_cmake_lib)
 }
   }
-},
+}*/,
 
 Review comment:
   I think this is a little bit confusing. We are actually testing cpu context 
on GPU platforms here. The reason we don't use CPU node is simply the CPU node 
type does not have big enough memory as GPU node. 
   
   We should either modify the CPU node type with a memory optimized one such 
as R5 (this is the ideal solution)
   
   Or we rename the pipeline stage so that it's clear to people these are tests 
running on CPUs.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] leezu commented on issue #17537: Outdated mxnet nightly build wheel instructions

2020-02-07 Thread GitBox
leezu commented on issue #17537: Outdated mxnet nightly build wheel 
instructions 
URL: 
https://github.com/apache/incubator-mxnet/issues/17537#issuecomment-583628037
 
 
   The key problem here is 
   
   > If we are officially blessing this page and making it official we can 
switch it. Otherwise if the community wants to do something different we can 
leave it and just access it at 
https://apache-mxnet.s3-us-west-2.amazonaws.com/dist/index.html until the 
community implements a new solution.
   
   To obtain that blessing, the builds located at that side should be created 
from a community controlled (ie. controlled via some configuration files in a 
public repository) resource. Has the Jenkins CD already replaced the 
proprietary build pipeline?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] haojin2 edited a comment on issue #16146: Website build on CI is down due to Julia error

2020-02-07 Thread GitBox
haojin2 edited a comment on issue #16146: Website build on CI is down due to 
Julia error
URL: 
https://github.com/apache/incubator-mxnet/issues/16146#issuecomment-583626780
 
 
   working on a fix, will have a PR out soon. Currently verifying my fix


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] haojin2 commented on issue #16146: Website build on CI is down due to Julia error

2020-02-07 Thread GitBox
haojin2 commented on issue #16146: Website build on CI is down due to Julia 
error
URL: 
https://github.com/apache/incubator-mxnet/issues/16146#issuecomment-583626780
 
 
   working on a fix, will have a PR out soon.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] haojin2 commented on issue #16146: Website build on CI is down due to Julia error

2020-02-07 Thread GitBox
haojin2 commented on issue #16146: Website build on CI is down due to Julia 
error
URL: 
https://github.com/apache/incubator-mxnet/issues/16146#issuecomment-583625138
 
 
   @aaronmarkham indeed it's a version problem:
   `pkg_resources.VersionConflict: (Markdown 3.2 
(/home/jenkins_slave/.local/lib/python3.5/site-packages), 
Requirement.parse('markdown<3.2'))`


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] aaronmarkham commented on issue #16146: Website build on CI is down due to Julia error

2020-02-07 Thread GitBox
aaronmarkham commented on issue #16146: Website build on CI is down due to 
Julia error
URL: 
https://github.com/apache/incubator-mxnet/issues/16146#issuecomment-583622171
 
 
   I'm about to head out to the airport and be traveling, so I don't know if I 
can test this and help with a patch in a reasonable amount of time... any 
takers?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] aaronmarkham commented on issue #16146: Website build on CI is down due to Julia error

2020-02-07 Thread GitBox
aaronmarkham commented on issue #16146: Website build on CI is down due to 
Julia error
URL: 
https://github.com/apache/incubator-mxnet/issues/16146#issuecomment-583621774
 
 
   My guess is that the dependencies in the julia docs chain hit this error:
   ```
   ERROR: mkdocs-material 4.6.0 has requirement markdown<3.2, but you'll have 
markdown 3.2 which is incompatible.
   ```
   It does this:
   ```
   pip install --user pygments mkdocs mkdocs-material python-markdown-math
   ```
   So I'm thinking those all need to be version pinned and roll back 
mkdocs-material to a version that still works. Or pin markdown to a previous 
version...
   
   That would be here:
   
https://github.com/apache/incubator-mxnet/blob/7caffa65e30f37e70796ba165ac5a4265e64974e/julia/docs/Makefile#L23


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] ChaiBapchya commented on issue #17484: Disable flaky test test_operator_gpu.test_convolution_multiple_streams

2020-02-07 Thread GitBox
ChaiBapchya commented on issue #17484: Disable flaky test 
test_operator_gpu.test_convolution_multiple_streams
URL: https://github.com/apache/incubator-mxnet/pull/17484#issuecomment-583617067
 
 
   Other PR already got merged 
https://github.com/apache/incubator-mxnet/pull/17499
   Closing this one in favor of that


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] ChaiBapchya closed pull request #17484: Disable flaky test test_operator_gpu.test_convolution_multiple_streams

2020-02-07 Thread GitBox
ChaiBapchya closed pull request #17484: Disable flaky test 
test_operator_gpu.test_convolution_multiple_streams
URL: https://github.com/apache/incubator-mxnet/pull/17484
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] samskalicky commented on issue #16146: Website build on CI is down due to Julia error

2020-02-07 Thread GitBox
samskalicky commented on issue #16146: Website build on CI is down due to Julia 
error
URL: 
https://github.com/apache/incubator-mxnet/issues/16146#issuecomment-583613433
 
 
   Looks like it was working 2 days ago:
   
http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/mxnet-validation%2Fwebsite/detail/PR-17486/3/pipeline/86
   
   What changed since then?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] samskalicky commented on issue #17486: Update CustomOp doc with changes for GPU support

2020-02-07 Thread GitBox
samskalicky commented on issue #17486: Update CustomOp doc with changes for GPU 
support
URL: https://github.com/apache/incubator-mxnet/pull/17486#issuecomment-583613040
 
 
   @aaronmarkham it looks fine to me here:
   
https://github.com/apache/incubator-mxnet/blob/9b93000c4a8f8da05e51547312bd605ec3798b3f/example/extensions/lib_custom_op/README.md
   
   Looks like its just weird GitHub source-diff showing odd italics.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] leezu opened a new issue #17548: CI doesn't test cmake build properly

2020-02-07 Thread GitBox
leezu opened a new issue #17548: CI doesn't test cmake build properly
URL: https://github.com/apache/incubator-mxnet/issues/17548
 
 
   Evidence https://github.com/apache/incubator-mxnet/issues/17514 
https://github.com/apache/incubator-mxnet/issues/17545


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] leezu commented on issue #17545: CMake build instruction on ubuntu not working

2020-02-07 Thread GitBox
leezu commented on issue #17545: CMake build instruction on ubuntu not working
URL: 
https://github.com/apache/incubator-mxnet/issues/17545#issuecomment-583595683
 
 
   b1e491182fa9c15da89f1b701778de3a1421811b is the first bad commit
   commit b1e491182fa9c15da89f1b701778de3a1421811b
   Author: Anirudh Subramanian 
   Date:   Sat Feb 1 09:36:59 2020 -0800
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] roywei closed pull request #16532: fix dropout gpu seed

2020-02-07 Thread GitBox
roywei closed pull request #16532: fix dropout gpu seed
URL: https://github.com/apache/incubator-mxnet/pull/16532
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] roywei commented on issue #16532: fix dropout gpu seed

2020-02-07 Thread GitBox
roywei commented on issue #16532: fix dropout gpu seed
URL: https://github.com/apache/incubator-mxnet/pull/16532#issuecomment-583594498
 
 
   closing in favor of https://github.com/apache/incubator-mxnet/pull/17547


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] roywei opened a new pull request #17547: Fix cudnn Dropout reproducibility

2020-02-07 Thread GitBox
roywei opened a new pull request #17547: Fix cudnn Dropout reproducibility
URL: https://github.com/apache/incubator-mxnet/pull/17547
 
 
   Fix https://github.com/apache/incubator-mxnet/issues/15662
   This will replace #16532 with an alternative solution.
   Please refer to the discussion in  
https://github.com/apache/incubator-mxnet/pull/16532#discussion_r339268855
   
   1. Added `GetSeed()` in GPU random resource, it's similar to CPU version.
   2. During cudnn dropout, check whether random seed has been changed and 
reset cudnn dropout descriptor's seed if random seed changed.
   
   Benefit:
   1. This avoided generating a random int (tensor on gpu) on GPU, copy to CPU 
and and pass it to `cudnnDropoutGetStatesSize`.
   2. get the seed from gpu random resource is fast, we can afford to do it 
every forward.
   
   Drawback:
   Will be affected by https://github.com/apache/incubator-mxnet/issues/7410, 
by default mxnet's random seed is fixed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] access2rohit commented on issue #17546: enabling build stage gpu_int64 to enable large tensor nightly runs

2020-02-07 Thread GitBox
access2rohit commented on issue #17546: enabling build stage gpu_int64 to 
enable large tensor nightly runs
URL: https://github.com/apache/incubator-mxnet/pull/17546#issuecomment-583590070
 
 
   @apeforest can you review this


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] access2rohit opened a new pull request #17546: enabling build stage gpu_int64 to enable large tensor nightly runs

2020-02-07 Thread GitBox
access2rohit opened a new pull request #17546: enabling build stage gpu_int64 
to enable large tensor nightly runs
URL: https://github.com/apache/incubator-mxnet/pull/17546
 
 
   ## Description ##
   Fixes nightly build failure due to absence of large tensor build artifact 
required for testing large tensor support on a nightly basis
   
   ## Checklist ##
   ### Essentials ###
   Please feel free to remove inapplicable items for your PR.
   - [x] Changes are complete (i.e. I finished coding on this PR)
   - [x] To the best of my knowledge, examples are either not affected by this 
change, or have been fixed to be compatible with this change
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] access2rohit commented on issue #17546: enabling build stage gpu_int64 to enable large tensor nightly runs

2020-02-07 Thread GitBox
access2rohit commented on issue #17546: enabling build stage gpu_int64 to 
enable large tensor nightly runs
URL: https://github.com/apache/incubator-mxnet/pull/17546#issuecomment-583589957
 
 
   @mxnet-label-bot add [pr-awaiting-review]


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] samskalicky edited a comment on issue #17537: Outdated mxnet nightly build wheel instructions

2020-02-07 Thread GitBox
samskalicky edited a comment on issue #17537: Outdated mxnet nightly build 
wheel instructions 
URL: 
https://github.com/apache/incubator-mxnet/issues/17537#issuecomment-583216709
 
 
   @szha you are correct, the way Javascript XMLHttpRequest works the page and 
links must be in the same domain as the one the page is accessed from. Heres a 
link to the official explanation: 
https://developer.mozilla.org/en-US/docs/Web/HTTP/CORS. So either we do it at 
https://apache-mxnet.s3-us-west-2.amazonaws.com or we do it at 
https://repo.mxnet.io but we cannot do both at the same time. 
   
   If we are officially blessing this page and making it official we can switch 
it. Otherwise if the community wants to do something different we can leave it 
and just access it at 
https://apache-mxnet.s3-us-west-2.amazonaws.com/dist/index.html until the 
community implements a new solution.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] leezu commented on issue #17521: cmake: don't build PTX and 3.5 arch if cuda arch detection fails

2020-02-07 Thread GitBox
leezu commented on issue #17521: cmake: don't build PTX and 3.5 arch if cuda 
arch detection fails
URL: https://github.com/apache/incubator-mxnet/pull/17521#issuecomment-583560030
 
 
   ping @ptrendx 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] apeforest opened a new issue #17545: CMake build instruction on ubuntu not working

2020-02-07 Thread GitBox
apeforest opened a new issue #17545: CMake build instruction on ubuntu not 
working
URL: https://github.com/apache/incubator-mxnet/issues/17545
 
 
   ## Description
   The CMake build instruction on ubuntu not working on a ubuntu instance with 
DLAMI
   
   ### Error Message
   FAILED: : && /usr/bin/c++  -mf16c -Wall -Wno-unknown-pragmas 
-Wno-sign-compare -O3 -msse3 -std=c++11 -fopenmp   
tests/CMakeFiles/mxnet_unit_tests.dir/cpp/engine/engine_shutdown_test.cc.o 
tests/CMakeFiles/mxnet_unit_tests.dir/cpp/engine/omp_test.cc.o 
tests/CMakeFiles/mxnet_unit_tests.dir/cpp/engine/thread_local_test.cc.o 
tests/CMakeFiles/mxnet_unit_tests.dir/cpp/engine/threaded_engine_test.cc.o 
tests/CMakeFiles/mxnet_unit_tests.dir/cpp/kvstore/gpu_topology_test.cc.o 
tests/CMakeFiles/mxnet_unit_tests.dir/cpp/misc/base.cc.o 
tests/CMakeFiles/mxnet_unit_tests.dir/cpp/misc/libinfo_test.cc.o 
tests/CMakeFiles/mxnet_unit_tests.dir/cpp/operator/activation_perf.cc.o 
tests/CMakeFiles/mxnet_unit_tests.dir/cpp/operator/batchnorm_test.cc.o 
tests/CMakeFiles/mxnet_unit_tests.dir/cpp/operator/coreop_perf.cc.o 
tests/CMakeFiles/mxnet_unit_tests.dir/cpp/operator/dropout_perf.cc.o 
tests/CMakeFiles/mxnet_unit_tests.dir/cpp/operator/fully_conn_perf.cc.o 
tests/CMakeFiles/mxnet_unit_tests.dir/cpp/operator/krprod_test.cc.o 
tests/CMakeFiles/mxnet_unit_tests.dir/cpp/operator/mkldnn_operator_test.cc.o 
tests/CMakeFiles/mxnet_unit_tests.dir/cpp/operator/mkldnn_test.cc.o 
tests/CMakeFiles/mxnet_unit_tests.dir/cpp/operator/runner/core_op_runner_test.cc.o
 tests/CMakeFiles/mxnet_unit_tests.dir/cpp/operator/slice_channel_perf.cc.o 
tests/CMakeFiles/mxnet_unit_tests.dir/cpp/operator/tune/operator_tune_test.cc.o 
tests/CMakeFiles/mxnet_unit_tests.dir/cpp/storage/storage_test.cc.o 
tests/CMakeFiles/mxnet_unit_tests.dir/cpp/test_main.cc.o 
tests/CMakeFiles/mxnet_unit_tests.dir/cpp/thread_safety/thread_safety_test.cc.o 
tests/CMakeFiles/mxnet_unit_tests.dir/cmake_device_link.o  -o 
tests/mxnet_unit_tests -L/usr/local/cuda/lib64  -L/usr/local/cuda/lib64/stubs 
-Wl,-rpath,/usr/local/cuda/lib64:/usr/local/lib:/home/ubuntu/src/incubator-mxnet/build/3rdparty/openmp/runtime/src
 lib/libgtest.a -Wl,--whole-archive libmxnet.a -Wl,--no-whole-archive 
3rdparty/dmlc-core/libdmlc.a 3rdparty/mkldnn/src/libdnnl.a 
/usr/local/lib/libopenblas.so /usr/lib/x86_64-linux-gnu/librt.so 
/usr/local/lib/libopencv_highgui.so.4.0.0 3rdparty/openmp/runtime/src/libomp.so 
-lpthread -llapack /usr/local/cuda/lib64/libcudnn.so 
/usr/local/lib/libopencv_videoio.so.4.0.0 
/usr/local/lib/libopencv_imgcodecs.so.4.0.0 
/usr/local/lib/libopencv_imgproc.so.4.0.0 
/usr/local/lib/libopencv_core.so.4.0.0 -lpthread 
/usr/local/cuda/lib64/libcudart.so /usr/lib/x86_64-linux-gnu/libcublas.so 
/usr/local/cuda/lib64/libcufft.so /usr/local/cuda/lib64/libcusolver.so 
/usr/local/cuda/lib64/libcurand.so /usr/local/cuda/lib64/libnvToolsExt.so -ldl 
-lrt -lcudadevrt -lcudart_static -lrt -lpthread -ldl && :
   libmxnet.a(cached_op.cc.o): In function 
`mxnet::CachedOp::CachedOpState::CachedOpState(mxnet::Context const&, 
nnvm::Graph const&, nnvm::Graph const&, bool)':
   
cached_op.cc:(.text._ZN5mxnet8CachedOp13CachedOpStateC2ERKNS_7ContextERKN4nnvm5GraphES8_b[_ZN5mxnet8CachedOp13CachedOpStateC5ERKNS_7ContextERKN4nnvm5GraphES8_b]+0x6e9):
 undefined reference to `mxnet::exec::FusePointwiseForward(nnvm::Graph&&)'
   
cached_op.cc:(.text._ZN5mxnet8CachedOp13CachedOpStateC2ERKNS_7ContextERKN4nnvm5GraphES8_b[_ZN5mxnet8CachedOp13CachedOpStateC5ERKNS_7ContextERKN4nnvm5GraphES8_b]+0x7c5):
 undefined reference to `mxnet::exec::FusePointwiseBackward(nnvm::Graph&&)'
   collect2: error: ld returned 1 exit status
   [587/587] Linking CXX shared library libmxnet.so
   ninja: build stopped: subcommand failed.
   
   ## To Reproduce
   Follow exactly the steps on 
https://mxnet.apache.org/get_started/ubuntu_setup.html
   
   ### Steps to reproduce
   git clone --recursive https://github.com/apache/incubator-mxnet.git mxnet
   cd mxnet
   cp config/config.cmake config.cmake
   
   rm -rf build
   mkdir -p build && cd build
   cmake -GNinja -C ../config.cmake ..
   cmake --build . --parallel 8
   
   ## Environment
   
   ```
   --Python Info--
   Version  : 3.6.6
   Compiler : GCC 7.2.0
   Build: ('default', 'Jun 28 2018 17:14:51')
   Arch : ('64bit', '')
   Pip Info---
   Version  : 19.3.1
   Directory: /home/ubuntu/anaconda3/lib/python3.6/site-packages/pip
   --MXNet Info---
   Version  : 1.6.0
   Directory: /home/ubuntu/src/mxnet/python/mxnet
   Num GPUs : 8
   Hashtag not found. Not installed from pre-built package.
   --System Info--
   Platform : Linux-4.4.0-1100-aws-x86_64-with-debian-stretch-sid
   system   : Linux
   node : ip-172-31-20-50
   release  : 4.4.0-1100-aws
   version  : #111-Ubuntu SMP Wed Dec 4 12:20:15 UTC 2019
   --Hardware Info--
   machine  : x86_6

[GitHub] [incubator-mxnet] leezu commented on issue #17543: MXNET-1444/MXNET-1445: replace NULL by nullptr

2020-02-07 Thread GitBox
leezu commented on issue #17543: MXNET-1444/MXNET-1445: replace NULL by nullptr 
URL: https://github.com/apache/incubator-mxnet/pull/17543#issuecomment-583548416
 
 
   You don't need to close / open new PRs to retrigger CI. Whenever you push a 
new commit, CI will rerun.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] leezu commented on issue #17543: MXNET-1444/MXNET-1445: replace NULL by nullptr

2020-02-07 Thread GitBox
leezu commented on issue #17543: MXNET-1444/MXNET-1445: replace NULL by nullptr 
URL: https://github.com/apache/incubator-mxnet/pull/17543#issuecomment-583548206
 
 
   Julia issue tracked at 
https://github.com/apache/incubator-mxnet/issues/16146. You can ignore that 
issue for now. Just make sure all other CI steps pass.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] leezu commented on issue #16146: Website build on CI is down due to Julia error

2020-02-07 Thread GitBox
leezu commented on issue #16146: Website build on CI is down due to Julia error
URL: 
https://github.com/apache/incubator-mxnet/issues/16146#issuecomment-583547770
 
 
   This affects all PRs.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] apeforest commented on issue #16735: Use single-bit for mask in dropout operator

2020-02-07 Thread GitBox
apeforest commented on issue #16735: Use single-bit for mask in dropout operator
URL: https://github.com/apache/incubator-mxnet/pull/16735#issuecomment-583539243
 
 
   > so we get 15x slow down?
   
   Yes, it seems so. Not sure if it is because the extra bit-operation logic we 
introduced or the modification to omp parallel clause. Need more investigation. 
@TaoLv Can MKL VSL support bit-wise mask so we don't have to do the extra 
conversion which seems redundant in the MKL case.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] olk edited a comment on issue #17543: MXNET-1444/MXNET-1445: replace NULL by nullptr

2020-02-07 Thread GitBox
olk edited a comment on issue #17543: MXNET-1444/MXNET-1445: replace NULL by 
nullptr 
URL: https://github.com/apache/incubator-mxnet/pull/17543#issuecomment-583536506
 
 
   Jenkins job related to website (Julia docu) fails because of  invalid 
markdown version:
   
   > [2020-02-07T17:50:14.697Z] pkg_resources.VersionConflict: (Markdown 3.2 
(/home/jenkins_slave/.local/lib/python3.5/site-packages), 
Requirement.parse('markdown<3.2'))
   > [2020-02-07T17:50:14.697Z] Makefile:19: recipe for target 'all' failed
   > [2020-02-07T17:50:14.697Z] make: Leaving directory '/work/mxnet/julia/docs'
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] olk commented on issue #17543: MXNET-1444/MXNET-1445: replace NULL by nullptr

2020-02-07 Thread GitBox
olk commented on issue #17543: MXNET-1444/MXNET-1445: replace NULL by nullptr 
URL: https://github.com/apache/incubator-mxnet/pull/17543#issuecomment-583536506
 
 
   Jenkins job related to website (Julia docu) fails because of :
   
   > [2020-02-07T17:50:14.697Z] pkg_resources.VersionConflict: (Markdown 3.2 
(/home/jenkins_slave/.local/lib/python3.5/site-packages), 
Requirement.parse('markdown<3.2'))
   > [2020-02-07T17:50:14.697Z] Makefile:19: recipe for target 'all' failed
   > [2020-02-07T17:50:14.697Z] make: Leaving directory '/work/mxnet/julia/docs'
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[incubator-mxnet] branch master updated (371beed -> 6533258)

2020-02-07 Thread apeforest
This is an automated email from the ASF dual-hosted git repository.

apeforest pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git.


from 371beed  add npx.gather_nd (#17477)
 add 6533258  [OpPerf] Implement remaining GEMM ops (#17501)

No new revisions were added by this update.

Summary of changes:
 benchmark/opperf/nd_operations/gemm_operators.py | 19 +++
 1 file changed, 15 insertions(+), 4 deletions(-)



[incubator-mxnet] branch master updated (371beed -> 6533258)

2020-02-07 Thread apeforest
This is an automated email from the ASF dual-hosted git repository.

apeforest pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git.


from 371beed  add npx.gather_nd (#17477)
 add 6533258  [OpPerf] Implement remaining GEMM ops (#17501)

No new revisions were added by this update.

Summary of changes:
 benchmark/opperf/nd_operations/gemm_operators.py | 19 +++
 1 file changed, 15 insertions(+), 4 deletions(-)



[GitHub] [incubator-mxnet] apeforest merged pull request #17501: [OpPerf] Implement remaining GEMM ops

2020-02-07 Thread GitBox
apeforest merged pull request #17501: [OpPerf] Implement remaining GEMM ops
URL: https://github.com/apache/incubator-mxnet/pull/17501
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] yzhliu opened a new pull request #17544: [Scala/Java] Remove unnecessary data slicing

2020-02-07 Thread GitBox
yzhliu opened a new pull request #17544: [Scala/Java] Remove unnecessary data 
slicing
URL: https://github.com/apache/incubator-mxnet/pull/17544
 
 
   Remove unnecessary slice during data loading
   should have been covered by existing test cases.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] samskalicky edited a comment on issue #17537: Outdated mxnet nightly build wheel instructions

2020-02-07 Thread GitBox
samskalicky edited a comment on issue #17537: Outdated mxnet nightly build 
wheel instructions 
URL: 
https://github.com/apache/incubator-mxnet/issues/17537#issuecomment-583526970
 
 
   Honestly I dont think the link matters. We're going to embed it in the 
website and wont expect users to remember the URL by heart. There is no static 
website at https://repo.mxnet.io/ anyway, so there no expectation that the 
download page should work at that address. 
   
   I dont think its a big deal which one we access it from since it will be a 
link in a webpage. 
   https://apache-mxnet.s3-us-west-2.amazonaws.com/dist/index.html";>Get 
Nightly builds here


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] samskalicky edited a comment on issue #17537: Outdated mxnet nightly build wheel instructions

2020-02-07 Thread GitBox
samskalicky edited a comment on issue #17537: Outdated mxnet nightly build 
wheel instructions 
URL: 
https://github.com/apache/incubator-mxnet/issues/17537#issuecomment-583526970
 
 
   Honestly I dont think the link matters. We're going to embed it in the 
website and wont expect users to remember the URL by heart. There is no static 
website at https://repo.mxnet.io/ anyway, so there no expectation that the 
download page should work at that address. 
   
   I dont think its a big deal which one we access it from since it will be a 
link in a webpage. 
   https://apache-mxnet.s3-us-west-2.amazonaws.com/";>Get Nightly 
builds here


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] samskalicky commented on issue #17537: Outdated mxnet nightly build wheel instructions

2020-02-07 Thread GitBox
samskalicky commented on issue #17537: Outdated mxnet nightly build wheel 
instructions 
URL: 
https://github.com/apache/incubator-mxnet/issues/17537#issuecomment-583526970
 
 
   Honestly I dont think the link matters. We're going to embed it in the 
website and wont expect users to remember the URL by heart. There is no static 
website at https://repo.mxnet.io/ anyway, so there no expectation that the 
download page should work at that address. 
   
   Honestly I dont think its a big deal which one we access it from since it 
will be a link in a webpage. 
   https://apache-mxnet.s3-us-west-2.amazonaws.com/";>Get Nightly 
builds here


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] eric-haibin-lin commented on issue #17537: Outdated mxnet nightly build wheel instructions

2020-02-07 Thread GitBox
eric-haibin-lin commented on issue #17537: Outdated mxnet nightly build wheel 
instructions 
URL: 
https://github.com/apache/incubator-mxnet/issues/17537#issuecomment-583521033
 
 
   Do it at  https://repo.mxnet.io sounds better. The link is easier to 
remember compared to the other one. @samskalicky @szha what do you think


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] eric-haibin-lin commented on issue #16735: Use single-bit for mask in dropout operator

2020-02-07 Thread GitBox
eric-haibin-lin commented on issue #16735: Use single-bit for mask in dropout 
operator
URL: https://github.com/apache/incubator-mxnet/pull/16735#issuecomment-583519418
 
 
   so we get 15x slow down? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] olk opened a new pull request #17543: MXNET-1444/MXNET-1445: replace NULL by nullptr

2020-02-07 Thread GitBox
olk opened a new pull request #17543: MXNET-1444/MXNET-1445: replace NULL by 
nullptr 
URL: https://github.com/apache/incubator-mxnet/pull/17543
 
 
   - using nullptr is more explicit
   - macro NULL can be a integer literal with value zero (since C++11)
   - literal nullptr is of type std::nullptr_t
   - as template arg NULL and 0 evaluate to integer
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] olk closed pull request #17536: MXNET-1444/MXNET-1445: replace NULL by nullptr literal

2020-02-07 Thread GitBox
olk closed pull request #17536: MXNET-1444/MXNET-1445: replace NULL by nullptr 
literal
URL: https://github.com/apache/incubator-mxnet/pull/17536
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] olk edited a comment on issue #17536: MXNET-1444/MXNET-1445: replace NULL by nullptr literal

2020-02-07 Thread GitBox
olk edited a comment on issue #17536: MXNET-1444/MXNET-1445: replace NULL by 
nullptr literal
URL: https://github.com/apache/incubator-mxnet/pull/17536#issuecomment-583383270
 
 
   generating Julia docs fails with:
   ```
   [2020-02-07T10:19:19.325Z] raise VersionConflict(dist, 
req).with_context(dependent_req)
   [2020-02-07T10:19:19.325Z] pkg_resources.VersionConflict: (Markdown 3.2 
(/home/jenkins_slave/.local/lib/python3.5/site-packages), 
Requirement.parse('markdown<3.2'))
   ```
   Seams to be an problem of the build system.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] olk commented on issue #17536: MXNET-1444/MXNET-1445: replace NULL by nullptr literal

2020-02-07 Thread GitBox
olk commented on issue #17536: MXNET-1444/MXNET-1445: replace NULL by nullptr 
literal
URL: https://github.com/apache/incubator-mxnet/pull/17536#issuecomment-583383270
 
 
   generating Julia docs fails with:
   ```
   [2020-02-07T10:19:19.325Z] raise VersionConflict(dist, 
req).with_context(dependent_req)
   [2020-02-07T10:19:19.325Z] pkg_resources.VersionConflict: (Markdown 3.2 
(/home/jenkins_slave/.local/lib/python3.5/site-packages), 
Requirement.parse('markdown<3.2'))
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] QueensGambit commented on issue #15092: mxnet model convert to onnx: No conversion function registered for op type LinearRegressionOutput yet.

2020-02-07 Thread GitBox
QueensGambit commented on issue #15092: mxnet model convert to onnx: No 
conversion function registered for op type LinearRegressionOutput yet.
URL: 
https://github.com/apache/incubator-mxnet/issues/15092#issuecomment-583374238
 
 
   Hello @eeqmcc ,
   I found a solution to this problem.
   The reason why you get this error is because your model was exported from 
the MXNet-symbol-API which includes loss functions within the network. When you 
define a network with the Gluon-API, the loss function is not part of the 
network definition, similar to other deep learning frameworks.
   The loss layers don't affect your output and are only used to calculate the 
gradient in the MXNet-symbol-API. Therefore, you can load your network into 
Gluon and export it again without the loss layers.
   
   ```python
   from onnx import checker
   import onnx
   
   sym = './SNIPER-symbol.json'
   params = './SNIPER-0002.params'
   input_shape = (8,3,416,416)
   onnx_file = './out.onnx'
   
   # check your last network output layer name by
   # mx.viz.print_summary(
   #symbol,
   #shape={'data':(1, input_shape[0], input_shape[1], input_shape[2])},
   #)
   # or reading the 'SNIPER-symbol.json' file
   prob_out_name = "cls_score"
   boxes_out_name = "bbox_pred"
   
   symbol = mx.sym.load(sym)
   inputs = mx.sym.var('data', dtype='float32')
   prob_out = symbol.get_internals()[prob_out_name]
   boxes_out = symbol.get_internals()[boxes_out_name]
   sym = mx.symbol.Group([prob_out, boxes_out])
   net = mx.gluon.SymbolBlock(sym, inputs)
   net.collect_params().load(params, ctx=mx.cpu())
   net.export("model")
   ```
   
   Next, you should be able to export the network to ONNX:
   ```python
   onnx_model_path = onnx_mxnet.export_model("model-symbol.json", 
"model-.params",[input_shape], np.float32, onnx_file)
   ```
   Now you can optionally validate the ONNX-model:
   ```python
   # validate model
   # load the ONNX-model
   model_proto = onnx.load_model(onnx_model_path)
   
   # check if the converted ONNX-protobuf is valid
   checker.check_graph(model_proto.graph)
   ```
   ---
   
   You also need to make sure that your ONNX-version is <= 1.3.0.
   * https://github.com/apache/incubator-mxnet/issues/14589
   ```bash
   pip install onnx==1.3.0
   ```
   Otherwise you will get errors for batch-normalization layers.
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] ChaiBapchya opened a new pull request #17542: [OpPerf] Add norm, cast ops, remaining optimizer ops

2020-02-07 Thread GitBox
ChaiBapchya opened a new pull request #17542: [OpPerf] Add norm, cast ops, 
remaining optimizer ops
URL: https://github.com/apache/incubator-mxnet/pull/17542
 
 
   ## Description ##
   
   Adds following ops to OpPerf [once all the OpPerf PRs get merged, all MXNet 
ops in NDArray namespace will be completed in OpPerf coverage (minus 
deprecated, _contrib ops and few other ops with known issues)]
   
   - norm op to reduction category
   - Following Optimizer ops
 - mp_nag_mom
 - nag_mom
 - lambd_update_phase_1 and 2
 - preloaded_multi_*
 - multi_*
   - Cast ops
 - cast
 - amp_cast
 - amp_multicast
   
   ## Checklist ##
   ### Essentials ###
   Please feel free to remove inapplicable items for your PR.
   
   - [ ] Changes are complete (i.e. I finished coding on this PR)
   - [ ] All changes have test coverage:
   - [ ] Code is well-documented: 
   - [ ] To the best of my knowledge, examples are either not affected by this 
change, or have been fixed to be compatible with this change
   
   
   ## Comments ##
   Ops falling in the category of multi_* and preloaded_multi_* were notorious
   They don't have standard keyworded arguments (data=data)
   They expect variable positional args (*data)
   It was previously handled such that only 1 value of variable positional arg 
could be passed
   
   Now, you can pass as many values for positional args as you want.
   However for running run_performance_test, inputs have to be key:value pair
   
   That is handled as args0, args1, arg2, etc
   So as long as the name of the key starts with args it will be considered as 
input for the operator.
   
   This is a very rare case that the user doesn't take keyworded args. Most 
other ops in MXNet NDArray namespace take keyworded args.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[incubator-mxnet] branch master updated (6cac786 -> 371beed)

2020-02-07 Thread haoj
This is an automated email from the ASF dual-hosted git repository.

haoj pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git.


from 6cac786  skip flaky test_convolution_multiple_streams (#17499)
 add 371beed  add npx.gather_nd (#17477)

No new revisions were added by this update.

Summary of changes:
 src/operator/tensor/indexing_op.cc | 1 +
 1 file changed, 1 insertion(+)



[incubator-mxnet] branch master updated (6cac786 -> 371beed)

2020-02-07 Thread haoj
This is an automated email from the ASF dual-hosted git repository.

haoj pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git.


from 6cac786  skip flaky test_convolution_multiple_streams (#17499)
 add 371beed  add npx.gather_nd (#17477)

No new revisions were added by this update.

Summary of changes:
 src/operator/tensor/indexing_op.cc | 1 +
 1 file changed, 1 insertion(+)



[GitHub] [incubator-mxnet] haojin2 merged pull request #17477: Add npx.gather_nd

2020-02-07 Thread GitBox
haojin2 merged pull request #17477: Add npx.gather_nd
URL: https://github.com/apache/incubator-mxnet/pull/17477
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] ChaiBapchya commented on issue #16146: Website build on CI is down due to Julia error

2020-02-07 Thread GitBox
ChaiBapchya commented on issue #16146: Website build on CI is down due to Julia 
error
URL: 
https://github.com/apache/incubator-mxnet/issues/16146#issuecomment-583301083
 
 
   Found here too - 
http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/mxnet-validation%2Fwebsite/detail/PR-17500/6/pipeline
   #17500 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] Yiyan66 opened a new pull request #17541: [numpy] add op random.rayleigh

2020-02-07 Thread GitBox
Yiyan66 opened a new pull request #17541: [numpy] add op random.rayleigh
URL: https://github.com/apache/incubator-mxnet/pull/17541
 
 
   ## Description ##
   add op random.rayleigh
   
   ## Checklist ##
   ### Essentials ###
   Please feel free to remove inapplicable items for your PR.
   - [ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to 
the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) 
created (except PRs with tiny changes)
   - [ ] Changes are complete (i.e. I finished coding on this PR)
   - [ ] All changes have test coverage:
   - Unit tests are added for small changes to verify correctness (e.g. adding 
a new operator)
   - Nightly tests are added for complicated/long-running ones (e.g. changing 
distributed kvstore)
   - Build tests will be added for build configuration changes (e.g. adding a 
new build option with NCCL)
   - [ ] Code is well-documented: 
   - For user-facing API changes, API doc string has been updated. 
   - For new C++ functions in header files, their functionalities and arguments 
are documented. 
   - For new examples, README.md is added to explain the what the example does, 
the source of the dataset, expected performance on test set and reference to 
the original paper if applicable
   - Check the API doc at 
https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
   - [ ] To the best of my knowledge, examples are either not affected by this 
change, or have been fixed to be compatible with this change
   
   ### Changes ###
   - [ ] Feature1, tests, (and when applicable, API doc)
   - [ ] Feature2, tests, (and when applicable, API doc)
   
   ## Comments ##
   - If this change is a backward incompatible change, why must this change be 
made.
   - Interesting edge cases to note here
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] stu1130 commented on issue #15383: [numpy] np.random.multinomial is different from _np

2020-02-07 Thread GitBox
stu1130 commented on issue #15383: [numpy] np.random.multinomial is different 
from _np
URL: 
https://github.com/apache/incubator-mxnet/issues/15383#issuecomment-583289615
 
 
   @xidulu Thanks for deep dive. I would probably get back to this a few weeks 
later


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] olk edited a comment on issue #17536: MXNET-1444/MXNET-1445: replace NULL by nullptr literal

2020-02-07 Thread GitBox
olk edited a comment on issue #17536: MXNET-1444/MXNET-1445: replace NULL by 
nullptr literal
URL: https://github.com/apache/incubator-mxnet/pull/17536#issuecomment-583282951
 
 
   There was an additional whitespace error from a previous commit - I don't 
know why it could pass the lint check.
   I've adopted my vimrc accordingly.
   
   Could I get a link to the coding/code formating standards used by MXNet?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] olk edited a comment on issue #17536: MXNET-1444/MXNET-1445: replace NULL by nullptr literal

2020-02-07 Thread GitBox
olk edited a comment on issue #17536: MXNET-1444/MXNET-1445: replace NULL by 
nullptr literal
URL: https://github.com/apache/incubator-mxnet/pull/17536#issuecomment-583282951
 
 
   There was an additional whitespace error from a previous commit - I don't 
know why it could pass the lint check.
   I've adopted my vimrc accordingly.
   
   Could I get a link to the coding/code formatting standards used by MXNet?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-mxnet] olk commented on issue #17536: MXNET-1444/MXNET-1445: replace NULL by nullptr literal

2020-02-07 Thread GitBox
olk commented on issue #17536: MXNET-1444/MXNET-1445: replace NULL by nullptr 
literal
URL: https://github.com/apache/incubator-mxnet/pull/17536#issuecomment-583282951
 
 
   There was an additional whitespace error from a previous commit - I don't 
know why it could pass the lint check.
   I've adopted my vimrc accordingly.
   
   Could I get a link to the coding/code formating standards used in MXNet?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services