[GitHub] [incubator-mxnet] TaoLv commented on issue #15424: fixed config.mk and Makefile bugs for installing mkl
TaoLv commented on issue #15424: fixed config.mk and Makefile bugs for installing mkl URL: https://github.com/apache/incubator-mxnet/pull/15424#issuecomment-513087297 @nuslq Thank you for the changes. It's now merged. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] TaoLv commented on issue #15424: fixed config.mk and Makefile bugs for installing mkl
TaoLv commented on issue #15424: fixed config.mk and Makefile bugs for installing mkl URL: https://github.com/apache/incubator-mxnet/pull/15424#issuecomment-510130871 @yugoren Can you double check? I can statically link MKL BLAS library by adding USE_BLAS=mkl to the make command line. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] TaoLv commented on issue #15424: fixed config.mk and Makefile bugs for installing mkl
TaoLv commented on issue #15424: fixed config.mk and Makefile bugs for installing mkl URL: https://github.com/apache/incubator-mxnet/pull/15424#issuecomment-509456651 @yugoren Please find the definition of `MSHADOW_USE_MKL` at https://github.com/dmlc/mshadow/blob/master/mshadow/base.h#L88 and https://github.com/dmlc/mshadow/blob/master/make/mshadow.mk#L101 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] TaoLv commented on issue #15424: fixed config.mk and Makefile bugs for installing mkl
TaoLv commented on issue #15424: fixed config.mk and Makefile bugs for installing mkl URL: https://github.com/apache/incubator-mxnet/pull/15424#issuecomment-508310683 Thank you for confirming. @larroy @nuslq, this is as expected. libmkldnn.so and libmklml_intel.so will be dynamically linked even USE_STATIC_MKL is true. Actually, they are not the `MKL` in `USE_STATIC_MKL`. Please refer to the logic here: https://github.com/dmlc/mshadow/blob/master/make/mshadow.mk#L87 - `USE_BLAS=mkl` and `USE_STATIC_MKL` are for how to link MKL BLAS. They can be used even `USE_MKLDNN=0` (in this case, you will not see the mkldnn.so and mklml_intel.so in ldd). - mklml_intel.so is introduced along with `USE_MKLDNN=1` to improve the performance of mkldnn.so. mklml_intel cannot be statically linked as no `.a` file is provided. Hope this explanation can address your questions. So the fix for lower case `use_blas` looks good. But the change and description for `USE_STATIC_MKL` does not make sense to me. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] TaoLv commented on issue #15424: fixed config.mk and Makefile bugs for installing mkl
TaoLv commented on issue #15424: fixed config.mk and Makefile bugs for installing mkl URL: https://github.com/apache/incubator-mxnet/pull/15424#issuecomment-508126089 @larroy it's passed to and used in mshadow.mk. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] TaoLv commented on issue #15424: fixed config.mk and Makefile bugs for installing mkl
TaoLv commented on issue #15424: fixed config.mk and Makefile bugs for installing mkl URL: https://github.com/apache/incubator-mxnet/pull/15424#issuecomment-507889995 I think the lower cases BLAS check in Makefile was added for runtime feature detection. It's not really used for BLAS linkage. Please correct me if I'm wrong @larroy . I tried USE_BLAS=mkl in make command line and can find MKL `.a` files in the link line and there is no MKL `.so` files in ldd output. Can you double check? @nuslq This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-mxnet] TaoLv commented on issue #15424: fixed config.mk and Makefile bugs for installing mkl
TaoLv commented on issue #15424: fixed config.mk and Makefile bugs for installing mkl URL: https://github.com/apache/incubator-mxnet/pull/15424#issuecomment-507519413 @nuslq Have you ever tried `USE_BLAS=mkl` in the make command line? I would expect MKL to be statically linked in this case. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
