[GitHub] [incubator-mxnet] bgawrych commented on pull request #18602: Fix softmax, logsoftmax failed on empty ndarray

2020-06-30 Thread GitBox 


bgawrych commented on pull request #18602:
URL: https://github.com/apache/incubator-mxnet/pull/18602#issuecomment-651597245


   @mxnet-bot run ci [codecov/project]



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-mxnet] bgawrych commented on pull request #18602: Fix softmax, logsoftmax failed on empty ndarray

2020-06-23 Thread GitBox 


bgawrych commented on pull request #18602:
URL: https://github.com/apache/incubator-mxnet/pull/18602#issuecomment-648002694


   > We usually just check and return directly before we launch the kernel 
which is run against different contexts
   > 
   > ```
   > if (inputs[0].shape().Size() == 0U) return;
   > ```
   > 
   > As the bug also affect on GPU and all the other contexts if possible
   
   So this condition should be put in the beginning of FCompute and FComputeEx 
functions, right? @stu1130 @TaoLv 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-mxnet] bgawrych commented on pull request #18602: Fix softmax, logsoftmax failed on empty ndarray

2020-06-22 Thread GitBox 


bgawrych commented on pull request #18602:
URL: https://github.com/apache/incubator-mxnet/pull/18602#issuecomment-647480351


   @mxnet-bot run ci [unix-cpu]



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org