[GitHub] [incubator-mxnet] cjolivier01 commented on issue #15369: Fix build with system's openmp

[GitBox]

cjolivier01 commented on issue #15369: Fix build with system's openmp
URL: https://github.com/apache/incubator-mxnet/pull/15369#issuecomment-507501977
 
 
   This is basically a duplicate of turning on llvm openmp.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] cjolivier01 commented on issue #15369: Fix build with system's openmp

[GitBox]

cjolivier01 commented on issue #15369: Fix build with system's openmp
URL: https://github.com/apache/incubator-mxnet/pull/15369#issuecomment-507501848
 
 
   Using cmake is another subject altogether.
   How is this PR not basically what was already blocked?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] cjolivier01 commented on issue #15369: Fix build with system's openmp

[GitBox]

cjolivier01 commented on issue #15369: Fix build with system's openmp
URL: https://github.com/apache/incubator-mxnet/pull/15369#issuecomment-507481585
 
 
   I don't think this is a good idea. we should standardize on one
   implementation.  Like I have pointed out, the default make build uses
   llvm/intel version.  cmake builds us llvm/intel version.  if libgomp is
   still being included, removing it should be investigated.  Trying to
   flip-flop between them on a whim is asking for trouble, and currently I
   know of no advantage to using libgomp.
   
   On Mon, Jul 1, 2019 at 5:33 PM Pedro Larroy 
   wrote:
   
   > @hubutui  would it be possible to add a CMake
   > option to choose the OpenMP implementation that one wishes for? There's
   > three options, MKL, 3rdparty OpenMP and the one found in the platform. So I
   > think the pr goes in the good direction but we would need a commandline
   > option.
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > 
,
   > or mute the thread
   > 

   > .
   >
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services