larroy commented on issue #15424: fixed config.mk and Makefile bugs for
installing mkl
URL: https://github.com/apache/incubator-mxnet/pull/15424#issuecomment-507446664
One question that I have about your description, where do we define
USE_STATIC_MKL? I see it in files define ad-hoc but not in the Makefile or
config.mk, could you edit the description and clarify where USE_STATIC_MKL is
updated or add a comment in Makefile or config.mk or documentation? I didn't
see it in the patch, maybe I missed something.
```
$ ag USE_STATIC_MKL |less
make/readthedocs.mk:54:USE_STATIC_MKL = NONE
make/readthedocs.mk:74: USE_STATIC_MKL = 1
make/maven/maven_linux_mkl.mk:124:USE_STATIC_MKL = 1
make/maven/maven_linux_mkl.mk:126:USE_STATIC_MKL = NONE
make/maven/maven_linux_cu90mkl.mk:127:USE_STATIC_MKL = 1
make/maven/maven_linux_cu90mkl.mk:129:USE_STATIC_MKL = NONE
make/maven/maven_linux_cu92mkl.mk:127:USE_STATIC_MKL = 1
make/maven/maven_linux_cu92mkl.mk:129:USE_STATIC_MKL = NONE
make/maven/maven_darwin_mkl.mk:124:USE_STATIC_MKL = 1
make/maven/maven_darwin_mkl.mk:126:USE_STATIC_MKL = NONE
make/pip/pip_linux_cu91.mk:127:USE_STATIC_MKL = 1
make/pip/pip_linux_cu91.mk:129:USE_STATIC_MKL = NONE
make/pip/pip_linux_cu80mkl.mk:111:USE_STATIC_MKL = 1
make/pip/pip_linux_cu80mkl.mk:113:USE_STATIC_MKL = NONE
make/pip/pip_linux_cu80.mk:127:USE_STATIC_MKL = 1
make/pip/pip_linux_cu80.mk:129:USE_STATIC_MKL = NONE
make/pip/pip_linux_cu90.mk:127:USE_STATIC_MKL = 1
make/pip/pip_linux_cu90.mk:129:USE_STATIC_MKL = NONE
make/pip/pip_linux_cu91mkl.mk:111:USE_STATIC_MKL = 1
make/pip/pip_linux_cu91mkl.mk:113:USE_STATIC_MKL = NONE
make/pip/pip_linux_cu101.mk:127:USE_STATIC_MKL = 1
make/pip/pip_linux_cu101.mk:129:USE_STATIC_MKL = NONE
make/pip/pip_linux_cu75mkl.mk:108:USE_STATIC_MKL = 1
make/pip/pip_linux_cu75mkl.mk:110:USE_STATIC_MKL = NONE
make/pip/pip_linux_cu100mkl.mk:111:USE_STATIC_MKL = 1
make/pip/pip_linux_cu100mkl.mk:113:USE_STATIC_MKL = NONE
make/pip/pip_linux_cpu.mk:124:USE_STATIC_MKL = 1
make/pip/pip_linux_cpu.mk:126:USE_STATIC_MKL = NONE
make/pip/pip_linux_cu75.mk:124:USE_STATIC_MKL = 1
make/pip/pip_linux_cu75.mk:126:USE_STATIC_MKL = NONE
make/pip/pip_linux_cu100.mk:127:USE_STATIC_MKL = 1
make/pip/pip_linux_cu100.mk:129:USE_STATIC_MKL = NONE
make/pip/pip_darwin_mkl.mk:108:USE_STATIC_MKL = 1
make/pip/pip_darwin_mkl.mk:110:USE_STATIC_MKL = NONE
make/pip/pip_linux_mkl.mk:108:USE_STATIC_MKL = 1
make/pip/pip_linux_mkl.mk:110:USE_STATIC_MKL = NONE
make/pip/pip_darwin_cpu.mk:124:USE_STATIC_MKL = 1
make/pip/pip_darwin_cpu.mk:126:USE_STATIC_MKL = NONE
make/pip/pip_linux_cu92.mk:127:USE_STATIC_MKL = 1
make/pip/pip_linux_cu92.mk:129:USE_STATIC_MKL = NONE
make/pip/pip_linux_cu92mkl.mk:111:USE_STATIC_MKL = 1
make/pip/pip_linux_cu92mkl.mk:113:USE_STATIC_MKL = NONE
make/pip/pip_linux_cu90mkl.mk:111:USE_STATIC_MKL = 1
make/pip/pip_linux_cu90mkl.mk:113:USE_STATIC_MKL = NONE
make/pip/pip_linux_cu101mkl.mk:111:USE_STATIC_MKL = 1
make/pip/pip_linux_cu101mkl.mk:113:USE_STATIC_MKL = NONE
make/crosscompile.jetson.mk:130:USE_STATIC_MKL = 1
make/crosscompile.jetson.mk:132:USE_STATIC_MKL = NONE
3rdparty/mshadow/make/mshadow.mk:87:ifneq ($(USE_STATIC_MKL), NONE)
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
