samskalicky commented on a change in pull request #18555:
URL: https://github.com/apache/incubator-mxnet/pull/18555#discussion_r447447347
##########
File path: src/operator/subgraph/build_subgraph.cc
##########
@@ -306,14 +300,19 @@ void PreSelectSubgraphNodes(const nnvm::Graph& g,
SubgraphSelectorV2Ptr subgraph
const std::vector<BiDirectedNodePtr>& simple_nodes,
std::vector<BiDirectedNode*>* subgraph_nodes) {
std::unordered_set<const BiDirectedNode*> excluded_nodes;
+ size_t n_excluded_nodes = 0;
const size_t max_num_retry = simple_nodes.size() * simple_nodes.size();
size_t count = 0;
bool success = false;
while (!success && count < max_num_retry) {
success = LabelSubgraph(g, subgraph_selector, label, snid, simple_nodes,
subgraph_nodes,
&excluded_nodes);
if (!success) {
- CHECK(!excluded_nodes.empty());
+ if (excluded_nodes.size() == n_excluded_nodes) {
Review comment:
Do nodes have to be excluded in order to have a possible subgraph?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
