[GitHub] DickJC123 commented on issue #9674: Fix test_sparse_operator failures due to out-of-bounds ref.

2018-02-02 Thread GitBox 
DickJC123 commented on issue #9674: Fix test_sparse_operator failures due to 
out-of-bounds ref.
URL: https://github.com/apache/incubator-mxnet/pull/9674#issuecomment-362760136
 
 
   To prove that the prior code referenced uninitialized data, substitute the 
following 4 lines for the single line the PR changed:
   ```
  bool will_reference_axis_first_element = !dispatched && in_stype == 
kCSRStorage;
 if (will_reference_axis_first_element && param.axis.ndim() == 0)
   LOG(FATAL) << "Code is about to make out-of-bounds reference of 
param.axis[0]";
 if (!dispatched && in_stype == kCSRStorage &&
   ```
   Then re-built mxnet and run:
   ```
   nosetests --verbose 
tests/python/unittest/test_sparse_operator.py:test_sparse_storage_fallback
   ```
   For me, the fatal exception is thrown.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DickJC123 commented on issue #9674: Fix test_sparse_operator failures due to out-of-bounds ref.

2018-02-01 Thread GitBox 
DickJC123 commented on issue #9674: Fix test_sparse_operator failures due to 
out-of-bounds ref.
URL: https://github.com/apache/incubator-mxnet/pull/9674#issuecomment-362442302
 
 
   The current test fails when uninitialized data is obtained from off the end 
of an array.  When the data referenced is not 0 or 1, there is no problem.  I 
recommend accepting this PR based on an inspection of the changed line since 
forcing the uninitialized data to a specific pattern is not possible.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services