[GitHub] Roshrini commented on a change in pull request #9963: [MXNET-34] Onnx Module to import onnx models into mxnet
Roshrini commented on a change in pull request #9963: [MXNET-34] Onnx Module to import onnx models into mxnet URL: https://github.com/apache/incubator-mxnet/pull/9963#discussion_r174317953 ## File path: python/mxnet/contrib/onnx/_import/import_helper.py ## @@ -0,0 +1,105 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# coding: utf-8 +# pylint: disable=invalid-name +"""Operator attributes conversion""" +from .op_translations import identity, random_uniform, random_normal +from .op_translations import add, subtract, multiply, divide, absolute, negative, add_n +from .op_translations import tanh +from .op_translations import ceil, floor +from .op_translations import concat +from .op_translations import leaky_relu, _elu, _prelu, softmax, fully_connected +from .op_translations import global_avgpooling, global_maxpooling, linalg_gemm +from .op_translations import sigmoid, pad, relu, matrix_multiplication, batch_norm +from .op_translations import dropout, local_response_norm, conv, deconv Review comment: why not import all functions from .op_translations instead of specifying each function here? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Roshrini commented on a change in pull request #9963: [MXNET-34] Onnx Module to import onnx models into mxnet
Roshrini commented on a change in pull request #9963: [MXNET-34] Onnx Module to
import onnx models into mxnet
URL: https://github.com/apache/incubator-mxnet/pull/9963#discussion_r174316464
##
File path: python/mxnet/contrib/onnx/_import/import_model.py
##
@@ -0,0 +1,46 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# coding: utf-8
+"""import function"""
+# pylint: disable=no-member
+
+from .import_onnx import GraphProto
+
+def import_model(model_file):
+"""Imports the supplied ONNX model file into MXNet symbol and parameters.
+:parameters model_file
+--
+model_file : ONNX model file name
+
+:returns (sym, params)
+---
+sym : mx.symbol
+Compatible mxnet symbol
+params : dict of str to mx.ndarray
+Dict of converted parameters stored in mx.ndarray format
+"""
+graph = GraphProto()
+
+# loads model file and returns ONNX protobuf object
+try:
+import onnx
+except ImportError:
+raise ImportError("Onnx and protobuf need to be installed")
Review comment:
Can we also add a link to onnx installation here while throwing this error?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] Roshrini commented on a change in pull request #9963: [MXNET-34] Onnx Module to import onnx models into mxnet
Roshrini commented on a change in pull request #9963: [MXNET-34] Onnx Module to import onnx models into mxnet URL: https://github.com/apache/incubator-mxnet/pull/9963#discussion_r174315641 ## File path: python/mxnet/contrib/onnx/_import/import_helper.py ## @@ -0,0 +1,105 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# coding: utf-8 +# pylint: disable=invalid-name +"""Operator attributes conversion""" +from .op_translations import identity, random_uniform, random_normal +from .op_translations import add, subtract, multiply, divide, absolute, negative, add_n +from .op_translations import tanh +from .op_translations import ceil, floor +from .op_translations import concat +from .op_translations import leaky_relu, _elu, _prelu, softmax, fully_connected +from .op_translations import global_avgpooling, global_maxpooling, linalg_gemm +from .op_translations import sigmoid, pad, relu, matrix_multiplication, batch_norm +from .op_translations import dropout, local_response_norm, conv, deconv +from .op_translations import reshape, cast, split, _slice, transpose, squeeze +from .op_translations import reciprocal, squareroot, power, exponent, _log +from .op_translations import reduce_max, reduce_mean, reduce_min, reduce_sum +from .op_translations import reduce_prod, avg_pooling, max_pooling +from .op_translations import argmax, argmin, maximum, minimum + +# convert_map defines maps of ONNX operator names to converter functor(callable) Review comment: converter functor? typo? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Roshrini commented on a change in pull request #9963: [MXNET-34] Onnx Module to import onnx models into mxnet
Roshrini commented on a change in pull request #9963: [MXNET-34] Onnx Module to import onnx models into mxnet URL: https://github.com/apache/incubator-mxnet/pull/9963#discussion_r174316786 ## File path: python/mxnet/contrib/onnx/_import/import_model.py ## @@ -0,0 +1,46 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# coding: utf-8 +"""import function""" +# pylint: disable=no-member + +from .import_onnx import GraphProto + +def import_model(model_file): +"""Imports the supplied ONNX model file into MXNet symbol and parameters. +:parameters model_file +-- +model_file : ONNX model file name + +:returns (sym, params) Review comment: Check for doc rendering. Will be helpful if we decide to add these API docs on the website later. Follow the same convention throughout This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
