[GitHub] ThomasDelteil commented on issue #10165: [MXNET-114] Add the ability to exclude specific lines in tutorial notebooks generated from .md

2018-03-26 Thread GitBox
ThomasDelteil commented on issue #10165: [MXNET-114] Add the ability to exclude 
specific lines in tutorial notebooks generated from .md
URL: https://github.com/apache/incubator-mxnet/pull/10165#issuecomment-376363624
 
 
   @szha re-rebased, is it ready to be merged? See approval from @thomelane 
@safrooze @Ishitori above.
   New link here: 
http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-10165/10/tutorials/onnx/inference_on_onnx_model.html
   I confirm that the `` filter is working as expected


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] ThomasDelteil commented on issue #10165: [MXNET-114] Add the ability to exclude specific lines in tutorial notebooks generated from .md

2018-03-26 Thread GitBox
ThomasDelteil commented on issue #10165: [MXNET-114] Add the ability to exclude 
specific lines in tutorial notebooks generated from .md
URL: https://github.com/apache/incubator-mxnet/pull/10165#issuecomment-376363624
 
 
   @szha re-rebased, is it ready to be merged? See approval from @thomelane 
@safrooze @Ishitori above.
   New link here: 
http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-10165/10/tutorials/onnx/inference_on_onnx_model.html
   I confirmed `` filter is working as expected


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] ThomasDelteil commented on issue #10165: [MXNET-114] Add the ability to exclude specific lines in tutorial notebooks generated from .md

2018-03-26 Thread GitBox
ThomasDelteil commented on issue #10165: [MXNET-114] Add the ability to exclude 
specific lines in tutorial notebooks generated from .md
URL: https://github.com/apache/incubator-mxnet/pull/10165#issuecomment-376319179
 
 
   @szha  @cjolivier01 do I need to rebase every time I commit to get the build 
to not show as failed?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] ThomasDelteil commented on issue #10165: [MXNET-114] Add the ability to exclude specific lines in tutorial notebooks generated from .md

2018-03-26 Thread GitBox
ThomasDelteil commented on issue #10165: [MXNET-114] Add the ability to exclude 
specific lines in tutorial notebooks generated from .md
URL: https://github.com/apache/incubator-mxnet/pull/10165#issuecomment-376317716
 
 
   They are showing on the website, but not in the generated notebook, which is 
what we want for the ``: 
   
http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-10165/7/tutorials/onnx/inference_on_onnx_model.ipynb
   
   edit: I added the line in back ticks to make it clearer that this is the 
output of the cell above
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] ThomasDelteil commented on issue #10165: [MXNET-114] Add the ability to exclude specific lines in tutorial notebooks generated from .md

2018-03-26 Thread GitBox
ThomasDelteil commented on issue #10165: [MXNET-114] Add the ability to exclude 
specific lines in tutorial notebooks generated from .md
URL: https://github.com/apache/incubator-mxnet/pull/10165#issuecomment-376317716
 
 
   They are showing on the website, but not in the generated notebook, which is 
what we want for the ``: 
   
http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-10165/7/tutorials/onnx/inference_on_onnx_model.ipynb
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] ThomasDelteil commented on issue #10165: [MXNET-114] Add the ability to exclude specific lines in tutorial notebooks generated from .md

2018-03-26 Thread GitBox
ThomasDelteil commented on issue #10165: [MXNET-114] Add the ability to exclude 
specific lines in tutorial notebooks generated from .md
URL: https://github.com/apache/incubator-mxnet/pull/10165#issuecomment-376317716
 
 
   They are showing on the website, but not in the generated notebook: 
   
http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-10165/7/tutorials/onnx/inference_on_onnx_model.ipynb
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] ThomasDelteil commented on issue #10165: [MXNET-114] Add the ability to exclude specific lines in tutorial notebooks generated from .md

2018-03-23 Thread GitBox
ThomasDelteil commented on issue #10165: [MXNET-114] Add the ability to exclude 
specific lines in tutorial notebooks generated from .md
URL: https://github.com/apache/incubator-mxnet/pull/10165#issuecomment-375844097
 
 
   @szha New tutorial here: 
http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-10165/7/tutorials/onnx/inference_on_onnx_model.html
 
   I confirm that the notebook does not have the images and that they have been 
properly filtered.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] ThomasDelteil commented on issue #10165: [MXNET-114] Add the ability to exclude specific lines in tutorial notebooks generated from .md

2018-03-23 Thread GitBox
ThomasDelteil commented on issue #10165: [MXNET-114] Add the ability to exclude 
specific lines in tutorial notebooks generated from .md
URL: https://github.com/apache/incubator-mxnet/pull/10165#issuecomment-375761992
 
 
   How do I trigger a new build? 
   @szha i have added a tutorial on inference with ONNX


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] ThomasDelteil commented on issue #10165: [MXNET-114] Add the ability to exclude specific lines in tutorial notebooks generated from .md

2018-03-23 Thread GitBox
ThomasDelteil commented on issue #10165: [MXNET-114] Add the ability to exclude 
specific lines in tutorial notebooks generated from .md
URL: https://github.com/apache/incubator-mxnet/pull/10165#issuecomment-375761992
 
 
   How do I trigger a new build?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] ThomasDelteil commented on issue #10165: [MXNET-114] Add the ability to exclude specific lines in tutorial notebooks generated from .md

2018-03-21 Thread GitBox
ThomasDelteil commented on issue #10165: [MXNET-114] Add the ability to exclude 
specific lines in tutorial notebooks generated from .md
URL: https://github.com/apache/incubator-mxnet/pull/10165#issuecomment-375116773
 
 
   @marcoabreu I wouldn't want this to become over-engineered, let's find a 
solution when we actually encounter this problem. This is already a hack around 
the fact that we don't have both notebooks and .md in the repo, let's not 
create a new markup language.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] ThomasDelteil commented on issue #10165: [MXNET-114] Add the ability to exclude specific lines in tutorial notebooks generated from .md

2018-03-21 Thread GitBox
ThomasDelteil commented on issue #10165: [MXNET-114] Add the ability to exclude 
specific lines in tutorial notebooks generated from .md
URL: https://github.com/apache/incubator-mxnet/pull/10165#issuecomment-375033568
 
 
   @szha do you have time to look at this PR please? It is a blocker for my 
upcoming tutorials. Thanks!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services