[GitHub] ThomasDelteil commented on issue #10528: [MXNET-316] Remove empty buckets causing index errors
ThomasDelteil commented on issue #10528: [MXNET-316] Remove empty buckets causing index errors URL: https://github.com/apache/incubator-mxnet/pull/10528#issuecomment-381716212 Thanks @harusametime ! I do not have merge rights. So if I understand correctly you modified the test so that sequences of length=40 are never generated? It might be clearer for the reader if you do `randint(1, max(buckets)-1) # leave out the two last buckets emtpy` Do you mind commenting on what you updated in the previous test? I see you removed an `assert` statement This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ThomasDelteil commented on issue #10528: [MXNET-316] Remove empty buckets causing index errors
ThomasDelteil commented on issue #10528: [MXNET-316] Remove empty buckets causing index errors URL: https://github.com/apache/incubator-mxnet/pull/10528#issuecomment-380875511 Thanks @harusametime ! Could we get a test to make sure it works and we don't introduce it this bug in the future? - [x] Could you please create a Jira ticket and add it to the title of your PR? Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
