[GitHub] aaronmarkham commented on a change in pull request #13979: [MXNET-1232] fix demo and add Eclipse support
aaronmarkham commented on a change in pull request #13979: [MXNET-1232] fix demo and add Eclipse support URL: https://github.com/apache/incubator-mxnet/pull/13979#discussion_r250828887 ## File path: scala-package/mxnet-demo/scala-demo/README.md ## @@ -1,7 +1,15 @@ # MXNet Scala Sample Project This is an project created to use Maven-published Scala package with two Scala examples. ## Setup -User are required to use `mvn package` to build the package, +User are required to use maven to build the package, by simply running Review comment: ```suggestion You are required to use maven to build the package, by running the following: ``` Again, is it really a requirement or one route to do things? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] aaronmarkham commented on a change in pull request #13979: [MXNET-1232] fix demo and add Eclipse support
aaronmarkham commented on a change in pull request #13979: [MXNET-1232] fix demo and add Eclipse support URL: https://github.com/apache/incubator-mxnet/pull/13979#discussion_r250827800 ## File path: scala-package/mxnet-demo/java-demo/README.md ## @@ -1,13 +1,15 @@ # MXNet Java Sample Project This is an project created to use Maven-published Scala/Java package with two Java examples. ## Setup -You can use the `Makefile` to make the Java package. Simply do the following: -```Bash -make javademo +User are required to use maven to build the package, by simply running Review comment: ```suggestion You are required to use Maven to build the package with the following commands: ``` However, isn't this not true? You can run the sample project by building for source, can you not? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] aaronmarkham commented on a change in pull request #13979: [MXNET-1232] fix demo and add Eclipse support
aaronmarkham commented on a change in pull request #13979: [MXNET-1232] fix demo and add Eclipse support URL: https://github.com/apache/incubator-mxnet/pull/13979#discussion_r250828035 ## File path: scala-package/mxnet-demo/java-demo/README.md ## @@ -1,13 +1,15 @@ # MXNet Java Sample Project This is an project created to use Maven-published Scala/Java package with two Java examples. ## Setup -You can use the `Makefile` to make the Java package. Simply do the following: -```Bash -make javademo +User are required to use maven to build the package, by simply running +``` +mvn package ``` -This will load the default parameter for all the environment variable. -If you want to run with GPU on Linux, just simply add `USE_CUDA=1` when you run the make file - +This command will pick the default values specified in the pom file. + +Note: If you are planning to use GPU, please add `-Dmxnet.profile=linux-x86_64-gpu` + +### Use customized version set You can use the following instruction as an alternative to achieve the same result: User are required to use `mvn package` to build the package, Review comment: Grammar on this line... also is this true? Should it be you "may" not "must" or "required"? ```suggestion You are required to use `mvn package` to build the package, ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] aaronmarkham commented on a change in pull request #13979: [MXNET-1232] fix demo and add Eclipse support
aaronmarkham commented on a change in pull request #13979: [MXNET-1232] fix demo and add Eclipse support URL: https://github.com/apache/incubator-mxnet/pull/13979#discussion_r250827463 ## File path: docs/install/java_setup.md ## @@ -85,6 +85,12 @@ Also, add the dependency which corresponds to your platform to the `dependencies The official Java Packages will be released with the release of MXNet 1.4 and will be available on [MXNet Maven package repository](https://search.maven.org/#search%7Cga%7C1%7Cg%3A%22org.apache.mxnet%22). +### Eclipse IDE Support +You can easily convert you existing maven project to a project that can run in Eclipse by: Review comment: ```suggestion You can convert your existing Maven project to a project that can run in Eclipse by: ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] aaronmarkham commented on a change in pull request #13979: [MXNET-1232] fix demo and add Eclipse support
aaronmarkham commented on a change in pull request #13979: [MXNET-1232] fix demo and add Eclipse support URL: https://github.com/apache/incubator-mxnet/pull/13979#discussion_r250829032 ## File path: scala-package/mxnet-demo/scala-demo/README.md ## @@ -54,9 +55,9 @@ If you want to test run on GPU, you can set a environment variable as follows: export SCALA_TEST_ON_GPU=1 ``` ## Clean up -Clean up for Maven package is simple, you can run the pre-configed `Makefile` as: +Clean up for Maven package is simple, you can just run Review comment: ```suggestion To clean up a Maven package, run the following: ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] aaronmarkham commented on a change in pull request #13979: [MXNET-1232] fix demo and add Eclipse support
aaronmarkham commented on a change in pull request #13979: [MXNET-1232] fix demo and add Eclipse support URL: https://github.com/apache/incubator-mxnet/pull/13979#discussion_r250828693 ## File path: scala-package/mxnet-demo/java-demo/README.md ## @@ -87,4 +95,4 @@ sudo apt install libopencv-imgcodecs3.4 Is there any other version available? You can find nightly release version from [here](https://repository.apache.org/#nexus-search;gav~org.apache.mxnet~~1.5.0-SNAPSHOT~~). -Please keep the same version in the Makefile or [above version](https://repository.apache.org/#nexus-search;gav~org.apache.mxnet) to run this demo. +Please keep the same version in the pom file or [above version](https://repository.apache.org/#nexus-search;gav~org.apache.mxnet) to run this demo. Review comment: This is kind of weird to link to above version. If you want them to look at the above version then don't link. Offer the link as a backup resource where they can see available versions... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] aaronmarkham commented on a change in pull request #13979: [MXNET-1232] fix demo and add Eclipse support
aaronmarkham commented on a change in pull request #13979: [MXNET-1232] fix demo and add Eclipse support URL: https://github.com/apache/incubator-mxnet/pull/13979#discussion_r250828151 ## File path: scala-package/mxnet-demo/java-demo/README.md ## @@ -71,9 +73,15 @@ If you want to test run on GPU, you can set a environment variable as follows: export SCALA_TEST_ON_GPU=1 ``` ## Clean up -Clean up for Maven package is simple, you can run the pre-configed `Makefile` as: +Clean up for Maven package is simple: ```Bash -make javaclean +mvn clean +``` + +## Run in Eclipse +You can convert the maven project to the eclipse one by running Review comment: ```suggestion You can convert the maven project to the eclipse one by running the following command: ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] aaronmarkham commented on a change in pull request #13979: [MXNET-1232] fix demo and add Eclipse support
aaronmarkham commented on a change in pull request #13979: [MXNET-1232] fix demo and add Eclipse support URL: https://github.com/apache/incubator-mxnet/pull/13979#discussion_r250827882 ## File path: scala-package/mxnet-demo/java-demo/README.md ## @@ -1,13 +1,15 @@ # MXNet Java Sample Project This is an project created to use Maven-published Scala/Java package with two Java examples. ## Setup -You can use the `Makefile` to make the Java package. Simply do the following: -```Bash -make javademo +User are required to use maven to build the package, by simply running +``` +mvn package ``` -This will load the default parameter for all the environment variable. -If you want to run with GPU on Linux, just simply add `USE_CUDA=1` when you run the make file - +This command will pick the default values specified in the pom file. Review comment: Link pom file. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] aaronmarkham commented on a change in pull request #13979: [MXNET-1232] fix demo and add Eclipse support
aaronmarkham commented on a change in pull request #13979: [MXNET-1232] fix demo and add Eclipse support URL: https://github.com/apache/incubator-mxnet/pull/13979#discussion_r250827528 ## File path: docs/install/java_setup.md ## @@ -85,6 +85,12 @@ Also, add the dependency which corresponds to your platform to the `dependencies The official Java Packages will be released with the release of MXNet 1.4 and will be available on [MXNet Maven package repository](https://search.maven.org/#search%7Cga%7C1%7Cg%3A%22org.apache.mxnet%22). +### Eclipse IDE Support +You can easily convert you existing maven project to a project that can run in Eclipse by: +``` +mvn eclipse:eclipse Review comment: From what directory? Is this known or should you mention it? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] aaronmarkham commented on a change in pull request #13979: [MXNET-1232] fix demo and add Eclipse support
aaronmarkham commented on a change in pull request #13979: [MXNET-1232] fix demo and add Eclipse support URL: https://github.com/apache/incubator-mxnet/pull/13979#discussion_r250827588 ## File path: docs/install/java_setup.md ## @@ -99,11 +105,11 @@ The previously mentioned setup with Maven is recommended. Otherwise, the followi Build Java from an Existing MXNet Installation -If you have already built MXNet **from source** and are looking to setup Java from that point, you may simply run the following from the MXNet source root: +If you have already built MXNet **from source** and are looking to setup Java from that point, you may simply run the following from the MXNet `scala-package`: Review comment: ```suggestion If you have already built MXNet **from source** and are looking to setup Java from that point, you may simply run the following from the MXNet `scala-package` folder: ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] aaronmarkham commented on a change in pull request #13979: [MXNET-1232] fix demo and add Eclipse support
aaronmarkham commented on a change in pull request #13979: [MXNET-1232] fix demo and add Eclipse support URL: https://github.com/apache/incubator-mxnet/pull/13979#discussion_r250828094 ## File path: scala-package/mxnet-demo/java-demo/README.md ## @@ -1,13 +1,15 @@ # MXNet Java Sample Project This is an project created to use Maven-published Scala/Java package with two Java examples. ## Setup -You can use the `Makefile` to make the Java package. Simply do the following: -```Bash -make javademo +User are required to use maven to build the package, by simply running +``` +mvn package ``` -This will load the default parameter for all the environment variable. -If you want to run with GPU on Linux, just simply add `USE_CUDA=1` when you run the make file - +This command will pick the default values specified in the pom file. + +Note: If you are planning to use GPU, please add `-Dmxnet.profile=linux-x86_64-gpu` + +### Use customized version set You can use the following instruction as an alternative to achieve the same result: User are required to use `mvn package` to build the package, which are shown below: Review comment: ```suggestion using the following commands: ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] aaronmarkham commented on a change in pull request #13979: [MXNET-1232] fix demo and add Eclipse support
aaronmarkham commented on a change in pull request #13979: [MXNET-1232] fix demo and add Eclipse support URL: https://github.com/apache/incubator-mxnet/pull/13979#discussion_r250828393 ## File path: scala-package/mxnet-demo/java-demo/README.md ## @@ -71,9 +73,15 @@ If you want to test run on GPU, you can set a environment variable as follows: export SCALA_TEST_ON_GPU=1 ``` ## Clean up -Clean up for Maven package is simple, you can run the pre-configed `Makefile` as: +Clean up for Maven package is simple: ```Bash -make javaclean +mvn clean +``` + +## Run in Eclipse +You can convert the maven project to the eclipse one by running +``` +mvn eclipse:eclipse Review comment: This is a repeat of before... why is this here? Also this is a conversion instruction not a "run" instruction as the title suggests. Maybe you can include some screenshots of how you open the project in eclipse and build it, etc... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
