[GitHub] anirudh2290 commented on issue #11212: cherry-pick bug fixes in MKLDNN for v1.2.0
anirudh2290 commented on issue #11212: cherry-pick bug fixes in MKLDNN for v1.2.0 URL: https://github.com/apache/incubator-mxnet/pull/11212#issuecomment-396765184 @zheng-da ok got it! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] anirudh2290 commented on issue #11212: cherry-pick bug fixes in MKLDNN for v1.2.0
anirudh2290 commented on issue #11212: cherry-pick bug fixes in MKLDNN for v1.2.0 URL: https://github.com/apache/incubator-mxnet/pull/11212#issuecomment-396680308 @pengzhao-intel There are still a lot of non CI-specific code changes. Since MKLDNN is marked as experimental for the release, I would err on the side of caution, add it to known issues for MKLDNN, and not add it to the release. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] anirudh2290 commented on issue #11212: cherry-pick bug fixes in MKLDNN for v1.2.0
anirudh2290 commented on issue #11212: cherry-pick bug fixes in MKLDNN for v1.2.0 URL: https://github.com/apache/incubator-mxnet/pull/11212#issuecomment-396473032 @pengzhao-intel I understand depthwise convolution is widely used but it is too big a change to be added to the patch release. What do others think @zheng-da @piiswrong ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] anirudh2290 commented on issue #11212: cherry-pick bug fixes in MKLDNN for v1.2.0
anirudh2290 commented on issue #11212: cherry-pick bug fixes in MKLDNN for v1.2.0 URL: https://github.com/apache/incubator-mxnet/pull/11212#issuecomment-396369271 this pr is also making a change to the mkldnn submodule through https://github.com/apache/incubator-mxnet/pull/10578 . This worries me since the mkldnn submodule change has a change of 124 files and this makes it a really big change for the patch release. I am not comfortable including #10578. Do other PRs depend on the change ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] anirudh2290 commented on issue #11212: cherry-pick bug fixes in MKLDNN for v1.2.0
anirudh2290 commented on issue #11212: cherry-pick bug fixes in MKLDNN for v1.2.0 URL: https://github.com/apache/incubator-mxnet/pull/11212#issuecomment-395904059 Was #10591 mentioned in the dev ? Which PR are 89d7b9b and e728cf05 part of ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] anirudh2290 commented on issue #11212: cherry-pick bug fixes in MKLDNN for v1.2.0
anirudh2290 commented on issue #11212: cherry-pick bug fixes in MKLDNN for v1.2.0 URL: https://github.com/apache/incubator-mxnet/pull/11212#issuecomment-395904059 Was #10591 mentioned in the dev ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
