[GitHub] anirudh2290 commented on issue #9772: ndarray indexing issues
anirudh2290 commented on issue #9772: ndarray indexing issues URL: https://github.com/apache/incubator-mxnet/issues/9772#issuecomment-381308739 @ashishlal related pr merged. can this be closed ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] anirudh2290 commented on issue #9772: ndarray indexing issues
anirudh2290 commented on issue #9772: ndarray indexing issues URL: https://github.com/apache/incubator-mxnet/issues/9772#issuecomment-365836694 @reminisce verified that it works for np.int64 on python2, doesn't work for np.int32. For python3, it doesnt work for either np.int32 or np.int64. This is probably because in python2, the int is 64 bit because of python build on my machine and isinstance check passed for np.int64. In python3 since int is changed and is not related to np.int32 or np.int64, it fails isinstance checks for both np.int32 and np.int64. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] anirudh2290 commented on issue #9772: ndarray indexing issues
anirudh2290 commented on issue #9772: ndarray indexing issues URL: https://github.com/apache/incubator-mxnet/issues/9772#issuecomment-365836694 @reminisce verified that it works for np.int64 on python2, doesn't work for np.int32. For python3, it doesnt work for either np.int32 or np.int64. This is probably because in python2, the int is 64 bit because of python build on my machine and isinstance check passed for np.int64. In python3 since int is changed and is not related to np.int32 or np.int64, it fail isinstance checks for both np.int32 and np.int64. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] anirudh2290 commented on issue #9772: ndarray indexing issues
anirudh2290 commented on issue #9772: ndarray indexing issues URL: https://github.com/apache/incubator-mxnet/issues/9772#issuecomment-365816203 @reminisce I wasnt able to reproduce the issue for python 2. The int type changed in python3 and the type is not related to numpy classes This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] anirudh2290 commented on issue #9772: ndarray indexing issues
anirudh2290 commented on issue #9772: ndarray indexing issues URL: https://github.com/apache/incubator-mxnet/issues/9772#issuecomment-365820033 @reminisce away from laptop. Will give that a try. Tried with np.int64 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] anirudh2290 commented on issue #9772: ndarray indexing issues
anirudh2290 commented on issue #9772: ndarray indexing issues URL: https://github.com/apache/incubator-mxnet/issues/9772#issuecomment-365816203 @reminisce I wasnt able to reproduce the issue for python 2. The int type changed in python3 and not related to numpy classes This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] anirudh2290 commented on issue #9772: ndarray indexing issues
anirudh2290 commented on issue #9772: ndarray indexing issues URL: https://github.com/apache/incubator-mxnet/issues/9772#issuecomment-365348247 Issue is that isinstance is not working as expected by the code and returns false in python3. Workaround is to force the type of i to be int instead of numpy.int64. I think this should also be fixed on the mxnet side. The problem is that we are calling isinstance with int and in the check isinstance(np.int64, int) is not reliable (https://github.com/numpy/numpy/issues/2951). Please see: https://github.com/apache/incubator-mxnet/blob/master/python/mxnet/ndarray/ndarray.py#L2039. The suggested fix is to check with np.integer for numpy data types. WDYT @reminisce ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] anirudh2290 commented on issue #9772: ndarray indexing issues
anirudh2290 commented on issue #9772: ndarray indexing issues URL: https://github.com/apache/incubator-mxnet/issues/9772#issuecomment-365348247 Issue is that isinstance is not working as expected by the code and returns false in python3. Workaround is to force the type of i to be int instead of numpy.int64. I think this should also be fixed on the mxnet side. The problem is that we are calling isinstance with int and in the check isinstance(np.int64, int) is not reliable. Please see: https://github.com/apache/incubator-mxnet/blob/master/python/mxnet/ndarray/ndarray.py#L2039. The suggested fix is to check with np.integer for numpy data types. WDYT @reminisce ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
