[GitHub] asmushetzel commented on a change in pull request #10864: Support for axis parameter in linalg.gemm

2018-05-21 Thread GitBox 
asmushetzel commented on a change in pull request #10864: Support for axis 
parameter in linalg.gemm
URL: https://github.com/apache/incubator-mxnet/pull/10864#discussion_r189729421
 
 

 ##
 File path: src/operator/tensor/la_op.h
 ##
 @@ -53,13 +54,17 @@ struct LaMatrixMacParam : public 
dmlc::Parameter {
 DMLC_DECLARE_FIELD(beta)
   .set_default(1.0)
   .describe("Scalar factor multiplied with C.");
+DMLC_DECLARE_FIELD(axis)
+  .set_default(-2)
+  .describe("Axis corresponding to the matrix rows.");
 
 Review comment:
   It's not similar to the theano's tensordot


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asmushetzel commented on a change in pull request #10864: Support for axis parameter in linalg.gemm

2018-05-21 Thread GitBox 
asmushetzel commented on a change in pull request #10864: Support for axis 
parameter in linalg.gemm
URL: https://github.com/apache/incubator-mxnet/pull/10864#discussion_r189726042
 
 

 ##
 File path: src/operator/tensor/la_op.h
 ##
 @@ -53,13 +54,17 @@ struct LaMatrixMacParam : public 
dmlc::Parameter {
 DMLC_DECLARE_FIELD(beta)
   .set_default(1.0)
   .describe("Scalar factor multiplied with C.");
+DMLC_DECLARE_FIELD(axis)
+  .set_default(-2)
+  .describe("Axis corresponding to the matrix rows.");
 
 Review comment:
   I changed the operator description and added an example. Let me know if this 
clarifies things.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services