[GitHub] cjolivier01 commented on issue #9677: Refactor operators and add MKLDNN
cjolivier01 commented on issue #9677: Refactor operators and add MKLDNN URL: https://github.com/apache/incubator-mxnet/pull/9677#issuecomment-366071774 The cpp unit tests aren't run ever on Windows. In fact, they can't be built on Windows at this time due to no static linking/dllexport issues, etc. While I was refactoring the cpp unit tests, I noticed that it wasn't turned off like it should be, so I fixed that. The disabling of the test was not done because of any changes in this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] cjolivier01 commented on issue #9677: Refactor operators and add MKLDNN
cjolivier01 commented on issue #9677: Refactor operators and add MKLDNN URL: https://github.com/apache/incubator-mxnet/pull/9677#issuecomment-366071774 The cpp unit tests aren;t run ever on Windows. In fact, they can;t be built on Windows at this time due to no static linking/dllexport issues, etc. While I was refactoring the cpp unit tests, I noticed that it wasn;t turned off like it should be, so I fixed that. The disabling of the test was not done because of any changes in this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] cjolivier01 commented on issue #9677: Refactor operators and add MKLDNN
cjolivier01 commented on issue #9677: Refactor operators and add MKLDNN URL: https://github.com/apache/incubator-mxnet/pull/9677#issuecomment-366071170 What you're showing there is CUDNN tuning, which is something different. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] cjolivier01 commented on issue #9677: Refactor operators and add MKLDNN
cjolivier01 commented on issue #9677: Refactor operators and add MKLDNN URL: https://github.com/apache/incubator-mxnet/pull/9677#issuecomment-366043337 Operator Tuning was never supported on Windows and has nothing to do with this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] cjolivier01 commented on issue #9677: Refactor operators and add MKLDNN
cjolivier01 commented on issue #9677: Refactor operators and add MKLDNN URL: https://github.com/apache/incubator-mxnet/pull/9677#issuecomment-366043180 " features being forgotten"? what features? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] cjolivier01 commented on issue #9677: Refactor operators and add MKLDNN
cjolivier01 commented on issue #9677: Refactor operators and add MKLDNN URL: https://github.com/apache/incubator-mxnet/pull/9677#issuecomment-366034644 There's only two out of 10-or-15-or-so tests that are disabled. I am fine with the merge from the point of the cpp tests. Although it's possible there is something wrong, it's not clear if it's the test or the main code, so I agree with @piiswrong that if it's really broken, we will find out soon enough after it is merged. Both tests are disabled for the same behavior. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] cjolivier01 commented on issue #9677: Refactor operators and add MKLDNN
cjolivier01 commented on issue #9677: Refactor operators and add MKLDNN URL: https://github.com/apache/incubator-mxnet/pull/9677#issuecomment-366034644 There's only two out of 10-or-15-or-so tests that are disabled. I am fine with the merge from the point of the cpp tests, although it's possible there is something wrong, it's not clear if it's the test or the main code, so I agree with @piiswrong that if it's really broken, we will find out soon enough after it is merged. Both tests are disabled for the same behavior. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
