[GitHub] eric-haibin-lin commented on a change in pull request #10435: [MXNET-289] Update example to resize data iterator to fix hang in dist sync for last epoch

2018-04-13 Thread GitBox 
eric-haibin-lin commented on a change in pull request #10435: [MXNET-289] 
Update example to resize data iterator to fix hang in dist sync for last epoch
URL: https://github.com/apache/incubator-mxnet/pull/10435#discussion_r181479187
 
 

 ##
 File path: example/image-classification/common/fit.py
 ##
 @@ -155,9 +159,16 @@ def fit(args, network, data_loader, **kwargs):
 head = '%(asctime)-15s Node[' + str(kv.rank) + '] %(message)s'
 logging.basicConfig(level=logging.DEBUG, format=head)
 logging.info('start with arguments %s', args)
+
+epoch_size = get_epoch_size(args, kv)
 
 # data iterators
 (train, val) = data_loader(args, kv)
+if 'dist' in args.kv_store and 'sync' in args.kv_store:
 
 Review comment:
   Please check "async" instead 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] eric-haibin-lin commented on a change in pull request #10435: [MXNET-289] Update example to resize data iterator to fix hang in dist sync for last epoch

2018-04-12 Thread GitBox 
eric-haibin-lin commented on a change in pull request #10435: [MXNET-289] 
Update example to resize data iterator to fix hang in dist sync for last epoch
URL: https://github.com/apache/incubator-mxnet/pull/10435#discussion_r181279912
 
 

 ##
 File path: example/image-classification/common/fit.py
 ##
 @@ -155,9 +159,16 @@ def fit(args, network, data_loader, **kwargs):
 head = '%(asctime)-15s Node[' + str(kv.rank) + '] %(message)s'
 logging.basicConfig(level=logging.DEBUG, format=head)
 logging.info('start with arguments %s', args)
+
+epoch_size = get_epoch_size(args, kv)
 
 # data iterators
 (train, val) = data_loader(args, kv)
+if 'dist' in args.kv_store and 'sync' in args.kv_store:
 
 Review comment:
   so there's no need to resize for async right?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services